Re: [HACKERS] GinPageIs* don't actually return a boolean

[Yury Zhuravlev]

Robert Haas wrote:
On Wed, Mar 2, 2016 at 9:48 PM, Peter Eisentraut <pete...@gmx.net> wrote:
On 2/11/16 9:30 PM, Michael Paquier wrote: ...

We need to decide what to do about this.  I disagree with Peter: I
think that regardless of stdbool, what we've got right now is sloppy
coding - bad style if nothing else.  Furthermore, I think that while C
lets you use any non-zero value to represent true, our bool type is
supposed to contain only one of those two values.  Therefore, I think
we should commit the full patch, back-patch it as far as somebody has
the energy for, and move on.  But regardless, this patch can't keep
sitting in the CommitFest - we either have to take it or reject it,
and soon.


I know that we are trying to do the right thing. But right now there is an 
error only in ginStepRight. Maybe now the fix this place, and we will think 
about "bool" then? The patch is attached (small and simple).

Thanks.


--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Companydiff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c
index 06ba9cb..30113d0 100644
--- a/src/backend/access/gin/ginbtree.c
+++ b/src/backend/access/gin/ginbtree.c
@@ -162,8 +162,8 @@ ginStepRight(Buffer buffer, Relation index, int lockmode)
 {
        Buffer          nextbuffer;
        Page            page = BufferGetPage(buffer);
-       bool            isLeaf = GinPageIsLeaf(page);
-       bool            isData = GinPageIsData(page);
+       uint8           isLeaf = GinPageIsLeaf(page);
+       uint8           isData = GinPageIsData(page);
        BlockNumber blkno = GinPageGetOpaque(page)->rightlink;
 
        nextbuffer = ReadBuffer(index, blkno);
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers