Re: [HACKERS] Sanity checking for ./configure options?

2016-02-26 Thread Peter Eisentraut
On 2/22/16 6:24 PM, Jim Nasby wrote: > On 2/5/16 10:08 AM, David Fetter wrote: >> On Wed, Feb 03, 2016 at 06:02:57PM -0600, Jim Nasby wrote: >>> I just discovered that ./configure will happily accept >>> '--with-pgport=' (I >>> was actually doing =$PGPORT, and didn't realize $PGPORT was empty). >>>

[HACKERS] syslog configurable line splitting behavior

2016-02-26 Thread Peter Eisentraut
Log_destination; extern char *Log_destination_string; +extern bool syslog_sequence_numbers; /* Log destination bitmap */ #define LOG_DESTINATION_STDERR 1 -- 2.7.2 From 72ea7dc222f41ab8246c0aa080d1c1adaf78f4c7 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 26 Feb 2016 22:37:15 -0

Re: [HACKERS] pg_ctl promote wait

2016-02-28 Thread Peter Eisentraut
ep 17 00:00:00 2001 From: Peter Eisentraut Date: Sun, 28 Feb 2016 20:21:54 -0500 Subject: [PATCH 1/3] pg_ctl: Add tests for promote action --- src/bin/pg_ctl/t/003_promote.pl | 62 + src/test/perl/TestLib.pm| 11 2 files changed, 73 insertion

[HACKERS] pg_resetxlog reference page reorganization

2016-02-29 Thread Peter Eisentraut
The pg_resetxlog reference page has grown over the years into an unnavigable jungle, so here is a patch that reorganizes it to be more in the style of the other ref pages, with a normal options list. From a9024195e9f7a0b47e592f39938bdc9743152a70 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut

Re: [HACKERS] remove wal_level archive

2016-02-29 Thread Peter Eisentraut
On 2/8/16 9:36 AM, David Steele wrote: > -#define XLogIsNeeded() (wal_level >= WAL_LEVEL_ARCHIVE) > +#define XLogIsNeeded() (wal_level >= WAL_LEVEL_REPLICA) > <...> > -#define XLogStandbyInfoActive() (wal_level >= WAL_LEVEL_HOT_STANDBY) > +#define XLogStandbyInfoActive() (wal_level >= WAL_LEVEL_REP

Re: [HACKERS] remove wal_level archive

2016-02-29 Thread Peter Eisentraut
replication slots can only be > used if wal_level >= archive"))); > We should still forbid the creation of replication slots if wal_level = > minimal. I think I took this out because you actually can't get to that check, but I put it back in because it seems better for clarit

Re: [HACKERS] GinPageIs* don't actually return a boolean

2016-03-02 Thread Peter Eisentraut
On 2/11/16 9:30 PM, Michael Paquier wrote: >> Well, Yury was saying upthread that some MSVC versions have a problem >> with the existing coding, which would be a reason to back-patch ... >> but I'd like to see a failing buildfarm member first. Don't particularly >> want to promise to support compi

Re: [HACKERS] Fix for OpenSSL error queue bug

2016-03-03 Thread Peter Eisentraut
On 2/5/16 5:04 AM, Peter Geoghegan wrote: > As Heikki goes into on that thread, the appropriate action seems to be > to constantly reset the error queue, and to make sure that we > ourselves clear the queue consistently. (Note that we might not have > consistently called ERR_get_error() in the even

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-03-05 Thread Peter Eisentraut
On 2/17/16 10:52 PM, Michael Paquier wrote: > On Thu, Feb 18, 2016 at 1:58 AM, Alvaro Herrera > wrote: >> Michael Paquier wrote: >>> Hi all, >>> >>> After looking at Alvaro's message mentioning the handling of >>> PQsocket() for invalid sockets, I just had a look by curiosity at >>> other calls of

Re: [HACKERS] GCC 6 warning fixes

2016-03-08 Thread Peter Eisentraut
On 3/8/16 4:44 PM, Robert Haas wrote: > On Mon, Feb 29, 2016 at 4:50 PM, Thomas Munro > wrote: >> On Sat, Feb 20, 2016 at 5:14 PM, Peter Eisentraut wrote: >>> Here are three patches to fix new warnings in GCC 6. >>> >>> 0001 is apparently a typo. >>

Re: [HACKERS] syslog configurable line splitting behavior

2016-03-08 Thread Peter Eisentraut
On 3/4/16 11:01 AM, Alexander Korotkov wrote: > On Sat, Feb 27, 2016 at 6:49 AM, Peter Eisentraut <mailto:pete...@gmx.net>> wrote: > > Writing log messages to syslog caters to ancient syslog implementations > in two ways: > > - sequence numbers > -

Re: [HACKERS] syslog configurable line splitting behavior

2016-03-08 Thread Peter Eisentraut
On 3/8/16 9:12 PM, Andreas Karlsson wrote: > As someone who uses syslog for my servers I find both of these GUCs > useful, especially when used in combination, and I do not think a > compile time option like suggest by Alexander would be suitable > substitute because then I would need a custom buil

Re: [HACKERS] Crash with old Windows on new CPU

2016-03-08 Thread Peter Eisentraut
On 2/12/16 11:24 AM, Christian Ullrich wrote: > Otherwise, it may be time to update the manual (15.6 Supported > Platforms) where it says PostgreSQL "can be expected to work on these > operating systems: [...] Windows (Win2000 SP4 and later), [...]". > Perhaps we could add "except Windows before 7

Re: [HACKERS] Fix for OpenSSL error queue bug

2016-03-10 Thread Peter Eisentraut
m not sure, I think we're in agreement on all > issues. I would have no problem with Peter E following through with > final steps + commit as Robert outlined, if that works for him. My proposal is the attached patch. From 697b4f75fccbb5eda530211f3ef58c2b226c5461 Mon Sep 17 00:00:00 2001 Fr

Re: [HACKERS] Relaxing SSL key permission checks

2016-03-10 Thread Peter Eisentraut
On 3/4/16 3:55 PM, Alvaro Herrera wrote: > * it failed to check for S_IXUSR, so permissions 0700 were okay, in > contradiction with what the error message indicates. This is a > preexisting bug actually. Do we want to fix it by preventing a > user-executable file (possibly breaking compability wi

Re: [HACKERS] Fix for OpenSSL error queue bug

2016-03-10 Thread Peter Eisentraut
On 3/10/16 9:38 PM, Peter Geoghegan wrote: > Looked at your proposed patch. Will respond to your original mail on the > matter. > > On Thu, Mar 3, 2016 at 4:15 PM, Peter Eisentraut wrote: >> I think clearing the error after a call is not necessary. The API >> clearly

Re: [HACKERS] Proposal: BSD Authentication support

2016-03-11 Thread Peter Eisentraut
On 1/7/16 9:40 PM, Marisa Emerson wrote: > There's a port for PAM, but we would prefer to use BSD Auth as its quite > a lot cleaner and is standard on OpenBSD. > > I've attached an updated patch that includes documentation. It has been > tested against OpenBSD 5.8. I'll add this thread to the comm

Re: [HACKERS] Proposal: BSD Authentication support

2016-03-11 Thread Peter Eisentraut
On 3/11/16 4:38 PM, Thomas Munro wrote: > It looks like this needs review from an OpenBSD user specifically. > FreeBSD and NetBSD use PAM instead of BSD auth. FreeBSD has man pages for this stuff, so maybe they also have it now. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.

Re: FW: [HACKERS] [NOVICE] WHERE clause not used when index is used

2016-03-15 Thread Peter Eisentraut
On 3/15/16 2:28 PM, Jernigan, Kevin wrote: > I recently joined the product management team for AWS RDS Postgres > (after years at Oracle in their database team), and we are very > interested in confirming (or not) that the fix for the problem below > will be included in 9.5.2, and in the community’

Re: [HACKERS] pam auth - add rhost item

2016-03-15 Thread Peter Eisentraut
On 3/10/16 8:11 AM, Grzegorz Sampolski wrote: > In attchment new patch with updated documentation and with small change > to coding style as you suggested. This patch seems fine. I'm not sure about the name "pamusedns" for the option, since we use the OS resolver, which might not actually use DNS

Re: [HACKERS] insufficient qualification of some objects in dump files

2016-03-15 Thread Peter Eisentraut
On 2/26/16 1:30 AM, Tom Lane wrote: > As the patch is presented, I agree with Peter that it does not really > need a format number bump. The question that has to be answered is > whether this solution is good enough? You could not trust it for > automated processing of tags --- it's easy to think

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2016-03-15 Thread Peter Eisentraut
On 2/5/16 3:09 AM, Kyotaro HORIGUCHI wrote: > I considered how to make tab-completion robust for syntactical > noises, in other words, optional words in syntax. Typically "IF > (NOT) EXISTS", UNIQUE and TEMPORARY are words that don't affect > further completion. To repeat the question I raised in

Re: [HACKERS] Relaxing SSL key permission checks

2016-03-15 Thread Peter Eisentraut
On 3/10/16 9:20 PM, Peter Eisentraut wrote: > On 3/4/16 3:55 PM, Alvaro Herrera wrote: >> * it failed to check for S_IXUSR, so permissions 0700 were okay, in >> contradiction with what the error message indicates. This is a >> preexisting bug actually. Do we want to f

Re: [HACKERS] syslog configurable line splitting behavior

2016-03-15 Thread Peter Eisentraut
_split_lines to syslog_split_messages, which I think is more accurate. From 70bacecba46eb38c02c43957c2f1812faf5684df Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 26 Feb 2016 22:34:30 -0500 Subject: [PATCH 1/2] Add syslog_sequence_numbers parameter --- doc/src/sgml/config.sgml | 28 ++

Re: [HACKERS] Relaxing SSL key permission checks

2016-03-19 Thread Peter Eisentraut
Committed with the discussed adjustment and documentation update. On 3/18/16 2:26 PM, Christoph Berg wrote: > Re: Peter Eisentraut 2016-03-16 <56e8c221.1050...@gmx.net> >>>> * it failed to check for S_IXUSR, so permissions 0700 were okay, in >>>> contradi

Re: [HACKERS] Relaxing SSL key permission checks

2016-03-19 Thread Peter Eisentraut
Committed with the discussed adjustment and documentation update. On 3/18/16 2:26 PM, Christoph Berg wrote: > Re: Peter Eisentraut 2016-03-16 <56e8c221.1050...@gmx.net> >>>> * it failed to check for S_IXUSR, so permissions 0700 were okay, in >>>> contradi

Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-12 Thread Peter Eisentraut
On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: > 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch > > Fixes completion for CREATE INDEX in ordinary way. This part has been fixed in another thread. Please check whether that satisfies all your issues. > 3. 0002-Fix-tab-completion-for-DROP-INDEX.pa

Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-16 Thread Peter Eisentraut
On 1/12/16 9:46 PM, Peter Eisentraut wrote: > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch >> >> Fixes completion for CREATE INDEX in ordinary way. > > This part has been fixed in another thread. Please check whethe

Re: [HACKERS] Releasing in September

2016-01-20 Thread Peter Eisentraut
On 1/20/16 1:44 PM, Robert Haas wrote: > And, you know, I did my time fighting major wars to try to compress > the release schedule, and honestly, it wasn't that much fun. The > process we have now is imperfect in many ways, but I no longer have > abuse heaped on me for wanting to boot a patch out

Re: [HACKERS] COPY (... tab completion

2016-01-20 Thread Peter Eisentraut
On 1/19/16 6:00 AM, Andreas Karlsson wrote: > On 01/19/2016 07:55 AM, Michael Paquier wrote: >> +/* If we have COPY BINARY, compelete with list of tables */ >> s/compelete/complete > > Fixed. > >> +else if (TailMatches2("COPY|\\copy", "(")) >> +COMPLETE_WITH_LIST7("SELECT", "TABLE

Re: [HACKERS] [PATCH] better systemd integration

2016-01-20 Thread Peter Eisentraut
On 1/18/16 10:58 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> I have written a couple of patches to improve the integration of the >> postgres daemon with systemd. > > Great. Is anything happening with these patches, or? They've been > inactive for quite

Re: [HACKERS] Improved tab completion for FDW DDL

2016-01-23 Thread Peter Eisentraut
On 1/18/16 8:36 PM, Andreas Karlsson wrote: > On 01/11/2016 02:39 AM, Peter Eisentraut wrote: >> The second part is not necessary, because there is already code that >> completes FDW names after "FOREIGN DATA WRAPPER". So this already works. > > Good spot, thank

Re: [HACKERS] Proposal: Trigonometric functions in degrees

2016-01-23 Thread Peter Eisentraut
On 1/23/16 12:08 PM, Tom Lane wrote: > So I pushed that, and tern/sungazer are still failing. Noah, could you > trace through that and see exactly where it's going off the rails? I'm still getting a failure in float8 on OS X after commit 73193d8: @@ -490,9 +490,9 @@ x | asind | acosd | atan

Re: [HACKERS] Proposal: Trigonometric functions in degrees

2016-01-23 Thread Peter Eisentraut
On 1/23/16 3:05 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/23/16 12:08 PM, Tom Lane wrote: >>> So I pushed that, and tern/sungazer are still failing. Noah, could you >>> trace through that and see exactly where it's going off the rails? > >>

Re: [HACKERS] Proposal: Trigonometric functions in degrees

2016-01-24 Thread Peter Eisentraut
On 1/23/16 4:18 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/23/16 3:05 PM, Tom Lane wrote: >>> Peter Eisentraut writes: >>>> I'm still getting a failure in float8 on OS X after commit 73193d8: > >>> Weird, because my OS X critters are

Re: [HACKERS] Releasing in September

2016-01-25 Thread Peter Eisentraut
On 1/25/16 2:48 AM, Torsten Zühlsdorff wrote: > Nobody, but there are different solutions. And the same solutions works > different in quality and quantity in the different projects. > In FreeBSD for example there is an online tool for review > (http://review.freebsd.org) which was opened to public

Re: [HACKERS] remove wal_level archive

2016-01-27 Thread Peter Eisentraut
On 1/26/16 10:56 AM, Simon Riggs wrote: > Removing one of "archive" or "hot standby" will just cause confusion and > breakage, so neither is a good choice for removal. I'm pretty sure nothing would break, but I do agree that it could be confusing. > What we should do is > 1. Map "archive" and "h

Re: [HACKERS] [PATCH] better systemd integration

2016-01-27 Thread Peter Eisentraut
for now. I'll come back to it later. > Second issue: > > Mapping of levels between pg and journal levels is moved by1 This is the same as how the "syslog" destination works. From 607323c95ca62d74668992219569c7cff470b63d Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date:

Re: [HACKERS] [PATCH] better systemd integration

2016-01-28 Thread Peter Eisentraut
On 1/28/16 4:00 AM, Pavel Stehule wrote: > Hi > > 2016-01-28 3:50 GMT+01:00 Peter Eisentraut <mailto:pete...@gmx.net>>: > > On 1/27/16 7:02 AM, Pavel Stehule wrote: > > The issues: > > > > 1. configure missing s

[HACKERS] insufficient qualification of some objects in dump files

2016-01-28 Thread Peter Eisentraut
Some dump objects whose names are not unique on a schema level have insufficient details in the dump TOC. For example, a column default might have a TOC entry like this: 2153; 2604 39696 DEFAULT public a rolename Note that this only contains the schema name and the column name, but not the table

Re: [HACKERS] [PATCH] better systemd integration

2016-01-30 Thread Peter Eisentraut
On 1/28/16 9:46 AM, Christoph Berg wrote: > If a cluster is configured for non-hot-standby replication, the > READY=1 seems to never happen. Did you check if that doesn't trigger > any timeouts with would make the unit "fail" or the like? As Pavel showed, it doesn't work for that. I'll look into

Re: [HACKERS] [PATCH] better systemd integration

2016-01-30 Thread Peter Eisentraut
On 1/28/16 10:08 AM, Alvaro Herrera wrote: > I wonder if instead of HAVE_SYSTEMD at each callsite we shouldn't > instead have a pg_sd_notify() call that's a no-op when not systemd. We do this for other optional features as well, and I think it keeps the code clearest, especially if the ifdef'ed se

Re: [HACKERS] [PATCH] better systemd integration

2016-01-30 Thread Peter Eisentraut
On 1/29/16 4:15 PM, Pavel Stehule wrote: > Hi > > > > > > > You sent only rebased code of previous version. I didn't find additional > > checks. > > Oops. Here is the actual new code. > > > New test is working as expected > > I did lot of tests - and this code works perfec

[HACKERS] statistics for shared catalogs not updated when autovacuum is off

2016-01-30 Thread Peter Eisentraut
When autovacuum is off, the statistics in pg_stat_sys_tables for shared catalogs (e.g., pg_authid, pg_database) never update. So seq_scan doesn't update when you read the table, last_analyze doesn't update when you run analyze, etc. But when you shut down the server and restart it with autovacuum

Re: [HACKERS] statistics for shared catalogs not updated when autovacuum is off

2016-02-01 Thread Peter Eisentraut
On 2/1/16 9:49 AM, Jim Nasby wrote: > On 1/30/16 5:05 PM, Peter Eisentraut wrote: >> When autovacuum is off, the statistics in pg_stat_sys_tables for shared >> catalogs (e.g., pg_authid, pg_database) never update. So seq_scan >> doesn't update when you read the table, l

Re: [HACKERS] [PATCH] better systemd integration

2016-02-02 Thread Peter Eisentraut
I've committed this. Thanks for checking. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal: multiple psql option -c

2016-02-04 Thread Peter Eisentraut
On 12/29/15 10:38 AM, Bruce Momjian wrote: > On Thu, Dec 10, 2015 at 11:10:55AM -0500, Robert Haas wrote: >> On Wed, Dec 9, 2015 at 12:15 AM, Pavel Stehule >> wrote: On Wed, Dec 9, 2015 at 2:07 PM, Pavel Stehule wrote: > should be noted, recorded somewhere so this introduce possibl

Re: [HACKERS] remove wal_level archive

2016-02-07 Thread Peter Eisentraut
ted patch to reflect these suggestions. From a1df946bc77cb51ca149a52276175a001942d8d0 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sun, 7 Feb 2016 10:09:05 -0500 Subject: [PATCH v2] Merge wal_level "archive" and "hot_standby" into new name "replica" The disti

Re: [HACKERS] Small PATCH: check of 2 Perl modules

2016-02-15 Thread Peter Eisentraut
On 2/12/16 8:20 AM, Eugene Kazakov wrote: > TAP-tests need two Perl modules: Test::More and IPC::Run. > > The patch adds checking of modules in configure.in and configure. I think those modules are part of a standard Perl installation. -- Sent via pgsql-hackers mailing list (pgsql-hackers@post

Re: [HACKERS] Small PATCH: check of 2 Perl modules

2016-02-15 Thread Peter Eisentraut
On 2/15/16 8:57 AM, Teodor Sigaev wrote: >> On 2/12/16 8:20 AM, Eugene Kazakov wrote: >>> TAP-tests need two Perl modules: Test::More and IPC::Run. >> I think those modules are part of a standard Perl installation. > > IPC::Run is not. At least for perl from ports tree in FreeBSD. Right, that's w

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-02-17 Thread Peter Eisentraut
On 2/9/16 11:21 AM, Daniel Verite wrote: > Note that NULL values in the column that pivots are discarded > by \crosstabview, because NULL as the name of a column does not > make sense. Why not? All you're doing is printing it out, and psql is quite capable of printing a null value. -- Sent vi

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-17 Thread Peter Eisentraut
On 1/31/16 7:34 AM, Michael Paquier wrote: > I am marking this patch as returned with feedback for now, not all the > issues have been fixed yet, and there are still no docs (the > conclusion being that people would like to have this stuff, right?). > Feel free to move it to the next CF should a ne

Re: [HACKERS] Figures in docs

2016-02-17 Thread Peter Eisentraut
On 2/16/16 8:17 PM, Tatsuo Ishii wrote: > It seems there's no figures/diagrams in our docs. I vaguely recall that > we used to have a few diagrams in our docs. If so, was there any > technical reason to remove them? Because no one has been able to propose a good format for storing and editing pict

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-17 Thread Peter Eisentraut
On 2/17/16 12:15 PM, Joe Conway wrote: > On 02/17/2016 02:32 AM, Michael Paquier wrote: >> Actually, having second-thoughts on the matter, why is is that >> necessary to document the function pg_config()? The functions wrapping >> a system view just have the view documented, take for example >> pg_

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-17 Thread Peter Eisentraut
On 2/17/16 5:20 PM, Josh berkus wrote: > I have a use-case for this feature, at part of it containerized > PostgreSQL. Right now, there is certain diagnostic information (like > timeline) which is exposed ONLY in pg_controldata. I'm talking about the pg_config() function, not pg_controldata. --

Re: [HACKERS] Figures in docs

2016-02-17 Thread Peter Eisentraut
On 2/17/16 8:23 PM, Tatsuo Ishii wrote: > Do we really need git history for each figure? It seems we are waiting > for a solution which will never realize. What we need is tooling around a new file format that is similar or analogous to our existing tooling, so that it is easy to edit, easy to rev

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-17 Thread Peter Eisentraut
On 2/17/16 9:08 PM, Michael Paquier wrote: > On Thu, Feb 18, 2016 at 11:02 AM, Peter Eisentraut wrote: >> On 2/17/16 5:20 PM, Josh berkus wrote: >>> I have a use-case for this feature, at part of it containerized >>> PostgreSQL. Right now, there is certain d

[HACKERS] pg_ctl promote wait

2016-02-17 Thread Peter Eisentraut
It would be nice if pg_ctl promote supported the -w (wait) option. How could pg_ctl determine when the promotion has finished? We could query pg_is_in_recovery(), but that would require database access, which we got rid of in pg_ctl. We could check when recovery.conf is gone or recovery.done app

Re: [HACKERS] Relaxing SSL key permission checks

2016-02-18 Thread Peter Eisentraut
On 2/18/16 10:17 AM, Tom Lane wrote: > Christoph Berg writes: >> Currently the server insists on ssl_key_file's permissions to be 0600 >> or less, and be owned by the database user. Debian has been patching >> be-secure.c since forever (the git history goes back to 8.2beta1) to >> relax that to 06

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-18 Thread Peter Eisentraut
On 2/18/16 3:30 AM, Andres Freund wrote: > I don't understand why you're so opposed to this. Several people said > that they're interested in this information in the current discussion > and it has been requested repeatedly over the years. I think no one except Andrew Dunstan has requested this, a

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-18 Thread Peter Eisentraut
On 2/18/16 12:20 PM, Joe Conway wrote: > Just to be clear, AFAIK there is no issue with the committed changes on > Windows. If there is please provide a concrete example that we can discuss. Originally it was mentioned that this feature could be used in the regression tests by making certain tests

Re: [HACKERS] pg_ctl promote wait

2016-02-19 Thread Peter Eisentraut
On 2/18/16 3:33 AM, Andres Freund wrote: > Hi, > > On 2016-02-17 21:47:50 -0500, Peter Eisentraut wrote: >> It would be nice if pg_ctl promote supported the -w (wait) option. >> >> How could pg_ctl determine when the promotion has finished? > > How about looking

Re: [HACKERS] pg_ctl promote wait

2016-02-19 Thread Peter Eisentraut
On 2/19/16 10:06 AM, Fujii Masao wrote: > One concern is that there can be a "time" after the pg_control's state > is changed to DB_IN_PRODUCTION and before the server is able to > start accepting normal (not read-only) connections. So if users try to > start write transaction just after pg_ctl pro

Re: [HACKERS] FDW: should GetFdwRoutine be called when drop table?

2016-02-19 Thread Peter Eisentraut
On 2/19/16 12:21 PM, Feng Tian wrote: > I have an fdw that each foreign table will acquire some persisted resource. > In my case, some files in file system. To drop the table cleanly, I > have written > an object_access_hook that remove those files. The hook is installed in > _PG_init. > > It

[HACKERS] GCC 6 warning fixes

2016-02-19 Thread Peter Eisentraut
r"); -- 2.7.1 From 996a5d27a2bc79e1e0b2ee0aa39cfdc7615e874c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 19 Feb 2016 23:07:46 -0500 Subject: [PATCH 2/3] psql: Fix some strange code in SQL help creation Struct QL_HELP used to be defined as static in the sql_help.h header f

Re: [HACKERS] Declarative partitioning

2016-02-19 Thread Peter Eisentraut
On 2/16/16 9:56 PM, Amit Langote wrote: > From now on, instead of attaching multiple files like in the previous > message, I will send a single tar.gz which will contain patches created by > git-format-patch. Please don't do that. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types

2016-02-24 Thread Peter Eisentraut
On 1/18/16 4:21 PM, Robert Haas wrote: > One idea that occurs to me is: If you can DECLARE BAR FOO%TYPE, but > then you want to make BAR an array of that type rather than a scalar, > why not write that as DECLARE BAR FOO%TYPE[]? That seems quite > natural to me. Right, and it's arguably dubious t

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-02-24 Thread Peter Eisentraut
Could you enhance the documentation about the difference between "wait event type name" and "wait event name" (examples?)? This is likely to be quite confusing for users who are used to just the plain "waiting" column. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: [HACKERS] insufficient qualification of some objects in dump files

2016-02-25 Thread Peter Eisentraut
ive version dump, but I'm not sure. The tags are more of an informational string for human consumption, not strictly part of the archive format. From 44a23b4e960040f1e5de7a0ae0ecb6de432c4027 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 25 Feb 2016 18:56:37 -0500 Subject: [PATCH] pg_du

[HACKERS] drop src/backend/port/darwin/system.c ?

2016-08-17 Thread Peter Eisentraut
/* only needed in OS X 10.1 and possibly early 10.2 releases */ Maybe it's time to let it go? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] Add -c to rsync commands on SR tutorial wiki page

2016-08-17 Thread Peter Eisentraut
to confirm before I just change the page... my intention is to > just stick -c in all the commands. Why do you think that? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mai

Re: [HACKERS] Making pg_hba.conf case-insensitive

2016-08-18 Thread Peter Eisentraut
;t work like that. pg_hba.conf is also not SQL, and neither, for that matter, is pg_ident.conf and postgresql.conf. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

2016-08-18 Thread Peter Eisentraut
hints.ai_next = NULL; > > ret = pg_getaddrinfo_all(str, NULL, &hints, > &gai_result); > if (ret == 0 && gai_result) In addition to what Heikki wrote, I think the above is not necessary. -- Peter Eisentraut

Re: [HACKERS] WIP: About CMake v2

2016-08-18 Thread Peter Eisentraut
llected a lot of practical information about where to get these things. You can see most of that at <https://www.postgresql.org/docs/devel/static/installation-platform-notes.html>. That's at least the spirit of things. I wouldn't worry about this so much right now. Get it work

Re: [HACKERS] pg_basebackup wish list

2016-08-18 Thread Peter Eisentraut
attached patch as a start? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 910310b7eab88af8972906307a55e02e64618da7 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 18 Aug 2016 12:00:00

Re: [HACKERS] drop src/backend/port/darwin/system.c ?

2016-08-18 Thread Peter Eisentraut
Let's nuke it. done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] bigint txids vs 'xid' type, new txid_recent(bigint) => xid

2016-08-19 Thread Peter Eisentraut
and conversions carefully. https://github.com/petere/pguint ;-) > I'm not against adding a 'bigxid' or 'epoch_xid' or something, > internally a uint64. It wouldn't need all the opclasses, casts, function > overloads, etc that uint8 would. That sounds much

[HACKERS] Make better use of existing enums in plpgsql

2016-08-19 Thread Peter Eisentraut
they are only used in pl_exec.c (could be moved there?), and it would bloat this patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 59f9df74fdf1da8ef5f426fabf0815d4e4423f12 Mon Sep 17 00:00:00 2001

Re: [HACKERS] UTF-8 docs?

2016-08-22 Thread Peter Eisentraut
k than just completing the conversion to XML. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [HACKERS] LSN as a recovery target

2016-08-22 Thread Peter Eisentraut
e useful there as well. GUC parsing generally needs, or used to need, to work under more constrained circumstances, e.g., no full memory management. That's not a reason not to try this, but there might be non-obvious problems. -- Peter Eisentraut http://www.2ndQuadrant.com/ P

Re: [HACKERS] UTF-8 docs?

2016-08-22 Thread Peter Eisentraut
On 8/22/16 9:32 AM, Tatsuo Ishii wrote: > I don't know what kind of problem you are seeing with encoding > handling, but at least UTF-8 is working for Japanese, French and > Russian. Those translations are using DocBook XML. -- Peter Eisentraut http://www.2

Re: [HACKERS] Showing parallel status in \df+

2016-08-24 Thread Peter Eisentraut
On 8/22/16 1:52 PM, Pavel Stehule wrote: > If I understand to purpose of this patch - it is compromise - PL source > is removed from table, but it is printed in result. What does it do if you are displaying more than one function? -- Peter Eisentraut http://www.2ndQuadra

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-26 Thread Peter Eisentraut
t; could still be refined, but it's much less likely that users will confuse data with configuration or plain logs under that scheme. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pg

Re: [HACKERS] Unsupported feature F867: WITH TIES

2016-08-26 Thread Peter Eisentraut
ome kind of 'syntactical sugar'? LIMIT/FETCH FIRST works at a level that is quite far removed from data type semantics, which is what you'd need to have handy to compute ties. LIMIT basically just tells the executor to stop after getting a certain number of rows. So implementing

Re: [HACKERS] OpenSSL 1.1 breaks configure and more

2016-08-26 Thread Peter Eisentraut
OpenSSL 0.9.7 and older are really not interesting for > PostgreSQL 10 anymore, I think. CentOS 5 currently ships 0.9.8e. That's usually the oldest OS we want to support eagerly. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote

[HACKERS] old_snapshot_threshold documentation

2016-08-26 Thread Peter Eisentraut
arise, and what are the trade-offs? Where can I see existing snapshots and how old they are? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-26 Thread Peter Eisentraut
This would just formalize where we think appropriate boundaries between the pieces are. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-26 Thread Peter Eisentraut
t; ton of stuff that doesn't need to get broken AFAICS. Sure, I'd be content with leaving those in the top-level instead of say "etc". -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- S

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-26 Thread Peter Eisentraut
his wouldn't be an entirely useless feature for postgres: Can you tell otherwise which of the various pid/lock/opts files you can delete if you have killed the processes and want to eliminate any left-over state? Is postmaster.opts a configuration file or a state file? -- Peter Eisentraut

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-26 Thread Peter Eisentraut
e document to be > symlinkable somewhere else) imo is different. I agree with all that. But the subject line is specifically about moving pg_xlog. So if your opinion is that we shouldn't move pg_xlog, then that is noted. But if we were to move it, we can think about a good place to mov

Re: [HACKERS] Renaming some binaries

2016-08-26 Thread Peter Eisentraut
e is the only documented way to do that thing. Until we have a better way to figure that out, I wouldn't want to put more things into pg_ctl, especially as the only way. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & S

Re: [HACKERS] OpenSSL 1.1 breaks configure and more

2016-08-27 Thread Peter Eisentraut
On 8/26/16 9:26 PM, Andreas Karlsson wrote: > I have attached a patch which removes the < 0.9.8 compatibility code. > Should we also add a version check to configure? We do not have any such > check currently. I think that is not necessary. -- Peter Eisentraut

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-29 Thread Peter Eisentraut
On 8/29/16 12:54 PM, Robert Haas wrote: > As for the new names, how about pg_wal and > pg_xact? I don't think "pg_trans" is as good; is it transactional or > transient or transport or transitive or what? pg_transaction_status? (or pg_xact_status if you want to k

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-08-29 Thread Peter Eisentraut
default log directory is called "pg_log", which is very similar to those other two. There is no quick way to tell their meaning apart. I would consider changing the default from "pg_log" to "log". Then we'd also be at the point where we can say, everything

[HACKERS] sequences and pg_upgrade

2016-08-30 Thread Peter Eisentraut
ose format changes between major releases, and transferred them via the dump/restore route. So instead of copying the disk files, issue a setval call, and the sequence should be all set up. Am I missing anything? Attached is a rough patch set that would implement that. -- Peter Eisentraut

[HACKERS] autonomous transactions

2016-08-30 Thread Peter Eisentraut
ys pretty. - The patch "Set log_line_prefix and application name in test drivers" (https://commitfest.postgresql.org/10/717/) is helpful in testing and debugging this. [0]: https://www.postgresql.org/message-id/flat/CA+Tgmoam66dTzCP8N2cRcS6S6dBMFX+JMba+mDf68H=kakn...@mail.gmail.com -- Pe

[HACKERS] ICU integration

2016-08-30 Thread Peter Eisentraut
ormatting.c needs some refactoring. There are so many ifdefs there and it's repeated almost identically three times, it's crazy to work in that. [0]: https://www.postgresql.org/message-id/flat/789A2F56-0E42-409D-A840-6AF5110D6085%40pingpong.net -- Peter Eisentraut http://www.2

[HACKERS] identity columns

2016-08-30 Thread Peter Eisentraut
one OID at a time, so you need to create the table and sequences in separate entries. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 4e09

Re: [HACKERS] ICU integration

2016-08-30 Thread Peter Eisentraut
ndexes, or build PostgreSQL with the right version of ICU."))); So you still need to manage this carefully, but at least you have a chance to learn about it. Suggestions for refining this are welcome. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

[HACKERS] sequence data type

2016-08-30 Thread Peter Eisentraut
to do manually. If you tell the sequence the data type you have in mind, it automatically sets appropriate min and max values. Serial columns also make use of this, so the sequence type automatically matches the column type. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Develo

  1   2   3   4   5   6   7   8   9   10   >