* Peter Eisentraut wrote:
On 2/12/16 11:24 AM, Christian Ullrich wrote:
Otherwise, it may be time to update the manual (15.6 Supported
Platforms) where it says PostgreSQL "can be expected to work on these
operating systems: [...] Windows (Win2000 SP4 and later), [...]".
Perhaps we
* Magnus Hagander wrote:
On Sat, Feb 13, 2016 at 4:45 PM, Christian Ullrich
wrote:
On February 13, 2016 4:10:34 PM Tom Lane wrote:
I'm also suspicious of the "#if _MSC_VER == 1800" tests, that is,
the code compiles on *exactly one* MSVC version.
The bug exists in onl
* Magnus Hagander wrote:
On Wed, Mar 9, 2016 at 4:36 PM, Christian Ullrich
wrote:
* Magnus Hagander wrote:
How does this work wrt mingw, though? Do we have the same problem there?
AIUI this code can never run on mingw, correct?
Not unless mingw defines _MSC_VER.
The question is then
* Magnus Hagander wrote:
I did notice the #ifdef's are actually different in the header and body
section of the patch, which seems wrong. I used the one from the actual
implementation (_M_AMD64) for the header includes as, and also merged the
#ifdef's together to a single #if in each section. Pl
* Alvaro Herrera wrote:
Magnus Hagander wrote:
On Wed, Mar 9, 2016 at 4:36 PM, Christian Ullrich
wrote:
And apparently not a single one with VS 2013. OK, I'll see what I can do
about setting some up soonish, at least with (server) 2008 and (client) 7.
FWIW, I have a local build of
* From: Magnus Hagander [mailto:mag...@hagander.net]
> I took a quick look at this one, and have some initial thoughts.
>
> I don't like the name "real_realm" as a parameter name. I'm wondering if
> it might be better to reverse the meaning, and call it sspi_netbios_realm
> (and then change the d
* Christian Ullrich wrote:
* From: Magnus Hagander [mailto:mag...@hagander.net]
I don't like the name "real_realm" as a parameter name. I'm wondering if
it might be better to reverse the meaning, and call it sspi_netbios_realm
(and then change the default to on, to be
* From: Robbie Harwood [mailto:rharw...@redhat.com]
> Christian Ullrich writes:
>
> > Updated patch attached.
>
> I unfortunately don't have windows machines to test this on, but I
> thought it might be helpful to review this anyway since I'm touching
> cod
On 2016-03-24 16:35, Christian Ullrich wrote:
* From: Robbie Harwood [mailto:rharw...@redhat.com]
Christian Ullrich writes:
pg_SSPI_recvauth(Port *port)
{
int mtype;
+ int status;
The section of this function for include_realm
* From: Christian Ullrich
> * From: Robbie Harwood [mailto:rharw...@redhat.com]
>
> > Christian Ullrich writes:
> > > + /* Replace domainname with realm name. */
> > > + if (upnamerealmsize > domainnamesize)
> > > +
* From: Alvaro Herrera [mailto:alvhe...@2ndquadrant.com]
> Christian Ullrich wrote:
> > * Christian Ullrich wrote:
> >
> > >* From: Magnus Hagander [mailto:mag...@hagander.net]
>
> > >>Code uses a mix of malloc() and palloc() (through sprintf). Is ther
* Tom Lane wrote:
Michael Paquier writes:
Buildfarm-not-being-happy-status: woodloose, mastodon, thrips, jacana.
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2016-03-29%2000%3A42%3A08
The origin of the problem is that, which prevents all the subsequent
queries to fail:
* Tom Lane wrote:
Christian Ullrich writes:
zic aborts somewhere between writing Etc/UTC and UTC.
Huh ... I would not have guessed that. Can you track down exactly
where it's failing?
I'd love to, but with 656ee84 I cannot reproduce on my Windows 10
system. I can try on t
* Christian Ullrich wrote:
* Tom Lane wrote:
Christian Ullrich writes:
zic aborts somewhere between writing Etc/UTC and UTC.
Huh ... I would not have guessed that. Can you track down exactly
where it's failing?
I'd love to, but with 656ee84 I cannot reproduce on my Windows
There are some instances of calls to FormatMessage() with the
FORMAT_MESSAGE_FROM_SYSTEM flag that omit the
FORMAT_MESSAGE_IGNORE_INSERTS flag. The effect of that is that if the
requested message string contains any insertion markers, the call to
FormatMessage() will fail because none of these
* Tom Lane wrote:
Christian Ullrich writes:
Anyway, I think Michael's fix is wrong. The bug is that the Win32
version of link() (at the bottom of zic.c) does not set errno if its
attempt to copy the file fails, so what dolink() puts into link_errno is
bogus.
Ah-hah, that explains t
* Magnus Hagander wrote:
On Tue, Mar 29, 2016 at 5:09 PM, David Steele wrote:
It seems like this patch should be set "ready for committer". Can one of
the reviewers do that if appropriate?
I'll pick it up to do that as well as committing it.
Ah, good news!
I hope it's not coming too la
* Christian Ullrich wrote:
* Christian Ullrich wrote:
* Christian Ullrich wrote:
> According to the release notes, the default for the "include_realm"
> option in SSPI authentication was changed from off to on in 9.5 for
> > improved security. However, the authenticat
* Andreas 'ads' Scherbaum wrote:
one of our customers approached us and complained, that GET DIAGNOSTICS
row_count returns invalid results if the number of rows is > 2^31. It's
Attached patch expands the row_count to 64 bit.
diagnostics=# select testfunc_pg((2^32 + 5)::bigint);
testfun
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
* Andreas 'ads' Scherbaum wrote:
> one of our customers approached us an
Ah, so it turns out I should have used the commitfest tool. My
apologies; I will send the whole thing through that again. Please
disregard the earlier message.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
Hello,
I just found a compatibility issue when I was migrating an elderly VM to
a new host. The VM is running Windows Server 2008 SP2, and it has the
EDB build of PostgreSQL 9.4.5 on it. (9.4.6 behaves the same.) It is
also not dependent on running in a VM; it would fail on the hardware as
we
* Christian Ullrich wrote:
Backends (and possibly other processes) crash at the slightest
provocation, such as "SELECT * FROM pg_stat_activity;" or VACUUM. The
log says either "exception 0xC005" (segfault) or "exception
0xC01D" (illegal instruction).
T
* Robert Haas wrote:
On Fri, Feb 12, 2016 at 7:26 PM, Christian Ullrich wrote:
startup_hacks(), I think. Proposed patch attached.
Thanks for the report and patch. Regrettably I haven't the Windows
knowledge to have any idea whether it's right or wrong, but hopefully
someone
On February 13, 2016 4:10:34 PM Tom Lane wrote:
> Christian Ullrich writes:
>> * Robert Haas wrote:
>>> Thanks for the report and patch. Regrettably I haven't the Windows
>>> knowledge to have any idea whether it's right or wrong, but hopefully
>>&g
* From: Christian Ullrich
> On February 13, 2016 4:10:34 PM Tom Lane wrote:
>
> > Christian Ullrich writes:
> > Lastly, I'd like to see some discussion of what side effects
> > "_set_FMA3_enable(0);" has ... I rather doubt that it's really
> >
* Andreas 'ads' Scherbaum wrote:
Attached is a new version of the patch, with %lu replaced by %zu.
I re-ran all the tests, especially the long test with 2^32+x rows, and
it produces the same result as before.
To paraphrase Twain: "Sire, the Board finds this patch perfect in all
the requiremen
* Michael Paquier wrote:
> On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich
wrote:
>> * Christian Ullrich wrote:
> And actually, by looking at those patches, isn't it a dangerous
> practice to be able to load multiple versions of the same DLL routines
> in the
* Michael Paquier wrote:
On Mon, Sep 5, 2016 at 9:18 AM, Noah Misch wrote:
Every vcbuild and msbuild invocation ought to recognize this variable, so
please update the two places involving ecpg_regression.proj. Apart from that,
the patch looks good.
Good catch. I did not notice those durin
* Michael Paquier wrote:
On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote:
My conclusion from April stands:
The fact that master looks like it does means that there have not been
many (or any) complaints about missing cross-module environment
variables. If nobody ever needs to see
* Michael Paquier wrote:
On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote:
* Michael Paquier wrote:
In order to avoid any problems with the load and unload windows, my
bet goes for 0001, 0002 and 0003, with the last two patches merged
together, 0001 being only a set of independent
attached, also reordering the ecpg-clean command line in clean.bat
to match the others that have the project file first.
--
Christian
>From 09a5f3945e2b87b56ca3525a56db970e9ecf8ffd Mon Sep 17 00:00:00 2001
From: Christian Ullrich
Date: Thu, 8 Sep 2016 08:34:45 +0200
Subject: [PATCH] Let MSBFL
* Noah Misch wrote:
> On Tue, Apr 26, 2016 at 07:39:29PM +0200, Christian Ullrich
> wrote:
> > * Christian Ullrich wrote:
> Patch 1 looks good, except that it should be three patches:
>
> - cosmetic parts: change whitespace and s/0/NULL/
> - remove CloseHandle() call
* From: MauMau [mailto:maumau...@gmail.com]
> From: "Christian Ullrich"
> > OK, here is the first draft against current master. It builds on Windows
> > with VS 2012 and on FreeBSD 10 with clang 3.3. I ran the regression
> > tests on Windows, they all pass.
* From: Noah Misch [mailto:n...@leadboat.com]
> I liked the proposal here; was there a problem with it?
> http://www.postgresql.org/message-
> id/ca+tgmoz3ake4enctmqmzsykc_0pjl_u4c_x47ge48uy1upb...@mail.gmail.com
You're referring to the suggestion of accepting and ignoring the option on
non-Windo
* From: Noah Misch [mailto:n...@leadboat.com]
> On Mon, Jun 30, 2014 at 07:28:03PM +0000, Christian Ullrich wrote:
> > * From: Noah Misch [mailto:n...@leadboat.com]
> > > I liked the proposal here; was there a problem with it?
> > > http://www.postgres
Hello,
my buildfarm animal woodlouse (Visual Studio 2013 on Windows 7) stopped
working correctly some months ago. After Tom kindly prodded me into
fixing it, I noticed that I had configured it to skip the ecpg-check
step because one of the tests in the "thread" section (not always the
same) n
* Andrew Dunstan wrote:
On 06/11/2017 11:33 AM, Christian Ullrich wrote:
To build correctly, it requires defining _WIN32_WINNT to be 0x600 or
above (and using an SDK that knows about InitOnceExecuteOnce()).
We already define _WIN32_WINNT to be 0x0600 on all appropriate platforms
(Vista
Christian
From 5dee698f4cef684a320ced59b19cd4fea61319fb Mon Sep 17 00:00:00 2001
From: Christian Ullrich
Date: Wed, 14 Jun 2017 22:18:18 +0200
Subject: [PATCH] Make setlocale() aware of multithreading to avoid crash.
---
src/interfaces/ecpg/test/expected/thread-alloc.c | 39 +++--
.../ecpg/test/
* On 2017-06-21 02:06, Haribabu Kommi wrote:
Thanks for the review. Here I attached an updated patch with README update.
Hello,
the most recent update to VS 2017, version 15.3, now identifies as
"14.11" rather than "14.10" in the output of nmake /?. Simply adding
this value to the two place
* Michael Meskes wrote:
The v3 patch looks good to me. I've changed this patch status to Ready
for Committer.
Thank you all, committed.
The buildfarm says that sorting is frequently done case-sensitively:
*** 1,2
- josh 1.00 10.00
Ram 00.00 21.00
--- 1,2
Ram 11
* Michael Meskes wrote:
>> It's not just thrips. Of the Windows machines that have reported in
>> since
>> that commit, only currawong and baiji passed. Although lorikeet,
>> woodlouse, bowerbird, and brolga are showing green, this proves
>> nothing
>> because they're all configured to skip the
* Dann Corbit wrote:
The PostgreSQL installer for Windows 64 appears to be broken for Microsoft
Windows Server 2012 Standard.
Even after uninstalling, removing the entire postgresql directory structure,
and running the installer as administrator, I get this error:
"fixing permissions on exis
items, plus the terminator.
--
Christian Ullrich
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ISCLOSING/NOT DISCLOSING, but I
prefer LEAKPROOF even over that, not just because it's shorter.
--
Christian Ullrich
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
e zone
time with time zone
bit varying
(7 Zeilen)
I think these are all specially handled in the parser.
--
Christian Ullrich
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
* Heikki Linnakangas wrote:
The current situation is that if you run out of disk space while writing
WAL, you get a PANIC, and the server shuts down. That's awful. We can
So we need to somehow stop new WAL insertions from happening, before
it's too late.
A naive idea is to check if there's
* Tom Lane wrote:
it supposes that rolvaliduntil represents an expiration date for the
user, but really it's only an expiration date for the password.)
Does anyone think the docs for CREATE ROLE/VALID UNTIL should mention
this more clearly? Currently, it is described as
The VALID UN
The CLOBBER_CACHE_ALWAYS animals (friarbird and jaguarundi) have been
failing persistently for about 36 hours now. The error is in a test
added by Tom's recent commit a4424c5:
Expected:
-- Check row comparisons with IN
select * from int8_tbl i8 where i8 in (row(123,456)); -- fail, type
misma
* Andrew Dunstan wrote:
I'm toying with the idea of a check_upgrade mode for the buildfarm
client where it wouldn't do a git pull, but would report changes if the
build result was different from the previous result. You'd run this
immediately after pulling new changes into your OS. Other, bright
* Stephen Frost wrote:
RLS fixes, new hooks, and new test module
The buildfarm says that with -DCLOBBER_CACHE_ALWAYS, the RLS violations
get blamed on the wrong tables. Mostly, they are catalogs (I have seen
pg_opclass, pg_am, and pg_amproc), but some also come up with binary
garbage instea
* Andrew Dunstan:
friarbird is a FreeBSD buildfarm animal running with
-DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours.
However, it's been stuck since Monday running the plpython regression
tests. The only relevant commit seems to be the transforms feature.
Here's what it's
* Peter Eisentraut wrote:
On 4/30/15 2:49 PM, Andrew Dunstan wrote:
friarbird is a FreeBSD buildfarm animal running with
-DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours.
However, it's been stuck since Monday running the plpython regression
tests. The only relevant commit
* Tom Lane wrote:
Christian Ullrich writes:
* Peter Eisentraut wrote:
On 4/30/15 2:49 PM, Andrew Dunstan wrote:
friarbird is a FreeBSD buildfarm animal running with
-DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours.
However, it's been stuck since Monday runnin
* Alvaro Herrera wrote:
Michael Paquier wrote:
Btw, perhaps this diff should be pushed as a different patch as this is a
rather different thing:
- if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED
&&
+ if (indexRelation->rd_rel->relpersistence ==
RELPERSISTENCE_UN
Hello,
I just noticed that last night all built branches failed on my buildfarm
animal, jaguarundi. They all failed on the "xml" test, and the output is
essentially the same everywhere:
***
*** 9,16
LINE 1: INSERT INTO xmltest VALUES (3, ' SELECT xmlconcat('', NULL, 'stand
* Michael Paquier wrote:
On Sat, Dec 5, 2015 at 4:38 PM, Christian Ullrich wrote:
I have zero experience with libxml2, so no idea if the previous context
level can be turned on again. IMHO, the libxml2 change is a bug in itself;
PostgreSQL's error messages are more readable with the XML
* Christian Ullrich wrote:
* Christian Ullrich wrote:
> According to the release notes, the default for the "include_realm"
> option in SSPI authentication was changed from off to on in 9.5 for
> > improved security. However, the authenticated user name, with the
> &
Hello,
here's a one-line patch to close a handle leak in pg_SSPI_recvauth().
According to the docs, the token retrieved with
QuerySecurityContextToken() must be closed.
--
Christian
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
new file mode 100644
index 0131bfd..57c2f48
*
Hello all,
the extension modules (TestUpgrade etc.) in the buildfarm client do not
use the "make" command override defined in the config file, instead
hardcoding command lines using "make". This fails where make is not GNU
make.
Patch attached, which fixes the problem on jaguarundi.
--
Chri
* Andrew Dunstan wrote:
On 12/04/2012 02:40 AM, Christian Ullrich wrote:
the extension modules (TestUpgrade etc.) in the buildfarm client do
not use the "make" command override defined in the config file,
Patch attached, which fixes the problem on jaguarundi.
Thanks, I will f
* Tom Lane wrote:
We really need to scare up another buildfarm member to run with
-DCLOBBER_CACHE_ALWAYS, now that jaguar has stopped doing so.
I would be happy to do that on jaguarundi, in exchange for dialing down
the build frequency from hourly to something a bit less ambitious. That
mach
* Christoph Berg wrote:
Re: Tom Lane 2013-01-09 <9802.1357702...@sss.pgh.pa.us>
and Python.h. However, adding one won't fix your problem on
Debian-based distros, because for some wacko reason they put the
headers and the shlib .so symlink in different packages, cf
http://packages.debian.org/
Hello all,
this patch adds support for connecting to servers running on Windows
and requesting SSPI authentication. It does this by treating
AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native SSPI support is
available.
In addition to being generally useful, this is a workaround to a
problem wit
* Robert Haas wrote:
On Mon, Jan 3, 2011 at 8:11 AM, Christian Ullrich wrote:
this patch adds support for connecting to servers running on Windows
and requesting SSPI authentication. It does this by treating
AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native SSPI support is
available.
I
* Joel Jacobson wrote:
The example from Tom Lane below results in a database which is not
possible to correctly dump using pg_dump.
The view v1 strangely becomes a table in the dump output?!
This is no bug, it's a feature (tm).
pg_dump is clever enough to detect the circular dependency and b
Magnus Hagander wrote:
On Mon, Jan 3, 2011 at 14:11, Christian Ullrich wrote:
Hello all,
this patch adds support for connecting to servers running on Windows
and requesting SSPI authentication. It does this by treating
AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native SSPI support is
* Christian Ullrich wrote:
Magnus Hagander wrote:
On Mon, Jan 3, 2011 at 14:11, Christian Ullrich
wrote:
This change has been tested and works correctly on FreeBSD 8.1, using
the Kerberos and GSSAPI libraries from Heimdal 1.4. The server is
running PostgreSQL 9.0.2 on Windows 2008
Hello all,
the EDB one-click installer has a slightly annoying bug in its
pg_env.bat script:
@SET PATH="C:\Program Files\PostgreSQL\9.1\bin";%PATH%
PATH entries should not be quoted. As it is, every time a program is
started from this path, I get a message along the lines of
could
* Bruce Momjian wrote:
Thom Brown wrote:
Also:
SELECT alias, description, token FROM ts_debug('myname+prior...@gmail.com');
Yields:
alias | description | token
---+-+
asciiword | Word, all ASCII | myname
blank | Space symb
When Magnus fixed and applied my SSPI-via-GSS patch in January, we
forgot to fix to the documentation. Suggested patch attached; should I
also put that four-liner into any CFs?
--
Christian
diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml
new file mode 100644
index 575
* Robert Haas wrote:
On Fri, Jun 24, 2011 at 6:07 PM, Christian Ullrich wrote:
When Magnus fixed and applied my SSPI-via-GSS patch in January, we forgot to
fix to the documentation. Suggested patch attached; should I also put that
four-liner into any CFs?
I have committed a slightly
* Magnus Hagander wrote:
However, i think the code path down around the error message is simply
incorrect. That #ifdef spaghetti is pretty hard to parse, but it gives
the wrong error message (we should say it's sspi that's not available
when we have none of the two options) and/or a "duplicate c
* Christopher Hotchkiss wrote:
I would like to propose (and volunteer to do if its considered to be a
decent idea) to extend the mapping of users to roles in the
pg_ident.conf to incorporate groups. This would allow any user who
belonged to a particular group in certain authentication systems to
* Christopher Hotchkiss wrote:
On Tue, Feb 1, 2011 at 2:49 PM, Christian Ullrich wrote:
* Christopher Hotchkiss wrote:
I would like to propose (and volunteer to do if its considered to be a
decent idea) to extend the mapping of users to roles in the
pg_ident.conf to incorporate groups. This
* Andrew Dunstan wrote:
On 04/07/2011 03:48 AM, Alastair Turner wrote:
Is the solution possibly to assign positive entries on the basis of
the superuser being a member of all groups but require negative
entries to explicitly specify that they apply to superuser?
I think that's just about g
* Tom Lane wrote:
I looked at this patch a bit. I agree that we need to fix
pgwin32_CommandLine to double-quote the executable name, but it needs a
great deal more work than that :-(. Whoever wrote this code was
One additional issue is that the path to the service executable should
use back
Hello all,
when pg_ctl start is used to run PostgreSQL in a console window on
Windows, it runs in the background (it is terminated by closing the
window, but that is probably inevitable). There is one problem, however:
The first Ctrl-C in that window, no matter in which situation, will
cause
* Michael Paquier wrote:
> On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich
> wrote:
>> I also did a debug build with 1+2+4 that came in at 84 μs/iteration.
>
> Moved to next CF. Christian, perhaps this patch should have an extra
> round of reviews?
It is significant
* From: Michael Paquier
> With 0005 I am seeing a compilation failure: you need to have the
> declarations in the _MSC_VER block at the beginning of the routine. It
Sorry, too used to C++.
> would be nice to mention in a code comment that this what Noah has
> mentioned upthread: if a CRT loads w
* Petr Jelinek wrote:
On 07/04/16 00:50, Michael Paquier wrote:
On Thu, Apr 7, 2016 at 7:44 AM, Michael Paquier
wrote:
On Thu, Apr 7, 2016 at 6:11 AM, Petr Jelinek
wrote:
On 06/04/16 22:50, Andrew Dunstan wrote:
* VS2015 appears to create version 12 solution files, not
version 14
* Magnus Hagander wrote:
On Tue, Mar 29, 2016 at 5:09 PM, David Steele wrote:
It seems like this patch should be set "ready for committer". Can one of
the reviewers do that if appropriate?
I'll pick it up to do that as well as committing it.
Magnus, do you intend to commit the patch be
Hello,
could we perhaps lower the verbosity level of the msvc build (in
src/tools/msvc/build.pl) from "detailed" to "normal"? In my experiment,
this reduces the size of the build log by 96.4 percent (from 12.5 MiB to
438 KiB), or if the log is not redirected, it shortens the build time by
45
* Michael Paquier wrote:
> On Fri, Apr 8, 2016 at 9:29 AM, Andrew Dunstan
> wrote:
Not out of the woods yet. Attached is what I got from VS2015 on a fresh W10
VM, with Michael's patch 0002 and 0004 applied.
Interesting, I have no idea what we are doing differently, and seeing
those errors
* Michael Paquier wrote:
On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan wrote:
¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote:
Michael, none of your patches change this, so how does it ever build on
your system?
Luck. I am getting a warning but the code is able to somewhat comp
* Tom Lane wrote:
+several. Grepping for compiler warnings, for example, is really painful
right now on any MSVC critter. I've resorted to grepping for "warning C",
which skips the noise messages, but I'm never sure if I'm missing
something.
You miss all diagnostics from other tools than the
* Andrew Dunstan wrote:
On 04/08/2016 11:02 AM, Christian Ullrich wrote:
src/port/chklocale.c(233): warning C4133: 'function': incompatible
types - from 'const char *' to 'LPCWSTR' [...\postgres.vcxproj]
Do you have a fix for the LPCWSTR parameter issue?
> Michael Paquier wrote:
>
> On Sat, Apr 9, 2016 at 7:41 AM, Michael Paquier
> wrote:
>> On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich
>> wrote:
>>> * Andrew Dunstan wrote:
>>>>> On 04/08/2016 11:02 AM, Christian Ullrich wrote:
>>&g
* Andrew Dunstan:
On 04/09/2016 08:43 AM, Christian Ullrich wrote:
Michael Paquier wrote:
I don't think that's good to use malloc in those code paths, and I
Oh?
+#if (_MSC_VER >= 1900)
+ uint32 cp;
+
+ if (GetLocal
.
--
Christian
From 9bc9e8ed79747f7bf3e727c9f64f4a088de589fb Mon Sep 17 00:00:00 2001
From: Christian Ullrich
Date: Mon, 11 Apr 2016 15:47:20 +0200
Subject: [PATCH] Fixed preprocessor condition (WIN64 -> _WIN64).
---
src/test/regress/pg_regress.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
* Tom Lane wrote:
Christian Ullrich writes:
According to git grep, this is the only place where WIN64 is used
without the leading underscore.
Hm, my grep found another one ...
Oh, sorry. I saw that one, but thought it was intentional because _WIN64
is defined automatically anyway
* From: Tom Lane [mailto:t...@sss.pgh.pa.us]
> Christian Ullrich writes:
> > * Tom Lane wrote:
> >> Hm, my grep found another one ...
>
> > Oh, sorry. I saw that one, but thought it was intentional because _WIN64
> > is defined automatically anyway.
>
>
* Alvaro Herrera wrote:
Michael Paquier wrote:
On Mon, Apr 11, 2016 at 3:25 PM, Michael Paquier
wrote:
Now, I have produced two patches:
- 0001-Support-for-VS-2015-locale-hack.patch, which makes use of
__crt_locale_data_public in ucrt/corecrt.h. This is definitely an ugly
hack, though I am co
* Michael Paquier wrote:
On Wed, Apr 20, 2016 at 1:48 AM, Christian Ullrich wrote:
Both patches behave exactly the same in this test. Of the 102 remaining
locales, I get an unexpected codepage for just four:
- kk: Expected 1251, used 1252
- kk-KZ: Expected 1251, used 1252
- sr: Expected 1251
* From: Andrew Dunstan [mailto:and...@dunslane.net]
> 4. The compiler complains about one of Microsoft's own header files -
> essentially it dislikes the=is construct:
>
> typedef enum { ... };
>
> It would be nice to make it shut up about it.
I doubt that's possible; the declaration *is* w
* Andrew Dunstan wrote:
On 04/22/2016 02:46 AM, Michael Paquier wrote:
Progress report:
1. My VS 2015 installations (I now have several) all generate
solution file
with:
Microsoft Visual Studio Solution File, Format Version 12.00
so I propose to set that as the solution file version.
>>
* Christian Ullrich wrote:
* Andrew Dunstan wrote:
On 04/22/2016 02:46 AM, Michael Paquier wrote:
Progress report:
1. My VS 2015 installations (I now have several) all generate
solution file
with:
Microsoft Visual Studio Solution File, Format Version 12.00
so I propose to set that as
* Andrew Dunstan wrote:
On 04/22/2016 01:21 AM, Michael Paquier wrote:
5. It also complains about us casting a pid_t to a HANDLE in
pg_basebackup.c. Not sure what to do about that.
The thing that's being cast is not a PID, but a HANDLE to a process.
pid_t is a typedef for int (in port/win32.
* Andrew Dunstan wrote:
On 04/24/2016 12:14 PM, Tom Lane wrote:
Andrew Dunstan writes:
OK, here's my final version of the patch, which I will apply in 24 hours
or so unless there is an objection.
BTW, in view of 9f633b404, shouldn't there be a similar addition to
win32env.c in this patch
* Andrew Dunstan wrote:
On 04/24/2016 03:16 PM, Christian Ullrich wrote:
* Andrew Dunstan wrote:
msvcr120.dll seems to be the highest numbered one on my system, and we
already cover that. If you like we can add to the comments in that file.
There won't be a higher one, with VS 2015
1 - 100 of 130 matches
Mail list logo
