inaries, it does
not include additional provided information.
Can you please guide how can I perform similar functionality via configure
script (that can be used on Unix like OS/MinGW) or It is intended for
Window specific requirement ?. Thanks.
Regards,
Muhammad Asif Naeem
On Tue, May 27, 2014 at
tdb.exe -V
> initdb (PostgreSQL) 9.5devel-30JUN
Patch looks good to me. I think it is ready for committer. Thanks.
Regards,
Muhammad Asif Naeem
On Fri, Jun 27, 2014 at 5:00 AM, Michael Paquier
wrote:
>
>
>
> On Fri, Jun 27, 2014 at 8:26 AM, Asif Naeem wrote:
>
>> I ha
- b/src/backend/utils/adt/network.c
> --
> File to patch:
Is there any other utility required to apply the patch, Can you please
guide ?. Thanks.
Regards,
Muhammad Asif Naeem
On Thu, Jun 5, 2014 at 6:28 AM, Haribabu Kommi
wrote:
> On Thu, Jun 5, 2014 at 9:12 AM, Andres Freund
> wrot
On Mon, Jun 30, 2014 at 4:45 PM, Abhijit Menon-Sen
wrote:
> At 2014-06-30 16:35:45 +0500, anaeem...@gmail.com wrote:
> >
> > pc1dotnetpk:postgresql asif$ patch -p0 <
> > > ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch
> > > can't find file to patch at input line 3
> > > Perhaps you
source
code, general practice seems to be to use “smaller" and “larger” as related
function name postfix e.g. timestamp_smaller()/timestamp_larger(),
interval_smaller/interval_larger(), cashsmaller()/cashlarger() etc. Thanks.
Regards,
Muhammad Asif Naeem
On Mon, Jul 7, 2014 at 1:56 PM, Asif
Hi MauMau,
Other than my pervious comments, patch looks good to me. Thanks.
Regards,
Muhammad Asif Naeem
On Wed, Feb 26, 2014 at 2:14 AM, Peter Eisentraut wrote:
> You should be able to do this without specifically referencing the names
> "libpq" or "ecpg". Loo
Yes. Can you please take a look at Win_lib_bin.patch I shared earlier ?, I
think it is or similar approach will be appropriate. Thanks.
Regards,
Muhammad Asif Naeem
On Tue, Jul 8, 2014 at 5:53 PM, MauMau wrote:
> From: "Asif Naeem"
>
> Other than my pervious comments, pat
NULL baz(3 rows)
>
> min( class="parameter">expression)
>
> - any array, numeric, string, or date/time type
> + any inet, array, numeric, string, or date/time type
>same as argument type
>
> minimum value
Thank you Haribabu. Please see my comments inlined below i.e.
On Sun, Jul 27, 2014 at 11:42 AM, Haribabu Kommi
wrote:
> On Thu, Jul 24, 2014 at 5:59 PM, Asif Naeem wrote:
> > Sorry for being late. Thank you for sharing updated patch, sgml changes
> > seems not working i.e.
&g
It seems that you need to use another oid. Other than this patch looks good
to me, please share updated patch and feel free to assign it to committer.
Thanks.
Regards,
Muhammad Asif Naeem
On Tue, Aug 12, 2014 at 3:12 PM, Haribabu Kommi
wrote:
> On Mon, Aug 4, 2014 at 3:22 PM, Asif Naeem
gt; symbolic link \"%s\": %m",
> 772 linkloc)));
> 773 }
> ….
Other than this patch looks good to me.
Regards,
Muhammad Asif Naeem
On Thu, Oct 31, 2013 at 8:03 PM, MauMau wrote:
> From: &q
e
>if (unlink(linkloc) < 0 && errno != ENOENT)
> + #endif
>ereport(ERROR,
>(errcode_for_file_access(),
> errmsg("could not remove symbolic link \"%s\": %m",
What is your opinion about it, Is it not worth changing ? . Thanks.
On We
or
AddDllDirectory function available that effects only subsequent calls to
LoadLibrary and LoadLibraryEx.
I will look into this patch further and let you know about my more
findings. Thanks.
Regards,
Muhammad Asif Naeem
On Wed, Dec 4, 2013 at 5:07 PM, MauMau wrote:
> From: "MauMa
riable "var" to "val"
> */
> static void
> doputenv(const char *var, const char *val)
> {
> char *s;
> pg_asprintf(&s, "%s=%s", var, val);
> putenv(s);
> }
Please do let me know if I missed something or more info is require
On Tue, Sep 17, 2013 at 3:13 PM, Asif Naeem wrote:
> Hi,
>
> I did put some time review the patch, please see my findings below i.e.
>
> 1. It seems that you have used strdup() on multiple places in the patch,
> e.g. in the below code snippet is it going to lead crash if new
: git apply: bad git-diff - expected /dev/null on line 1557
Neither git nor patch command apply the patch successfully. Can you please
guide ?. Thanks.
Best Regards,
Muhammad Asif Naeem
On Wed, Oct 2, 2013 at 7:29 AM, Peter Eisentraut wrote:
> On Tue, 2013-09-17 at 15:13 +0500, Asif Nae
You are right, wget worked. Latest patch looks good to me. make check run
fine. Thank you Peter.
On Wed, Oct 2, 2013 at 5:02 PM, Peter Eisentraut wrote:
> On 10/2/13 5:12 AM, Asif Naeem wrote:
> > Neither git nor patch command apply the patch successfully. Can you
> > please
+1
I think you can safely use va_list without copy on Windows. va_copy is
available in Visual Studio 2013 as part of support for C99, previous
versions don't have it.
Regards,
Muhammad Asif Naeem
On Tue, Oct 15, 2013 at 10:33 AM, Amit Kapila wrote:
> On Tue, Oct 15, 2013 at 2:18 A
On Tue, Oct 15, 2013 at 10:55 AM, David Rowley wrote:
> Though this is not yet enough to get the windows build work with me... I'm
> still getting link failures for isolationtester.c
>
>
> "D:\Postgres\c\pgsql.sln" (default target) (1) ->
> "D:\Postgres\c\isolationtester.vcxproj" (default target)
C:\Users\asif\Desktop\Program files\9.3\data1" -l logfile start
> server starting
Can you please share the exact steps ?. Thanks.
Regards,
Muhammad Asif Naeem
On Mon, Oct 28, 2013 at 10:26 AM, Naoya Anzai wrote:
> Hi All,
>
> I have found a case that PostgreSQL Service does not s
gram files\9.3\data" -w
> NAME INVALID
> C:\Users\asif\Desktop\Program files\9.3\bin\pg_ctl.exe runservice -N
> "postgresql-9.3" -D "C:\Users\asif\Desktop\Program files\9.3\data" -w.exe
> NAME INVALID
Fix :
postgresql-9.3 service path : "C:/Users/asif/D
Hi Sandeep,
PFA Naoya's patch (pg_ctl.c.patch).
Hi Naoya,
Good finding. I have attached another version of patch
(pg_ctl.c_windows_vulnerability.patch) attached that has fewer lines of
code changes, can you please take a look ?. Thanks.
Best Regards,
Asif Naeem
On Mon, Oct 28, 2013 at
Yes. It should not be installer issue as installer is using pg_ctl to
register and run the service on Windows. Thanks.
Best Regards,
Muhammad Asif Naeem
On Tue, Oct 29, 2013 at 9:57 AM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> So, this is not an installer issue. Is
On Thu, Oct 31, 2013 at 10:17 AM, Amit Kapila wrote:
> On Tue, Oct 29, 2013 at 12:46 PM, Naoya Anzai
> wrote:
> > Hi Sandeep
> >
> >> I think, you should change the subject line to "Unquoted service path
> containing space is vulnerable and can be exploited on Windows" to get the
> attention..
elp" for help.
> postgres=# select version();
> version
> -
> PostgreSQL 9.5alpha2, compiled by Visual C++ build 1800, 64-bit
> (1 row)
Regards,
Muhammad Asif Naeem
On Thu, Sep 24, 201
> Type "help" for help.
> postgres=# select version();
> version
> -
> PostgreSQL 9.5alpha2, compiled by Visual C++ build 1800, 64-bit
> (1 row)
Regards,
Muhammad Asif Naeem
O
It seems that compiler is complain about "Relation" structure, can you
please try adding the following in trigtest.c i.e.
#include "utils/rel.h"
Best Regards,
Asif Naeem
On Tue, Mar 20, 2012 at 3:53 PM, Marco Nenciarini <
marco.nenciar...@2ndquadrant.it> wrote:
> I
Thank you Michael overall v3 patch looks good to me, There is one
observation that it is not installing following lib files that are required
for dev work i.e.
>
> inst\lib\libpq.lib
> inst\lib\libpgtypes.lib
> inst\lib\libecpg_compat.lib
> inst\lib\libecpg.lib
Please do let me know if I missed so
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
Thank you Michael. v4 patch looks good to me.
The new status of this pa
ot; seems good for help message but it seem not
well handled in the script, it is still saying “Invalid command line
options.”, along with this, option "/?" seems not handled by any other .bat
build script. Other than this, with the patch applied, is it an acceptable
behavior that (2) show
another patch, If
you like please feel free to change status to ready for committer. Thanks.
On Fri, Apr 17, 2015 at 10:36 AM, Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 5:40 PM, Asif Naeem wrote:
> > Along with fixing the space in installation path, it is also changing the
>
Thank you Michael, latest patch looks good to me. I have changed its status
to ready for committer.
Regards,
Muhammad Asif Naeem
On Tue, Apr 21, 2015 at 6:02 PM, Michael Paquier
wrote:
>
>
> On Tue, Apr 21, 2015 at 4:33 PM, Asif Naeem wrote:
>
>> The v2 patch looks good t
ent from archive
> LOG: restored log file "00010004" from archive
> DEBUG: got WAL segment from archive
> LOG: restored log file "00010005" from archive
> DEBUG: got WAL segment from archive
> LOG: restored log file "000
refix/bin/postmaster") is not going to
accept "-I" option as mentioned in the patch i.e.
contrib/start-scripts/linux
> su - $PGUSER -c "$DAEMON -I -D '$PGDATA' &" >>$PGLOG 2>&
Rest of the patch changes looks good to me. Thanks.
Best
0x0060bdd9 in ServerLoop ()
> #16 0x0060e9d7 in PostmasterMain ()
> #17 0x005ad360 in main ()
Apparently it is being crashed because of invalid related pointer value of
pfree() *header->context->methods->free_p. It is reproducible with latest
version of pyth
FYI,
I have observed this crash on Linux64. Thanks.
Best Regards,
Muhammad Asif Naeem
On Thu, Apr 26, 2012 at 5:32 PM, Asif Naeem wrote:
> Hi,
>
> PFA test case. It used simple select statement to retrieve data via
> plpython. It crashes latest pg 9.2 with the following stack trace
317e0246c645f60c39e6572644cff1cb03b4c65
> Author: Tom Lane
> Date: Tue May 29 23:22:14 2012 -0400
> Rewrite --section option to decouple it from --schema-only/--data-only.
PFA patch. Thanks.
Best Regards,
Muhammad Asif Naeem
pg_backup_tar.c.patch.pg
Description: Binary data
--
Se
PLyUnicode_Bytes() -> PLy_elog() ...
I think primary reason that trigger this issue is when Function
PLyUnicode_Bytes() calls "PyUnicode_AsEncodedString( ,WIN1252 /*Server
encoding*/, ) " it fails with null. I built latest pg 9.2 source code with
python 3.2.2.3 by using Visual Studio 2010. Thanks.
Best Regards,
Muhammad Asif Naeem
Thank you. Please do let me know once fix check-in. I will test it and
share feedback with you. Thanks.
Best Regards,
Asif Naeem
On Fri, Jun 29, 2012 at 3:36 AM, Jan Urbański wrote:
> On 27/06/12 13:57, Jan Urbański wrote:
>
>> On 27/06/12 11:51, Asif Naeem wrote:
>>
>>
-8')
$$ language plpython3u;
select enctest(), encode(convert_to(enctest(), 'utf-8'), 'hex');
enctest | encode
--+
tróspido | 7472c3b3737069646f
(1 row)
Please do let me know If you have any other query. Thanks.
Best Regards,
Muhammad Asif Naeem
Hi Michael,
Thank you for v2 patch, I would like to comment on it. It seems that you
have used function EVP_CIPHER_CTX_reset in the patch that was introduced in
OpenSSL 1.1.0, older library version might not work now, is it intentional
change ?.
Regards,
Muhammad Asif Naeem
On Tue, Dec 6, 2016
I guess use of deprecated function is fine, until OpenSSL library support
it.
On Tue, Dec 6, 2016 at 6:15 PM, Michael Paquier
wrote:
> On Tue, Dec 6, 2016 at 9:31 PM, Asif Naeem wrote:
> > Thank you for v2 patch, I would like to comment on it. It seems that you
> > have used fu
inion ?. I am hopeful I will be able to share all my
findings tomorrow. Thanks.
On Wed, Dec 7, 2016 at 2:23 AM, Michael Paquier
wrote:
> On Tue, Dec 6, 2016 at 11:42 PM, Asif Naeem wrote:
> > Thanks for updated patch. Although EVP_CIPHER_CTX_cleanup() seems
> de
3250/16384
> ./data/base/13250/16384
> postgres=# vacuum test1;
> VACUUM
> [asif@centos66 inst_96]$ find . | grep base/13250/16384
> ./data/base/13250/16384
> ./data/base/13250/16384_fsm
> ./data/base/13250/16384_vm
Please do let me know if I missed something or more informati
Thank you Robert. Sure, I will add the updated patch on the next CommitFest
with all the suggested changes.
On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas wrote:
> On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem wrote:
> >> Oh, I see. I think it's probably not a good idea t
On Thu, Apr 7, 2016 at 2:15 AM, Jim Nasby wrote:
> On 4/6/16 11:06 AM, Robert Haas wrote:
>
>> This is too late for 9.6 at this point and certainly requires
>> discussion anyway, so please add it to the next CommitFest.
>>
>
> If the goal here is to free up space via truncation when there's a rea
On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas wrote:
> On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem wrote:
> >> Oh, I see. I think it's probably not a good idea to skip truncating
> >> those maps, but perhaps the option could be defined as making no new
> >>
nvenience but it will make results better. Please do
let me know if I missed something or more information is required. Thanks.
Regards,
Muhammad Asif Naeem
chkpass_RANDOMIZE_ALLOCATED_MEMORY_v1.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
tps://commitfest.postgresql.org/action/patch_view?id=1330
Above link result in the following error i.e.
Not found
> The specified URL was not found.
>
Please do let me know if I missed something. Thanks.
Regards,
Muhammad Asif Naeem
On Tue, Feb 24, 2015 at 11:59 PM, Peter Eisentraut wro
Thank you Michael, It works.
On Thu, Feb 26, 2015 at 5:59 PM, Michael Paquier
wrote:
> On Thu, Feb 26, 2015 at 9:15 PM, Asif Naeem wrote:
> > This thread seems relevant, Please guide me to how can access older CF
> pages
> >> The MSVC portion of this fix got comple
On Fri, Feb 27, 2015 at 11:32 AM, Stefan Kaltenbrunner <
ste...@kaltenbrunner.cc> wrote:
> On 02/26/2015 01:59 PM, Michael Paquier wrote:
> > On Thu, Feb 26, 2015 at 9:15 PM, Asif Naeem wrote:
> >> This thread seems relevant, Please guide me to how can access older C
st\lib\libpq.dll
> inst\lib\libpgtypes.dll
> inst\lib\libecpg_compat.dll
> inst\lib\libecpg.dll
>
Thanks.
Regards,
Muhammad Asif Naeem
On Tue, Jan 20, 2015 at 6:06 AM, Michael Paquier
wrote:
> Hi all,
>
> Here is a continuation of the thread which covered $subject for MinGW
>
Thank you Tom, Thank you Amit.
Regards,
Muhammad Asif Naeem
On Wed, Mar 4, 2015 at 9:30 AM, Tom Lane wrote:
> Amit Kapila writes:
> > On Sat, Feb 14, 2015 at 10:26 PM, Tom Lane wrote:
> >> It's not a false alarm, unfortunately, because chkpass_in actually does
>
Thank you for useful suggestions. PFA patch, I have tried to cover all the
points mentioned.
Regards,
Muhammad Asif Naeem
On Wed, Apr 6, 2016 at 9:06 PM, Robert Haas wrote:
> On Wed, Apr 6, 2016 at 3:32 AM, Asif Naeem wrote:
> >> Oh, I see. I think it's probably not a
54 matches
Mail list logo
