Thank you Peter. When I try to apply the patch on latest PG source code on master branch, it gives the following error message i.e.
> asif$ git apply /Users/asif/core/Patch\:\ Add\ use\ of\ > asprintf\(\)/v2-0001-Add-use-of-asprintf.patch > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-Add-use-of-asprintf.patch:76: trailing whitespace. > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-Add-use-of-asprintf.patch:77: trailing whitespace. > for ac_func in asprintf crypt fls getopt getrusage inet_aton random rint > srandom strerror strlcat strlcpy > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-Add-use-of-asprintf.patch:90: trailing whitespace. > AC_REPLACE_FUNCS([asprintf crypt fls getopt getrusage inet_aton random > rint srandom strerror strlcat strlcpy]) > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-Add-use-of-asprintf.patch:104: trailing whitespace. > values[1] = psprintf("%s/%s", fctx->location, de->d_name); > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-Add-use-of-asprintf.patch:118: trailing whitespace. > pg_asprintf(&todo, > fatal: git apply: bad git-diff - expected /dev/null on line 1557 Neither git nor patch command apply the patch successfully. Can you please guide ?. Thanks. Best Regards, Muhammad Asif Naeem On Wed, Oct 2, 2013 at 7:29 AM, Peter Eisentraut <pete...@gmx.net> wrote: > On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: > > I did put some time review the patch, please see my findings below > > i.e. > > Updated patch for this. > >