Small fry gathered wile reading walsender.c ...
(to be applied to master)
Thanks,
Erik Rijkers
--- src/backend/replication/walsender.c.orig 2017-03-28 08:34:56.787217522 +0200
+++ src/backend/replication/walsender.c 2017-03-28 08:44:56.486327700 +0200
@@ -14,11 +14,11 @@
* replication-mode c
2017-03-27 13:59 GMT+02:00 Alexander Korotkov :
> On Fri, Mar 10, 2017 at 6:06 PM, Pavel Stehule
> wrote:
>
>> 2017-03-10 16:00 GMT+01:00 Alexander Korotkov
>> :
>>
>>> On Fri, Mar 10, 2017 at 5:16 PM, Stephen Frost
>>> wrote:
>>>
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote
-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160
Hi PostgreSQL Hackers,
I'm developing software using PostgreSQL for several years and want to
propose a feature to improve security of (badly written?) Web-Apps.
I call it 'Database Security Modules', derived from
Linux-Security-Modules (aka S
On Tue, Mar 28, 2017 at 1:57 PM, Vaishnavi Prabakaran
wrote:
> Thanks Craig and Michael for confirming that "PQsetSingleRowMode" should be
> called right after "PQbatchQueueProcess".
>
> Michael Paquier wrote:
>
>> It seems to me that
>>this should also be effective only during the fetching of one
2017-03-28 9:51 GMT+02:00 Jan Kechel :
> -BEGIN PGP SIGNED MESSAGE-
> Hash: RIPEMD160
>
>
> Hi PostgreSQL Hackers,
>
>
> I'm developing software using PostgreSQL for several years and want to
> propose a feature to improve security of (badly written?) Web-Apps.
>
> I call it 'Database Secu
Hi Stephen,
On 2017/03/21 1:40, Stephen Frost wrote:
> Amit,
>
> * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote:
>> On 2017/02/17 22:32, Stephen Frost wrote:
>>> * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote:
In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER T
On Tue, Mar 28, 2017 at 12:21 PM, Amit Kapila wrote:
> I think both way it can work. I feel there is no hard pressed need
> that we should make the computation in sorting same as what you do
> _hash_doinsert. In patch_B, I don't think new naming for variables is
> good.
>
> Assert(!a->isnull1)
On Tue, Mar 28, 2017 at 10:00 AM, Tomas Vondra wrote:
>
>
> On 03/27/2017 01:40 PM, Rushabh Lathia wrote:
>
>>
>> ...
>> I was doing more testing with the patch and I found one more server
>> crash with the patch around same area, when we forced the gather
>> merge for the scan having zero rows.
Hi
I am sending a patch with changes in XMLTABLE documentation proposed by
Arjen.
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index ba6f8dd8d2..857c56241b 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -10504,7 +10504,7 @@ SELECT xpath_exists('
Tom Lane writes:
> I wrote:
>> Peter Eisentraut writes:
>>> Clean up Perl code according to perlcritic
>
>> This seems to have broken the regression tests (specifically, dblink)
>> on at least some of the Windows buildfarm critters.
>
> I'm hardly a Perl expert, but it looks to me like the culpr
I'm just reviewing Tomas' code for the dependencies part of the stats
when I saw something that looked a bit unusual.
I tested with:
CREATE TABLE ab1 (a INTEGER, b INTEGER);
ALTER TABLE ab1 ALTER a SET STATISTICS 0;
INSERT INTO ab1 SELECT a, a%23 FROM generate_series(1, 1000) a;
CREATE STATISTICS
Hello,
On 27.03.2017 23:28, Dmitry Dolgov wrote:
Here is a new version of this patch. What was changed:
* I rebased code against the latest version of master and adapted recent
changes about the expression execution
* Several names (functions and related pg_type column) were changed
* A new
On 28 March 2017 at 11:58, Arthur Zakirov wrote:
>
> Your patch reverts commits from 25-26 march. And therefore contains 15000
lines.
Wow, I didn't notice that, sorry - will fix it shortly.
On 27 March 2017 at 13:05, Amit Khandekar wrote:
>> Also, there are a few places in the documentation mentioning that such
>> updates cause error,
>> which will need to be updated. Perhaps also add some explanatory notes
>> about the mechanism (delete+insert), trigger behavior, caveats, etc.
>>
On Mon, Mar 27, 2017 at 2:19 PM, Pavan Deolasee
wrote:
> On Fri, Mar 24, 2017 at 11:49 PM, Pavan Deolasee
> wrote:
>>
>>
>>
>> On Fri, Mar 24, 2017 at 6:46 PM, Amit Kapila
>> wrote:
>>>
>>>
>>>
>>> I was worried for the case if the index is created non-default
>>> collation, will the datumIsEqua
On 2017/03/28 0:23, Robert Haas wrote:
> On Thu, Mar 9, 2017 at 8:23 PM, Amit Langote wrote:
>> Attached updated patches.
>
> Committed 0002, 0003.
Thanks a lot for committing these and reviewing 0001.
> I think the section on BRIN in 0001 is just silly. BRIN is a very
> useful index type, poss
On Mon, Mar 27, 2017 at 2:19 PM, Pavan Deolasee
wrote:
>
>
> On Fri, Mar 24, 2017 at 11:49 PM, Pavan Deolasee
> wrote:
>>
>>
>>
>> On Fri, Mar 24, 2017 at 6:46 PM, Amit Kapila
>> wrote:
>>>
>>>
>>>
>>> I was worried for the case if the index is created non-default
>>> collation, will the datumIs
On 2017/03/27 23:30, Robert Haas wrote:
> On Fri, Feb 17, 2017 at 3:23 AM, Amit Langote
> wrote:
>> In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER TABLE
>> command for those schema elements of a table that could not be included
>> directly in the CREATE TABLE command for the
On 03/27/2017 08:58 PM, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut writes:
>>> Clean up Perl code according to perlcritic
>> This seems to have broken the regression tests (specifically, dblink)
>> on at least some of the Windows buildfarm critters.
> I'm hardly a Perl expert, but it looks t
On 03/28/2017 05:23 AM, Dagfinn Ilmari Mannsåker wrote:
> + @opts = grep { !/\$\(/ && /^--/ }
> + map { (my $x = $_) =~
> s/\Q$(top_builddir)\E/\"$topdir\"/; $x;}
> + split(/\s+/, $1);
>
The use of this lexical $x variable seems entire
Andrew Dunstan writes:
> I would try something like this:
>
> @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ }
> map { s/\Q$(top_builddir)\E/\"$topdir\"/; }
> split(/\s+/, $1);
That map is not going to work: it'll modify the values returned by
split(), but s/// (without the /r modi
On 03/28/2017 07:31 AM, Dagfinn Ilmari Mannsåker wrote:
> Andrew Dunstan writes:
>
>> I would try something like this:
>>
>> @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ }
>> map { s/\Q$(top_builddir)\E/\"$topdir\"/; }
>> split(/\s+/, $1);
> That map is not going to work: it'll m
Andrew Dunstan writes:
> On 03/28/2017 05:23 AM, Dagfinn Ilmari Mannsåker wrote:
>> +@opts = grep { !/\$\(/ && /^--/ }
>> +map { (my $x = $_) =~
>> s/\Q$(top_builddir)\E/\"$topdir\"/; $x;}
>> +split(/\s+/, $1);
>>
>
> The use of this lexi
can you help with fixing it Pavel?
On Mon, Mar 27, 2017 at 11:48 AM, Pavel Stehule
wrote:
> Hi
>
> fresh update - I enhanced Value node by location field as Tom proposal.
>
> Few more regress tests.
>
> But I found significant issue, that needs bigger fix - Surafel, please,
> can you fix it.
>
>
2017-03-28 13:58 GMT+02:00 Surafel Temesgen :
> can you help with fixing it Pavel?
>
There must be some new preanalyze stage - you have to know result columns
before you are starting a analyze
Regards
Pavel
>
> On Mon, Mar 27, 2017 at 11:48 AM, Pavel Stehule
> wrote:
>
>> Hi
>>
>> fresh updat
On 3/28/17 05:23, Dagfinn Ilmari Mannsåker wrote:
> I suggest splitting the substitution and filtering part into separate
> map and grep calls, for clarity. The substituion is crying out for the
> /r regex modifier to avoid the local variable, but that's only available
> since perl 5.14.
>
> diff
Hi,
After runinng sqlsmith against latest sources of PG v10 , able to see a
crash -
here is the standalone testcase -
Make sure 'logging_collector=on' in postgresql.conf file
Connect to psql terminal ,run this query
postgres=# select
80 as c0,
pg_catalog.pg_backend_pid()
Michael Paquier wrote:
> # Running: testlibpqbatch dbname=postgres 1 copyfailure
> dispatching SELECT query failed: cannot queue commands during COPY
>
> COPYBUF: 5
>
> Error status and message got from server due to COPY command failure
> are : PGRES_FATAL_ERROR ERROR: unexpected m
On Tue, Mar 28, 2017 at 4:05 PM, Amit Kapila wrote:
> On Mon, Mar 27, 2017 at 2:19 PM, Pavan Deolasee
> wrote:
>> On Fri, Mar 24, 2017 at 11:49 PM, Pavan Deolasee
>> wrote:
>>>
>>>
>>>
>>> On Fri, Mar 24, 2017 at 6:46 PM, Amit Kapila
>>> wrote:
I was worried for the case if
On 3/24/17 10:50 AM, David Steele wrote:
Hi Pritam,
On 3/17/17 5:41 PM, Pritam Baral wrote:
So sorry. I'm attaching the correct version of the original with this,
in case you want to test the limited implementation, because I still
have to go through Tom's list of suggestions.
BTW, the patch
On 23 March 2017 at 13:16, Dave Page wrote:
> Thanks - updated patch attached.
I've edited the comments and docs on this patch, so attach a new
version with similar name.
--
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Serv
On 27 March 2017 at 13:54, Robert Haas wrote:
> On Sat, Mar 25, 2017 at 12:30 PM, Dave Page wrote:
>> Right - and if a user doesn't like it, they can easily just not use the
>> default role and create their own alternative instead.
>
> OK, I see the points that both of you are making and I admit
Hi Alexander,
On 3/20/17 10:19 AM, Heikki Linnakangas wrote:
On 03/20/2017 11:33 AM, Alexander Korotkov wrote:
Please, find rebased patch in the attachment.
I had a quick look at this.
<...>
According to 'perf', 85% of the CPU time is spent in ExecCopySlot(). To
alleviate that, it might b
On 28 March 2017 at 03:53, Craig Ringer wrote:
> On 28 March 2017 at 09:25, Andres Freund wrote:
>
>> If you actually need separate decoding of 2PC, then you want to wait for
>> the PREPARE to be replicated. If that replication has to wait for the
>> to-be-replicated prepared transaction to comm
Hi Takeshi,
On 3/23/17 1:33 AM, Haribabu Kommi wrote:
The test patch looks good to me.
This thread has been idle for five days. Please respond with a new
patch by 2017-03-30 00:00 AoE (UTC-12) or this submission will be marked
"Returned with Feedback".
--
-David
da...@pgmasters.net
--
On 2017-03-28 15:32:49 +0100, Simon Riggs wrote:
> On 28 March 2017 at 03:53, Craig Ringer wrote:
> > On 28 March 2017 at 09:25, Andres Freund wrote:
> >
> >> If you actually need separate decoding of 2PC, then you want to wait for
> >> the PREPARE to be replicated. If that replication has to wa
2017-03-28 14:18 GMT+02:00 Pavel Stehule :
>
>
> 2017-03-28 13:58 GMT+02:00 Surafel Temesgen :
>
>> can you help with fixing it Pavel?
>>
>
> There must be some new preanalyze stage - you have to know result columns
> before you are starting a analyze
>
maybe some recheck after analyze stage to r
On 28 March 2017 at 15:38, Andres Freund wrote:
> On 2017-03-28 15:32:49 +0100, Simon Riggs wrote:
>> On 28 March 2017 at 03:53, Craig Ringer wrote:
>> > On 28 March 2017 at 09:25, Andres Freund wrote:
>> >
>> >> If you actually need separate decoding of 2PC, then you want to wait for
>> >> the
On Mon, Mar 27, 2017 at 10:25 PM, Pavan Deolasee
wrote:
> On Tue, Mar 28, 2017 at 1:59 AM, Robert Haas wrote:
>> On Thu, Mar 23, 2017 at 2:47 PM, Pavan Deolasee
>> wrote:
>> > It's quite hard to say that until we see many more benchmarks. As author
>> > of
>> > the patch, I might have got repeti
On 3/23/17 11:27 PM, Peter Eisentraut wrote:
On 3/17/17 18:35, Tomas Vondra wrote:
On 03/17/2017 05:23 PM, Peter Eisentraut wrote:
I'm struggling to find a good way to share code between
bt_page_items(text, int4) and bt_page_items(bytea).
If we do it via the SQL route, as I had suggested, it m
On 2017-03-28 15:55:15 +0100, Simon Riggs wrote:
> On 28 March 2017 at 15:38, Andres Freund wrote:
> > On 2017-03-28 15:32:49 +0100, Simon Riggs wrote:
> >> On 28 March 2017 at 03:53, Craig Ringer wrote:
> >> > On 28 March 2017 at 09:25, Andres Freund wrote:
> >> >
> >> >> If you actually need s
Tomas Vondra wrote:
> OK, this did the trick. And just as I suspected, it seems to be due to doing
> memcpy+offsetof when serializing the statistic into a bytea. The attached
> patch fixes that for me. Can you test it on your build?
Buildfarm member skink confirms that this is fixed. Thanks!
--
On 3/23/17 01:38, Rushabh Lathia wrote:
> DBLINK contrib module started showing :"unnamed" connection name.
> Before this, macro used to assign the conname local variable; I quickly
> worked
> on the fix and attached patch do fix the issues. Patch assign the conname
> local variable, so that error
Hi,
On 2017-03-27 16:03:48 +0800, Craig Ringer wrote:
> On 27 March 2017 at 14:08, Craig Ringer wrote:
>
> > So this patch makes ReplicationSlotAcquire check that the slot
> > database matches the current database and refuse to acquire the slot
> > if it does not.
>
> New patch attached that dr
On 3/23/17 1:54 AM, Masahiko Sawada wrote:
On Wed, Mar 15, 2017 at 7:51 AM, Peter Geoghegan wrote:
On Tue, Mar 14, 2017 at 3:10 PM, Peter Geoghegan wrote:
We already have BTPageOpaqueData.btpo, a union whose contained type
varies based on the page being dead. We could just do the same with
so
Last night I updated longfin's host to the latest macOS and XCode point
releases. That brought with it a new clang version which is slightly
pickier than the old: it's complaining about
log.c:5047:16: error: implicit conversion from 'int' to 'char' changes value
from 255 to -1 [-Werror,-Wconstan
On Tue, Mar 28, 2017 at 5:00 AM, Mithun Cy wrote:
>> This will go wrong for split point group zero. In general, I feel if
>> you handle computation for split groups lesser than
>> SPLITPOINT_GROUPS_WITH_ONLY_ONE_PHASE in the caller, then all your
>> macros will become much simpler and less error
On Tue, Mar 28, 2017 at 11:25 AM, Tom Lane wrote:
> As noted in the other thread, we could either fix this in a
> quick-and-dirty way by casting XLR_BLOCK_ID_DATA_SHORT and related
> values to "char" explicitly, or we could run around and change the
> target pointer variables to be "unsigned char
On 3/28/17 10:24, Simon Riggs wrote:
>> Let me make a modest proposal.
>
> +1
>
> I aim to commit something today. If you have other viewpoints, so say
> now. There aren't many days left to express views and do anything
> about them, so lets do it.
I don't even see an actual proposed patch here,
On 2017-03-28 11:25:08 -0400, Tom Lane wrote:
> Last night I updated longfin's host to the latest macOS and XCode point
> releases. That brought with it a new clang version which is slightly
> pickier than the old: it's complaining about
>
> log.c:5047:16: error: implicit conversion from 'int' to
This patch touches the pg_buffercache and pg_freespacemap extensions,
but there appear to be some files missing.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hack
Hi Pavan,
On 3/28/17 11:04 AM, Robert Haas wrote:
On Mon, Mar 27, 2017 at 10:25 PM, Pavan Deolasee
wrote:
On Tue, Mar 28, 2017 at 1:59 AM, Robert Haas wrote:
On Thu, Mar 23, 2017 at 2:47 PM, Pavan Deolasee
wrote:
It's quite hard to say that until we see many more benchmarks. As author
of
t
On Tue, Mar 28, 2017 at 11:31 AM, Peter Eisentraut
wrote:
> This patch touches the pg_buffercache and pg_freespacemap extensions,
> but there appear to be some files missing.
Are you looking at an old version? There was one where I forgot to add
some files, but that was fixed within an hour or so
On Mon, Mar 27, 2017 at 11:57 PM, Rafia Sabih
wrote:
> On Mon, Mar 27, 2017 at 5:54 PM, Robert Haas wrote:
>>
>> If it's just that they are relying on unsynchronized global variables,
>> then it's sufficient to mark them parallel-restricted ('r'). Do we
>> really need to go all the way to parall
On 3/27/17 08:54, Robert Haas wrote:
> OK, I see the points that both of you are making and I admit that
> they've got some validity to them. Let me make a modest proposal.
> Suppose we define the pg_monitor role as strictly a bundle of
> privileges that could be granted individually if desired, a
On 3/28/17 11:34, Dave Page wrote:
> On Tue, Mar 28, 2017 at 11:31 AM, Peter Eisentraut
> wrote:
>> This patch touches the pg_buffercache and pg_freespacemap extensions,
>> but there appear to be some files missing.
>
> Are you looking at an old version? There was one where I forgot to add
> some
On Tue, Mar 28, 2017 at 6:50 AM, Amit Langote
wrote:
>> Isn't it bogus that this is generating ALTER TABLE .. SET NOT NULL
>> columns at all? You didn't say anything like that when setting up the
>> database, so why should it be there when dumping?
>
> So we should find a way for the NOT NULL con
On 3/21/17 08:12, Robert Haas wrote:
> I think a big part of the usability problem here comes from the fact
> that the default database for connections is based on the username,
> but the default databases that get created have fixed names (postgres,
> template1). So the default configuration is o
On Mon, Mar 27, 2017 at 11:47 PM, Thomas Munro
wrote:
> Couldn't cleanup code continue to work just the same way though? The
> only extra structure is an intrusive freelist, but that could be
> completely ignored by code that wants to scan the whole array after
> crash. It would only be used to
I accidentally sent this off-list, sending to the list now:
On Sun, Mar 26, 2017 at 10:38 PM, Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> At Sat, 25 Mar 2017 19:53:47 -0700, Jeff Janes
> wrote in gmail.com>
> > On Thu, Mar 23, 2017 at 7:01 PM, Kyotaro HORIGUCHI <
> > horiguchi
On Tue, Mar 28, 2017 at 11:44 AM, Peter Eisentraut
wrote:
> On 3/21/17 08:12, Robert Haas wrote:
>> I think a big part of the usability problem here comes from the fact
>> that the default database for connections is based on the username,
>> but the default databases that get created have fixed n
Hi Thomas,
On 3/28/17 1:41 AM, Rafia Sabih wrote:
On Mon, Mar 27, 2017 at 12:20 PM, Thomas Munro
I thought this last point about Windows might be fatal to my design,
but it seems that Windows since at least version 2000 has support for
Unixoid unlinkability via the special flag FILE_SHARE_DELE
On Mon, Mar 27, 2017 at 11:20 PM, Petr Jelinek
wrote:
> On 28/03/17 04:46, Robert Haas wrote:
>> On Mon, Mar 27, 2017 at 10:04 PM, Andres Freund wrote:
Btw now that I look at the code, I guess we'll want to get rid of
bgw_main completely in HEAD given that we can't guarantee it will be
Andres Freund writes:
> On 2017-03-28 11:25:08 -0400, Tom Lane wrote:
>> Since, per previous agreement[1], longfin is running with -Werror, we
>> either have to do something about this or revert the decision to make it
>> use -Werror --- and I'm not too pleased about the latter idea. We should
>>
В письме от 17 марта 2017 14:21:26 пользователь Alvaro Herrera написал:
> Please make sure to mark functions as static (e.g. bringetreloptcatalog).
I am a bit confused here:
For brin and nbtree this is a good idea: brin.c and nbtree.c has AM-handler
inside it, and there are other static functio
Thank you, pushed
Matheus de Oliveira wrote:
On Thu, Mar 2, 2017 at 10:27 AM, David Steele mailto:da...@pgmasters.net>> wrote:
It looks like this patch is still waiting on an update for tab
completion in psql.
Hi All,
Sorry about the long delay... It was so simple to add it to tab-c
> On Mar 28, 2017, at 8:34 AM, Dave Page wrote:
>
> On Tue, Mar 28, 2017 at 11:31 AM, Peter Eisentraut
> wrote:
>> This patch touches the pg_buffercache and pg_freespacemap extensions,
>> but there appear to be some files missing.
>
> Are you looking at an old version? There was one where I fo
On 28/03/17 17:55, Robert Haas wrote:
> On Mon, Mar 27, 2017 at 11:20 PM, Petr Jelinek
> wrote:
>> On 28/03/17 04:46, Robert Haas wrote:
>>> On Mon, Mar 27, 2017 at 10:04 PM, Andres Freund wrote:
> Btw now that I look at the code, I guess we'll want to get rid of
> bgw_main completely in
Robert Haas writes:
> On Tue, Mar 28, 2017 at 11:44 AM, Peter Eisentraut
> wrote:
>> On 3/21/17 08:12, Robert Haas wrote:
>>> I think a big part of the usability problem here comes from the fact
>>> that the default database for connections is based on the username,
>>> but the default databases
On Tue, Mar 28, 2017 at 11:39 AM, Peter Eisentraut
wrote:
> On 3/28/17 11:34, Dave Page wrote:
>> On Tue, Mar 28, 2017 at 11:31 AM, Peter Eisentraut
>> wrote:
>>> This patch touches the pg_buffercache and pg_freespacemap extensions,
>>> but there appear to be some files missing.
>>
>> Are you loo
On 03/27/2017 02:00 PM, Kang Yuzhe wrote:
> 1. Prepare Hands-on with PG internals
>
> For example, a complete Hands-on with SELECT/INSERT SQL Standard PG
> internals.
> The point is the experts can pick one fairly complex feature and walk it from
> Parser to Executor in a hands-on manner explai
On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada wrote:
> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada
> wrote:
>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote:
>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada
>>> wrote:
On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote:
>
On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao wrote:
> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada
> wrote:
>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada
>> wrote:
>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote:
On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada
wro
On Tue, Mar 28, 2017 at 12:18 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Tue, Mar 28, 2017 at 11:44 AM, Peter Eisentraut
>> wrote:
>>> On 3/21/17 08:12, Robert Haas wrote:
I think a big part of the usability problem here comes from the fact
that the default database for connection
On Tue, Mar 28, 2017 at 12:04 PM, Mark Dilger wrote:
>
>> On Mar 28, 2017, at 8:34 AM, Dave Page wrote:
>>
>> On Tue, Mar 28, 2017 at 11:31 AM, Peter Eisentraut
>> wrote:
>>> This patch touches the pg_buffercache and pg_freespacemap extensions,
>>> but there appear to be some files missing.
>>
>
On Mon, Mar 27, 2017 at 8:36 AM, Ashutosh Bapat
wrote:
> I have gone through the patch, and it looks good to me. Here's the set
> of patches with this patch included. Fixed the testcase failures.
> Rebased the patchset on de4da168d57de812bb30d359394b7913635d21a9.
This version of 0001 looks much b
On Tue, Mar 28, 2017 at 12:47 PM, Dave Page wrote:
>> I don't see any precedent in the code for having a hardcoded role, other than
>> superuser, and allowing privileges based on a hardcoded test for membership
>> in that role. I'm struggling to think of all the security implications of
>> that.
Nikolay Shaplov wrote:
> В письме от 17 марта 2017 14:21:26 пользователь Alvaro Herrera написал:
>
> > Please make sure to mark functions as static (e.g. bringetreloptcatalog).
> I am a bit confused here:
>
> For brin and nbtree this is a good idea: brin.c and nbtree.c has AM-handler
> inside it
On Tue, Mar 28, 2017 at 4:05 PM, Amit Kapila
wrote:
>
>
> As asked previously, can you explain me on what basis are you
> considering it robust? The comments on top of datumIsEqual() clearly
> indicates the danger of using it for toasted values (Also, it will
> probably not give the answer you w
On Tue, Mar 28, 2017 at 4:07 PM, Amit Kapila
wrote:
>
> Noted few cosmetic issues in 0005_warm_updates_v21:
>
> 1.
> pruneheap.c(939): warning C4098: 'heap_get_root_tuples' : 'void'
> function returning a value
>
Thanks. Will fix.
>
> 2.
> + * HCWC_WARM_UPDATED_TUPLE - a tuple with HEAP_WARM_
On Tue, Mar 28, 2017 at 12:55 PM, Robert Haas wrote:
> On Tue, Mar 28, 2017 at 12:47 PM, Dave Page wrote:
>>> I don't see any precedent in the code for having a hardcoded role, other
>>> than
>>> superuser, and allowing privileges based on a hardcoded test for membership
>>> in that role. I'm s
On Tue, Mar 28, 2017 at 7:04 PM, Amit Kapila
wrote:
>
>
> For such an heap insert, we will pass
> the actual value of column to index_form_tuple during index insert.
> However during recheck when we fetch the value of c2 from heap tuple
> and pass it index tuple, the value is already in compres
Fujii Masao wrote:
> This is the evidence that no one cares about the details of VACUUM VERBOSE
> output example. So I'm tempted to simplify the example (please see the
> attached patch) instead of keeping updating the example.
Agreed.
> > If this patch is applied, it should back-patch to all su
On Tue, Mar 28, 2017 at 8:34 PM, Robert Haas wrote:
> On Mon, Mar 27, 2017 at 10:25 PM, Pavan Deolasee
> wrote:
> > On Tue, Mar 28, 2017 at 1:59 AM, Robert Haas
> wrote:
> >> On Thu, Mar 23, 2017 at 2:47 PM, Pavan Deolasee
> >> wrote:
> >> > It's quite hard to say that until we see many more b
Hi guys,
My name is Shubham Barai and I am a final year student at Maharashtra
Institute of Technology, Pune, India. I am very interested in contributing
Postgresql this year through GSoC project.
I am particularly interested in working on the project "Explicitly support
predicate locks in index
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Mar 28, 2017 at 12:47 PM, Dave Page wrote:
> >> I don't see any precedent in the code for having a hardcoded role, other
> >> than
> >> superuser, and allowing privileges based on a hardcoded test for membership
> >> in that role.
Robert Haas writes:
> On Tue, Mar 28, 2017 at 12:18 PM, Tom Lane wrote:
>> Perhaps we could satisfy novices by changing the out-of-the-box
>> behavior, but provide some way to select the old behavior for
>> installations that are really depending on it.
> Hmm. I guess that would mean that the s
Hi
rebased due last changes in pg_exec.c
Regards
Pavel
diff --git a/doc/src/sgml/plpgsql.sgml b/doc/src/sgml/plpgsql.sgml
index d356deb9f5..56da4d6163 100644
--- a/doc/src/sgml/plpgsql.sgml
+++ b/doc/src/sgml/plpgsql.sgml
@@ -802,6 +802,32 @@ $$ LANGUAGE plpgsql;
happen in a plain SQL comma
OK, so before I start hacking again, here's a proposal based on my
understanding of folks comments, and so open questions. If I can get
agreement and answers, I'll be able to break out vi again without
(hopefully) too many more revisions:
pg_read_all_stats: Will have C-coded access to pg_stats vie
> On Mar 28, 2017, at 9:55 AM, Robert Haas wrote:
>
> On Tue, Mar 28, 2017 at 12:47 PM, Dave Page wrote:
>>> I don't see any precedent in the code for having a hardcoded role, other
>>> than
>>> superuser, and allowing privileges based on a hardcoded test for membership
>>> in that role. I'm
CheckVarSlotCompatibility contains the comment
* Note: we allow a reference to a dropped attribute. slot_getattr will
* force a NULL result in such cases.
While still true, that second sentence is now quite irrelevant, because we
don't go through slot_getattr anymore. So it se
On 3/24/17 12:51 PM, Ashutosh Sharma wrote:
Hi,
On Fri, Mar 24, 2017 at 9:00 PM, David Steele wrote:
Hi Ashutosh,
On 3/22/17 8:52 AM, Amit Kapila wrote:
On Wed, Mar 22, 2017 at 12:07 AM, David Steele
wrote:
Amit, Magnus, you are signed up as reviewers for this patch. Do you know
when y
On Tue, Mar 28, 2017 at 1:52 PM, Mark Dilger wrote:
>
>> On Mar 28, 2017, at 9:55 AM, Robert Haas wrote:
>>
>> On Tue, Mar 28, 2017 at 12:47 PM, Dave Page wrote:
I don't see any precedent in the code for having a hardcoded role, other
than
superuser, and allowing privileges based
> On Mar 28, 2017, at 9:47 AM, Dave Page wrote:
>
>> Does
>> pg_read_all_stats still have access to stats for mysecuretable?
>
> Yes, because the ACL on the table controls reading/writing the data in
> the table. It doesn't have any bearing on any kind of table metadata.
> A user who has no pri
On Tue, Mar 28, 2017 at 1:40 PM, Haribabu Kommi
wrote:
>
>
> On Mon, Mar 27, 2017 at 1:27 PM, Haribabu Kommi
> wrote:
>>
>>
>>
>> On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao
>> wrote:
>>>
>>> On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi
>>> wrote:
>>> >
>>> >
>>> > On Wed, Feb 8, 2017 at 9
Hi,
On 2017-03-28 13:52:50 -0400, Tom Lane wrote:
> CheckVarSlotCompatibility contains the comment
>
>* Note: we allow a reference to a dropped attribute. slot_getattr will
>* force a NULL result in such cases.
>
> While still true, that second sentence is now quite irrelevant,
lazy_vacuum_heap() does not count pages that it skips due to not
obtaining the buffer cleanup lock. vacuum_pinskipped.patch fixes that.
That should be backpatched to 9.5.
vacuum_comment.patch cleans up a comment in lazy_scan_heap().
--
Jim C. Nasby, Data Architect j...@nas
Dave,
* Dave Page (dp...@pgadmin.org) wrote:
> OK, so before I start hacking again, here's a proposal based on my
> understanding of folks comments, and so open questions. If I can get
> agreement and answers, I'll be able to break out vi again without
> (hopefully) too many more revisions:
>
> p
Greetings,
* Mark Dilger (hornschnor...@gmail.com) wrote:
> The inability to revoke access to this sort of information being proposed
> makes me a bit uneasy.
What data are you concerned about, specifically?
> Mostly, I think, I'm bothered because there may
> be people who have revoked privile
On 28/03/17 19:43, Pavel Stehule wrote:
> Hi
>
> rebased due last changes in pg_exec.c
>
Thanks, I went over this and worked over the documentation/comments a
bit (attached updated version of the patch with my changes).
>From my side this can go to committer.
--
Petr Jelinek
1 - 100 of 171 matches
Mail list logo
