Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-06-24 Thread Michael Paquier
On Mon, Jun 24, 2013 at 11:06 PM, Andres Freund wrote: > On 2013-06-24 09:57:24 -0400, Tom Lane wrote: >> Andres Freund writes: >> > Otherwise I think there's not really much left to be done. Fujii? >> >> Well, other than the fact that we've not got MVCC catalog scans yet. > > That statement was

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-24 Thread Alexander Korotkov
On Fri, Jun 21, 2013 at 11:43 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > On 19.06.2013 11:56, Alexander Korotkov wrote: > >> On Wed, Jun 19, 2013 at 12:49 PM, Heikki Linnakangas< >> hlinnakan...@vmware.com> wrote: >> >> On 19.06.2013 11:30, Alexander Korotkov wrote: >>> >>> On W

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Mark Kirkwood
On 25/06/13 03:54, Joshua D. Drake wrote: It is mentioned. Of course now I can't find it but it is there. However, I believe you are taking the wrong perspective on this. This is not a shame wall. It is a transparent reminder of the policy and those who have not assisted in reviewing a patch b

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-24 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkov wrote: > On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas < > hlinnakan...@vmware.com> wrote: > >> On 17.06.2013 15:56, Alexander Korotkov wrote: >> >>> On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkov>> >**wrote: >>> >>> This patch intro

Re: [HACKERS] Patch for removng unused targets

2013-06-24 Thread Alvaro Herrera
Etsuro Fujita escribió: > > From: Hitoshi Harada [mailto:umi.tan...@gmail.com] > > > I tried several ways but I couldn't find big problems. Small typo: > > s/rejunk/resjunk/ > > Thank you for the review. Attached is an updated version of the patch. Thanks. I gave this a look, and made it some

Re: [HACKERS] patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-06-24 Thread Josh Berkus
On 06/24/2013 02:21 PM, Tom Lane wrote: >> Right, but I'm worried about the "surprise!" factor. That is, if we >> make the first default "free" by using a magic value, then a SET DEFAULT >> on that column is going to have some very surprising results as suddenly >> the whole table needs to get wri

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-06-24 Thread Noah Misch
On Mon, Jun 24, 2013 at 04:00:00PM +0400, Alexander Law wrote: > 23.06.2013 20:53, Noah Misch wrote: >> The attached revision fixes all above points. Would you look it over? The >> area was painfully light on comments, so I added some. I renamed >> pgwin32_toUTF16(), which ceases to be a good na

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-24 Thread Cédric Villemain
Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : > On 06/24/2013 04:02 PM, Cédric Villemain wrote: > > WIth extension, we do have to set VPATH explicitely if we want to use > > VPATH (note that contribs/extensions must not care that postgresql has > > been built with or without VPATH set).

Re: [HACKERS] [RFC] Minmax indexes

2013-06-24 Thread Bruce Momjian
On Sat, Jun 15, 2013 at 11:39:23AM -0400, Tom Lane wrote: > Simon Riggs writes: > > On 15 June 2013 00:01, Josh Berkus wrote: > >> If we're going to start adding reloptions for specific table behavior, > >> I'd rather think of all of the optimizations we might have for a > >> prospective "append-

Re: [HACKERS] C++ compiler

2013-06-24 Thread Bruce Momjian
On Thu, Jun 20, 2013 at 12:45:48PM +0800, Craig Ringer wrote: > I see value in making the codebase compileable with g++... and down the > track I can see being able to use basic class features as quite useful > given Pg's fairly OO internal design. Inline template functions instead > of macros woul

Re: [HACKERS] C++ compiler

2013-06-24 Thread Joshua D. Drake
On 06/24/2013 04:59 PM, Bruce Momjian wrote: On Thu, Jun 20, 2013 at 12:45:48PM +0800, Craig Ringer wrote: I see value in making the codebase compileable with g++... and down the track I can see being able to use basic class features as quite useful given Pg's fairly OO internal design. Inline

Re: [HACKERS] C++ compiler

2013-06-24 Thread Claudio Freire
On Mon, Jun 24, 2013 at 9:19 PM, Joshua D. Drake wrote: >> >> I think the big question is whether you can _control_ what C++ features >> are used, or whether you are perpetually instructing users what C++ >> features not to use. > > > How is that different than us having to do the same with C? P

Re: [HACKERS] Adding IEEE 754:2008 decimal floating point and hardware support for it

2013-06-24 Thread Tomas Vondra
On 12.6.2013 07:03, Pavel Stehule wrote: > Hello > > I worked with gdc' _Decimal* types last week > > https://github.com/okbob/pgDecimal > > I tested it, and should to say, so implementation in gcc is not good > - lack of lot of functionality, and our Money type is little bit > faster :( Tomas V

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-06-24 Thread Josh Kupershmidt
On Tue, Jun 18, 2013 at 12:42 PM, Jeff Davis wrote: > Attached a new diff for pg_filedump that makes use of the above change. > > I'm not sure what the resolution of Alvaro's concern was, so I left the > flag reporting the same as the previous patch. This patch is in the current CommitFest, does

Re: [HACKERS] C++ compiler

2013-06-24 Thread Bruce Momjian
On Mon, Jun 24, 2013 at 09:21:26PM -0300, Claudio Freire wrote: > On Mon, Jun 24, 2013 at 9:19 PM, Joshua D. Drake > wrote: > >> > >> I think the big question is whether you can _control_ what C++ features > >> are used, or whether you are perpetually instructing users what C++ > >> features not

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-24 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/14/2013 12:08 PM, Liming Hu wrote: >>> I have implemented the code according to Joe's >>> suggestion, and put the code at: >>> https://github.com/liminghu/fuzzystrmatch/tree/fuzzystrmatchv1.1 >>> > >>> Please submit a proper

Re: [HACKERS] patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-06-24 Thread Robert Haas
On Mon, Jun 24, 2013 at 4:50 PM, Tom Lane wrote: > The point of what I was suggesting isn't to conserve storage, but to > reduce downtime during a schema change. Remember that a rewriting ALTER > TABLE locks everyone out of that table for a long time. Sure, I understand. As Josh says, though, i

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-24 Thread Noah Misch
On Sat, Jun 22, 2013 at 04:54:50PM +0200, Andres Freund wrote: > On 2013-06-21 16:45:28 +0200, Andres Freund wrote: > > On 2013-06-21 09:51:05 -0400, Noah Misch wrote: > > > That being said, if we discover a simple-enough fix that performs well, > > > we may > > > as well incorporate it. > > > >

Re: [HACKERS] C++ compiler

2013-06-24 Thread Joshua D. Drake
On 06/24/2013 05:37 PM, Bruce Momjian wrote: On Mon, Jun 24, 2013 at 09:21:26PM -0300, Claudio Freire wrote: On Mon, Jun 24, 2013 at 9:19 PM, Joshua D. Drake wrote: I think the big question is whether you can _control_ what C++ features are used, or whether you are perpetually instructing u

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Noah Misch
On Mon, Jun 24, 2013 at 10:10:11AM -0700, Josh Berkus wrote: > On 06/24/2013 10:02 AM, Dimitri Fontaine wrote: > > Josh Berkus writes: > >> patch. The vast majority chose not to respond to my email to them at > >> all. When private email fails, the next step is public email. > > > > The only pr

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Michael Paquier
On Tue, Jun 25, 2013 at 11:06 AM, Noah Misch wrote: > On Mon, Jun 24, 2013 at 10:10:11AM -0700, Josh Berkus wrote: >> On 06/24/2013 10:02 AM, Dimitri Fontaine wrote: >> > Josh Berkus writes: >> >> patch. The vast majority chose not to respond to my email to them at >> >> all. When private email

Re: [HACKERS] patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-06-24 Thread Noah Misch
On Mon, Jun 24, 2013 at 01:32:41PM -0700, Josh Berkus wrote: > Do we really have ironclad numbers which show that the patch affects > performance negatively? I didn't think the previous performance test > was comprehensive; I was planning to develop one myself this week. Not ironclad, no: http://

Re: [HACKERS] C++ compiler

2013-06-24 Thread Craig Ringer
On 06/25/2013 09:38 AM, Joshua D. Drake wrote: > > On 06/24/2013 05:37 PM, Bruce Momjian wrote: >> >> On Mon, Jun 24, 2013 at 09:21:26PM -0300, Claudio Freire wrote: >>> On Mon, Jun 24, 2013 at 9:19 PM, Joshua D. Drake >>> wrote: > > I think the big question is whether you can _control_ w

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Amit Langote
Hi, > parameter improvement idea is which we extend ini file for to set > parameter each standby. For example : > > > [Server] > standby_name = 'slave1' > synchronous_transfer = commit > wal_sender_timeout = 30 > [Server] > standby_name = 'slave2' > synchronous_transfer = all

Re: [HACKERS] C++ compiler

2013-06-24 Thread Bruce Momjian
On Mon, Jun 24, 2013 at 06:38:48PM -0700, Joshua D. Drake wrote: > > On 06/24/2013 05:37 PM, Bruce Momjian wrote: > > > >On Mon, Jun 24, 2013 at 09:21:26PM -0300, Claudio Freire wrote: > >>On Mon, Jun 24, 2013 at 9:19 PM, Joshua D. Drake > >>wrote: > > I think the big question is whethe

Re: [HACKERS] C++ compiler

2013-06-24 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 10:32:42AM +0800, Craig Ringer wrote: > > Anything supported by C99 and not other versions I would say. However, > > my point is if done correctly we would state which features ahead of > > time we are willing to use and make them part of the developer faq? > > If C++ is se

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-24 Thread Steve Singer
On 05/28/2013 04:41 PM, Szymon Guz wrote: Hi, I've got a patch. This is for a plpython enhancement. There is an item at the TODO list http://wiki.postgresql.org/wiki/Todo#Server-Side_Languages "Fix loss of information during conversion of numeric type to Python float" This patch uses a deci

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Pavan Deolasee
On Mon, Jun 24, 2013 at 7:17 PM, Sawada Masahiko wrote: > > > > [Server] > standby_name = 'slave1' > synchronous_transfer = commit > wal_sender_timeout = 30 > [Server] > standby_name = 'slave2' > synchronous_transfer = all > wal_sender_timeout = 50 > --- > Wha

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Tom Lane
Mark Kirkwood writes: > One of the reasons for fewer reviewers than submitters, is that it is a > fundamentally more difficult job. I've submitted a few patches in a few > different areas over the years - however if I grab a patch on the queue > that is not in exactly one of the areas I know ab

Re: [HACKERS] C++ compiler

2013-06-24 Thread Tom Lane
Bruce Momjian writes: > Right. I don't think there are any C features we want to avoid; are > there any? We're avoiding C99-and-later features that are not in C89, such as // for comments, as well as more useful things. It might be time to reconsider whether we should move the baseline portabil

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-06-24 Thread Tom Lane
Josh Kupershmidt writes: > This patch is in the current CommitFest, does it still need to be > reviewed? If so, I notice that the version in pgfoundry's CVS is > rather different than the version the patch seems to have been built > against (presumably the pg_filedump-9.2.0.tar.gz release), and >

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Amit Langote
Hi, > >> So our proposal on this problem is that we must ensure that master should > not make any file system level changes without confirming that the >> corresponding WAL record is replicated to the standby. > > How will you take care of extra WAL on old master during recovery. If it > plays t

Re: [HACKERS] Move unused buffers to freelist

2013-06-24 Thread Amit Kapila
On Monday, June 24, 2013 11:00 PM Robert Haas wrote: > On Thu, Jun 6, 2013 at 3:01 AM, Amit Kapila > wrote: > > To avoid above 3 factors in test readings, I used below steps: > > 1. Initialize the database with scale factor such that database size > + > > shared_buffers = RAM (shared_buffers = 1/4

Re: [HACKERS] proposal 9.4 plpgsql: allows access to call stack from GET DIAGNOSTICS statement

2013-06-24 Thread Rushabh Lathia
On Tue, Jun 25, 2013 at 1:47 AM, Pavel Stehule wrote: > Hello > > This is fragment ofmy old code from orafce package - it is functional, > but it is written little bit more generic due impossible access to > static variables (in elog.c) > > static char* > dbms_utility_format_call_stack(char mode)

[HACKERS] Problem building in a directory shared from Mac to Ubuntu

2013-06-24 Thread Ashutosh Bapat
Hi, I am observing a strange problem when I build latest PostgreSQL head on Ubuntu 12.04. I am running Ubuntu 12.04 as VM on Mac 10.7. The build directory points to a sub-directory of host directory shared from Mac to Ubuntu 12.04. The source is also located in a sub-directory of the shared directo

Re: [HACKERS] C++ compiler

2013-06-24 Thread james
On 25/06/2013 05:16, Tom Lane wrote: It might be time to reconsider whether we should move the baseline portability requirement up to C99. My understanding was that you picked up a lot of users when the Win32 port became useful. While you can build with msys, I would think that leaving Micro

Re: [HACKERS] proposal 9.4 plpgsql: allows access to call stack from GET DIAGNOSTICS statement

2013-06-24 Thread Pavel Stehule
2013/6/25 Rushabh Lathia : > > > > On Tue, Jun 25, 2013 at 1:47 AM, Pavel Stehule > wrote: >> >> Hello >> >> This is fragment ofmy old code from orafce package - it is functional, >> but it is written little bit more generic due impossible access to >> static variables (in elog.c) >> >> static cha

Re: [HACKERS] C++ compiler

2013-06-24 Thread Craig Ringer
On 06/25/2013 01:36 PM, james wrote: > On 25/06/2013 05:16, Tom Lane wrote: >> It might be time to reconsider whether we should move the baseline >> portability requirement up to C99. > > My understanding was that you picked up a lot of users when the Win32 > port became useful. While you can bui

Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division

2013-06-24 Thread Jeevan Chalke
Hi David, I hope this is the latest patch to review, right ? I am going to review it. I have gone through the discussion on this thread and I agree with Stephen Frost that it don't add much improvements as such but definitely it is going to be easy for contributors in this area as they don't nee

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Mark Kirkwood
On 25/06/13 15:56, Tom Lane wrote: Mark Kirkwood writes: One of the reasons for fewer reviewers than submitters, is that it is a fundamentally more difficult job. I've submitted a few patches in a few different areas over the years - however if I grab a patch on the queue that is not in exactly

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-24 Thread Hari Babu
On January 23, 2013 9:13 AM Josh Kupershmidt wrote: >There have been some complaints[1][2] in the past about pg_ctl not playing nice with relative path specifications for the datadir. Here's a concise illustration: > > $ mkdir /tmp/mydata/ && initdb /tmp/mydata/ > $ cd /tmp/ > $ pg_ctl -D ./myda

[HACKERS] converting datum to numeric

2013-06-24 Thread Szymon Guz
Hi, I've got a couple of questions. I was using numeric_out like this: DatumGetCString(DirectFunctionCall1(numeric_out, d)); Why do I have to use DirectFunctionCall1 instead of calling numeric_out? I was suggested to use numeric_send instead of numeric_out, however when changing the function n

Re: [HACKERS] [RFC] Minmax indexes

2013-06-24 Thread Simon Riggs
On 25 June 2013 00:51, Bruce Momjian wrote: > On Sat, Jun 15, 2013 at 11:39:23AM -0400, Tom Lane wrote: > > Simon Riggs writes: > > > On 15 June 2013 00:01, Josh Berkus wrote: > > >> If we're going to start adding reloptions for specific table behavior, > > >> I'd rather think of all of the opt

Re: [HACKERS] Problem building in a directory shared from Mac to Ubuntu

2013-06-24 Thread Craig Ringer
On 06/25/2013 01:14 PM, Ashutosh Bapat wrote: > Hi, > I am observing a strange problem when I build latest PostgreSQL head on > Ubuntu 12.04. I am running Ubuntu 12.04 as VM on Mac 10.7. The build > directory points to a sub-directory of host directory shared from Mac to > Ubuntu 12.04. "shared" h

Re: [HACKERS] converting datum to numeric

2013-06-24 Thread Pavel Stehule
Hello 2013/6/25 Szymon Guz : > Hi, > I've got a couple of questions. > > I was using numeric_out like this: > > DatumGetCString(DirectFunctionCall1(numeric_out, d)); > > Why do I have to use DirectFunctionCall1 instead of calling numeric_out? numeric_out functions doesn't use C calling convention

Re: [HACKERS] Problem building in a directory shared from Mac to Ubuntu

2013-06-24 Thread Ashutosh Bapat
On Tue, Jun 25, 2013 at 12:03 PM, Craig Ringer wrote: > On 06/25/2013 01:14 PM, Ashutosh Bapat wrote: > > Hi, > > I am observing a strange problem when I build latest PostgreSQL head on > > Ubuntu 12.04. I am running Ubuntu 12.04 as VM on Mac 10.7. The build > > directory points to a sub-directory

<    1   2