Excerpts from Tom Lane's message of mar feb 15 12:42:00 -0300 2011:
> Heikki Linnakangas writes:
> > pageinspect is just a debugging aid, so I think we should change it from
> > smallint to int4 in 9.1, and not bother backporting.
>
> I don't see any reason that the old version of the function
On 15.02.2011 18:03, Tom Lane wrote:
Robert Haas writes:
On Tue, Feb 15, 2011 at 10:53 AM, Tom Lane wrote:
What risk? And at least we'd be trying to do it cleanly, in a manner
that should work for at least 99% of users. AFAICT, Heikki's proposal
is "break it for everyone, and damn the torpe
On Tue, Feb 15, 2011 at 11:03 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Tue, Feb 15, 2011 at 10:53 AM, Tom Lane wrote:
>>> What risk? And at least we'd be trying to do it cleanly, in a manner
>>> that should work for at least 99% of users. AFAICT, Heikki's proposal
>>> is "break it for e
Robert Haas writes:
> On Tue, Feb 15, 2011 at 10:53 AM, Tom Lane wrote:
>> What risk? And at least we'd be trying to do it cleanly, in a manner
>> that should work for at least 99% of users. AFAICT, Heikki's proposal
>> is "break it for everyone, and damn the torpedoes".
> I must be confused.
On Tue, Feb 15, 2011 at 10:53 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Tue, Feb 15, 2011 at 10:42 AM, Tom Lane wrote:
>>> I don't see any reason that the old version of the function couldn't be
>>> dropped in the upgrade script. It's not likely anything would be
>>> depending on it, is i
Robert Haas writes:
> On Tue, Feb 15, 2011 at 10:42 AM, Tom Lane wrote:
>> I don't see any reason that the old version of the function couldn't be
>> dropped in the upgrade script. It's not likely anything would be
>> depending on it, is it?
> I don't see much point in taking the risk.
What ri
On Tue, Feb 15, 2011 at 10:42 AM, Tom Lane wrote:
> Heikki Linnakangas writes:
>> On 14.02.2011 21:49, Alvaro Herrera wrote:
>>> Thanks to Noah Misch's review of the keylock patch I noticed that
>>> pageinspect's heap_page_items(bytea) function returns infomask and
>>> infomask2 as smallint (sign
Heikki Linnakangas writes:
> On 14.02.2011 21:49, Alvaro Herrera wrote:
>> Thanks to Noah Misch's review of the keylock patch I noticed that
>> pageinspect's heap_page_items(bytea) function returns infomask and
>> infomask2 as smallint (signed). But the fields in the tuple header are
>> 16 bits u
On 14.02.2011 21:49, Alvaro Herrera wrote:
Thanks to Noah Misch's review of the keylock patch I noticed that
pageinspect's heap_page_items(bytea) function returns infomask and
infomask2 as smallint (signed). But the fields in the tuple header are
16 bits unsigned, so if the high (16th) bit is se
