Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-03-28 Thread David Fetter
On Mon, Mar 28, 2011 at 10:56:39PM +0300, Peter Eisentraut wrote: > On tor, 2011-03-24 at 16:05 -0400, Peter Eisentraut wrote: > > Anyway, here is a small patch that changes the duplicate_oids script > > to return a nonzero exit status in case of a problem, and then creates > > a global maintainer-

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-03-28 Thread Peter Eisentraut
On tor, 2011-03-24 at 16:05 -0400, Peter Eisentraut wrote: > Anyway, here is a small patch that changes the duplicate_oids script > to return a nonzero exit status in case of a problem, and then creates > a global maintainer-check target that checks that and the SGML syntax > and the NLS thing. Ot

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-03-24 Thread Robert Haas
On Thu, Mar 24, 2011 at 4:05 PM, Peter Eisentraut wrote: > On tor, 2011-02-10 at 12:58 +0200, Peter Eisentraut wrote: >> There is make check target in doc/src/sgml/ that is supposed to catch >> this.  But it's probably hard to remember to run that. >> >> One thing I was thinking of was that we cou

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-03-24 Thread Peter Eisentraut
On tor, 2011-02-10 at 12:58 +0200, Peter Eisentraut wrote: > There is make check target in doc/src/sgml/ that is supposed to catch > this. But it's probably hard to remember to run that. > > One thing I was thinking of was that we could add a global make > maintainer-check target (a name I picked

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread David Fetter
On Thu, Feb 10, 2011 at 11:29:43AM -0300, Alvaro Herrera wrote: > Excerpts from Peter Eisentraut's message of jue feb 10 07:58:16 -0300 2011: > > > One thing I was thinking of was that we could add a global make > > maintainer-check target (a name I picked up from other projects) > > which would r

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread David Fetter
On Thu, Feb 10, 2011 at 09:16:09PM +0200, Peter Eisentraut wrote: > On tor, 2011-02-10 at 10:40 -0800, David Fetter wrote: > > I think all such checks belong in .git/hooks/pre-commit, and need > > to be as cross-platform as needed for committers. Would a > > *n*x-based version do for a start? > >

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread Peter Eisentraut
On tor, 2011-02-10 at 10:40 -0800, David Fetter wrote: > I think all such checks belong in .git/hooks/pre-commit, and need to > be as cross-platform as needed for committers. Would a *n*x-based > version do for a start? I think as a matter of principle, the only things that belongs into git hooks

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread David Fetter
On Thu, Feb 10, 2011 at 12:58:16PM +0200, Peter Eisentraut wrote: > On ons, 2011-02-09 at 08:00 -0800, David Fetter wrote: > > On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote: > > > Remove more SGML tabs. > > > > Perhaps we should see about putting something in .git/hooks/pre-commit

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of jue feb 10 07:58:16 -0300 2011: > One thing I was thinking of was that we could add a global make > maintainer-check target (a name I picked up from other projects) which > would run various source code sanity checks. Besides the SGML tabs > issue, my f

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-10 Thread Peter Eisentraut
On ons, 2011-02-09 at 08:00 -0800, David Fetter wrote: > On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote: > > Remove more SGML tabs. > > Perhaps we should see about putting something in .git/hooks/pre-commit > so people can focus on more substantive matters. > > Is there some kind o

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-09 Thread Magnus Hagander
On Feb 9, 2011 5:01 PM, "David Fetter" wrote: > > On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote: > > Remove more SGML tabs. > > Perhaps we should see about putting something in .git/hooks/pre-commit > so people can focus on more substantive matters. > > Is there some kind of cross-

Re: [HACKERS] [COMMITTERS] pgsql: Remove more SGML tabs.

2011-02-09 Thread David Fetter
On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote: > Remove more SGML tabs. Perhaps we should see about putting something in .git/hooks/pre-commit so people can focus on more substantive matters. Is there some kind of cross-platform way to do this? I'm thinking that given the fact th