On Thu, Feb 10, 2011 at 12:58:16PM +0200, Peter Eisentraut wrote: > On ons, 2011-02-09 at 08:00 -0800, David Fetter wrote: > > On Wed, Feb 09, 2011 at 01:17:06PM +0000, Bruce Momjian wrote: > > > Remove more SGML tabs. > > > > Perhaps we should see about putting something in .git/hooks/pre-commit > > so people can focus on more substantive matters. > > > > Is there some kind of cross-platform way to do this? I'm thinking > > that given the fact that our build system already requires Perl, there > > should be, but I'm not quite sure how this would be accomplished. > > There is make check target in doc/src/sgml/ that is supposed to catch > this. But it's probably hard to remember to run that.
It's "check-tabs", and if you hadn't mentioned it, I'd never have seen it. > One thing I was thinking of was that we could add a global make > maintainer-check target (a name I picked up from other projects) which > would run various source code sanity checks. Besides the SGML tabs > issue, my favourite would be duplicate_oids. Maybe if we could find a > third use case, we'd have a quorum for implementing this. I think all such checks belong in .git/hooks/pre-commit, and need to be as cross-platform as needed for committers. Would a *n*x-based version do for a start? Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
