Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-29 Thread Bruce Momjian
Gavin Sherry wrote: > On Thu, 29 Aug 2002, Tom Lane wrote: > > > Robert Treat <[EMAIL PROTECTED]> writes: > > > One of my users is generating a notice message --> NOTICE: Adding > > > missing FROM-clause entry for table "msg202" It might be helpful to > > > dump out the query on notice messages

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Bruce Momjian
Larry Rosenman wrote: > > > 3. Not sure what the "original" is for -- you're not transforming > > > anything. > > > > Agreed. Just call it "Error query". Seems clear to me. > What about rule(s) transformation(s)? Will we see the real query or the > transformed query? Well, looking at Gavin's

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Larry Rosenman
On Wed, 2002-08-28 at 14:05, Bruce Momjian wrote: > Peter Eisentraut wrote: > > Gavin Sherry writes: > > > > > Attached is the patch. debug_print_error_query is set to false by default. > > > > > > For want of a better phrase, I've prepended 'original query: ' to the > > > error message to highli

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Bruce Momjian
Peter Eisentraut wrote: > Gavin Sherry writes: > > > Attached is the patch. debug_print_error_query is set to false by default. > > > > For want of a better phrase, I've prepended 'original query: ' to the > > error message to highlight why it is in the log. > > >From your resident How-To-Name-S

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Peter Eisentraut
Christopher Kings-Lynne writes: > Do you think that 'original query: ..' looks a bit like bad english? Should > it be properly capitalised? ie. 'Original query: ...'? Just nitpicking... I find it's generally better to not capitalize anything in program messages, unless the sentence/paragraph

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Peter Eisentraut
Gavin Sherry writes: > Attached is the patch. debug_print_error_query is set to false by default. > > For want of a better phrase, I've prepended 'original query: ' to the > error message to highlight why it is in the log. >From your resident How-To-Name-Stuff Nitpicker: 1. The names of the deb

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-28 Thread Christopher Kings-Lynne
l query: ...'? Just nitpicking... Chris > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Gavin Sherry > Sent: Wednesday, 28 August 2002 2:27 PM > To: Tom Lane > Cc: Hackers; [EMAIL PROTECTED] > Subject: Re: [PATCHES] [HACKERS] P