Re: [HACKERS] visibility maps and heap_prune

2010-02-27 Thread Bruce Momjian
Heikki Linnakangas wrote: > Bruce Momjian wrote: > > Pavan Deolasee wrote: > >> On Fri, Feb 26, 2010 at 8:19 AM, Bruce Momjian wrote: > >> > >>> Whatever happened to this? It was in the first 9.0 commitfest but was > >>> returned with feedback but never updated: > >>> > >>> > >> Though Alex did s

Re: [HACKERS] visibility maps and heap_prune

2010-02-27 Thread Heikki Linnakangas
Bruce Momjian wrote: > Pavan Deolasee wrote: >> On Fri, Feb 26, 2010 at 8:19 AM, Bruce Momjian wrote: >> >>> Whatever happened to this? It was in the first 9.0 commitfest but was >>> returned with feedback but never updated: >>> >>> >> Though Alex did some useful tests and review, and in fact con

Re: [HACKERS] visibility maps and heap_prune

2010-02-26 Thread Bruce Momjian
Pavan Deolasee wrote: > On Fri, Feb 26, 2010 at 8:19 AM, Bruce Momjian wrote: > > > > > Whatever happened to this? It was in the first 9.0 commitfest but was > > returned with feedback but never updated: > > > > > Though Alex did some useful tests and review, and in fact confirmed that the > VAC

Re: [HACKERS] visibility maps and heap_prune

2010-02-25 Thread Pavan Deolasee
On Fri, Feb 26, 2010 at 8:19 AM, Bruce Momjian wrote: > > Whatever happened to this? It was in the first 9.0 commitfest but was > returned with feedback but never updated: > > Though Alex did some useful tests and review, and in fact confirmed that the VACUUM time dropped from 16494 msec to 366

Re: [HACKERS] visibility maps and heap_prune

2010-02-25 Thread Robert Haas
On Thu, Feb 25, 2010 at 10:32 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Thu, Feb 25, 2010 at 9:49 PM, Bruce Momjian wrote: >> > Whatever happened to this? ?It was in the first 9.0 commitfest but was >> > returned with feedback but never updated: >> > >> > ? ? ? ?https://commitfest.postg

Re: [HACKERS] visibility maps and heap_prune

2010-02-25 Thread Bruce Momjian
Robert Haas wrote: > On Thu, Feb 25, 2010 at 9:49 PM, Bruce Momjian wrote: > > Whatever happened to this? ?It was in the first 9.0 commitfest but was > > returned with feedback but never updated: > > > > ? ? ? ?https://commitfest.postgresql.org/action/patch_view?id=75 > > Well, the patch author c

Re: [HACKERS] visibility maps and heap_prune

2010-02-25 Thread Robert Haas
On Thu, Feb 25, 2010 at 9:49 PM, Bruce Momjian wrote: > Whatever happened to this?  It was in the first 9.0 commitfest but was > returned with feedback but never updated: > >        https://commitfest.postgresql.org/action/patch_view?id=75 Well, the patch author chose not to pursue it. It's clea

Re: [HACKERS] visibility maps and heap_prune

2010-02-25 Thread Bruce Momjian
Whatever happened to this? It was in the first 9.0 commitfest but was returned with feedback but never updated: https://commitfest.postgresql.org/action/patch_view?id=75 --- Pavan Deolasee wrote: > ISTM that the PD

Re: [HACKERS] visibility maps and heap_prune

2009-07-25 Thread Robert Haas
On Tue, Jul 21, 2009 at 2:37 AM, Pavan Deolasee wrote: > On Tue, Jul 21, 2009 at 10:38 AM, Robert Haas wrote: >> Pavan, are you planning to respond to Alex's comments and/or update this >> patch? > > Yes, I will. Hopefully  by end of this week. Since it has now been 10 days since this patch was r

Re: [HACKERS] visibility maps and heap_prune

2009-07-20 Thread Pavan Deolasee
On Tue, Jul 21, 2009 at 10:38 AM, Robert Haas wrote: > > Pavan, are you planning to respond to Alex's comments and/or update this > patch? > Yes, I will. Hopefully by end of this week. Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers ma

Re: [HACKERS] visibility maps and heap_prune

2009-07-20 Thread Robert Haas
On Wed, Jul 15, 2009 at 11:44 PM, Alex Hunsaker wrote: > On Mon, Dec 8, 2008 at 06:56, Pavan Deolasee wrote: >> Here is a patch which implements this. The PD_ALL_VISIBLE flag is set if all >> tuples in the page are visible to all transactions and there are no DEAD >> line pointers in the page. The

Re: [HACKERS] visibility maps and heap_prune

2009-07-15 Thread Alex Hunsaker
On Mon, Dec 8, 2008 at 06:56, Pavan Deolasee wrote: > Here is a patch which implements this. The PD_ALL_VISIBLE flag is set if all > tuples in the page are visible to all transactions and there are no DEAD > line pointers in the page. The second check is required so that VACUUM takes > up the page.

Re: [HACKERS] visibility maps and heap_prune

2009-01-20 Thread Heikki Linnakangas
Bruce Momjian wrote: Pavan Deolasee wrote: On Mon, Dec 8, 2008 at 11:33 AM, Pavan Deolasee wrote: On Sat, Dec 6, 2008 at 8:08 PM, Heikki Linnakangas < heikki.linnakan...@enterprisedb.com> wrote: If you see a straightforward way, please submit a patch! Will do that. Here is a patch whi

Re: [HACKERS] visibility maps and heap_prune

2009-01-20 Thread Bruce Momjian
Pavan Deolasee wrote: > On Mon, Dec 8, 2008 at 11:33 AM, Pavan Deolasee > wrote: > > > > > > > On Sat, Dec 6, 2008 at 8:08 PM, Heikki Linnakangas < > > heikki.linnakan...@enterprisedb.com> wrote: > > > >> > >> If you see a straightforward way, please submit a patch! > >> > >> > > Will do that. >

Re: [HACKERS] visibility maps and heap_prune

2009-01-15 Thread Robert Haas
> Yeah, I dropped the ball on that one. It's been knocking in the back of my > head since, but I've never gotten around. I'm feeling reluctant to review it > since it's not really a high priority thing, and I'm not sure whether we > want it or not. In that case perhaps we should add it to http://w

Re: [HACKERS] visibility maps and heap_prune

2009-01-15 Thread Heikki Linnakangas
Pavan Deolasee wrote: On Thu, Jan 15, 2009 at 7:10 AM, Bruce Momjian wrote: Is this something for 8.4 CVS? I worked out the patch as per Heikki's suggestion. So I think he needs to review and decide it's fate. Yeah, I dropped the ball on that one. It's been knocking in the back of my head

Re: [HACKERS] visibility maps and heap_prune

2009-01-15 Thread Pavan Deolasee
On Thu, Jan 15, 2009 at 7:10 AM, Bruce Momjian wrote: > > Is this something for 8.4 CVS? > I worked out the patch as per Heikki's suggestion. So I think he needs to review and decide it's fate. Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hac

Re: [HACKERS] visibility maps and heap_prune

2009-01-14 Thread Bruce Momjian
Is this something for 8.4 CVS? --- Pavan Deolasee wrote: > On Mon, Dec 8, 2008 at 11:33 AM, Pavan Deolasee > wrote: > > > > > > > On Sat, Dec 6, 2008 at 8:08 PM, Heikki Linnakangas < > > heikki.linnakan...@enterprisedb.com

Re: [HACKERS] visibility maps and heap_prune

2008-12-08 Thread Pavan Deolasee
On Mon, Dec 8, 2008 at 11:33 AM, Pavan Deolasee <[EMAIL PROTECTED]>wrote: > > > On Sat, Dec 6, 2008 at 8:08 PM, Heikki Linnakangas < > [EMAIL PROTECTED]> wrote: > >> >> If you see a straightforward way, please submit a patch! >> >> > Will do that. > > Here is a patch which implements this. The PD

Re: [HACKERS] visibility maps and heap_prune

2008-12-07 Thread Pavan Deolasee
On Sat, Dec 6, 2008 at 8:08 PM, Heikki Linnakangas < [EMAIL PROTECTED]> wrote: > > If you see a straightforward way, please submit a patch! > > Will do that. Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com

Re: [HACKERS] visibility maps and heap_prune

2008-12-06 Thread Heikki Linnakangas
Pavan Deolasee wrote: ISTM that the PD_ALL_VISIBLE flag and the visibility map bit can be set at the end of pruning operation if we know that there are only tuples visible to all transactions left in the page. Right. The way pruning is done, I think it would be straight forward to get this in

[HACKERS] visibility maps and heap_prune

2008-12-04 Thread Pavan Deolasee
ISTM that the PD_ALL_VISIBLE flag and the visibility map bit can be set at the end of pruning operation if we know that there are only tuples visible to all transactions left in the page. The way pruning is done, I think it would be straight forward to get this information. Thanks, Pavan -- Pava