Re: [HACKERS] splitting *_desc routines

2012-11-27 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane escribió: >> FWIW, I'd vote for dumping all of these into *one* rmgrdesc directory >> (which may as well be under access/ since that's where the xlog code is), >> regardless of where the corresponding replay code is in the source tree. >> I don't think splitting t

Re: [HACKERS] splitting *_desc routines

2012-11-23 Thread Tom Lane
Alvaro Herrera writes: > So incorporating these ideas, the layout now looks like this: > ./commands/seq_desc.c > ./commands/dbase_desc.c > ./commands/tablespace_desc.c > ./catalog/storage_desc.c > ./utils/cache/relmap_desc.c > ./access/rmgrdesc/mxact_desc.c > ./access/rmgrdesc/spgdesc.c > ./acces

Re: [HACKERS] splitting *_desc routines

2012-11-23 Thread Simon Riggs
On 23 November 2012 22:52, Alvaro Herrera wrote: > ./access/rmgrdesc/xact_desc.c > ./access/rmgrdesc/heapdesc.c Could we have either all underscores _ or none at all for the naming? -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

Re: [HACKERS] splitting *_desc routines

2012-11-23 Thread Alvaro Herrera
Robert Haas escribió: > On Thu, Oct 25, 2012 at 4:25 AM, Simon Riggs wrote: > > I'd put these in a separate directory to avoid annoyance. Transam is > > already too large. > > +1. A further advantage of that is that it means that that everything > in that new directory will be intended to end up

Re: [HACKERS] splitting *_desc routines

2012-10-26 Thread Robert Haas
On Thu, Oct 25, 2012 at 4:25 AM, Simon Riggs wrote: > I'd put these in a separate directory to avoid annoyance. Transam is > already too large. +1. A further advantage of that is that it means that that everything in that new directory will be intended to end up as all-separately-compilable, whi

Re: [HACKERS] splitting *_desc routines

2012-10-25 Thread Simon Riggs
On 24 October 2012 21:44, Alvaro Herrera wrote: > Here's a small WIP patch that does the proposed splitting. This is a > first step towards the objective of having a separately compilable > xlogdump -- more work is needed before that can be made to work fully. > > Now, per previous discussion, I

Re: [HACKERS] splitting *_desc routines

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 12:14 PM, Andres Freund wrote: >> An alternative thing that might be worth considering before you go all >> in on this is whether the xlogdump functionality shouldn't just be part >> of the regular server executable, ie you'd call it with >> >> postgres --xlogdump >>

Re: [HACKERS] splitting *_desc routines

2012-08-30 Thread Andres Freund
On Wednesday, August 29, 2012 10:06:16 PM Tom Lane wrote: > Alvaro Herrera writes: > > I looked at Andres' patch and the general idea is rather horrible: it > > links all backend files into the output executable. This is so that the > > *_desc functions can be used from their respective object fi

Re: [HACKERS] splitting *_desc routines

2012-08-29 Thread Tom Lane
Alvaro Herrera writes: > I looked at Andres' patch and the general idea is rather horrible: it > links all backend files into the output executable. This is so that the > *_desc functions can be used from their respective object files, which > obviously have a lot of requirements for backend infr

[HACKERS] splitting *_desc routines

2012-08-29 Thread Alvaro Herrera
So Andres Freund floated a proposal to create an xlogdump sort of tool, in core, and posted a patch. One advantage of having xlogdump in core is that we can have buildfarm test that part of the Xlog code, which currently sees no testing at all. In fact we could use it as a testbed for XLog in gene