Re: [HACKERS] some missing internationalization in pg_basebackup

2011-08-16 Thread Magnus Hagander
On Tue, Aug 16, 2011 at 11:35, Dimitri Fontaine wrote: > Magnus Hagander writes: >> Note that the progress indicator will *always* count wrong when you >> choose to include WAL, since we just don't know how much WAL there >> should be. I guess in this case we could just advance the "end >> counte

Re: [HACKERS] some missing internationalization in pg_basebackup

2011-08-16 Thread Dimitri Fontaine
Magnus Hagander writes: > Note that the progress indicator will *always* count wrong when you > choose to include WAL, since we just don't know how much WAL there > should be. I guess in this case we could just advance the "end > counter" as well as we go, making sure it doesn't shoot above 100%.

Re: [HACKERS] some missing internationalization in pg_basebackup

2011-08-16 Thread Magnus Hagander
On Tue, Aug 16, 2011 at 10:33, Peter Eisentraut wrote: > On ons, 2011-08-10 at 11:39 +0200, Magnus Hagander wrote: >> On Tue, Aug 9, 2011 at 13:38, Peter Eisentraut wrote: >> > I noticed that the progress reporting code in pg_basebackup does not >> > allow for translation.  This would normally be

Re: [HACKERS] some missing internationalization in pg_basebackup

2011-08-16 Thread Peter Eisentraut
On ons, 2011-08-10 at 11:39 +0200, Magnus Hagander wrote: > On Tue, Aug 9, 2011 at 13:38, Peter Eisentraut wrote: > > I noticed that the progress reporting code in pg_basebackup does not > > allow for translation. This would normally be easy to fix, but this > > code has a number of tricky issues

Re: [HACKERS] some missing internationalization in pg_basebackup

2011-08-10 Thread Magnus Hagander
On Tue, Aug 9, 2011 at 13:38, Peter Eisentraut wrote: > I noticed that the progress reporting code in pg_basebackup does not > allow for translation.  This would normally be easy to fix, but this > code has a number of tricky issues, including the INT64_FORMAT, possibly > some plural concerns, and

[HACKERS] some missing internationalization in pg_basebackup

2011-08-09 Thread Peter Eisentraut
I noticed that the progress reporting code in pg_basebackup does not allow for translation. This would normally be easy to fix, but this code has a number of tricky issues, including the INT64_FORMAT, possibly some plural concerns, and some space alignment issues that hidden in some of those hardc