Re: [HACKERS] slotname vs slot_name

2014-07-02 Thread Andres Freund
On 2014-06-05 12:57:57 +0200, Andres Freund wrote: > > BTW, what about also renaming pg_llog directory? I'm afraid that > > a user can confuse pg_log with pg_llog. > > We have: > * pg_ldecoding (Heikki) > * pg_lcse or pg_lcset (Petr) > * pg_logical (Andres) > > I like, what a surprise, my own sug

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Michael Paquier
On Fri, Jun 6, 2014 at 2:43 AM, Tom Lane wrote: > Alvaro Herrera writes: >> Robert Haas wrote: >>> For my part, I'd strongly prefer a name based on the term "logical >>> decoding". > >> There is no reason not to use long names, so I think pg_logical_decoding >> is fine. > > +1 Indeed. With such a

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Petr Jelinek
On 05/06/14 19:56, Andres Freund wrote: On June 5, 2014 7:43:06 PM CEST, Tom Lane wrote: Alvaro Herrera writes: Robert Haas wrote: For my part, I'd strongly prefer a name based on the term "logical decoding". There is no reason not to use long names, so I think pg_logical_decoding is fi

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Andres Freund
On June 5, 2014 7:43:06 PM CEST, Tom Lane wrote: >Alvaro Herrera writes: >> Robert Haas wrote: >>> For my part, I'd strongly prefer a name based on the term "logical >>> decoding". > >> There is no reason not to use long names, so I think >pg_logical_decoding >> is fine. > >+1 Still not a fan of

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Tom Lane
Alvaro Herrera writes: > Robert Haas wrote: >> For my part, I'd strongly prefer a name based on the term "logical >> decoding". > There is no reason not to use long names, so I think pg_logical_decoding > is fine. +1 regards, tom lane -- Sent via pgsql-hackers mailing

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Alvaro Herrera
Robert Haas wrote: > > BTW, the stuff that we have in pg_llog are not really logs at all, so > > pg_llog was always a misnomer. > > Also true. > > For my part, I'd strongly prefer a name based on the term "logical > decoding". This feature has lots of names (change-set extraction, > logical rep

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Robert Haas
On Thu, Jun 5, 2014 at 7:12 AM, Heikki Linnakangas wrote: >>> BTW, what about also renaming pg_llog directory? I'm afraid that >>> a user can confuse pg_log with pg_llog. >> >> We have: >> * pg_ldecoding (Heikki) >> * pg_lcse or pg_lcset (Petr) >> * pg_logical (Andres) >> >> I like, what a surpris

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Andres Freund
On 2014-06-05 12:57:57 +0200, Andres Freund wrote: > On 2014-06-05 10:57:58 +0900, Fujii Masao wrote: > > I like using "slot_name" everywhere, i.e, even in recovery.conf. > > primary_slot_name seems not so long name. > > It also has the advantage that we can add a couple more slot_* options > late

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Andres Freund
On 2014-06-05 14:12:31 +0300, Heikki Linnakangas wrote: > On 06/05/2014 01:57 PM, Andres Freund wrote: > >On 2014-06-05 10:57:58 +0900, Fujii Masao wrote: > >We have: > >* pg_ldecoding (Heikki) > >* pg_lcse or pg_lcset (Petr) > >* pg_logical (Andres) > > > >I like, what a surprise, my own suggestio

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Heikki Linnakangas
On 06/05/2014 02:10 PM, Magnus Hagander wrote: On Thu, Jun 5, 2014 at 12:57 PM, Andres Freund wrote: We have: * pg_ldecoding (Heikki) * pg_lcse or pg_lcset (Petr) * pg_logical (Andres) I like, what a surprise, my own suggestion best. The name seems more versatile because it's not restricted t

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Heikki Linnakangas
On 06/05/2014 01:57 PM, Andres Freund wrote: On 2014-06-05 10:57:58 +0900, Fujii Masao wrote: On Thu, Jun 5, 2014 at 8:24 AM, Andres Freund wrote: Hi, Due to the opened window of the pg_control/catalog version bump a chance has opened to fix a inconsistency I've recently been pointed towards:

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Magnus Hagander
On Thu, Jun 5, 2014 at 12:57 PM, Andres Freund wrote: > On 2014-06-05 10:57:58 +0900, Fujii Masao wrote: > > On Thu, Jun 5, 2014 at 8:24 AM, Andres Freund > wrote: > > > Hi, > > > > > > Due to the opened window of the pg_control/catalog version bump a > chance > > > has opened to fix a inconsist

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Andres Freund
On 2014-06-05 20:02:38 +0900, Michael Paquier wrote: > On Thu, Jun 5, 2014 at 7:57 PM, Andres Freund wrote: > > We have: > > * pg_ldecoding (Heikki) > > * pg_lcse or pg_lcset (Petr) > > * pg_logical (Andres) > pg_decoding, simply? I don't like it much, because it's pretty much restricted for data

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Michael Paquier
On Thu, Jun 5, 2014 at 7:57 PM, Andres Freund wrote: > We have: > * pg_ldecoding (Heikki) > * pg_lcse or pg_lcset (Petr) > * pg_logical (Andres) pg_decoding, simply? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Andres Freund
On 2014-06-05 10:57:58 +0900, Fujii Masao wrote: > On Thu, Jun 5, 2014 at 8:24 AM, Andres Freund wrote: > > Hi, > > > > Due to the opened window of the pg_control/catalog version bump a chance > > has opened to fix a inconsistency I've recently been pointed > > towards: > > Namely that replication

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Michael Paquier
On Thu, Jun 5, 2014 at 5:27 PM, Magnus Hagander wrote: > > On Jun 5, 2014 10:22 AM, "Devrim Gündüz" wrote: >> >> >> Hi, >> >> On Thu, 2014-06-05 at 10:57 +0900, Fujii Masao wrote: >> > BTW, what about also renaming pg_llog directory? I'm afraid that >> > a user can confuse pg_log with pg_llog. >>

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Magnus Hagander
On Jun 5, 2014 10:22 AM, "Devrim Gündüz" wrote: > > > Hi, > > On Thu, 2014-06-05 at 10:57 +0900, Fujii Masao wrote: > > BTW, what about also renaming pg_llog directory? I'm afraid that > > a user can confuse pg_log with pg_llog. > > +1. I hit this while testing 9.4 this week. Should be confusing f

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Devrim Gündüz
Hi, On Thu, 2014-06-05 at 10:57 +0900, Fujii Masao wrote: > BTW, what about also renaming pg_llog directory? I'm afraid that > a user can confuse pg_log with pg_llog. +1. I hit this while testing 9.4 this week. Should be confusing for many end-users. Regards, -- Devrim GÜNDÜZ Principal Systems

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Petr Jelinek
On 05/06/14 10:11, Heikki Linnakangas wrote: On 06/05/2014 05:09 AM, Amit Langote wrote: Hi, On Thu, Jun 5, 2014 at 10:57 AM, Fujii Masao wrote: I like using "slot_name" everywhere, i.e, even in recovery.conf. primary_slot_name seems not so long name. +1 BTW, what about also renaming pg_

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Heikki Linnakangas
On 06/05/2014 05:09 AM, Amit Langote wrote: Hi, On Thu, Jun 5, 2014 at 10:57 AM, Fujii Masao wrote: I like using "slot_name" everywhere, i.e, even in recovery.conf. primary_slot_name seems not so long name. BTW, what about also renaming pg_llog directory? I'm afraid that a user can confuse pg

Re: [HACKERS] slotname vs slot_name

2014-06-04 Thread Amit Langote
Hi, On Thu, Jun 5, 2014 at 10:57 AM, Fujii Masao wrote: > I like using "slot_name" everywhere, i.e, even in recovery.conf. > primary_slot_name seems not so long name. > > BTW, what about also renaming pg_llog directory? I'm afraid that > a user can confuse pg_log with pg_llog. > Recently I came

Re: [HACKERS] slotname vs slot_name

2014-06-04 Thread Fujii Masao
On Thu, Jun 5, 2014 at 8:24 AM, Andres Freund wrote: > Hi, > > Due to the opened window of the pg_control/catalog version bump a chance > has opened to fix a inconsistency I've recently been pointed > towards: > Namely that replication slots are named 'slot_name' in one half of the > cases and 'sl

[HACKERS] slotname vs slot_name

2014-06-04 Thread Andres Freund
Hi, Due to the opened window of the pg_control/catalog version bump a chance has opened to fix a inconsistency I've recently been pointed towards: Namely that replication slots are named 'slot_name' in one half of the cases and 'slotname' in the other. That's in views, SRF columns, function parame