On 1/13/17 9:45 AM, Peter Eisentraut wrote:
> On 1/12/17 9:43 PM, Bruce Momjian wrote:
>> On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote:
>>> Peter Eisentraut writes:
In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
In pg_upgrade, there is this code:
>>>
Peter Eisentraut writes:
> On 1/12/17 9:43 PM, Bruce Momjian wrote:
>> On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote:
>>> Peter Eisentraut writes:
I think the last line should be changed to something like
fast ? "-m fast" : "-m smart");
>>> There is maybe room for a separate
On 1/12/17 9:43 PM, Bruce Momjian wrote:
> On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
>>> In pg_upgrade, there is this code:
>>> ...
>>> I think the last line should be chang
On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
> > In pg_upgrade, there is this code:
> > ...
> > I think the last line should be changed to something like
> > fast
Peter Eisentraut writes:
> In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
> In pg_upgrade, there is this code:
> ...
> I think the last line should be changed to something like
> fast ? "-m fast" : "-m smart");
Ugh. Clear oversight.
There is maybe roo
In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
In pg_upgrade, there is this code:
void
stop_postmaster(bool fast)
{
...
exec_prog(SERVER_STOP_LOG_FILE, NULL, !fast,
"\"%s/pg_ctl\" -w -D \"%s\" -o \"%s\" %s stop",
cluster->bindir, clust