Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". > In pg_upgrade, there is this code: > ... > I think the last line should be changed to something like > fast ? "-m fast" : "-m smart");
Ugh. Clear oversight. There is maybe room for a separate discussion about whether pg_upgrade *should* be using fast mode, but if so we could remove the "bool fast" argument from this function altogether. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers