Thomas Lockhart <[EMAIL PROTECTED]> writes:
> If LOCALE_NAME_BUFLEN changes size between writing and reading the
> control file, the CRC *could* still be calculated correctly.
There might be some value to storing sizeof(ControlFileData) explicitly,
so that that CRC calculation could be made. But
> > OK, I'll add NAMEDATALEN, FUNC_MAX_ARGS, and LOCALE_NAME_BUFLEN. Any
> > more?
> No, you're missing my point: there is zero value in adding
> LOCALE_NAME_BUFLEN as an explicit field in ControlFileData.
> The entire physical layout of ControlFileData has to be implicit in
> PG_CONTROL_VERSION,
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> OK, I'll add NAMEDATALEN, FUNC_MAX_ARGS, and LOCALE_NAME_BUFLEN. Any
> more?
No, you're missing my point: there is zero value in adding
LOCALE_NAME_BUFLEN as an explicit field in ControlFileData.
The entire physical layout of ControlFileData has to be
> > I notice that the compile-time locale settings are registered in that
> > same structure. And that they depend on NAMEDATALEN,
> They do? That would be fairly broken if so; sizeof(ControlFileData)
> has to be independent of configurable settings, else you'll not get as
> far as inspecting any
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> I notice that the compile-time locale settings are registered in that
> same structure. And that they depend on NAMEDATALEN,
They do? That would be fairly broken if so; sizeof(ControlFileData)
has to be independent of configurable settings, else you'
At Tom Lane's suggestion, I am adding a field to pg_control to hold the
compile-time configuration of timestamp and time storage.
I notice that the compile-time locale settings are registered in that
same structure. And that they depend on NAMEDATALEN, which is *not* in
that structure. istm that
