Re: [HACKERS] new version of contrib-intarray

2001-03-19 Thread Bruce Momjian
> Bruce Momjian writes: > > > Seems I am no longer capable of understanding the affects of such > > changes as this: > > > > ! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -DPGSQL71 > > > > ! override CPPFLAGS += -I$(srcdir) -DPGSQL71 > > > > Having $(srcdir) before $(CPPFLAGS) must be si

Re: [HACKERS] new version of contrib-intarray

2001-03-19 Thread Bruce Momjian
Sorry, I have again messed up this Makefile, and I am glad Tom has put things back. Seems I am no longer capable of understanding the affects of such changes as this: ! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -DPGSQL71 ! override CPPFLAGS += -I$(srcdir) -DPG

Re: [HACKERS] new version of contrib-intarray

2001-03-19 Thread Peter Eisentraut
Bruce Momjian writes: > Seems I am no longer capable of understanding the affects of such > changes as this: > > ! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -DPGSQL71 > > ! override CPPFLAGS += -I$(srcdir) -DPGSQL71 > > Having $(srcdir) before $(CPPFLAGS) must be significant. The

[HACKERS] New version of contrib-intarray is ready !

2001-03-19 Thread Oleg Bartunov
Hi, New version of contrib-intarray is available from http://www.sai.msu.su/~megera/postgres/gist/code/7.1/contrib-intarray.tar.gz >From README.intarray: March 19, 2001 1. Added support for toastable keys 2. Improved split algorithm for intbig (selection speedup is about 30%) Reg

Re: [HACKERS] new version of contrib-intarray

2001-03-18 Thread Oleg Bartunov
I just returned from vacation and identified the problem. We'll fix it. Regards, Oleg On Sun, 18 Mar 2001, Tom Lane wrote: > I wrote: > > I did this, also reinstalled the include-file changes I had made, and > > then spent several fruitless hours trying to find why the "i

Re: [HACKERS] new version of contrib-intarray

2001-03-18 Thread Tom Lane
I wrote: > I did this, also reinstalled the include-file changes I had made, and > then spent several fruitless hours trying to find why the "intbig" index > operators fail selftest here (on HP-PA). I suppose it's a portability > problem, since presumably they pass for Oleg ... but I don't see it

Re: [HACKERS] new version of contrib-intarray

2001-03-18 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > I only saw that the Makefile is back to how it looked at rev 1.1 before I > did some work on it. AFAICT the Makefile should be reverted back to the > previous revision, since the code change does not require any changes to > the Makefile. I did this

Re: [HACKERS] new version of contrib-intarray

2001-03-18 Thread Peter Eisentraut
Bruce Momjian writes: > I see change of += in CFLAGS (harmless), Not. > movement of #include > , and removal of // comments, which don't appear anymore in > the code. I only saw that the Makefile is back to how it looked at rev 1.1 before I did some work on it. AFAICT the Makefile should be r

Re: [HACKERS] new version of contrib-intarray

2001-03-17 Thread Bruce Momjian
I checked README.intarray to see what the most recent date was, and it was Jan 10, so I knew that this version was newer. I then did a diff -c against the current CVS and I didn't see anything unusual in the changes. Attached is the CVS diff command line showing me all the changes made: cvs

Re: [HACKERS] new version of contrib-intarray

2001-03-17 Thread Peter Eisentraut
Bruce Momjian writes: > Installed in CVS. Thanks. You overwrote the changes that other people have made meanwhile. > > > Mark, > > > > we prepared new version of contrib-intarray - > > index support for 1-D integer arrays using GiST. > > > > Changes: > > > > > > - Improved regression test > >

Re: [HACKERS] new version of contrib-intarray

2001-03-17 Thread Bruce Momjian
Installed in CVS. Thanks. > Mark, > > we prepared new version of contrib-intarray - > index support for 1-D integer arrays using GiST. > > Changes: > > > - Improved regression test > - Current implementation provides index support for one-dimensional >array of int4's - gist__int_ops, s

Re: [HACKERS] new version of contrib-intarray

2001-03-17 Thread Bruce Momjian
Seems we have an older version in CVS. I will update it now. I assume /contrib is available for changes up until release, as usual. > Mark, > > we prepared new version of contrib-intarray - > index support for 1-D integer arrays using GiST. > > Changes: > > > - Improved regression test > -

Re: [HACKERS] new version of contrib-intarray

2001-01-29 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > gist__int_ops| 1007 > gist__intbig_ops | 1007 > we want gist__int_ops to be default index opclass. > If we delete gist__intbig_ops entry from opclass, then we couldn't use > gist__intbig_ops ! Put in gist__intbig_ops with zero for the

Re: [HACKERS] new version of contrib-intarray

2001-01-29 Thread Oleg Bartunov
On Sat, 27 Jan 2001, Tom Lane wrote: > Oleg Bartunov <[EMAIL PROTECTED]> writes: > > btw, is there way to specify default ops for index ? > > Sure, that's what pg_opclass is for. Just insert the opclass name > and the OID of the type you want it to be the default index opclass > for. Tom, we al

Re: [HACKERS] new version of contrib-intarray

2001-01-27 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > btw, is there way to specify default ops for index ? Sure, that's what pg_opclass is for. Just insert the opclass name and the OID of the type you want it to be the default index opclass for. regards, tom lane

Re: [HACKERS] new version of contrib-intarray

2001-01-26 Thread Oleg Bartunov
On Sat, 27 Jan 2001, Bruce Momjian wrote: > > Oleg, do you want this in /contrib for 7.1? yes, if it's possible. btw, is there way to specify default ops for index ? We have two methods of index creation for intarrays and would like to define which should be used by default > > > Mark, > > > >

Re: [HACKERS] new version of contrib-intarray

2001-01-26 Thread Bruce Momjian
Oleg, do you want this in /contrib for 7.1? > Mark, > > we prepared new version of contrib-intarray - > index support for 1-D integer arrays using GiST. > > Changes: > > > - Improved regression test > - Current implementation provides index support for one-dimensional >array of int4's

[HACKERS] new version of contrib-intarray

2001-01-25 Thread Oleg Bartunov
Mark, we prepared new version of contrib-intarray - index support for 1-D integer arrays using GiST. Changes: - Improved regression test - Current implementation provides index support for one-dimensional array of int4's - gist__int_ops, suitable for small and medium size of arrays, an