Re: [HACKERS] minor issues in pg_rewind

2015-06-11 Thread Fujii Masao
On Thu, Jun 11, 2015 at 10:21 AM, Michael Paquier wrote: > On Thu, Jun 11, 2015 at 2:38 AM, Fujii Masao wrote: >> * Remove invalid option character "N" from the third argument (valid option >> string) of getopt_long(). >> * Use pg_free() or pfree() to free the memory allocated by pg_malloc() or >

Re: [HACKERS] minor issues in pg_rewind

2015-06-10 Thread Michael Paquier
On Thu, Jun 11, 2015 at 2:38 AM, Fujii Masao wrote: > * Remove invalid option character "N" from the third argument (valid option > string) of getopt_long(). > * Use pg_free() or pfree() to free the memory allocated by pg_malloc() or > palloc() instead of always using free(). > * Assume problem is

[HACKERS] minor issues in pg_rewind

2015-06-10 Thread Fujii Masao
Hi, Attached patch fixes the minor issues in pg_rewind. The fixes are * Remove invalid option character "N" from the third argument (valid option string) of getopt_long(). * Use pg_free() or pfree() to free the memory allocated by pg_malloc() or palloc() instead of always using free(). * Assume