On Thu, Jun 11, 2015 at 2:38 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > * Remove invalid option character "N" from the third argument (valid option > string) of getopt_long(). > * Use pg_free() or pfree() to free the memory allocated by pg_malloc() or > palloc() instead of always using free(). > * Assume problem is no disk space if write() fails but doesn't set errno. > * Fix several typos.
This looks good to me, especially the ENOSPC enforcement for pg_control. We may want to rename datapagemap_iterate to datapagemap_init as well. I can't really see what iterate means in this context. Regards, -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers