Re: [HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Peter Geoghegan
On Sat, Jun 29, 2013 at 8:55 PM, Peter Eisentraut wrote: > ./src/include/storage/checksum_impl.h: In function ‘uint32 > pg_checksum_block(char*, uint32)’: > ./src/include/storage/checksum_impl.h:154: warning: comparison between signed > and unsigned integer expressions On the subject of checksu

Re: [HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Tom Lane
Peter Eisentraut writes: > ./src/include/storage/checksum_impl.h: In function ‘uint32 > pg_checksum_block(char*, uint32)’: > ./src/include/storage/checksum_impl.h:154: warning: comparison between signed > and unsigned integer expressions > We could exclude that file from the check, but it's als

[HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Peter Eisentraut
./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’: ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions We could exclude that file from the check, but it's also easy to fix by making the variable