On Sat, Jun 29, 2013 at 8:55 PM, Peter Eisentraut <pete...@gmx.net> wrote:
> ./src/include/storage/checksum_impl.h: In function ‘uint32 
> pg_checksum_block(char*, uint32)’:
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed 
> and unsigned integer expressions

On the subject of checksum_impl.h, don't you think it's a bit
unfortunate that clients have to do this?:

+ // checksum_impl.h uses Assert, which doesn't work outside the server
+ #undef Assert
+ #define Assert(X)
+
+ #include "storage/checksum_impl.h"
+

Maybe external utilities ought to include another header that does all
of this for them?

-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to