On Mon, Jan 26, 2015 at 9:52 PM, Michael Paquier
wrote:
> On Tue, Jan 27, 2015 at 4:21 AM, Robert Haas wrote:
>> That's what I hope to find out. :-)
> Buildfarm seems happy now. I just gave a try to that on one of my
> small Windows VMs and compared the performance with 9.4 for this
> simple tes
On Tue, Jan 27, 2015 at 4:21 AM, Robert Haas wrote:
> That's what I hope to find out. :-)
Buildfarm seems happy now. I just gave a try to that on one of my
small Windows VMs and compared the performance with 9.4 for this
simple test case when building with MSVC 2010:
create table aa as select ran
On Mon, Jan 26, 2015 at 2:10 PM, Peter Geoghegan wrote:
> On Mon, Jan 26, 2015 at 11:05 AM, Robert Haas wrote:
>> Now that these issues are fixed and the buildfarm is green again, I'm
>> going to try re-enabling this optimization on Windows. My working
>> theory is that disabling that categorica
On Mon, Jan 26, 2015 at 11:05 AM, Robert Haas wrote:
> Now that these issues are fixed and the buildfarm is green again, I'm
> going to try re-enabling this optimization on Windows. My working
> theory is that disabling that categorically was a mis-diagnosis of the
> real problem, and that now th
On Fri, Jan 23, 2015 at 12:34 PM, Robert Haas wrote:
> In other words, even on systems that don't HAVE_LOCALE_T, we still
> have to support the default collation and the C collation, and they
> have to behave differently. There's no way to make that work using
> only strxfrm(), because nothing ge
On Thu, Jan 22, 2015 at 5:51 PM, Peter Geoghegan wrote:
> That having been said, it's clearer to continue to handle each case (C
> locale vs other locales) separately within the new
> bttext_abbrev_convert() function, just to be consistent, but also to
> avoid NUL-terminating the text strings to p
On Thu, Jan 22, 2015 at 12:34 PM, Robert Haas wrote:
> This isn't really Windows-specific. The root of the problem is that
> when LC_COLLATE=C you were trying to use strxfrm() for the abbreviated
> key even though memcmp() is the authoritative comparator in that case.
> Exactly which platforms ha
On Thu, Jan 22, 2015 at 1:00 PM, Peter Geoghegan wrote:
> On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas wrote:
>> Stay tuned for more exciting dispatches from the department of abbreviated
>> keys!
>
> I certainly suspected that we'd have problems with Windows, but
> nothing this bad.
This isn't
On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas wrote:
> Stay tuned for more exciting dispatches from the department of abbreviated
> keys!
I certainly suspected that we'd have problems with Windows, but
nothing this bad.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On Thu, Jan 22, 2015 at 12:17 PM, Robert Haas wrote:
> Long story short: this was broken. It may be that when the dust
> settles we can try re-enabling this on Windows. It might work now
> that this issue is (hopefully) fixed.
Uggh. That still wasn't right; I've pushed commit
d060e07fa919e0eb
On Thu, Jan 22, 2015 at 11:28 AM, Robert Haas wrote:
> This seems to have broken more stuff. My working hypothesis is that
> the culprit is here:
>
> /*
> * There is no special handling of the C locale here, unlike with
> * varstr_cmp(). strxfrm() is used indifferently.
On Thu, Jan 22, 2015 at 10:57 AM, Robert Haas wrote:
> On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan wrote:
>> Even following Robert's disabling of abbreviated keys on Windows,
>> buildfarm animals hamerkop, brolga, currawong and bowerbird remain
>> unhappy, with failing regression tests for "
On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan wrote:
> Even following Robert's disabling of abbreviated keys on Windows,
> buildfarm animals hamerkop, brolga, currawong and bowerbird remain
> unhappy, with failing regression tests for "collate" and sometimes
> (but not always) "aggregates". Som
Even following Robert's disabling of abbreviated keys on Windows,
buildfarm animals hamerkop, brolga, currawong and bowerbird remain
unhappy, with failing regression tests for "collate" and sometimes
(but not always) "aggregates". Some of these only use the C locale.
I think that "aggregates" does
14 matches
Mail list logo
