Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-09 Thread Cédric Villemain
Le samedi 8 juin 2013 23:27:16, Tom Lane a écrit : > =?iso-8859-1?q?C=E9dric_Villemain?= writes: > > I'm not sure of expected value of "max_safe_fds". Your patch now > > initialize with 5 slots instead of 10, if max_safe_fds is large maybe it > > is better to double the size each time we need inst

Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Recently we had a gripe about how you can't read very many files > concurrently with contrib/file_fdw: > http://www.postgresql.org/message-id/of419b5767.8a3c9adb-on85257b79.005491e9-85257b79.0054f...@isn.rtss.qc.ca Ouch, that's pretty bad. > Barring object

Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Tom Lane
=?iso-8859-1?q?C=E9dric_Villemain?= writes: > I'm not sure of expected value of "max_safe_fds". Your patch now initialize > with 5 slots instead of 10, if max_safe_fds is large maybe it is better to > double the size each time we need instead of jumping directly to the largest > size ? I don't

Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Cédric Villemain
> > I just wonder about this statement that you removed: > > * Since we don't want to encourage heavy use of those functions, > > * it seems OK to put a pretty small maximum limit on the number of > > * simultaneously allocated descs. > > > Is it now encouraged to use those functions, or at

Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Tom Lane
=?iso-8859-15?q?C=E9dric_Villemain?= writes: > I just wonder about this statement that you removed: > * Since we don't want to encourage heavy use of those functions, > * it seems OK to put a pretty small maximum limit on the number of > * simultaneously allocated descs. > Is it now encour

Re: [HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Cédric Villemain
Le samedi 8 juin 2013 19:06:58, Tom Lane a écrit : > Recently we had a gripe about how you can't read very many files > concurrently with contrib/file_fdw: > http://www.postgresql.org/message-id/OF419B5767.8A3C9ADB-ON85257B79.005491E > 9-85257b79.0054f...@isn.rtss.qc.ca > > The reason for this is

[HACKERS] Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

2013-06-08 Thread Tom Lane
Recently we had a gripe about how you can't read very many files concurrently with contrib/file_fdw: http://www.postgresql.org/message-id/of419b5767.8a3c9adb-on85257b79.005491e9-85257b79.0054f...@isn.rtss.qc.ca The reason for this is that file_fdw goes through the COPY code, which uses AllocateFil