> Right. The point is that I don't get those (apparently) with -O2 either,
> with my particular compiler. Hmm. Actually, I *do* get those if I make
> sure that some of the other options are set too; my quick test added -O2
> but left out some of the -w switches. OK, never mind...
btw, now that I'
Thomas Lockhart wrote:
>>>But I do override some parameters in my Makefile.custom:
>>>CFLAGS+= -g -O0 -DUSE_ASSERT_CHECKING
>>>
>>If you use -O0 then you miss most of the interesting warnings.
>>
>
>?? Not in this case. afaik -O0 suppresses most optimizations (and hence
>does not reorder instru
...
> In particular, you don't get "unused variable" and "variable may not
> have been set before being used" warnings at -O0, because the
> control-flow analysis needed to emit those warnings is not done at -O0.
Right. The point is that I don't get those (apparently) with -O2 either,
with my par
Thomas Lockhart wrote:
>>FWIW, I'm still seeing:
>>gram.y:99: warning: `set_name_needs_quotes' declared `static' but never
>>defined
>
>
> Ack. Sloppy patching. Should be fixed now...
>
> - Thomas
Yup, did the trick.
Thanks,
Joe
---(end of broadca
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> But I do override some parameters in my Makefile.custom:
> CFLAGS+= -g -O0 -DUSE_ASSERT_CHECKING
>> If you use -O0 then you miss most of the interesting warnings.
> ?? Not in this case. afaik -O0 suppresses most optimizations
In particular, you don't
> > But I do override some parameters in my Makefile.custom:
> > CFLAGS+= -g -O0 -DUSE_ASSERT_CHECKING
> If you use -O0 then you miss most of the interesting warnings.
?? Not in this case. afaik -O0 suppresses most optimizations (and hence
does not reorder instructions, which is why I use it for
Thomas Lockhart writes:
> But I do override some parameters in my Makefile.custom:
>
> CFLAGS+= -g -O0 -DUSE_ASSERT_CHECKING
If you use -O0 then you miss most of the interesting warnings.
--
Peter Eisentraut [EMAIL PROTECTED]
---(end of broadcast)---
> FWIW, I'm still seeing:
> gram.y:99: warning: `set_name_needs_quotes' declared `static' but never
> defined
Ack. Sloppy patching. Should be fixed now...
- Thomas
---(end of broadcast)---
TIP 2: you can get off all lists at once
Thomas Lockhart wrote:
>
> btw, I've updated gram.y and variable.c to suppress the reported
> warnings (which I *still* don't see here; that is very annoying).
>
FWIW, I'm still seeing:
gram.y:99: warning: `set_name_needs_quotes' declared `static' but never
defined
Joe
-
> I think it was originally needed only for the CRC code, so we put it
> there to begin with. Clearly should be in a more widely used place now.
> Do you have any opinion whether c.h or int8.h is the Right Place?
> I'm still dithering about that.
In looking at the code, istm that the versions sh
Tom Lane wrote:
> Joe Conway <[EMAIL PROTECTED]> writes:
>
>>but did *not* get the INT64CONST warning that Tom did. I'm using an
>>updated Red Hat 7.2 box.
>
>
> Probably it depends on compiler version? I'm using gcc 2.95.3.
>
could be:
[postgres@jec-linux pgsql]$ gcc -v
Reading specs from
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> I'm still not sure why the INT64CONST conflict does not show up as a
> warning on my machine, but looking at the code I'm not sure why we would
> ever have had two versions in the first place. Anyone want to take
> responsibility for consolidating it i
Joe Conway <[EMAIL PROTECTED]> writes:
> but did *not* get the INT64CONST warning that Tom did. I'm using an
> updated Red Hat 7.2 box.
Probably it depends on compiler version? I'm using gcc 2.95.3.
regards, tom lane
---(end of broadcast)---
> >> With fairly vanilla configure options, I get...
> > Please be specific on the options and platform.
> HPUX 10.20,
> ./configure --with-CXX --with-tcl --enable-cassert
Boy, how plain-vanilla. *My* configure line is all of
./configure --prefix=/home/thomas/local
But I do override some parame
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> More specifically, the *only* compiler warning I see (other than the
> usual yacc/lex symbol warnings) is that a routine in gram.y,
> set_name_needs_quotes(), is defined but not used. Don't know where that
> routine came from, and afaik I didn't accide
Thomas Lockhart wrote:
>>With fairly vanilla configure options, I get...
>
>
> Please be specific on the options and platform. I do *not* see these
> warnings here with my "fairly vanilla configure options" ;)
>
> Can't fix what I can't see, and we should track down what interactions
> are happ
Thomas Lockhart <[EMAIL PROTECTED]> writes:
>> With fairly vanilla configure options, I get...
> Please be specific on the options and platform.
HPUX 10.20,
./configure --with-CXX --with-tcl --enable-cassert
regards, tom lane
---(end of broadcast
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> btw, I've updated the regression tests and results for my platform, but
> other platforms (e.g. Solaris) will need their results files updated...
I committed a fix for HPUX's horology file, and did some extrapolation
to produce a Solaris version; some
> With fairly vanilla configure options, I get...
Please be specific on the options and platform. I do *not* see these
warnings here with my "fairly vanilla configure options" ;)
Can't fix what I can't see, and we should track down what interactions
are happening to get these variables exposed..
> > I'm seeing half a dozen gcc warnings as a result of these patches.
> Where are they?
More specifically, the *only* compiler warning I see (other than the
usual yacc/lex symbol warnings) is that a routine in gram.y,
set_name_needs_quotes(), is defined but not used. Don't know where that
routin
Thomas Lockhart <[EMAIL PROTECTED]> writes:
>> I'm seeing half a dozen gcc warnings as a result of these patches.
>> Do you want to fix 'em, or shall I?
> Where are they?
With fairly vanilla configure options, I get
make[3]: Entering directory `/home/postgres/pgsql/src/backend/parser'
gcc -O1 -
> I'm seeing half a dozen gcc warnings as a result of these patches.
> Do you want to fix 'em, or shall I?
Where are they? I haven't noticed anything in the files I have changes;
are the warnings elsewhere?
- Thomas
---(end of broadcast)-
I'm seeing half a dozen gcc warnings as a result of these patches.
Do you want to fix 'em, or shall I?
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://www.postgresql.org/users-lo
btw, I've updated the regression tests and results for my platform, but
other platforms (e.g. Solaris) will need their results files updated...
- Thomas
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http:/
I've applied patches to implement an int64-based data/time storage
scheme. I've also accumulated some other minor fixes, which result in an
initdb being required (sorry!).
Note that the *default* timestamp type is now TIMESTAMP WITHOUT TIME
ZONE. This is what we discussed previously for the trans
25 matches
Mail list logo
