Dimitri Fontaine writes:
> Tom Lane writes:
>> Right, AFAIK there is nothing in KNNGIST that would involve an on-disk
>> data change.
> But any external module relying on GiST will have to provide for the new
> function you're thinking about, right? Updating was already needed to
> cope with the
Tom Lane writes:
> Right, AFAIK there is nothing in KNNGIST that would involve an on-disk
> data change.
Nice, that matches my Royal Oak memories.
But any external module relying on GiST will have to provide for the new
function you're thinking about, right? Updating was already needed to
cope w
Robert Haas writes:
> On Wed, Dec 1, 2010 at 5:22 AM, Dimitri Fontaine
> wrote:
>> IIRC, the goal here was to be able to benefit from KNN GiST from
>> existing GiST indexes as soon as you restart the server with the new
>> code compiled in. I'm not sure it's that important in the context of
>> p
On Wed, Dec 1, 2010 at 5:22 AM, Dimitri Fontaine wrote:
> Tom Lane writes:
>> Lastly, I'm pretty un-thrilled with the way that the KNNGIST patch
>> implements the interface to the opclass-specific hook functions.
>> Seems like it would be cleaner to leave the Consistent function alone
>> and inve
Tom Lane writes:
> Lastly, I'm pretty un-thrilled with the way that the KNNGIST patch
> implements the interface to the opclass-specific hook functions.
> Seems like it would be cleaner to leave the Consistent function alone
> and invent a new, separate hook function for processing ORDER BY.
> Is
On Tue, Nov 30, 2010 at 2:50 PM, Tom Lane wrote:
> In the current KNNGIST patch, the indexable ORDER BY clauses are
> transmitted to the executor by cramming them in with the index qual
> conditions (the IndexScan plan node's indexqual list), from whence
> they become part of the ScanKey array pas
In the current KNNGIST patch, the indexable ORDER BY clauses are
transmitted to the executor by cramming them in with the index qual
conditions (the IndexScan plan node's indexqual list), from whence
they become part of the ScanKey array passed to the index AM.
Robert complained that this was an in
