Re: 9.2 branch and 9.1beta2 timing (was Re: [HACKERS] InitProcGlobal cleanup)

2011-06-02 Thread Robert Haas
On Thu, Jun 2, 2011 at 5:35 PM, Kevin Grittner wrote: > Robert Haas wrote: > >> It appears that the open items list is a bit stale: >> >> http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items >> >> The first item listed there is, I believe, fixed. > > That was "SSI HOT chain traversal issue"

Re: 9.2 branch and 9.1beta2 timing (was Re: [HACKERS] InitProcGlobal cleanup)

2011-06-02 Thread Kevin Grittner
Robert Haas wrote: > It appears that the open items list is a bit stale: > > http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items > > The first item listed there is, I believe, fixed. That was "SSI HOT chain traversal issue" -- which was fixed. I just moved it to "Resolved Issues". >

Re: 9.2 branch and 9.1beta2 timing (was Re: [HACKERS] InitProcGlobal cleanup)

2011-06-02 Thread Robert Haas
On Thu, Jun 2, 2011 at 4:42 PM, Tom Lane wrote: > Robert Haas writes: >> I'll commit this to 9.2 after we branch.  (When are we doing that, BTW?) > > Sometime in the next two weeks I guess ;-).  At the PGCon meeting we > said 1 June, but seeing that we still have a couple of open beta2 issues > I

9.2 branch and 9.1beta2 timing (was Re: [HACKERS] InitProcGlobal cleanup)

2011-06-02 Thread Tom Lane
Robert Haas writes: > I'll commit this to 9.2 after we branch. (When are we doing that, BTW?) Sometime in the next two weeks I guess ;-). At the PGCon meeting we said 1 June, but seeing that we still have a couple of open beta2 issues I'm not in a hurry. I think a reasonable plan would be to f

Re: [HACKERS] InitProcGlobal cleanup

2011-06-02 Thread Tom Lane
Robert Haas writes: > OK, here's a version with more comments. Looks OK to me, assuming you've checked that the right number of PGPROCs are getting created (in particular the AV launcher is no longer accounted for explicitly). regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] InitProcGlobal cleanup

2011-06-02 Thread Robert Haas
On Thu, Jun 2, 2011 at 3:13 PM, Tom Lane wrote: > Robert Haas writes: >> OK, here's a version with more comments. > > Looks OK to me, assuming you've checked that the right number of PGPROCs > are getting created (in particular the AV launcher is no longer > accounted for explicitly). That shoul

Re: [HACKERS] InitProcGlobal cleanup

2011-06-02 Thread Robert Haas
On Thu, Jun 2, 2011 at 1:53 PM, Tom Lane wrote: > Robert Haas writes: >> While working on my patch to reduce the overhead of frequent table >> locks, I had cause to monkey with InitProcGlobal() and noticed that >> it's sort of a mess.  For reasons that are not clear to me, it >> allocates one of

Re: [HACKERS] InitProcGlobal cleanup

2011-06-02 Thread Tom Lane
Robert Haas writes: > While working on my patch to reduce the overhead of frequent table > locks, I had cause to monkey with InitProcGlobal() and noticed that > it's sort of a mess. For reasons that are not clear to me, it > allocates one of the three PGPROC arrays using ShemInitStruct() and > th

[HACKERS] InitProcGlobal cleanup

2011-06-02 Thread Robert Haas
While working on my patch to reduce the overhead of frequent table locks, I had cause to monkey with InitProcGlobal() and noticed that it's sort of a mess. For reasons that are not clear to me, it allocates one of the three PGPROC arrays using ShemInitStruct() and the other two using ShmemAlloc().