On 3/17/17 3:58 AM, Kyotaro HORIGUCHI wrote:
> At Mon, 13 Mar 2017 10:42:05 -0400, David Steele wrote
> in <1e8297fd-f7f2-feab-848d-5121e45c8...@pgmasters.net>
>> It has been a while since this thread has received any comments or a new
>> patch. The general consensus seems to be that this featur
At Mon, 13 Mar 2017 10:42:05 -0400, David Steele wrote in
<1e8297fd-f7f2-feab-848d-5121e45c8...@pgmasters.net>
> It has been a while since this thread has received any comments or a new
> patch. The general consensus seems to be that this feature is too large
> a rewrite of tab completion consid
Hello,
On 3/1/17 9:38 PM, Kyotaro HORIGUCHI wrote:
> At Tue, 28 Feb 2017 10:39:01 -0500, Stephen Frost wrote
> in <20170228153901.gh9...@tamriel.snowman.net>
>> * David Fetter (da...@fetter.org) wrote:
>>> On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:
* Kyotaro HORIGUCHI (
Hello,
At Tue, 28 Feb 2017 10:39:01 -0500, Stephen Frost wrote in
<20170228153901.gh9...@tamriel.snowman.net>
> * David Fetter (da...@fetter.org) wrote:
> > On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:
> > > * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote:
> > > > I
* David Fetter (da...@fetter.org) wrote:
> On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:
> > * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote:
> > > I suppose it is for suggesting what kind of word should come
> > > there, or avoiding silence for a tab. Or for symmetry w
On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:
> * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote:
> > I suppose it is for suggesting what kind of word should come
> > there, or avoiding silence for a tab. Or for symmetry with other
> > types of manipulation, like DROP. A
* Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote:
> I suppose it is for suggesting what kind of word should come
> there, or avoiding silence for a tab. Or for symmetry with other
> types of manipulation, like DROP. Another possibility is creating
> multiple objects with similar names, s
At Mon, 27 Feb 2017 10:43:39 +0900, Michael Paquier
wrote in
> On Mon, Feb 27, 2017 at 10:20 AM, Tom Lane wrote:
> > Michael Paquier writes:
> >> On Mon, Feb 27, 2017 at 10:12 AM, Tom Lane wrote:
> >>> BTW ... can anyone explain to me the reason why we offer to complete
> >>> CREATE OBJECT wi
On Mon, Feb 27, 2017 at 10:20 AM, Tom Lane wrote:
> Michael Paquier writes:
>> On Mon, Feb 27, 2017 at 10:12 AM, Tom Lane wrote:
>>> BTW ... can anyone explain to me the reason why we offer to complete
>>> CREATE OBJECT with the names of existing objects of that kind?
>
>> Isn't that to facilita
Michael Paquier writes:
> On Mon, Feb 27, 2017 at 10:12 AM, Tom Lane wrote:
>> BTW ... can anyone explain to me the reason why we offer to complete
>> CREATE OBJECT with the names of existing objects of that kind?
> Isn't that to facilitate commands appended after CREATE SCHEMA? Say
> table foo
On Mon, Feb 27, 2017 at 10:12 AM, Tom Lane wrote:
> Michael Paquier writes:
>> On Mon, Feb 27, 2017 at 5:21 AM, Tom Lane wrote:
>>> So I'd be a whole lot happier if it didn't do that. Can we really not
>>> add the desired features in a more localized fashion?
>
>> As "if not exists" is defined
Michael Paquier writes:
> On Mon, Feb 27, 2017 at 5:21 AM, Tom Lane wrote:
>> So I'd be a whole lot happier if it didn't do that. Can we really not
>> add the desired features in a more localized fashion?
> As "if not exists" is defined after the object type if would not be
> that complicated t
On Mon, Feb 27, 2017 at 5:21 AM, Tom Lane wrote:
> Robert Haas writes:
>> Yeah, maybe, but we'd need a committer to take more of an interest in
>> this patch series. Personally, I'm wondering why we need a series of
>> 19 patches to add tab completion support for IF NOT EXISTS. The
>> feature w
Robert Haas writes:
> Yeah, maybe, but we'd need a committer to take more of an interest in
> this patch series. Personally, I'm wondering why we need a series of
> 19 patches to add tab completion support for IF NOT EXISTS. The
> feature which is the subject of this thread arrives in patch 0017
2017-02-26 19:43 GMT+01:00 Robert Haas :
> On Wed, Feb 22, 2017 at 12:38 AM, Pavel Stehule
> wrote:
> > Now first patch is broken :(
> >
> > It is pretty sensitive to any changes. Isn't possible to commit first
> four
> > patches first and separately maybe out of commitfest window?
>
> Yeah, mayb
On Wed, Feb 22, 2017 at 12:38 AM, Pavel Stehule wrote:
> Now first patch is broken :(
>
> It is pretty sensitive to any changes. Isn't possible to commit first four
> patches first and separately maybe out of commitfest window?
Yeah, maybe, but we'd need a committer to take more of an interest in
2017-02-14 11:51 GMT+01:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Thank you for the comment.
>
> At Mon, 6 Feb 2017 17:10:43 +0100, Pavel Stehule
> wrote in mail.gmail.com>
> > > 0001-Refactoring-tab-complete-to-make-psql_completion-cod.patch
> > > - Just a refactoring of psql
Thank you for the comment.
At Mon, 6 Feb 2017 17:10:43 +0100, Pavel Stehule
wrote in
> > 0001-Refactoring-tab-complete-to-make-psql_completion-cod.patch
> > - Just a refactoring of psql_completion
> >
> > 0002-Make-keywords-case-follow-to-input.patch
> > - The letter case of additional sugg
Hi
2017-02-03 9:17 GMT+01:00 Kyotaro HORIGUCHI :
> Hello. This is the new version of this patch.
>
> - Rebased to the current master (555494d)
> PUBLICATION/SUBSCRIPTION stuff conflicted.
>
> - Fix a bug of CREATE INDEX(0012-Simplify-completion-for-CREATE-INDEX.
> patch).
> CREATE INDEX ON no
Hello. This is the new version of this patch.
- Rebased to the current master (555494d)
PUBLICATION/SUBSCRIPTION stuff conflicted.
- Fix a bug of CREATE INDEX(0012-Simplify-completion-for-CREATE-INDEX.patch).
CREATE INDEX ON no longer gets a suggestion of "ON".
- Added logging feature (0018
2017-02-01 9:37 GMT+01:00 Kyotaro HORIGUCHI :
> Thank you for reviewing.
>
> At Tue, 31 Jan 2017 11:28:17 +0100, Pavel Stehule
> wrote in gmail.com>
> > I am doing a review of this set of patches:
> >
> > 1. There are no problem with patching, compiling - all regress tests
> passed
> Oh! My ne
Thank you for reviewing.
At Tue, 31 Jan 2017 11:28:17 +0100, Pavel Stehule
wrote in
> I am doing a review of this set of patches:
>
> 1. There are no problem with patching, compiling - all regress tests passed
Oh! My new check script made from Michael's suggestion finds one
trailing space in
2017-01-31 11:10 GMT+01:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> At Tue, 31 Jan 2017 15:07:55 +0900, Michael Paquier <
> michael.paqu...@gmail.com> wrote in 8v0X6A4gKQb2Uc=mc+...@mail.gmail.com>
> > On Tue, Jan 31, 2017 at 2:58 PM, Pavel Stehule
> wrote:
> > > I found a error -
At Tue, 31 Jan 2017 15:07:55 +0900, Michael Paquier
wrote in
> On Tue, Jan 31, 2017 at 2:58 PM, Pavel Stehule
> wrote:
> > I found a error - I sent mail only to author 2016-12-31 :( - It is my
> > mistake. I am sorry
>
> Ah... Thanks for the update. No problem.
Ouch. Sorry for missing you co
On Tue, Jan 31, 2017 at 2:58 PM, Pavel Stehule wrote:
> I found a error - I sent mail only to author 2016-12-31 :( - It is my
> mistake. I am sorry
Ah... Thanks for the update. No problem.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
2017-01-31 6:56 GMT+01:00 Michael Paquier :
> On Tue, Jan 31, 2017 at 2:53 PM, Pavel Stehule
> wrote:
> > I tested new set of these patches and I found some regressions there -
> > mentioned in my last mail.
> >
> > Maybe I miss new update, bit I don't know about it.
>
> The last update I am awar
>
>
>
> 2017-01-31 6:51 GMT+01:00 Michael Paquier :
>
>>
>>
>> The current patch status was "waiting on author", but that's incorrect
>> as a new series of this patch has been sent. Please be careful with
>> the status of the CF app! I am moving it to next CF with "needs
>> review". Gerdan Santos h
On Tue, Jan 31, 2017 at 2:53 PM, Pavel Stehule wrote:
> I tested new set of these patches and I found some regressions there -
> mentioned in my last mail.
>
> Maybe I miss new update, bit I don't know about it.
The last update I am aware of is that saying: "lot of patches. I hope
I look on these
2017-01-31 6:51 GMT+01:00 Michael Paquier :
> On Tue, Dec 27, 2016 at 12:23 PM, Kyotaro HORIGUCHI
> wrote:
> > Hello,
> >
> > At Mon, 26 Dec 2016 14:24:33 +0100, Pavel Stehule <
> pavel.steh...@gmail.com> wrote in yNSvn8Vvf+m=DBy3ps=y0_3...@mail.gmail.com>
> > pavel.stehule> 2016-12-26 9:40 GMT+
On Tue, Dec 27, 2016 at 12:23 PM, Kyotaro HORIGUCHI
wrote:
> Hello,
>
> At Mon, 26 Dec 2016 14:24:33 +0100, Pavel Stehule
> wrote in
> pavel.stehule> 2016-12-26 9:40 GMT+01:00 Kyotaro HORIGUCHI
> > >:
>>
>> > > Thanks for reviewing but I ran out of time for this CF..
>> > >
>> > > I'm going to
Hello,
At Mon, 26 Dec 2016 14:24:33 +0100, Pavel Stehule
wrote in
pavel.stehule> 2016-12-26 9:40 GMT+01:00 Kyotaro HORIGUCHI
>:
>
> > > Thanks for reviewing but I ran out of time for this CF..
> > >
> > > I'm going to move this to the next CF.
> >
> > I splitted the patch into small pieces.
2016-12-26 9:40 GMT+01:00 Kyotaro HORIGUCHI :
> > Thanks for reviewing but I ran out of time for this CF..
> >
> > I'm going to move this to the next CF.
>
> I splitted the patch into small pieces. f3fd531 conflicted to
> this so rebased onto the current master HEAD.
>
> 0001 is psql_completion re
Hello,
At Fri, 25 Nov 2016 06:51:43 +0100, Pavel Stehule
wrote in
> I am sure about benefit of all patches - but it is lot of changes in one
> moment, and it is not necessary in this moment.
>
> patches 0004 and 0005 does some bigger mental changes, and the work can be
> separated.
The patche
2016-11-25 2:24 GMT+01:00 Kyotaro HORIGUCHI :
> Hello,
>
> Thank you for looking this long-and-bothersome patch.
>
>
> At Wed, 23 Nov 2016 07:12:00 +0100, Pavel Stehule
> wrote in vd9fgpsgv...@mail.gmail.com>
> > Hi
> >
> > 2016-11-15 12:26 GMT+01:00 Kyotaro HORIGUCHI <
> horiguchi.kyot...@lab.n
Hello,
Thank you for looking this long-and-bothersome patch.
At Wed, 23 Nov 2016 07:12:00 +0100, Pavel Stehule
wrote in
> Hi
>
> 2016-11-15 12:26 GMT+01:00 Kyotaro HORIGUCHI jp>:
>
> > Hello, I rebased this patch on the current master.
> >
> > At Mon, 31 Oct 2016 10:15:48 +0900 (Tokyo Stan
Hi
2016-11-15 12:26 GMT+01:00 Kyotaro HORIGUCHI :
> Hello, I rebased this patch on the current master.
>
> At Mon, 31 Oct 2016 10:15:48 +0900 (Tokyo Standard Time), Kyotaro
> HORIGUCHI wrote in <
> 20161031.101548.162143279.horiguchi.kyot...@lab.ntt.co.jp>
> > Anyway, I fixed space issues and ad
At Thu, 29 Sep 2016 16:16:00 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20160929.161600.224338668.horiguchi.kyot...@lab.ntt.co.jp>
> That looks better. I'll change the API as the following.
>
> COMPLETE_WITH_QUERY(query);
> COMPLETE_WITH_QUERY_KW(query, kwlist);
> COMPLETE_WITH_SC
Hello,
At Tue, 20 Sep 2016 16:50:29 +0900, Michael Paquier
wrote in
> On Mon, Sep 19, 2016 at 6:11 PM, Pavel Stehule
> wrote:
> > I am thinking so commit's description should be inside README
>
> Horiguchi-san, your patch has some whitespace issues, you may want to
> get a run with git diff
Thank you for reviewing!
At Mon, 19 Sep 2016 11:11:03 +0200, Pavel Stehule
wrote in
> >> 2. Make keywords' case follow to input
> >>
> >> Allow the keywords suggested along with databse objects to
> >> follow the input letter case. The core part of this patch is a
> >> new function additi
Hello,
At Wed, 28 Sep 2016 12:49:25 -0400, Robert Haas wrote
in
> This patch hasn't been updated in over a week and we're just about out
> of time for this CommitFest, so I've marked it "Returned with
> Feedback" for now. If it gets updated, it can be resubmitted for the
> next CommitFest.
Th
On Tue, Sep 20, 2016 at 3:50 AM, Michael Paquier
wrote:
> On Mon, Sep 19, 2016 at 6:11 PM, Pavel Stehule
> wrote:
>> I am thinking so commit's description should be inside README
>
> Horiguchi-san, your patch has some whitespace issues, you may want to
> get a run with git diff --check. Here are
On Mon, Sep 19, 2016 at 6:11 PM, Pavel Stehule wrote:
> I am thinking so commit's description should be inside README
Horiguchi-san, your patch has some whitespace issues, you may want to
get a run with git diff --check. Here are some things I have spotted:
src/bin/psql/tab-complete.c:1074: trail
Hi
> Pavel
>
>
>> 2. Make keywords' case follow to input
>>
>> Allow the keywords suggested along with databse objects to
>> follow the input letter case. The core part of this patch is a
>> new function additional_kw_query(), which dynamically generates
>> additional query string with s
2016-09-16 10:31 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hello, this is the new version.
>
> At Tue, 13 Sep 2016 10:50:13 +0900 (Tokyo Standard Time), Kyotaro
> HORIGUCHI wrote in <
> 20160913.105013.65452566.horiguchi.kyot...@lab.ntt.co.jp>
> > > > This patch consists o
Hi
2016-09-16 10:31 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hello, this is the new version.
>
> At Tue, 13 Sep 2016 10:50:13 +0900 (Tokyo Standard Time), Kyotaro
> HORIGUCHI wrote in <
> 20160913.105013.65452566.horiguchi.kyot...@lab.ntt.co.jp>
> > > > This patch consis
Hello,
At Sat, 10 Sep 2016 07:40:16 +0200, Pavel Stehule
wrote in
> 2016-09-06 15:00 GMT+02:00 Kyotaro HORIGUCHI <
> horiguchi.kyot...@lab.ntt.co.jp>:
>
> > Hello, this is the new version of this patch. Rebased on the
> > current master.
..
> > This patch consists of the following files. Since
2016-09-06 15:00 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hello, this is the new version of this patch. Rebased on the
> current master.
>
> At Tue, 06 Sep 2016 13:06:51 +0900 (Tokyo Standard Time), Kyotaro
> HORIGUCHI wrote in <
> 20160906.130651.171572544.horiguchi.kyot
Hello,
At Sun, 4 Sep 2016 12:54:57 +0200, Pavel Stehule
wrote in
> This patch needs rebase.
Thank you. I'll rebase the following patch and repost as soon as
possible.
https://www.postgresql.org/message-id/20160407.211917.147996130.horiguchi.kyot...@lab.ntt.co.jp
regards,
--
Kyotaro Horiguc
Hi
This patch needs rebase.
Regards
Pavel
On Thu, Apr 7, 2016 at 8:19 AM, Kyotaro HORIGUCHI
wrote:
> Thank you for looking this and for the comment.
>
> Since the end of this CF is quite soon and this seems in
> uncommittable state, feel free to move this to the next CF if any
> other patch with more priority.
Moved. It's appropriate to
Pavel Stehule writes:
> 1. We want this patch - it increase a functionality of autocomplete
TBH, I do not think that is an agreed-to statement. I concur with
Peter's comments upthread questioning how much use-case there is for
interactive completion of IF (NOT) EXISTS. If it were a small and
un
Hi
2016-04-04 7:58 GMT+02:00 Kyotaro HORIGUCHI :
> Thank you for testing. That is a silly mistake, sorry.
>
> The attached is the fixed version.
>
> # Can I add a suffix to format-patche's output files?
>
> At Sat, 2 Apr 2016 07:18:32 +0200, Pavel Stehule
> wrote in <
> cafj8pradf3rmq3y33aer1c7w
Thank you for testing. That is a silly mistake, sorry.
The attached is the fixed version.
# Can I add a suffix to format-patche's output files?
At Sat, 2 Apr 2016 07:18:32 +0200, Pavel Stehule
wrote in
> >> Finally I settled it by replacing comma expression with logical
> >> OR or AND express
2016-04-02 7:16 GMT+02:00 Pavel Stehule :
> Hi
>
> 2016-04-01 10:21 GMT+02:00 Kyotaro HORIGUCHI <
> horiguchi.kyot...@lab.ntt.co.jp>:
>
>> Hello, sorry for being a bit late.
>> The attatched are the new version of the patch.. set.
>>
>> 1. 0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql.patc
Hi
2016-04-01 10:21 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hello, sorry for being a bit late.
> The attatched are the new version of the patch.. set.
>
> 1. 0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql.patch
>
> Adds IF (NOT) EXISTS completion. It doesn't fix
Hello, sorry for being a bit late.
The attatched are the new version of the patch.. set.
1. 0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql.patch
Adds IF (NOT) EXISTS completion. It doesn't fix the issue that
the case of additional keywords don't follow the input.
2. 0002-Make-added-keyw
2016-04-01 4:52 GMT+02:00 Kyotaro HORIGUCHI :
> At Thu, 31 Mar 2016 11:22:20 +0200, Pavel Stehule
> wrote in <
> cafj8prd7vadunoiapb8exwc+c5ccis-rj2dphvzcwzkgxjb...@mail.gmail.com>
> > 2016-03-30 10:34 GMT+02:00 Kyotaro HORIGUCHI <
> > horiguchi.kyot...@lab.ntt.co.jp>:
> >
> > > Hi,
> > >
> > > A
At Thu, 31 Mar 2016 11:22:20 +0200, Pavel Stehule
wrote in
> 2016-03-30 10:34 GMT+02:00 Kyotaro HORIGUCHI <
> horiguchi.kyot...@lab.ntt.co.jp>:
>
> > Hi,
> >
> > At Wed, 30 Mar 2016 09:23:49 +0200, Pavel Stehule
> > wrote in <
> > cafj8prbvka6ng4jwz2qmro7inudfjws5w0+demvgzznuf-h...@mail.gmail.
2016-03-30 10:34 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hi,
>
> At Wed, 30 Mar 2016 09:23:49 +0200, Pavel Stehule
> wrote in <
> cafj8prbvka6ng4jwz2qmro7inudfjws5w0+demvgzznuf-h...@mail.gmail.com>
> > Hi
> >
> > ...
> > >> =# alter table if
> > >> =# alter table if exis
Hi,
At Wed, 30 Mar 2016 09:23:49 +0200, Pavel Stehule
wrote in
> Hi
>
> ...
> >> =# alter table if
> >> =# alter table if exists
> >> ==
> >> =# alter table I
> >> =# alter table IF EXISTS// "information_schema" doesn't match.
> >>
> >> Since this is another problem from IF (NOT) EXIST
Hi
...
>> =# alter table if
>> =# alter table if exists
>> ==
>> =# alter table I
>> =# alter table IF EXISTS// "information_schema" doesn't match.
>>
>> Since this is another problem from IF (NOT) EXISTS, this is
>> in separate form.
>>
>> What do you think about this?
>>
>
> +1
>
The ne
No one should care of this but to make shure..
At Tue, 29 Mar 2016 20:12:03 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20160329.201203.78219296.horiguchi.kyot...@lab.ntt.co.jp>
> By the way, memory blocks that readline sees are freed by it but
> blocks allocated by the additional
2016-03-30 5:43 GMT+02:00 Kyotaro HORIGUCHI :
> Hello,
>
> At Tue, 29 Mar 2016 13:12:06 +0200, Pavel Stehule
> wrote in kpzfw1+af_lutm...@mail.gmail.com>
> > 2016-03-29 12:08 GMT+02:00 Kyotaro HORIGUCHI <
> > > > > As mentioned before, upper-lower problem is an existing
> > > > > issue. The case
Hello,
At Tue, 29 Mar 2016 13:12:06 +0200, Pavel Stehule
wrote in
> 2016-03-29 12:08 GMT+02:00 Kyotaro HORIGUCHI <
> > > > As mentioned before, upper-lower problem is an existing
> > > > issue. The case of the words in a query result list cannot be
> > > > edited since it may contain words that
2016-03-29 12:08 GMT+02:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:
> Hi, Pavel.
>
> At Tue, 29 Mar 2016 09:59:01 +0200, Pavel Stehule
> wrote in <
> cafj8prdepggymz2axgtl33pud7x+xieao++wa+v9nqpqiyd...@mail.gmail.com>
> > > > On 3/18/16 3:22 AM, Pavel Stehule wrote:
> > > >
> > > > >
Hi, thank you for the suggestion.
At Tue, 29 Mar 2016 12:54:01 +0300, Artur Zakirov
wrote in <56fa50b9.7000...@postgrespro.ru>
> On 29.03.2016 10:59, Pavel Stehule wrote:
> > > > I am looking this patch. It looks well, but this feature doesn't
> > > > respect upper or lower chars
Hi, Pavel.
At Tue, 29 Mar 2016 09:59:01 +0200, Pavel Stehule
wrote in
> > > On 3/18/16 3:22 AM, Pavel Stehule wrote:
> > >
> > > > I am looking this patch. It looks well, but this feature doesn't
> > > > respect upper or lower chars. It enforce upper chars. This is not
> > > > consi
On 29.03.2016 10:59, Pavel Stehule wrote:
Hi
2016-03-29 8:43 GMT+02:00 Kyotaro HORIGUCHI
mailto:horiguchi.kyot...@lab.ntt.co.jp>>:
Thank you Pavel, David.
Thank you for pointing syntaxes to be addressed. Most of the are
addressed in the attached patch.
At Tue, 22 Mar 2016 12:
Hi
2016-03-29 8:43 GMT+02:00 Kyotaro HORIGUCHI :
> Thank you Pavel, David.
>
> Thank you for pointing syntaxes to be addressed. Most of the are
> addressed in the attached patch.
>
>
> At Tue, 22 Mar 2016 12:57:27 -0400, David Steele
> wrote in <56f17977.8040...@pgmasters.net>
> > Hi Kyotaro,
>
Thank you Pavel, David.
Thank you for pointing syntaxes to be addressed. Most of the are
addressed in the attached patch.
At Tue, 22 Mar 2016 12:57:27 -0400, David Steele wrote in
<56f17977.8040...@pgmasters.net>
> Hi Kyotaro,
>
> On 3/18/16 3:22 AM, Pavel Stehule wrote:
>
> > I am looki
Hi Kyotaro,
On 3/18/16 3:22 AM, Pavel Stehule wrote:
> I am looking this patch. It looks well, but this feature doesn't
> respect upper or lower chars. It enforce upper chars. This is not
> consistent with any other autocomplete.
>
>
> I checked it against sql help and these stateme
On Wed, Mar 16, 2016 at 2:42 AM, Robert Haas wrote:
> On Fri, Feb 26, 2016 at 2:37 AM, Kyotaro HORIGUCHI
> wrote:
>> Hello, this is the new version of this patch.
>
> The CommitFest entry for this patch is messed up. It shows no author,
> even though I'm pretty sure that a patch has to have one
Hi
2016-03-17 21:02 GMT+01:00 Pavel Stehule :
> Hi
>
>
> I am looking this patch. It looks well, but this feature doesn't respect
> upper or lower chars. It enforce upper chars. This is not consistent with
> any other autocomplete.
>
I checked it against sql help and these statements doesn't wor
Hi
2016-03-16 5:01 GMT+01:00 Kyotaro HORIGUCHI :
> Hello,
>
> # It seems that I have been forgotten in the recepient list..
>
> At Tue, 15 Mar 2016 22:09:59 -0400, Peter Eisentraut
> wrote in <56e8c077.2000...@gmx.net>
> > On 2/5/16 3:09 AM, Kyotaro HORIGUCHI wrote:
> > > I considered how to mak
Mmm. Have I broken the entry?
At Tue, 15 Mar 2016 13:55:24 -0400, David Steele wrote in
<56e84c8c.7060...@pgmasters.net>
> On 3/15/16 1:42 PM, Robert Haas wrote:
> > On Fri, Feb 26, 2016 at 2:37 AM, Kyotaro HORIGUCHI
> > wrote:
> >> Hello, this is the new version of this patch.
> >
> > The Com
Hello,
# It seems that I have been forgotten in the recepient list..
At Tue, 15 Mar 2016 22:09:59 -0400, Peter Eisentraut wrote in
<56e8c077.2000...@gmx.net>
> On 2/5/16 3:09 AM, Kyotaro HORIGUCHI wrote:
> > I considered how to make tab-completion robust for syntactical
> > noises, in other wor
On 2/5/16 3:09 AM, Kyotaro HORIGUCHI wrote:
> I considered how to make tab-completion robust for syntactical
> noises, in other words, optional words in syntax. Typically "IF
> (NOT) EXISTS", UNIQUE and TEMPORARY are words that don't affect
> further completion.
To repeat the question I raised in
On 3/15/16 1:42 PM, Robert Haas wrote:
> On Fri, Feb 26, 2016 at 2:37 AM, Kyotaro HORIGUCHI
> wrote:
>> Hello, this is the new version of this patch.
>
> The CommitFest entry for this patch is messed up. It shows no author,
> even though I'm pretty sure that a patch has to have one by
> definiti
On Fri, Feb 26, 2016 at 2:37 AM, Kyotaro HORIGUCHI
wrote:
> Hello, this is the new version of this patch.
The CommitFest entry for this patch is messed up. It shows no author,
even though I'm pretty sure that a patch has to have one by
definition.
https://commitfest.postgresql.org/9/518/
Also,
Hello, this is the new version of this patch.
At Fri, 26 Feb 2016 13:17:26 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20160226.131726.54224488.horiguchi.kyot...@lab.ntt.co.jp>
> Hello, thank you for the comments.
>
> At Mon, 15 Feb 2016 15:43:57 +0300, Artur Zakirov
> wrote in
Hello, thank you for the comments.
At Mon, 15 Feb 2016 15:43:57 +0300, Artur Zakirov
wrote in <56c1c80d.7020...@postgrespro.ru>
> On 05.02.2016 11:09, Kyotaro HORIGUCHI wrote:
> > Hello,
> >
> > I considered how to make tab-completion robust for syntactical
> > noises, in other words, optional w
On 05.02.2016 11:09, Kyotaro HORIGUCHI wrote:
Hello,
I considered how to make tab-completion robust for syntactical
noises, in other words, optional words in syntax. Typically "IF
(NOT) EXISTS", UNIQUE and TEMPORARY are words that don't affect
further completion. However, the current delimit-mat
Hello,
I considered how to make tab-completion robust for syntactical
noises, in other words, optional words in syntax. Typically "IF
(NOT) EXISTS", UNIQUE and TEMPORARY are words that don't affect
further completion. However, the current delimit-matching
mechanism is not so capable (or is complex
83 matches
Mail list logo
