Hi 2016-03-29 8:43 GMT+02:00 Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp >:
> Thank you Pavel, David. > > Thank you for pointing syntaxes to be addressed. Most of the are > addressed in the attached patch. > > > At Tue, 22 Mar 2016 12:57:27 -0400, David Steele <da...@pgmasters.net> > wrote in <56f17977.8040...@pgmasters.net> > > Hi Kyotaro, > > > > On 3/18/16 3:22 AM, Pavel Stehule wrote: > > > > > I am looking this patch. It looks well, but this feature doesn't > > > respect upper or lower chars. It enforce upper chars. This is not > > > consistent with any other autocomplete. > > As mentioned before, upper-lower problem is an existing > issue. The case of the words in a query result list cannot be > edited since it may contain words that should not be changed, > such as relation names. So we can address it only before issueing > a query but I haven't found simple way to do it. > This is unpleasant. I am sorry. I had very uncomfortable feeling from this behave. I am thinking so it should be solvable - you have to convert only keyword IF EXISTS or IF NOT EXISTS. Maybe there are not trivial solution, but this should be fixed. > > > > I checked it against sql help and these statements doesn't work > > Thank you very much. > > > > alter foreign table hhhh drop column > > > drop cast > > > drop operator > > > drop transform -- missing autocomplete completely > > These are not done. Each of them has issues to be addressed > before adding completion of IF EXISTS. > > > > alter text search configuration jjj drop mapping > > > alter type hhh drop attribute > > > drop extension > > Done. > > > > drop text search > > I don't see the syntax "drop text search [if exists]". drop text > search (configuration|dictionary|parser|template) are already > addressed. > ok, probably my mistake. I am sorry. > > > > drop user mapping > > "drop user" was not completed with "mapping". I added it then > addressed this. (This might be another issue.) > > > > alter table jjj add column > > Done if it is mentioning DROP COLUMN. But new two macros > HeadMatches6 and 7 are introduced together. > > > > create temp sequence > > > create sequence > > DROP SEQUENCE is already completed with IF EXISTS. CREATE [TEMP] > SEQUENCE with IF NOT EXISTS is added. > > > Do you have an idea of when you will have a new patch ready? > > Sorry to to have been late. The attached is the revised version. > I'll check it today. Regards Pavel > > regards, > > -- > Kyotaro Horiguchi > NTT Open Source Software Center >
