Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-21 Thread Hannu Krosing
On Thu, 2011-07-21 at 00:21 +0200, Florian Pflug wrote: > There's a small additional concern, though, which is that there's an > XPath 2.0 spec out there, and it modifies the type system and data model > rather heavily. So before we go adding functions, it'd probably be wise > to check that we're n

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-20 Thread Tom Lane
Florian Pflug writes: > There's a small additional concern, though, which is that there's an > XPath 2.0 spec out there, and it modifies the type system and data model > rather heavily. So before we go adding functions, it'd probably be wise > to check that we're not painting ourselves into a corn

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-20 Thread Florian Pflug
On Jul20, 2011, at 23:35 , Tom Lane wrote: > I find your argument against XPATH_STRING() a bit unconvincing. > The use case for that is not where you are trying to evaluate an > unknown, arbitrary XPath expression; it's where you are evaluating an > expression that you *know* returns string (ie, it

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-20 Thread Tom Lane
[ having now read the relevant threads a bit more carefully ... ] Florian Pflug writes: > On Jul18, 2011, at 22:19 , Tom Lane wrote: >> Yeah, it's not clear to me either which of those are still reasonable >> candidates for committing as-is. > There are actually three XML-related patches from me

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-19 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar jul 19 12:09:24 -0400 2011: > Robert Haas writes: > > On Mon, Jul 18, 2011 at 4:19 PM, Tom Lane wrote: > >> If you mean the business about allowing GUCs in postgresql.conf to be > >> applied even if there are semantic errors elsewhere, I'm just as happy > >

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-19 Thread Tom Lane
Robert Haas writes: > On Mon, Jul 18, 2011 at 4:19 PM, Tom Lane wrote: >> If you mean the business about allowing GUCs in postgresql.conf to be >> applied even if there are semantic errors elsewhere, I'm just as happy >> to let Alexey or Florian have a go at it first, if they want.  The real >> q

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-19 Thread Yeb Havinga
On 2011-07-18 21:59, Robert Haas wrote: There are only two patches left and I think we really ought to try to take a crack at doing something with them. Yeb is working on the userspace access vector cache patch, which I think is going drag on longer than we want keep the CommitFest open, but I'm

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Jeff Davis
On Mon, 2011-07-18 at 15:59 -0400, Robert Haas wrote: > On a pgbench run with 8 > clients on a 32-core machine, I see about a 2% speedup from that patch > on pgbench -S, and it grows to 8% at 32 clients. At 80 clients (but > still just a 32-core box), the results bounce around more, but taking > t

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Florian Pflug
On Jul18, 2011, at 22:19 , Tom Lane wrote: >> and an >> error-reporting patch that Tom weighed in on over the weekend. This >> last suffers from the issue that it's not quite clear whether Tom is >> going to do the work or whether he's expecting the submitter to do it. > > If you mean the busines

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Florian Pflug
On Jul18, 2011, at 22:19 , Tom Lane wrote: > Robert Haas writes: >> We're down to three patches that fall into this category: two XML >> patches by Florian, which have been somewhat derailed by an argument >> about whether values of type xml should, in fact, be required to be >> valid xml (I think

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Robert Haas
On Mon, Jul 18, 2011 at 4:19 PM, Tom Lane wrote: >> and an >> error-reporting patch that Tom weighed in on over the weekend.  This >> last suffers from the issue that it's not quite clear whether Tom is >> going to do the work or whether he's expecting the submitter to do it. > > If you mean the b

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Josh Berkus
Robert, >> * Collect frequency statistics and selectivity estimation for arrays >> * Allow multiple Postgres clusters running on the same machine to >> distinguish themselves in the event log >> * lazy vxid locks > > I'm not clear on your criteria for moving these patches, as they seem > to be in

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Josh Berkus
Simon, >> * Cascade Replication > > Sorry, too busy reviewing to take note of this. I expect to commit > when its tested and ready. So, would that be this commitfest, or next commitfest? -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Tom Lane
Robert Haas writes: > We're down to three patches that fall into this category: two XML > patches by Florian, which have been somewhat derailed by an argument > about whether values of type xml should, in fact, be required to be > valid xml (I think you know my vote on this one...); Yeah, it's no

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Simon Riggs
On Fri, Jul 15, 2011 at 10:05 PM, Josh Berkus wrote: > PATCHES WHICH HAVE BEEN UPDATED AND NEED FURTHER REVIEW: > > * Cascade Replication Sorry, too busy reviewing to take note of this. I expect to commit when its tested and ready. --  Simon Riggs   http://www.2ndQuadrant.com/

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-18 Thread Robert Haas
On Fri, Jul 15, 2011 at 5:05 PM, Josh Berkus wrote: > As you can probably tell, we are not ready to end the commitfest.  (I > think Robert gave me this CF to show why even talking about a one-week > mini-fest is a fantasy.  If so, successful.). Heh, heh. Well, it wasn't that premeditated, but I'

Re: [HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-16 Thread Florian Pflug
On Jul15, 2011, at 23:05 , Josh Berkus wrote: > * Bugfix for XPATH() if expression returns a scalar value Well, Peter Eisentraut seemed to disagree with my approach initially, and seemed to prefer a separate function for XPATH expressions which return a scalar value. http://archives.postgresql.

[HACKERS] Commitfest Status: Sudden Death Overtime

2011-07-15 Thread Josh Berkus
All, As you can probably tell, we are not ready to end the commitfest. (I think Robert gave me this CF to show why even talking about a one-week mini-fest is a fantasy. If so, successful.). I've booted the patches which obviously aren't going to be immediately ready. Nine patches are ready for