(2014/04/08 9:26), Michael Paquier wrote:
On Tue, Apr 8, 2014 at 5:24 AM, Andres Freund wrote:
On 2014-04-05 11:46:16 -0400, Tom Lane wrote:
ISTM this is because the proposed feature is wrongheaded. The basic
concept of CREATE TABLE LIKE is that you're copying properties from
another object o
On Mon, Apr 7, 2014 at 4:24 PM, Andres Freund wrote:
> On 2014-04-05 11:46:16 -0400, Tom Lane wrote:
>> ISTM this is because the proposed feature is wrongheaded. The basic
>> concept of CREATE TABLE LIKE is that you're copying properties from
>> another object of the same type. You might or migh
On Tue, Apr 8, 2014 at 5:24 AM, Andres Freund wrote:
> On 2014-04-05 11:46:16 -0400, Tom Lane wrote:
>> ISTM this is because the proposed feature is wrongheaded. The basic
>> concept of CREATE TABLE LIKE is that you're copying properties from
>> another object of the same type. You might or migh
On 2014-04-05 11:46:16 -0400, Tom Lane wrote:
> ISTM this is because the proposed feature is wrongheaded. The basic
> concept of CREATE TABLE LIKE is that you're copying properties from
> another object of the same type. You might or might not want every
> property, but there's no question of whe
Michael Paquier writes:
> On Tue, Feb 18, 2014 at 7:22 AM, Andres Freund wrote:
>> Unless I miss something this possibly allows column definition to slip
>> by that shouldn't because normally all fdw column definitions are passed
>> through transformColumnDefinition() which does some checks, but
On 2014-02-18 08:35:35 +0900, Michael Paquier wrote:
> On Tue, Feb 18, 2014 at 7:22 AM, Andres Freund wrote:
> > On 2014-02-17 23:07:45 +0900, Michael Paquier wrote:
> >> On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund
> >> wrote:
> >> > I don't think this really has gone above Needs Review yet.
On Tue, Feb 18, 2014 at 7:22 AM, Andres Freund wrote:
> On 2014-02-17 23:07:45 +0900, Michael Paquier wrote:
>> On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund
>> wrote:
>> > I don't think this really has gone above Needs Review yet.
>> I am not sure that this remark makes the review of this patc
On 2014-02-17 23:07:45 +0900, Michael Paquier wrote:
> On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund wrote:
> > I don't think this really has gone above Needs Review yet.
> I am not sure that this remark makes the review of this patch much
> progressing :(
>
> By the way, I spent some time looki
On 2014-02-17 23:07:45 +0900, Michael Paquier wrote:
> On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund wrote:
> > I don't think this really has gone above Needs Review yet.
> I am not sure that this remark makes the review of this patch much
> progressing :(
Uh. What should I then say if a patch i
On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund wrote:
> I don't think this really has gone above Needs Review yet.
I am not sure that this remark makes the review of this patch much
progressing :(
By the way, I spent some time looking at it and here are some comments:
- Regression tests added are
On 2014-02-16 20:27:09 -0800, David Fetter wrote:
> On Sat, Feb 15, 2014 at 03:14:03PM +0100, Andres Freund wrote:
> > On 2014-01-31 18:16:18 +0100, Vik Fearing wrote:
> > > On 01/25/2014 06:25 AM, David Fetter wrote:
> > > > Please find attached the next rev :)
> > >
> > > This version looks comm
On Sat, Feb 15, 2014 at 03:14:03PM +0100, Andres Freund wrote:
> On 2014-01-31 18:16:18 +0100, Vik Fearing wrote:
> > On 01/25/2014 06:25 AM, David Fetter wrote:
> > > Please find attached the next rev :)
> >
> > This version looks committable to me, so I am marking it as such.
>
> This doesn't c
On 2014-01-31 18:16:18 +0100, Vik Fearing wrote:
> On 01/25/2014 06:25 AM, David Fetter wrote:
> > Please find attached the next rev :)
>
> This version looks committable to me, so I am marking it as such.
This doesn't contain a single regression test, I don't see how that's
ok. Marking as waitin
On 01/25/2014 06:25 AM, David Fetter wrote:
>> I like this patch, but I don't like its implementation at all.
>> >
>> > First of all, the documentation doesn't compile:
>> >
>> > openjade:ref/create_foreign_table.sgml:124:17:E: end tag for "LISTITEM"
>> > omitted, but OMITTAG NO was specified
>>
On Sun, Nov 24, 2013 at 02:03:18AM +0100, Vik Fearing wrote:
> On 10/15/2013 07:50 AM, David Fetter wrote:
> > On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote:
> >> Folks,
> >>
> >> Please find attached a patch implementing and documenting, to some
> >> extent, $subject. I did this in
On 01/16/2014 01:21 AM, Tom Lane wrote:
> Vik Fearing writes:
>>> I am marking this patch as 'returned with feedback' in the commitfest app.
>> It looks like this patch got left behind in the previous commitfest.
>> What is the policy for moving it? Is it too late and will have to wait
>> until
Vik Fearing writes:
>> I am marking this patch as 'returned with feedback' in the commitfest app.
> It looks like this patch got left behind in the previous commitfest.
> What is the policy for moving it? Is it too late and will have to wait
> until the next commitfest?
> https://commitfest.po
On Thu, Jan 16, 2014 at 01:07:50AM +0100, Vik Fearing wrote:
> On 11/24/2013 02:03 AM, Vik Fearing wrote:
> > On 10/15/2013 07:50 AM, David Fetter wrote:
> >> On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote:
> >>> Folks,
> >>>
> >>> Please find attached a patch implementing and documen
On 11/24/2013 02:03 AM, Vik Fearing wrote:
> On 10/15/2013 07:50 AM, David Fetter wrote:
>> On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote:
>>> Folks,
>>>
>>> Please find attached a patch implementing and documenting, to some
>>> extent, $subject. I did this in aid of being able to i
On 10/15/2013 07:50 AM, David Fetter wrote:
> On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote:
>> Folks,
>>
>> Please find attached a patch implementing and documenting, to some
>> extent, $subject. I did this in aid of being able to import SQL
>> standard catalogs and other entities
On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote:
> Folks,
>
> Please find attached a patch implementing and documenting, to some
> extent, $subject. I did this in aid of being able to import SQL
> standard catalogs and other entities where a known example could
> provide a template f
Folks,
Please find attached a patch implementing and documenting, to some
extent, $subject. I did this in aid of being able to import SQL
standard catalogs and other entities where a known example could
provide a template for a foreign table.
Should there be errhint()s, too? Should we pile up a
22 matches
Mail list logo
