On 01/25/2014 06:25 AM, David Fetter wrote: >> I like this patch, but I don't like its implementation at all. >> > >> > First of all, the documentation doesn't compile: >> > >> > openjade:ref/create_foreign_table.sgml:124:17:E: end tag for "LISTITEM" >> > omitted, but OMITTAG NO was specified >> > openjade:ref/create_foreign_table.sgml:119:4: start tag was here > Fixed. > >> > I fixed that, and then noticed that like_option is not explained like it >> > is in CREATE TABLE. > Also fixed. > >> > Then I got down to the description of the LIKE clause in both pages, and >> > I noticed the last line of CREATE TABLE, which is "Inapplicable options >> > (e.g., INCLUDING INDEXES from a view) are ignored.". This is >> > inconsistent with the behavior of this patch to throw errors for >> > inapplicable options. > Fixed. > > Please find attached the next rev :)
This version looks committable to me, so I am marking it as such. -- Vik -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
