Re: [HACKERS] Autovacuum loose ends

2005-07-22 Thread Alvaro Herrera
On Fri, Jul 22, 2005 at 07:37:53PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I've hacked the whole thing enough that I fixed most of the issues. > > However this one I don't know how to handle. What I need to do is > > compare each database's frozen Xid with the curre

Re: [HACKERS] Autovacuum loose ends

2005-07-22 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I've hacked the whole thing enough that I fixed most of the issues. > However this one I don't know how to handle. What I need to do is > compare each database's frozen Xid with the current transaction Id. > I can get the frozenxid from the flatfile --

Re: [HACKERS] Autovacuum loose ends

2005-07-22 Thread Alvaro Herrera
On Thu, Jul 14, 2005 at 10:52:56AM -0400, Tom Lane wrote: Hey, > * Or actually, it would vacuum template0, except that since no regular > backend ever connects to template0, there will be no stats DB entry for > it and so the loop in AutoVacMain will ignore it. This is definitely > BAD as it mea

Re: [HACKERS] Autovacuum loose ends

2005-07-16 Thread Tom Lane
Ron Mayer <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> ISTM the point of the delay parameters >> for autovac is to put a lid on its impact on interactive response. Seen >> in that light, you do not care exactly which table it's hitting at the >> moment. > Unless the table in question takes a

Re: [HACKERS] Autovacuum loose ends

2005-07-16 Thread Ron Mayer
Tom Lane wrote: ISTM the point of the delay parameters for autovac is to put a lid on its impact on interactive response. Seen in that light, you do not care exactly which table it's hitting at the moment. Unless the table in question takes a big lock when it's VACUUMed like tables with GiST

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Hannu Krosing
On N, 2005-07-14 at 14:12 -0400, Tom Lane wrote: > "Matthew T. O'Connor" writes: > > Speaking of which, I think I mentioned this to Alvaro, but I guess it > > just didn't make it in. The pg_autovacuum table should have a few > > additional columns that allow setting vacuum delay settings on a p

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > I was thinking GUC settings only; is there a real use-case for > table-specific delay parameters? ISTM the point of the delay parameters > for autovac is to put a lid on its impact on interactive response. Seen > in that light, you do not care exactly which

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Thanks, and again sorry for the bugs. The code for shutting the whole > thing down was not easy for me to understand -- I think it should be > better documented. I can send a src/backend/postmaster/README file if > you think it's worth it; I'd document

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Matthew T. O'Connor
Tom Lane wrote: "Matthew T. O'Connor" writes: Speaking of which, I think I mentioned this to Alvaro, but I guess it just didn't make it in. The pg_autovacuum table should have a few additional columns that allow setting vacuum delay settings on a per table basis. I also think that there

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Tom Lane
"Matthew T. O'Connor" writes: > Speaking of which, I think I mentioned this to Alvaro, but I guess it > just didn't make it in. The pg_autovacuum table should have a few > additional columns that allow setting vacuum delay settings on a per > table basis. I also think that there should be GUC

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Oh, is that right? Actually in the end I forgot about temp tables so I > didn't handle them specially, but now I remember that when I started > looking at Matthew's integration code I thought that temp tables should > be analyzed if they happen to have

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Alvaro Herrera
On Thu, Jul 14, 2005 at 10:52:56AM -0400, Tom Lane wrote: > I've applied Alvaro's latest integrated-autovacuum patch. There are > still a number of loose ends to be dealt with before beta, though: Thanks, and again sorry for the bugs. The code for shutting the whole thing down was not easy for m

Re: [HACKERS] Autovacuum loose ends

2005-07-14 Thread Matthew T. O'Connor
This is great news! I will do what I can to continue improving the code and address these concerns as best I can. Many of the items below will need to be addressed by Alvaro, but I will comment where I think I have something useful to say :-) Tom Lane wrote: I've applied Alvaro's latest in

[HACKERS] Autovacuum loose ends

2005-07-14 Thread Tom Lane
I've applied Alvaro's latest integrated-autovacuum patch. There are still a number of loose ends to be dealt with before beta, though: * Not all the functionality of the current contrib code seems to have made it in. In particular I noted the "sleep scaling factor" is missing, as well as the opt