Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-23 Thread Zdenek Kotala
Greg Smith píše v út 15. 12. 2009 v 12:10 -0500: > Please send that updated version, and let's keep working on this into > the next CommitFest, where it will be in the front of the queue rather > than how it ended up at the tail of this one just based on its > submission date. You're not really

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-15 Thread Bernd Helmle
--On 15. Dezember 2009 12:10:09 -0500 Greg Smith wrote: But I'm afraid we're already out of time for this one if you're still tweaking the probes here.  With a functional change like that, our normal process at this point would be to have the reviewer re-evaluate things before they head to

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-15 Thread Greg Smith
Zdenek Kotala wrote: Bernd Helmle píše v po 14. 12. 2009 v 20:42 +0100: Oh, and i was under the opinion the last discussions were about executor probes only (note the patch is split up into two parts now, SLRU and executor probes). The latter won't be fixed, but it seems the SLRU part at le

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-14 Thread Zdenek Kotala
Bernd Helmle píše v po 14. 12. 2009 v 20:42 +0100: > > --On 14. Dezember 2009 20:33:12 +0100 Bernd Helmle > wrote: > > >> Since the author has pretty much admitted he didn't fix any of the > >> issues that were raised by the last committer review, I'm a little > >> confused about why you're ask

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-14 Thread Bernd Helmle
--On 14. Dezember 2009 20:33:12 +0100 Bernd Helmle wrote: Since the author has pretty much admitted he didn't fix any of the issues that were raised by the last committer review, I'm a little confused about why you're asking for another one. It wasn't clear to me what Zdenek meant with "I

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-14 Thread Bernd Helmle
--On 14. Dezember 2009 07:49:34 -0500 Robert Haas wrote: Since the author has pretty much admitted he didn't fix any of the issues that were raised by the last committer review, I'm a little confused about why you're asking for another one. It wasn't clear to me what Zdenek meant with "If

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-14 Thread Robert Haas
On Mon, Dec 14, 2009 at 7:19 AM, Bernd Helmle wrote: > --On 10. Dezember 2009 16:49:50 +0100 Zdenek Kotala > wrote: > >> You need to determine which SLRU is used. Because SLRUs are initialized >> during startup  pointer should be same in all backends. If I think more >> about it. Maybe it could b

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-14 Thread Bernd Helmle
--On 10. Dezember 2009 16:49:50 +0100 Zdenek Kotala wrote: You need to determine which SLRU is used. Because SLRUs are initialized during startup pointer should be same in all backends. If I think more about it. Maybe it could be goot to add probe also into SimpleLruInit to catch name of S

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-10 Thread Bernd Helmle
--On 9. Dezember 2009 19:08:07 -0500 Theo Schlossnagle wrote: Now, there was some indication that there was a better place to probe that would be more comprehensive -- that should be addressed. For now there exists no consensus where they should go in. Tom pointed out various issues with

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-10 Thread Zdenek Kotala
Dne 10.12.09 15:51, Bernd Helmle napsal(a): --On 8. Dezember 2009 11:10:44 +0100 Zdenek Kotala wrote: If you think that it is better I could split patch into two separate patches and both can be reviewed separately. I split up this patch into two separate patches: one for SLRU and one f

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-10 Thread Bernd Helmle
--On 8. Dezember 2009 11:10:44 +0100 Zdenek Kotala wrote: If you think that it is better I could split patch into two separate patches and both can be reviewed separately. I split up this patch into two separate patches: one for SLRU and one for the executor probes. I've done some docume

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-09 Thread Theo Schlossnagle
On Dec 8, 2009, at 5:10 AM, Zdenek Kotala wrote: > Dne 8.12.09 00:27, Bernd Helmle napsal(a): >> --On 13. November 2009 23:29:41 +0100 Zdenek Kotala >> wrote: >>> t contains two DTrace probe groups. One is related to monitoring SLRU >>> and second is about executor nodes. >>> >>> I merged it

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-08 Thread Zdenek Kotala
Dne 8.12.09 00:27, Bernd Helmle napsal(a): --On 13. November 2009 23:29:41 +0100 Zdenek Kotala wrote: t contains two DTrace probe groups. One is related to monitoring SLRU and second is about executor nodes. I merged it with the head. Original end of mail thread is here: http://archive

Re: [HACKERS] [patch] executor and slru dtrace probes

2009-12-07 Thread Bernd Helmle
--On 13. November 2009 23:29:41 +0100 Zdenek Kotala wrote: t contains two DTrace probe groups. One is related to monitoring SLRU and second is about executor nodes. I merged it with the head. Original end of mail thread is here: http://archives.postgresql.org/pgsql-hackers/2009-04/msg001

[HACKERS] [patch] executor and slru dtrace probes

2009-11-13 Thread Zdenek Kotala
I attached patch which was already sent on february/april, but it was lost in time. It is originally from Robert Lor and Theo Schlossnagle. It contains two DTrace probe groups. One is related to monitoring SLRU and second is about executor nodes. I merged it with the head. Original end of mail t