Re: [HACKERS] [PATCHES] Postgresql.conf Documentation change

2004-08-19 Thread Bruce Momjian
Josh Berkus wrote: > Tom, > > > Right at the moment my feeling is that there are issues here that are > > considerably more subtle than we realized, and rather than risk creating > > unforeseen problems, we ought to bounce the whole issue back to the TODO > > list for 8.1. > > Agreed. I will sub

Re: [HACKERS] [PATCHES] Postgresql.conf Documentation change

2004-08-19 Thread Josh Berkus
Tom, > Right at the moment my feeling is that there are issues here that are > considerably more subtle than we realized, and rather than risk creating > unforeseen problems, we ought to bounce the whole issue back to the TODO > list for 8.1. Agreed. I will submit a new patch that simply adds a

Re: [HACKERS] [PATCHES] Postgresql.conf Documentation change

2004-08-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > By removing comments from postgresql.conf, I am afraid we are making all > environment value useless. Good point. > I suppose the easiest fix would be to re-command the postgresql.conf > values that can be over-ridden with environment variables, or make

Re: [HACKERS] [PATCHES] Postgresql.conf Documentation change

2004-08-19 Thread Bruce Momjian
I had a problem with this patch. By removing the comment from 'port', the postgresql.conf 'port' value is used in the regression tests rather than the environment value. I see in guc.c env = getenv("PGPORT"); if (env != NULL) SetConfigOption("port", env, PGC_POSTMASTER, PGC_S_EN