I had a problem with this patch. By removing the comment from 'port',
the postgresql.conf 'port' value is used in the regression tests rather
than the environment value. I see in guc.c
env = getenv("PGPORT");
if (env != NULL)
SetConfigOption("port", env, PGC_POSTMASTER, PGC_S_ENV_VAR);
but, look at this:
typedef enum
{
PGC_S_DEFAULT, /* wired-in default */
PGC_S_ENV_VAR, /* postmaster environment variable */
PGC_S_FILE, /* postgresql.conf */
PGC_S_ARGV, /* postmaster command line */
PGC_S_UNPRIVILEGED, /* dividing line for USERLIMIT */
PGC_S_DATABASE, /* per-database setting */
PGC_S_USER, /* per-user setting */
PGC_S_CLIENT, /* from client connection request */
PGC_S_OVERRIDE, /* special case to forcibly set default */
PGC_S_INTERACTIVE, /* dividing line for error reporting */
PGC_S_TEST, /* test per-database or per-user setting */
PGC_S_SESSION /* SET command */
} GucSource;
which says that the config file value overrides the environment value.
By removing comments from postgresql.conf, I am afraid we are making all
environment value useless.
I suppose the easiest fix would be to re-command the postgresql.conf
values that can be over-ridden with environment variables, or make
environment variables more significant than postgresql.conf values, and,
being in beta, which should we do now and which should we do for 8.1?
Comments?
---------------------------------------------------------------------------
Josh Berkus wrote:
> Tom,
>
> Attached is that patch I talked to you about on hackers. It changes the
> description at the top and uncomments most (but not all) of the lines in an
> effort to make it clear that commenting is not a way to restore the defaults.
>
> I've tested this on my machine and we end up with the exact same defaults with
> this patch as without, so no changes to initdb should be required.
>
> --
> -Josh Berkus
>
> ______AGLIO DATABASE SOLUTIONS___________________________
> Josh Berkus
> Enterprise vertical business [EMAIL PROTECTED]
> and data analysis solutions (415) 752-2500
> and database optimization fax 752-2387
> utilizing Open Source technology San Francisco
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
--
Bruce Momjian | http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend
