Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-15 Thread Robert Haas
On Fri, Apr 12, 2013 at 1:00 PM, Tom Lane wrote: > Robert Haas writes: >> The hunk that changes the messages might need some thought so that it >> doesn't cause a translation regression. But in general I see no >> reason not to do this before we release beta1. It seems safe enough, >> and chang

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-14 Thread Christoph Berg
Re: Tom Lane 2013-04-12 <20318.1365786...@sss.pgh.pa.us> > Robert Haas writes: > > The hunk that changes the messages might need some thought so that it > > doesn't cause a translation regression. But in general I see no > > reason not to do this before we release beta1. It seems safe enough, >

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-12 Thread Tom Lane
Robert Haas writes: > The hunk that changes the messages might need some thought so that it > doesn't cause a translation regression. But in general I see no > reason not to do this before we release beta1. It seems safe enough, > and changes that reduce the need for packagers to carry private >

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-12 Thread Alvaro Herrera
Robert Haas escribió: > On Tue, Apr 9, 2013 at 8:08 AM, Christoph Berg wrote: > > Debian has been patching pg_regress for years because our default unix > > socket directory is /var/run/postgresql, but that is not writable by > > the build user at build time. This used to be a pretty ugly "make- >

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-12 Thread Robert Haas
On Tue, Apr 9, 2013 at 8:08 AM, Christoph Berg wrote: > Debian has been patching pg_regress for years because our default unix > socket directory is /var/run/postgresql, but that is not writable by > the build user at build time. This used to be a pretty ugly "make- > patch-make check-unpatch-make

Re: [HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-12 Thread Christoph Berg
Re: To PostgreSQL Hackers 2013-04-09 <20130409120807.gd26...@msgid.df7cb.de> If the patch looks too intrusive at this stage of the release, it would be enough if the last chunk got included, which should really be painless: > diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regres

[HACKERS] [PATCH] pg_regress and non-default unix socket path

2013-04-09 Thread Christoph Berg
Hi, Debian has been patching pg_regress for years because our default unix socket directory is /var/run/postgresql, but that is not writable by the build user at build time. This used to be a pretty ugly "make- patch-make check-unpatch-make install" patch dance, but now it is a pretty patch that m