Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Peter Geoghegan
On Tue, Jul 15, 2014 at 9:58 PM, Alvaro Herrera wrote: > I try to mention message-ids in commit messages. Are these useful? In my view, yes, certainly. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Alvaro Herrera
Simon Riggs wrote: > On 15 July 2014 19:15, Tom Lane wrote: > > > Where was the discussion of > > why this change should be back-patched? > > Your question has broader implications. Currently commit messages do > not reference the conversations that led to them and a great many use > entirely di

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Tom Lane
Simon Riggs writes: > On 15 July 2014 22:01, Tom Lane wrote: >> I searched the archives looking for that discussion and couldn't find it; >> can you provide a link? > http://www.postgresql.org/message-id/e1u2jod-0005w4...@gemulon.postgresql.org Ah. I hadn't searched backwards quite far enough

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Simon Riggs
On 15 July 2014 22:01, Tom Lane wrote: > Simon Riggs writes: >> On 15 July 2014 19:15, Tom Lane wrote: >>> While I'm not necessarily objecting to the content of this patch, >>> I do have a problem with the process. Where was the discussion of >>> why this change should be back-patched? > >> The

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Tom Lane
Simon Riggs writes: > On 15 July 2014 19:15, Tom Lane wrote: >> While I'm not necessarily objecting to the content of this patch, >> I do have a problem with the process. Where was the discussion of >> why this change should be back-patched? > There was recent discussion of it on-list and a pub

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Simon Riggs
On 15 July 2014 19:15, Tom Lane wrote: > Where was the discussion of > why this change should be back-patched? Your question has broader implications. Currently commit messages do not reference the conversations that led to them and a great many use entirely different descriptions on-list and in

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Simon Riggs
On 15 July 2014 19:15, Tom Lane wrote: > Simon Riggs writes: >> Reset master xmin when hot_standby_feedback disabled. >> If walsender has xmin of standby then ensure we >> reset the value to 0 when we change from hot_standby_feedback=on >> to hot_standby_feedback=off. > >> Branch >> -- >> REL

Re: [HACKERS] [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-07-15 Thread Tom Lane
Simon Riggs writes: > Reset master xmin when hot_standby_feedback disabled. > If walsender has xmin of standby then ensure we > reset the value to 0 when we change from hot_standby_feedback=on > to hot_standby_feedback=off. > Branch > -- > REL9_2_STABLE While I'm not necessarily objecting t