Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-10-13 Thread Bruce Momjian
Tom Lane wrote: > Florian Pflug writes: > > On Jun1, 2011, at 20:28 , Peter Eisentraut wrote: > >> Well, initdb still succeeds if you give it an invalid locale name. It > >> warns, but that can easily be missed if initdb is hidden behind a few > >> other layers. If you then run pg_upgrade, you g

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-06-01 Thread Tom Lane
Florian Pflug writes: > On Jun1, 2011, at 20:28 , Peter Eisentraut wrote: >> Well, initdb still succeeds if you give it an invalid locale name. It >> warns, but that can easily be missed if initdb is hidden behind a few >> other layers. If you then run pg_upgrade, you get a hosed instance. > Wh

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-06-01 Thread Florian Pflug
On Jun1, 2011, at 20:28 , Peter Eisentraut wrote: > Well, initdb still succeeds if you give it an invalid locale name. It > warns, but that can easily be missed if initdb is hidden behind a few > other layers. If you then run pg_upgrade, you get a hosed instance. Whats the rational behind that b

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-06-01 Thread Peter Eisentraut
On ons, 2011-06-01 at 13:21 -0400, Tom Lane wrote: > Peter Eisentraut writes: > >>> I think you misread what I wrote, or I misexplained it, but never > >>> mind. Matching locale names case-insensitively sounds reasonable to > >>> me, unless someone has reason to believe it will blow up. > > > On

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-06-01 Thread Tom Lane
Peter Eisentraut writes: >>> I think you misread what I wrote, or I misexplained it, but never >>> mind. Matching locale names case-insensitively sounds reasonable to >>> me, unless someone has reason to believe it will blow up. > On FreeBSD, locale names appear to be case-sensitive: > $ LC_ALL

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-06-01 Thread Peter Eisentraut
On tis, 2011-05-24 at 15:59 -0400, Bruce Momjian wrote: > > I think you misread what I wrote, or I misexplained it, but never > > mind. Matching locale names case-insensitively sounds reasonable to > > me, unless someone has reason to believe it will blow up. > > OK, that's what I needed to hear.

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Tim Uckun
> I thought the problem was that they upgraded the OS and now the encoding > names changed, though they behaved the same.  Is that now what is > happening?  Can they supply the values with different cases? > In my case I never touched the locale. It was set by the OS. I presume this is true for m

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Bruce Momjian
Tom Lane wrote: > Robert Haas writes: > > On Wed, May 25, 2011 at 2:13 PM, Bruce Momjian wrote: > >> I thought the problem was that they upgraded the OS and now the encoding > >> names changed, though they behaved the same. ?Is that now what is > >> happening? ?Can they supply the values with dif

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Tom Lane
Robert Haas writes: > On Wed, May 25, 2011 at 2:13 PM, Bruce Momjian wrote: >> I thought the problem was that they upgraded the OS and now the encoding >> names changed, though they behaved the same.  Is that now what is >> happening?  Can they supply the values with different cases? > Oh, hmm.

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Robert Haas
On Wed, May 25, 2011 at 2:13 PM, Bruce Momjian wrote: > Alvaro Herrera wrote: >> Excerpts from Robert Haas's message of mié may 25 13:33:41 -0400 2011: >> > On Wed, May 25, 2011 at 1:22 PM, Bruce Momjian wrote: >> >> > > I can easily remove dashes before the compare if people like that idea >> >

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Bruce Momjian
Alvaro Herrera wrote: > Excerpts from Robert Haas's message of mi?? may 25 13:33:41 -0400 2011: > > On Wed, May 25, 2011 at 1:22 PM, Bruce Momjian wrote: > > > > I can easily remove dashes before the compare if people like that idea > > > --- I think you could argue that a dash is not significant

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié may 25 13:33:41 -0400 2011: > On Wed, May 25, 2011 at 1:22 PM, Bruce Momjian wrote: > > I can easily remove dashes before the compare if people like that idea > > --- I think you could argue that a dash is not significant, unless "ab-c" > > and "a-bc" ar

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Robert Haas
On Wed, May 25, 2011 at 1:22 PM, Bruce Momjian wrote: > Alvaro Herrera wrote: >> Excerpts from Bruce Momjian's message of mar may 24 15:59:59 -0400 2011: >> >> > > I think you misread what I wrote, or I misexplained it, but never >> > > mind.  Matching locale names case-insensitively sounds reason

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Bruce Momjian
Alvaro Herrera wrote: > Excerpts from Bruce Momjian's message of mar may 24 15:59:59 -0400 2011: > > > > I think you misread what I wrote, or I misexplained it, but never > > > mind. Matching locale names case-insensitively sounds reasonable to > > > me, unless someone has reason to believe it wi

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-25 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of mar may 24 15:59:59 -0400 2011: > > I think you misread what I wrote, or I misexplained it, but never > > mind. Matching locale names case-insensitively sounds reasonable to > > me, unless someone has reason to believe it will blow up. > > OK, that's what

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-24 Thread Bruce Momjian
Robert Haas wrote: > On Mon, May 23, 2011 at 2:57 PM, Bruce Momjian wrote: > > Robert Haas wrote: > >> On Mon, May 23, 2011 at 8:26 AM, Bruce Momjian wrote: > >> > Sorry, I was unclear. ?The question is whether the case of _name_ of the > >> > locale is significant, meaning can you have two local

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-24 Thread Bruce Momjian
Robert Haas wrote: > On Mon, May 23, 2011 at 8:26 AM, Bruce Momjian wrote: > > Sorry, I was unclear. ?The question is whether the case of _name_ of the > > locale is significant, meaning can you have two locale names that differ > > only by case and behave differently? > > That would seem surpris

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-23 Thread Robert Haas
On Mon, May 23, 2011 at 2:57 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Mon, May 23, 2011 at 8:26 AM, Bruce Momjian wrote: >> > Sorry, I was unclear. ?The question is whether the case of _name_ of the >> > locale is significant, meaning can you have two locale names that differ >> > only

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-23 Thread Robert Haas
On Mon, May 23, 2011 at 8:26 AM, Bruce Momjian wrote: > Sorry, I was unclear.  The question is whether the case of _name_ of the > locale is significant, meaning can you have two locale names that differ > only by case and behave differently? That would seem surprising to me, but I really have no

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-23 Thread Bruce Momjian
Robert Haas wrote: > On Sun, May 22, 2011 at 9:39 PM, Bruce Momjian wrote: > > Tim Uckun wrote: > >> pg_upgrade from 8.4 to 9.0 fails with the following error message. > >> > >> old and new cluster lc_collate values do not match > >> > >> > >> on 8.4 show lc_collate outputs > >> > >>

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-22 Thread Robert Haas
On Sun, May 22, 2011 at 9:39 PM, Bruce Momjian wrote: > Tim Uckun wrote: >> pg_upgrade from 8.4 to 9.0 fails with the following error message. >> >> old and new cluster lc_collate values do not match >> >> >> on 8.4 show lc_collate outputs >> >>  en_NZ.utf8 >> (1 row) >> >> >> on 9.0

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-05-22 Thread Bruce Momjian
Tim Uckun wrote: > pg_upgrade from 8.4 to 9.0 fails with the following error message. > > old and new cluster lc_collate values do not match > > > on 8.4 show lc_collate outputs > > en_NZ.utf8 > (1 row) > > > on 9.0 it outputs > > en_NZ.UTF8 > (1 row) > > > So the