Re: [HACKERS] list of credits for release notes

2017-10-03 Thread Kohei KaiGai
ould be Masao Fujii. >>> - KaiGai Kohei should be Kohei Kaigai. >> >> But his emails say Fujii Masao, not Masao Fujii. > > Michael is correct. > > Sometimes people choose family name first in the emails. However I am > sure "Fujii" is the family name and

Re: [HACKERS] Float value 'Infinity' is cast to numeric 1 on Windows

2017-09-27 Thread Kohei KaiGai
Hello, Does it make sense to put a check of "isinf(val)" and ereport prior to the snprintf()? It is a lightweight check more than set_var_from_str(). Thanks, 2017-09-27 19:41 GMT+09:00 Taiki Kondo : > Hi all, > > I build PostgreSQL 9.6.5 by Visual Studio 2013 on Windows, I found weird > behavio

Re: ParallelFinish-hook of FDW/CSP (Re: [HACKERS] Steps inside ExecEndGather)

2017-02-24 Thread Kohei KaiGai
2017-02-25 1:40 GMT+09:00 Claudio Freire : > On Fri, Feb 24, 2017 at 1:24 PM, Robert Haas wrote: >> On Fri, Feb 24, 2017 at 7:29 PM, Kohei KaiGai wrote: >>> This attached patch re-designed the previous v2 according to Robert's >>> comment. >>>

Re: ParallelFinish-hook of FDW/CSP (Re: [HACKERS] Steps inside ExecEndGather)

2017-02-24 Thread Kohei KaiGai
Hello, This attached patch re-designed the previous v2 according to Robert's comment. All I had to do is putting entrypoint for ForeignScan/CustomScan at ExecShutdownNode, because it is already modified to call child node first, earlier than ExecShutdownGather which releases DSM segment. Thanks,

Re: [HACKERS] PassDownLimitBound for ForeignScan/CustomScan [take-2]

2017-01-02 Thread Kohei KaiGai
Oops, I oversight this patch was marked as "returned with feedback", not "moved to the next CF". Its status has not been changed since the last update. (Code was revised according to the last comment by Jeevan, but CF-Nov was time up at that time.) How do I handle the patch? 2016-12-05 16:49 GMT

Re: [HACKERS] varlena beyond 1GB and matrix

2016-12-22 Thread Kohei KaiGai
2016-12-23 8:24 GMT+09:00 Robert Haas : > On Wed, Dec 7, 2016 at 11:01 PM, Kohei KaiGai wrote: >> Regardless of the ExpandedObject, does the flatten format need to >> contain fully flatten data chunks? > > I suspect it does, and I think that's why this isn't go

Re: [HACKERS] varlena beyond 1GB and matrix

2016-12-22 Thread Kohei KaiGai
2016-12-23 8:23 GMT+09:00 Robert Haas : > On Wed, Dec 7, 2016 at 10:44 PM, Kohei KaiGai wrote: >>> Handling objects >1GB at all seems like the harder part of the >>> problem. >>> >> I could get your point almost. Does the last line above mention about >

Re: [HACKERS] varlena beyond 1GB and matrix

2016-12-08 Thread Kohei KaiGai
2016-12-08 16:11 GMT+09:00 Craig Ringer : > On 8 December 2016 at 12:01, Kohei KaiGai wrote: > >>> At a higher level, I don't understand exactly where such giant >>> ExpandedObjects would come from. (As you point out, there's certainly >>> no easy way

Re: [HACKERS] varlena beyond 1GB and matrix

2016-12-07 Thread Kohei KaiGai
2016-12-08 8:36 GMT+09:00 Tom Lane : > Robert Haas writes: >> On Wed, Dec 7, 2016 at 8:50 AM, Kohei KaiGai wrote: >>> I like to propose a new optional type handler 'typserialize' to >>> serialize an in-memory varlena structure (that can have indirect >

Re: [HACKERS] varlena beyond 1GB and matrix

2016-12-07 Thread Kohei KaiGai
2016-12-08 8:04 GMT+09:00 Robert Haas : > On Wed, Dec 7, 2016 at 8:50 AM, Kohei KaiGai wrote: >> I like to propose a new optional type handler 'typserialize' to >> serialize an in-memory varlena structure (that can have indirect >> references) to on-disk format. >

[HACKERS] varlena beyond 1GB and matrix

2016-12-07 Thread Kohei KaiGai
This is a design proposal for matrix data type which can be larger than 1GB. Not only a new data type support, it also needs a platform enhancement because existing varlena has a hard limit (1GB). We had a discussion about this topic on the developer unconference at Tokyo/Akihabara, the day before

Re: [HACKERS] raw output from copy

2016-12-06 Thread Kohei KaiGai
2016-12-06 16:59 GMT+09:00 Pavel Stehule : > > > 2016-12-06 1:50 GMT+01:00 Kohei KaiGai : >> >> 2016-12-05 22:45 GMT+09:00 Pavel Stehule : >> > >> > There are more goals: >> > >> > 1. user friendly import of text or binary data - import t

Re: [HACKERS] raw output from copy

2016-12-05 Thread Kohei KaiGai
2016-12-05 22:45 GMT+09:00 Pavel Stehule : > > There are more goals: > > 1. user friendly import of text or binary data - import text data (with > psql) from file is possible - but you have to load a content to psql > variable. For binary data you should to use workaround based on LO and > transfor

Re: [HACKERS] raw output from copy

2016-12-05 Thread Kohei KaiGai
Sorry for my late response. I've briefly checked a series of discussion in the past. I understood the target/purpose of this patch is provision of a fast interface to import/export a particular cell of a relation, by skip of text<->binary transformation. Its typical use case are XML and JSON data

Re: [HACKERS] Use of pg_proc.probin is legal?

2016-11-17 Thread Kohei KaiGai
2016-11-16 7:46 GMT-08:00 Tom Lane : > Kohei KaiGai writes: >> On the other hands, interpret_AS_clause() raises an ereport if SQL >> function tries to use probin except >> for C-language. Is it illegal for other languages to use probin field >> to store something u

[HACKERS] Use of pg_proc.probin is legal?

2016-11-15 Thread Kohei KaiGai
Hello, I have a question as subject line. https://www.postgresql.org/docs/devel/static/catalog-pg-proc.html According to the documentation, the purpose of pg_proc.probin is introduced as follows: | Additional information about how to invoke the function. Again, the interpretation is language-spec

Re: [HACKERS] Academic help for Postgres

2016-05-11 Thread Kohei KaiGai
2016-05-11 23:20 GMT+09:00 Bruce Momjian : > I am giving a keynote at an IEEE database conference in Helsinki next > week (http://icde2016.fi/). (Yes, I am not attending PGCon Ottawa > because I accepted the Helsinki conference invitation before the PGCon > Ottawa date was changed from June to May

Re: [HACKERS] textlike under the LIKE operator for char(n)

2016-05-06 Thread Kohei KaiGai
2016-05-06 23:17 GMT+09:00 Kevin Grittner : > On Fri, May 6, 2016 at 8:58 AM, Kohei KaiGai wrote: > >> postgres=# select 'abcd'::char(20) LIKE 'ab%cd'; >> ?column? >> -- >> f >> (1 row) >> >> postgres=# select 

[HACKERS] textlike under the LIKE operator for char(n)

2016-05-06 Thread Kohei KaiGai
Hi, I found a mysterious behavior when we use LIKE operator on char(n) data type. postgres=# select 'abcd'::char(20) LIKE 'ab%cd'; ?column? -- f (1 row) postgres=# select 'abcd'::char(4) LIKE 'ab%cd'; ?column? -- t (1 row) LIKE operator (that is eventually processed by text

Re: CustomScan in a larger structure (RE: [HACKERS] CustomScan support on readfuncs.c)

2016-02-12 Thread Kohei KaiGai
2016-02-13 0:11 GMT+09:00 Robert Haas : > On Fri, Feb 12, 2016 at 9:56 AM, Andres Freund wrote: >> On 2016-02-10 23:26:20 -0500, Robert Haas wrote: >>> I think the part about whacking around the FDW API is a little more >>> potentially objectionable to others, so I want to hold off doing that >>>

Re: [HACKERS] cash_mul_int8 / cash_div_int8

2015-10-07 Thread Kohei KaiGai
Also, cash_pl, cash_mi, cash_mul_int4 and so on... does not have overflow checks like as int8pl has. Of course, most of people don't need to worry about 64bit overflow for money... :-). 2015-10-08 0:03 GMT+09:00 Kohei KaiGai : > I noticed cash_mul_int8 / cash_div_int8 are defined i

[HACKERS] cash_mul_int8 / cash_div_int8

2015-10-07 Thread Kohei KaiGai
I noticed cash_mul_int8 / cash_div_int8 are defined in cash.c, however, pg_proc.h and pg_operator.h contains no relevant entries. Is it just a careless oversight? Thanks, -- KaiGai Kohei -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscriptio

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-08-19 Thread Kohei KaiGai
2015-08-19 21:29 GMT+09:00 Simon Riggs : > On 19 August 2015 at 12:55, Kohei KaiGai wrote: >> >> 2015-08-19 20:12 GMT+09:00 Simon Riggs : >> > On 12 June 2015 at 00:29, Tomas Vondra >> > wrote: >> > >> >> >> >> I see two ways t

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-08-19 Thread Kohei KaiGai
2015-08-19 20:12 GMT+09:00 Simon Riggs : > On 12 June 2015 at 00:29, Tomas Vondra wrote: > >> >> I see two ways to fix this: >> >> (1) enforce the 1GB limit (probably better for back-patching, if that's >> necessary) >> >> (2) make it work with hash tables over 1GB >> >> I'm in favor of (2) if

Re: [HACKERS] security labels on databases are bad for dump & restore

2015-07-14 Thread Kohei KaiGai
2015-07-15 2:39 GMT+09:00 Ted Toth : > That's exactly what I'm talking about like I said KaiGais branch was > never merged into the mainline so I do not believe that it is used at > all. > It depends on the definition of "integrated". The PostgreSQL core offers an infrastructure for label based sec

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-06-24 Thread Kohei KaiGai
Does it make sense to put the result tuple of remote join on evety estate->es_epqTupleSet[] slot represented by this ForeignScan if scanrelid==0? It allows to recheck qualifier for each LockRow that intends to lock base foreign table underlying the remote join. ForeignScan->fdw_relids tells us whi

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-06-11 Thread Kohei KaiGai
2015-06-11 23:33 GMT+09:00 Tomas Vondra : > Hi, > > On 06/11/15 16:20, Jan Wieck wrote: >> >> On 06/11/2015 09:53 AM, Kouhei Kaigai wrote: curious: what was work_mem set to? >>> work_mem=48GB >>> >>> My machine mounts 256GB physical RAM. >> >> >> work_mem can be allocated several tim

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-06-11 Thread Kohei KaiGai
2015-06-11 23:28 GMT+09:00 Robert Haas : > On Wed, Jun 10, 2015 at 10:57 PM, Kouhei Kaigai wrote: >> The attached patch replaces this palloc0() by MemoryContextAllocHuge() + >> memset(). >> Indeed, this hash table is constructed towards the relation with >> nrows=119994544, >> so, it is not stra

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-06-11 Thread Kohei KaiGai
2015-06-11 23:20 GMT+09:00 Jan Wieck : > On 06/11/2015 09:53 AM, Kouhei Kaigai wrote: >>> >>> curious: what was work_mem set to? >>> >> work_mem=48GB >> >> My machine mounts 256GB physical RAM. > > > work_mem can be allocated several times per backend. Nodes like sort and > hash_aggregate may each

Re: [HACKERS] trust authentication behavior

2015-05-18 Thread Kohei KaiGai
2015-05-18 15:15 GMT+09:00 Denis Kirjanov : > > > - Ursprüngliche Mail - > Von: "Kohei KaiGai" > An: "Robert Haas" > CC: "David G. Johnston" , "Denis Kirjanov" > , pgsql-hackers@postgresql.org, "Kohei KaiGai" >

Re: [HACKERS] trust authentication behavior

2015-05-15 Thread Kohei KaiGai
2015-05-16 5:13 GMT+09:00 Robert Haas : > On Thu, May 14, 2015 at 3:52 PM, David G. Johnston > wrote: >> On Thu, May 14, 2015 at 12:22 PM, Denis Kirjanov wrote: >>> >>> Yeah, but the idea is to do that without the pg_hba.conf >> >> You may want to try describing the problem and not just ask if th

Re: [HACKERS] One question about security label command

2015-05-13 Thread Kohei KaiGai
2015-05-13 21:45 GMT+09:00 Robert Haas : > On Sun, May 10, 2015 at 3:15 AM, Kohei KaiGai wrote: >> 2015-05-01 9:52 GMT+09:00 Kohei KaiGai : >>> 2015-05-01 7:40 GMT+09:00 Alvaro Herrera : >>>> Kouhei Kaigai wrote: >>>>> > * Tom Lane (t...@sss.pg

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-10 Thread Kohei KaiGai
Tom, I briefly checked your updates. Even though it is not described in the commit-log, I noticed a problematic change. This commit reverts create_plan_recurse() as static function. It means extension cannot have child node, even if it wants to add a custom-join logic. Please assume a simple case

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 Thread Kohei KaiGai
2015-05-09 8:18 GMT+09:00 Kohei KaiGai : > 2015-05-09 2:46 GMT+09:00 Tom Lane : >> Kouhei Kaigai writes: >>>> I've been trying to code-review this patch, because the documentation >>>> seemed several bricks shy of a load, and I find myself entirely

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 Thread Kohei KaiGai
2015-05-09 8:32 GMT+09:00 Kohei KaiGai : > 2015-05-09 3:51 GMT+09:00 Tom Lane : >> Robert Haas writes: >>> On Fri, May 8, 2015 at 1:46 PM, Tom Lane wrote: >>>> That's nice, but 9.5 feature freeze is only a week away. I don't have a >>>> lot

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 Thread Kohei KaiGai
2015-05-09 11:21 GMT+09:00 Robert Haas : > On Fri, May 8, 2015 at 5:48 PM, Tom Lane wrote: >> ... btw, I just noticed something that had escaped me because it seems so >> obviously wrong that I had not even stopped to consider the possibility >> that the code was doing what it's doing. To wit, th

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-08 Thread Kohei KaiGai
2015-05-09 3:51 GMT+09:00 Tom Lane : > Robert Haas writes: >> On Fri, May 8, 2015 at 1:46 PM, Tom Lane wrote: >>> That's nice, but 9.5 feature freeze is only a week away. I don't have a >>> lot of confidence that this stuff is actually in a state where we won't >>> regret shipping it in 9.5. > >

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-08 Thread Kohei KaiGai
2015-05-09 2:46 GMT+09:00 Tom Lane : > Kouhei Kaigai writes: >>> I've been trying to code-review this patch, because the documentation >>> seemed several bricks shy of a load, and I find myself entirely confused >>> by the fdw_ps_tlist and custom_ps_tlist fields. > >> Main-point of your concern is

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-08 Thread Kohei KaiGai
2015-05-09 6:48 GMT+09:00 Tom Lane : > ... btw, I just noticed something that had escaped me because it seems so > obviously wrong that I had not even stopped to consider the possibility > that the code was doing what it's doing. To wit, that the planner > supposes that two foreign tables are pote

Re: [HACKERS] feature freeze and beta schedule

2015-05-02 Thread Kohei KaiGai
2015-05-02 1:37 GMT+09:00 Andres Freund : > * ctidscan as an example of custom-scan > Hasn't really gotten sufficient review. > => Move > I have to agree. > * Join pushdown support for foreign tables > Hasn't gotten particularly much review yet. And it doesn't look > entirely ready to me o

Re: [HACKERS] One question about security label command

2015-04-30 Thread Kohei KaiGai
2015-05-01 7:40 GMT+09:00 Alvaro Herrera : > Kouhei Kaigai wrote: >> > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> > > The idea of making the regression test entirely independent of the >> > > system's policy would presumably solve this problem, so I'd kind of >> > > like to see progress on that fron

Re: [HACKERS] One question about security label command

2015-03-11 Thread Kohei KaiGai
2015-03-12 1:27 GMT+09:00 Alvaro Herrera : > Robert Haas wrote: >> On Tue, Mar 10, 2015 at 6:58 PM, Kohei KaiGai wrote: >> > ERRCODE_FEATURE_NOT_SUPPORTED is suitable error code here. >> > Please see the attached one. >> >> Committed. I did not bother b

Re: [HACKERS] One question about security label command

2015-03-10 Thread Kohei KaiGai
ERRCODE_FEATURE_NOT_SUPPORTED is suitable error code here. Please see the attached one. Thanks, 2015-03-11 4:34 GMT+09:00 Robert Haas : > On Tue, Mar 10, 2015 at 9:41 AM, Alvaro Herrera > wrote: >> And perhaps make it an ereport also, with errcode etc. > > Yeah, definitely. > > -- > Robert Haas

Re: [HACKERS] One question about security label command

2015-03-10 Thread Kohei KaiGai
The attached patch revises error message when security label is specified on unsupported object. getObjectTypeDescription() may be better than oid of catalog. postgres=# SECURITY LABEL FOR selinux ON ROLE kaigai postgres-# IS 'system_u:object_r:unlabeled_t:s0'; ERROR: sepgsql provider does not

Re: [HACKERS] Parallel Seq Scan

2015-02-23 Thread Kohei KaiGai
> Amit and I had a long discussion about this on Friday while in Boston > together. I previously argued that the master and the slave should be > executing the same node, ParallelSeqScan. However, Amit argued > persuasively that what the master is doing is really pretty different > from what the

Re: [HACKERS] Commit fest 2015-12 enters money time

2015-02-16 Thread Kohei KaiGai
2015-02-16 12:25 GMT+09:00 Michael Paquier : > > > On Fri, Feb 13, 2015 at 10:06 AM, Michael Paquier > wrote: >> >> In order to move on to the next CF, I am going to go through all the >> remaining patches and update their status accordingly. And sorry for >> slacking a bit regarding that. If you

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-10 Thread Kohei KaiGai
2015-01-11 10:40 GMT+09:00 Jim Nasby : > On 1/9/15, 8:51 PM, Kohei KaiGai wrote: >> >> 2015-01-10 9:56 GMT+09:00 Jim Nasby : >>> >>> On 1/9/15, 6:54 PM, Jim Nasby wrote: >>>> >>>> >>>> On 1/9/15, 6:44 PM, Petr Jelinek wrote: >

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-09 Thread Kohei KaiGai
2015-01-10 9:56 GMT+09:00 Jim Nasby : > On 1/9/15, 6:54 PM, Jim Nasby wrote: >> >> On 1/9/15, 6:44 PM, Petr Jelinek wrote: > > Yep, I had a same impression when I looked at the code first time, however, it is defined as below. Not a manner of custom-scan itself. /*

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-09 Thread Kohei KaiGai
2015-01-10 8:18 GMT+09:00 Jim Nasby : > On 1/6/15, 5:43 PM, Kouhei Kaigai wrote: scan_relid != InvalidOid > > >>> >>> > >>> >Ideally, they should be OidIsValid(scan_relid) >>> > >> >> Scan.scanrelid is an index of range-tables list, not an object-id. >> So, InvalidOid or OidIsValid()

[HACKERS] "port/atomics/arch-*.h" are missing from installation

2014-10-02 Thread Kohei KaiGai
I got the following error when I try to build my extension towards the latest master branch. Is the "port/atomics/*.h" files forgotten on make install? [kaigai@magro pg_strom]$ make gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-at

Re: [HACKERS] [v9.5] Custom Plan API

2014-10-01 Thread Kohei KaiGai
2014-10-02 0:41 GMT+09:00 Merlin Moncure : > On Tue, Jul 8, 2014 at 6:55 AM, Kouhei Kaigai wrote: >> * Syntax also reflects what the command does more. New syntax to >> define custom plan provider is: >> CREATE CUSTOM PLAN PROVIDER >> FOR HANDLER ; > > -1 on 'cpp' prefix. I don't se

Re: [HACKERS] [v9.5] Custom Plan API

2014-09-29 Thread Kohei KaiGai
2014-09-29 20:26 GMT+09:00 Thom Brown : > On 29 September 2014 09:48, Kouhei Kaigai wrote: >>> On Wed, Sep 17, 2014 at 7:40 PM, Kouhei Kaigai wrote: >>> > At this moment, I revised the above portion of the patches. >>> > create_custom_plan() was modified to call "PlanCustomPath" callback >>> > ne

Re: [HACKERS] [v9.5] Custom Plan API

2014-08-30 Thread Kohei KaiGai
2014-08-29 13:33 GMT-04:00 Robert Haas : > On Wed, Aug 27, 2014 at 6:51 PM, Kouhei Kaigai wrote: >>> > I'd like to follow this direction, and start stripping the DDL support. >>> >>> ...please make it so. >>> >> The attached patch eliminates DDL support. >> >> Instead of the new CREATE CUSTOM PLAN

Re: [HACKERS] [v9.5] Custom Plan API

2014-08-22 Thread Kohei KaiGai
2014-08-23 0:39 GMT+09:00 Robert Haas : > On Thu, Jul 17, 2014 at 3:38 PM, Tom Lane wrote: >> Alvaro Herrera writes: >>> I haven't followed this at all, but I just skimmed over it and noticed >>> the CustomPlanMarkPos thingy; apologies if this has been discussed >>> before. It seems a bit odd to

Re: [HACKERS] RLS Design

2014-07-08 Thread Kohei KaiGai
2014-07-09 15:07 GMT+09:00 Stephen Frost : > KaiGai, > > * Kohei KaiGai (kai...@kaigai.gr.jp) wrote: >> What I'd like to implement is adjustment of query like: >> SELECT * FROM t1 WHERE (x like '%abc%') AND (quals by built-in RLS) >> AND (q

Re: [HACKERS] RLS Design

2014-07-08 Thread Kohei KaiGai
2014-07-06 14:19 GMT+09:00 Stephen Frost : > Kaigai, > > * Kouhei Kaigai (kai...@ak.jp.nec.com) wrote: >> > Can you clarify where this is coming from..? It sounds like you're >> > referring to an existing implementation and, if so, it'd be good to get >> > more information on how that works exactl

Re: [HACKERS] 9.5 CF1

2014-07-07 Thread Kohei KaiGai
>> Custom Plan API >> Shigeru Hanada has said he plans to post a design review soon. > > Any updates? Should this be moved to the next CF? > Now I'm working to revise the patch according to his suggestion; will be completed within a couple of days. A few issues needs design-level suggestion fro

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-07-04 Thread Kohei KaiGai
Here is no other reason than what Alvaro mentioned in the upthread. We intended to store security label of SELinux (less than 100bytes at most), so I didn't think it leads any problem actually. On the other hands, pg_seclabel was merged in another development cycle. We didn't have deep discussion

Re: [HACKERS] NUMA packaging and patch

2014-06-26 Thread Kohei KaiGai
Hello, Let me comment on this patch. It can be applied on head of the master branch, built and run regression test successfully. What this patch tries to do is quite simple and obvious. It suggests operating system to distribute physical pages to every numa nodes on allocation. One thing I conce

Re: [HACKERS] sepgsql: label regression test failed

2014-05-16 Thread Kohei KaiGai
2014-05-16 16:26 GMT+09:00 Heikki Linnakangas : > On 05/14/2014 07:33 AM, Sergey Muraviov wrote: >> >> I've got this compiler warning: >> relation.c: In function ‘sepgsql_relation_drop’: >> relation.c:472:25: warning: ‘tclass’ may be used uninitialized in this >> function [-Wmaybe-uninitialized]

Re: [HACKERS] sepgsql: label regression test failed

2014-05-15 Thread Kohei KaiGai
e used uninitialized in this > function [-Wmaybe-uninitialized] > sepgsql_avc_check_perms(&object, > ^ > > > 2013-12-25 0:34 GMT+04:00 Kohei KaiGai : > >> Hello, >> >> It seems to me changes in the base security policy on Fedora af

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-04-28 Thread Kohei KaiGai
>> Yeah. I'm still not exactly convinced that custom-scan will ever allow >> independent development of new plan types (which, with all due respect to >> Robert, is what it was being sold as last year in Ottawa). But I'm not >> opposed in principle to committing it, if we can find a way to have a

[HACKERS] Best way to know frequency of column reference?

2014-03-21 Thread Kohei KaiGai
Hello, As people may know, I've implemented a relation cache mechanism on top of custom-plan interface, that holds contents of a particular columns only, thus it does not need to take storage access as long as user's query refers the columns on in-memory cache. The key factor of how this mechanism

Re: [HACKERS] Creating tables for columns

2014-03-21 Thread Kohei KaiGai
I had implemented similar code on top of FDW API. https://github.com/kaigai/pg_strom/blob/old_cuda/utilcmds.c#L244 Probably, heap_create_with_catalog() is what you are finding out. 2014-03-21 22:57 GMT+09:00 Rajashree Mandaogane : > We are working on a project in which we need to create tables

Re: contrib/cache_scan (Re: [HACKERS] What's needed for cache-only table scan?)

2014-03-06 Thread Kohei KaiGai
2014-03-06 18:17 GMT+09:00 Haribabu Kommi : > > On Tue, Mar 4, 2014 at 3:07 PM, Kouhei Kaigai wrote: >> >> > > 4. + cchunk = ccache_vacuum_tuple(ccache, ccache->root_chunk, &ctid); >> > > + if (pchunk != NULL && pchunk != cchunk) >> > > >> > > + ccache_merge_chunk(ccache, pchunk); >> > > >> > > +

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-04 Thread Kohei KaiGai
2014-03-05 5:52 GMT+09:00 Stephen Frost : > * Robert Haas (robertmh...@gmail.com) wrote: >> On Tue, Mar 4, 2014 at 2:34 PM, Stephen Frost wrote: >> > Alright- so do you feel that the simple ctidscan use-case is a >> > sufficient justification and example of how this can be generally >> > useful th

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-04 Thread Kohei KaiGai
2014-03-04 23:10 GMT+09:00 Stephen Frost : >> The "cache_scan" module that I and Haribabu are discussing in another >> thread also might be a good demonstration for custom-scan interface, >> however, its code scale is a bit larger than ctidscan. > > That does sound interesting though I'm curious ab

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-04 Thread Kohei KaiGai
2014-03-04 23:09 GMT+09:00 Robert Haas : > On Mon, Mar 3, 2014 at 5:15 PM, Stephen Frost wrote: >>> As I mentioned >>> up-thread, I'd really like to see FDW join push-down, FDW aggregate >>> push-down, parallel query execution, and parallel remote-FDW execution >>> and I don't see this CustomScan

Re: [HACKERS] Triggers on foreign tables

2014-03-03 Thread Kohei KaiGai
I tried to check the latest (v8) patch again, then could not find problem in your design change from the v7. As Noah pointed out, it uses per query-depth tuplestore being released on AfterTriggerEndSubXact. So, may I mark it as "ready for committer"? 2014-03-03 15:48 GMT+09:00 Ronan Dunklau : > H

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-01 Thread Kohei KaiGai
2014-03-02 10:38 GMT+09:00 Robert Haas : > On Wed, Feb 26, 2014 at 10:23 AM, Stephen Frost wrote: >> * Kouhei Kaigai (kai...@ak.jp.nec.com) wrote: >>> IIUC, his approach was integration of join-pushdown within FDW APIs, >>> however, it does not mean the idea of remote-join is rejected. >> >> For m

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-01 Thread Kohei KaiGai
2014-03-02 10:29 GMT+09:00 Stephen Frost : > * Kohei KaiGai (kai...@kaigai.gr.jp) wrote: >> As you mentioned, it is a headache for packagers, and does not make >> sense for us if packager disabled the feature that requires proprietary >> drivers. > > No, I disagree with

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-01 Thread Kohei KaiGai
2014-03-02 9:51 GMT+09:00 Stephen Frost : > KaiGai, > > * Kohei KaiGai (kai...@kaigai.gr.jp) wrote: >> Now we have two options for GPU programming: CUDA or OpenCL. >> Both of libraries and drivers are provided under the proprietary license, >> so it does not fit for

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-03-01 Thread Kohei KaiGai
2014-03-01 22:38 GMT+09:00 Stephen Frost : > KaiGai, > > * Kohei KaiGai (kai...@kaigai.gr.jp) wrote: >> BTW, this kind of discussion looks like a talk with a ghost because >> we cannot see the new interface according to the parallel execution >> right now, so we cannot

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-02-28 Thread Kohei KaiGai
2014-03-01 0:36 GMT+09:00 Stephen Frost : > * Kouhei Kaigai (kai...@ak.jp.nec.com) wrote: >> * Stephen Frost (sfr...@snowman.net) wrote: >> > I don't see how you can be when there hasn't been any discussion that I've >> > seen about how parallel query execution is going to change things for us. >>

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-02-25 Thread Kohei KaiGai
om Tom's idea of pathifying those operations). > We will need much lesser hooks in custom scan node. > > BTW, from the patch, I do not see this change to be light weight. I was > expecting more of a list of hooks to be defined by the user and this > infrastructure just calling th

Re: [HACKERS] New hook after raw parsing, before analyze

2014-02-13 Thread Kohei KaiGai
See the discussion of Custom-Scan API. https://commitfest.postgresql.org/action/patch_view?id=1282 I believe my third patch is what you really want to do... > This rewritten query would be handled by the FDW table that I previously > added to the catalog. > > The reason I want this new hook is t

Re: contrib/cache_scan (Re: [HACKERS] What's needed for cache-only table scan?)

2014-02-12 Thread Kohei KaiGai
2014-02-12 14:59 GMT+09:00 Haribabu Kommi : > I reviewed all the three patches. The first 1 and 2 core PostgreSQL patches > are fine. > And I have comments in the third patch related to cache scan. > Thanks for your volunteering. > 1. +# contrib/dbcache/Makefile > >Makefile header comment is n

Re: [HACKERS] dynamic shared memory and locks

2014-02-10 Thread Kohei KaiGai
2014-02-08 4:52 GMT+09:00 Robert Haas : > On Tue, Jan 21, 2014 at 11:37 AM, Robert Haas wrote: >> One idea I just had is to improve the dsm_toc module so that it can >> optionally set up a tranche of lwlocks for you, and provide some >> analogues of RequestAddinLWLocks and LWLockAssign for that ca

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2014-01-29 Thread Kohei KaiGai
2014-01-29 Christian Convey : > > On Mon, Jan 27, 2014 at 7:14 PM, Kouhei Kaigai wrote: >> >> FDW's join pushing down is one of the valuable use-cases of this >> interface, >> but not all. As you might know, my motivation is to implement GPU >> acceleration >> feature on top of this interface, tha

Re: [HACKERS] dynamic shared memory and locks

2014-01-23 Thread Kohei KaiGai
2014/1/23 Andres Freund : > On 2014-01-23 23:03:40 +0900, Kohei KaiGai wrote: >> Isn't it necessary to have an interface to initialize LWLock structure being >> allocated on a dynamic shared memory segment? >> Even though LWLock structure is exposed at lwlock.h, w

Re: [HACKERS] dynamic shared memory and locks

2014-01-23 Thread Kohei KaiGai
Isn't it necessary to have an interface to initialize LWLock structure being allocated on a dynamic shared memory segment? Even though LWLock structure is exposed at lwlock.h, we have no common way to initialize it. How about to have a following function? void InitLWLock(LWLock *lock) { SpinL

Re: [HACKERS] sepgsql: label regression test failed

2013-12-24 Thread Kohei KaiGai
confined" domain that has different meaning by release. I'll make a patch. Please wait for a while. Thanks for your test & reports. 2013/12/18 Sergey Muraviov : > # semodule -l | grep sepgslq > sepgsql-regtest 1.07 > > Full list of modules is in attachment. > > > 201

Re: [HACKERS] sepgsql: label regression test failed

2013-12-18 Thread Kohei KaiGai
Could you show me semodule -l on your environment? I believe security policy has not been changed between F19 and F20... Thanks, 2013/12/18 Sergey Muraviov : > Hi > > I've tried to test postgres 9.3.2 and 9.4devel with selinux on Fedora 20 and > met with a label regression test failure. > > PS >

Re: [HACKERS] shared memory message queues

2013-12-08 Thread Kohei KaiGai
2013/12/6 Kohei KaiGai : > What will happen if sender tries to send a large chunk that needs to > be split into multiple sub-chunks and receiver concurrently detaches > itself from the queue during the writes by sender? > It seems to me the sender gets SHM_MQ_DETACHED and only >

Re: [HACKERS] shared memory message queues

2013-12-05 Thread Kohei KaiGai
to do so if needed. The * handle must be for a background worker initialized with bgw_notify_pid * equal to our PID. Right now, that's all I can comment on. I'll do follow-up code reading in the weekend. Thanks, 2013/11/20 Robert Haas : > On Tue, Nov 19, 2013 at 12:33 AM, K

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2013-12-04 Thread Kohei KaiGai
Thanks for fixing many my carelessness. I didn't know "seek" was an irregular verb... Best regards, 2013/12/4 Shigeru Hanada : > 2013/11/29 Kohei KaiGai : >> I merged all the propositions from Jim. Thanks, it made the documentation >> quality better. Also, I

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2013-12-04 Thread Kohei KaiGai
Hanada-san, Thanks for your reviewing, 2013/12/4 Shigeru Hanada : > I first reviewed postgres_fdw portion of the patches to learn the > outline of Custom Plan. Wiki page is also a good textbook of the > feature. I have some random comments about the basic design of Custom > Plan: > > (1) IIUC a

Re: [HACKERS] Status of FDW pushdowns

2013-11-21 Thread Kohei KaiGai
2013/11/21 Bruce Momjian : > Where are we on the remaining possible pushdowns for foreign data > wrappers, particularly the Postgres one? I know we do WHERE restriction > pushdowns in 9.3, but what about join and aggregate pushdowns? Is > anyone working on those? > > I know join pushdowns seem in

Re: [HACKERS] shared memory message queues

2013-11-18 Thread Kohei KaiGai
Hello, I tried to look at the patch #1 and #2 at first, but I shall rest of portion later. * basic checks All the patches (not only #1, #2) can be applied without any problem towards the latest master branch. Its build was succeeded with Werror. Regression test works fine on the core and contrib/

Re: [HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
2013/11/12 Tom Lane : > Kohei KaiGai writes: >> So, are you thinking it is a feasible approach to focus on custom-scan >> APIs during the upcoming CF3, then table-caching feature as use-case >> of this APIs on CF4? > > Sure. If you work on this extension after C

Re: [HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
2013/11/12 Tom Lane : > Kohei KaiGai writes: >> 2013/11/12 Tom Lane : >>> There's no possible way you'll finish this for 9.4. > >> Yes, I understand it is not possible to submit whole of the patch until >> CF3 deadline. So, I'd like to find ou

Re: [HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
2013/11/12 Claudio Freire : > On Tue, Nov 12, 2013 at 11:45 AM, Kohei KaiGai wrote: >> Hello, >> >> It is a brief design proposal of a feature I'd like to implement on top of >> custom-scan APIs. Because it (probably) requires a few additional base >> feat

Re: [HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
2013/11/12 Robert Haas : > On Tue, Nov 12, 2013 at 9:45 AM, Kohei KaiGai wrote: >> It is a brief design proposal of a feature I'd like to implement on top of >> custom-scan APIs. Because it (probably) requires a few additional base >> features not only custom-scan, I&#

Re: [HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
2013/11/12 Tom Lane : > Kohei KaiGai writes: >> The cache-only table scan, being in subject line, is an alternative scan >> logic towards sequential scan if all the referenced columns are cached. > > This seems like a pretty dubious idea to me --- you're talking about &g

[HACKERS] What's needed for cache-only table scan?

2013-11-12 Thread Kohei KaiGai
Hello, It is a brief design proposal of a feature I'd like to implement on top of custom-scan APIs. Because it (probably) requires a few additional base features not only custom-scan, I'd like to see feedback from the hackers. The cache-only table scan, being in subject line, is an alternative sc

Re: Custom Scan APIs (Re: [HACKERS] Custom Plan node)

2013-11-11 Thread Kohei KaiGai
Hi, I tried to write up a wikipage to introduce how custom-scan works. https://wiki.postgresql.org/wiki/CustomScanAPI Any comments please. 2013/11/6 Kohei KaiGai : > The attached patches provide a feature to implement custom scan node > that allows extension to replace a part of plan tre

[HACKERS] Re: Exempting superuser from row-security isn't enough. Run predicates as DEFINER?

2013-11-11 Thread Kohei KaiGai
Hi Craig, I'd like to vote the last options. It is a separate problem (or, might be specification), I think. According to the document of view, http://www.postgresql.org/docs/devel/static/sql-createview.html | Access to tables referenced in the view is determined by permissions of | the view own

Re: [HACKERS] [v9.4] row level security

2013-11-06 Thread Kohei KaiGai
2013/11/6 Craig Ringer : > On 11/05/2013 09:36 PM, Robert Haas wrote: >> I haven't studied this patch in detail, but I see why there's some >> unhappiness about that code: it's an RLS-specific kluge. Just >> shooting from the hip here, maybe we should attack the problem of >> making security-barri

Re: [HACKERS] How should row-security affects ON UPDATE RESTRICT / CASCADE ?

2013-10-29 Thread Kohei KaiGai
2013/10/30 Craig Ringer : > On 10/30/2013 10:50 AM, Tom Lane wrote: >> Craig Ringer writes: >>> > I'd kind of like to see FK constraints affected by RLS for >>> > non-superusers, at least as an option. >> I think that's a complete nonstarter. Aside from the fact that such a >> constraint will hav

Re: [HACKERS] How should row-security affects ON UPDATE RESTRICT / CASCADE ?

2013-10-29 Thread Kohei KaiGai
2013/10/29 Tom Lane : > Craig Ringer writes: >> During my testing of Kohei KaiGai's row-security patches I've been >> looking into how foreign keys should be and are handled. There are some >> interesting wrinkles around FK cascades, the rights under which FK >> checks execute, and about the consi

  1   2   3   4   5   6   >