Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-21 Thread Julien Tachoires
On 20/03/2015 00:33, Andreas Karlsson wrote: > On 03/19/2015 04:55 PM, Julien Tachoires wrote: >> On 18/03/2015 19:54, Andreas Karlsson wrote: >>> Looks good but I think one minor improvement could be to set the table >>> space of the toast entires to the same as the

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-19 Thread Julien Tachoires
On 18/03/2015 19:54, Andreas Karlsson wrote: > On 03/17/2015 09:00 AM, Julien Tachoires wrote: >> Here is a new version fixing this issue. I've added a new kind of TOC >> entry for being able to handle pg_restore --no-tablespace case. > > Looks good but I think one min

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-17 Thread Julien Tachoires
On 15/03/2015 20:27, Julien Tachoires wrote: > On 15/03/2015 04:34, Andreas Karlsson wrote: >> On 03/15/2015 04:25 AM, Andreas Karlsson wrote: >>> Nice. You will also want to apply the attached patch which fixes support >>> for the --no-tablespaces flag. >> >&

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-15 Thread Julien Tachoires
On 15/03/2015 04:34, Andreas Karlsson wrote: > On 03/15/2015 04:25 AM, Andreas Karlsson wrote: >> Nice. You will also want to apply the attached patch which fixes support >> for the --no-tablespaces flag. > > Just realized that --no-tablespaces need to be fixed for pg_restore too. Indeed, after t

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Julien Tachoires
On 14/03/2015 16:10, Andreas Karlsson wrote: > Noticed a bug when playing round some more with pg_dump. It does not > seem to dump custom table space for the table and default table space > for the toast correctly. It forgets about the toast table being in > pg_default. Good catch. This is now

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-13 Thread Julien Tachoires
Hi, On 10/03/2015 00:31, Andreas Karlsson wrote: > On 03/03/2015 04:14 PM, Julien Tachoires wrote: >> Sorry for the delay, I missed this thread. >> Here is a new version of this patch considering Andreas' comments. > > Please also add it to the next open commitfest s

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-12 Thread Julien Tachoires
On 10/03/2015 13:27, Alvaro Herrera wrote: > Robert Haas wrote: >> On Mon, Mar 9, 2015 at 7:26 PM, Andreas Karlsson wrote: > >>> I think we should allow moving the indexes for consistency. With this patch >>> we can move everything except for TOAST indexes. >> >> It might make sense to always put

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-03 Thread Julien Tachoires
Hi, Sorry for the delay, I missed this thread. Here is a new version of this patch considering Andreas' comments. On 30/12/2014 03:48, Andreas Karlsson wrote: > - A test fails in create_view.out. I looked some into it and did not see > how this could happen. > > *** > /home/andreas/dev/po

[HACKERS] Rowtype column and domain subfield with DEFAULT and NOT NULL constraint

2014-03-12 Thread Julien Tachoires
there is no DEFAULT the parser/rewriter should set the column/subfield to NULL. Is build_column_default() the right place to handle that case ? -- Julien Tachoires http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Improving psql \ds

2012-10-08 Thread Julien Tachoires
2012/10/8 Tom Lane : > Julien Tachoires writes: >> 2012/10/8 Tom Lane : >>> The other problem you're going to have here is that there is in fact no >>> such command as "\ds" (nor "\ds+"); rather, it's a special case of >>> \dts

Re: [HACKERS] Improving psql \ds

2012-10-08 Thread Julien Tachoires
2012/10/8 Robert Haas : > On Mon, Oct 8, 2012 at 3:49 AM, Julien Tachoires wrote: >> 2012/10/8 Tom Lane : >>> Julien Tachoires writes: >>>> About \ds behaviour, I think to add 2 columns : >>>> - 'LastValue' >>>> - 'Increme

Re: [HACKERS] Improving psql \ds

2012-10-08 Thread Julien Tachoires
2012/10/8 Tom Lane : > Julien Tachoires writes: >> About \ds behaviour, I think to add 2 columns : >> - 'LastValue' >> - 'Increment' > > That would make the command a great deal slower, since it would have to > access each sequence to get that inf

[HACKERS] Improving psql \ds

2012-10-07 Thread Julien Tachoires
Hi, I would like to work on psql \ds improvements. Here's my idea : - in src/bin/psql/describe.c, add a new function : listSequences(*pattern, verbose) wich will list sequences and remove code related to sequences from listTables() - in src/bin/psql/command.c, call listSequences() on \ds - about l

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2012-01-25 Thread Julien Tachoires
2012/1/24 Robert Haas : > On Sun, Jan 22, 2012 at 11:04 AM, Julien Tachoires wrote: >> 2011/12/15 Alvaro Herrera : >>> >>> Uhm, surely you could compare the original toast tablespace to the heap >>> tablespace, and if they differ, handle appropriately when cre

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2012-01-16 Thread Julien Tachoires
Hi, 2012/1/16 Alvaro Herrera : > > Excerpts from Jaime Casanova's message of lun ene 16 03:23:30 -0300 2012: >> On Tue, Dec 13, 2011 at 12:29 PM, Julien Tachoires wrote: >> > >> > OK, considering that, I don't see any way to handle the case raised by &

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2011-12-13 Thread Julien Tachoires
2011/12/13 Robert Haas : > On Tue, Dec 13, 2011 at 12:02 PM, Julien Tachoires wrote: >> Right, it seems to happen when the destination tablespace is the same >> as the database's tbs, because, in this case, relation's tbs is set to >> InvalidOid : >> src/b

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2011-12-13 Thread Julien Tachoires
2011/12/13 Jaime Casanova : > On Mon, Dec 12, 2011 at 10:54 AM, Julien Tachoires wrote: >> 2011/12/10 Jaime Casanova : >>> On Mon, Nov 28, 2011 at 1:32 PM, Julien Tachoires wrote: >>> >>>>> 2) after CLUSTER the index of the toast table gets moved to t

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2011-12-12 Thread Julien Tachoires
Hi, 2011/12/10 Jaime Casanova : > On Mon, Nov 28, 2011 at 1:32 PM, Julien Tachoires wrote: > >>> 2) after CLUSTER the index of the toast table gets moved to the same >>> tablespace as the main table >> > > there is still a variant of this one, i

[HACKERS] patch : Allow toast tables to be moved to a different tablespace

2011-10-07 Thread Julien Tachoires
Hi, Here's a patch to allow TOAST tables to be moved to a different tablespace. This item has been picked up from the TODO list. Main idea is to consider that a TOAST table can have its own tablespace. Regards, -- JT diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_tabl