Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Michael Paquier
On Fri, Apr 22, 2016 at 1:30 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 04/21/2016 05:15 PM, Tom Lane wrote: >>> Do the other contrib modules all pass? I can't recall if seg was the >>> only one we'd left like this. > >> Only seg fails. > > As a crosscheck, I put some code into fmgr_c_va

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Michael Paquier
On Fri, Apr 22, 2016 at 4:39 AM, Andrew Dunstan wrote: > On 04/11/2016 03:47 AM, Michael Paquier wrote: >> On Mon, Apr 11, 2016 at 3:25 PM, Michael Paquier >> wrote: >>> >>> Now, I have produced two patches: >>> - 0001-Support-for-VS-2015-locale-hack.patch, which makes use of >>> __crt_locale_dat

Re: [HACKERS] GIN data corruption bug(s) in 9.6devel

2016-04-21 Thread Noah Misch
On Mon, Apr 18, 2016 at 05:48:17PM +0300, Teodor Sigaev wrote: > >>Added, see attached patch (based on v3.1) > > > >With this applied, I am getting a couple errors I have not seen before > >after extensive crash recovery testing: > >ERROR: attempted to delete invisible tuple > >ERROR: unexpected

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Amit Kapila
On Fri, Apr 22, 2016 at 1:31 AM, Gavin Flower wrote: > On 22/04/16 06:07, Robert Haas wrote: > >> On Thu, Apr 21, 2016 at 1:48 PM, Tom Lane wrote: >> >>> Robert Haas writes: >>> On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: > Andres Freund writes: > >> max_parallel_de

Re: [HACKERS] Fix of doc for synchronous_standby_names.

2016-04-21 Thread Kyotaro HORIGUCHI
I came to think that both of you are misunderstanding how synchronous standbys are choosed so I'd like to clarify the behavior. At Fri, 22 Apr 2016 11:09:28 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20160422.110928.18809311.horiguchi.kyot...@lab.ntt.co.jp> > > > But this particul

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Michael Paquier
On Fri, Apr 22, 2016 at 4:56 AM, Christian Ullrich wrote: > * From: Andrew Dunstan [mailto:and...@dunslane.net] > >> 4. The compiler complains about one of Microsoft's own header files - >> essentially it dislikes the=is construct: >> >> typedef enum { ... }; >> >> It would be nice to make it

Re: [HACKERS] kqueue

2016-04-21 Thread Andres Freund
On 2016-04-21 14:25:06 -0400, Robert Haas wrote: > On Thu, Apr 21, 2016 at 2:22 PM, Andres Freund wrote: > > On 2016-04-21 14:15:53 -0400, Robert Haas wrote: > >> On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro > >> wrote: > >> > On the WaitEventSet thread I posted a small patch to add kqueue > >>

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Tom Lane
Andrew Dunstan writes: > On 04/21/2016 05:15 PM, Tom Lane wrote: >> Do the other contrib modules all pass? I can't recall if seg was the >> only one we'd left like this. > Only seg fails. As a crosscheck, I put some code into fmgr_c_validator() to log a message when creating a V0 function with

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Andrew Dunstan
On 04/21/2016 05:15 PM, Tom Lane wrote: IIRC, we had intentionally left contrib/seg using mostly V0 calling convention as a canary to let us know when that broke. It's a bit astonishing that it lasted this long, maybe. But it looks like we're going to have to convert at least the bool-return

[HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-21 Thread Peter Geoghegan
Postgres 9.6 saw the performance characteristics of sorting significantly altered. While almost every external sort will see a benefit without any change in configuration, there is a new scope for DBAs to tune the system to better take advantage of the improved implementation of external sorting. T

[HACKERS] Missing lookup in msvcr120 for pgwin32_putenv

2016-04-21 Thread Michael Paquier
Hi all, While looking at e545281 I bumped into the following thing that has visibly been forgotten since VS2013 support has been added: --- a/src/port/win32env.c +++ b/src/port/win32env.c @@ -67,6 +67,9 @@ pgwin32_putenv(const char *envval) "msvcr110", 0, NULL },

Re: [HACKERS] Dead code in win32.h

2016-04-21 Thread Michael Paquier
On Fri, Apr 22, 2016 at 4:52 AM, Tom Lane wrote: > I wrote: >> Perhaps I'm missing something, but if so, in what way is the >> "#if _MSC_VER >= 1600" stanza not totally useless given the >> immediately preceding macro redefinitions? > > Some rummaging in the git history says that that stanza did s

Re: [HACKERS] Should XLogInsert() be done only inside a critical section?

2016-04-21 Thread Michael Paquier
On Fri, Apr 22, 2016 at 5:18 AM, Alvaro Herrera wrote: > Michael Paquier wrote: >> On Thu, Apr 21, 2016 at 5:44 AM, Tom Lane wrote: >> > Anyway, I went through our tree and added START/END_CRIT_SECTION calls >> > around all XLogInsert calls that could currently be reached without one; >> > see at

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-21 Thread Etsuro Fujita
On 2016/04/22 9:22, Michael Paquier wrote: On Thu, Apr 21, 2016 at 11:53 PM, Robert Haas wrote: I have committed this patch. Thanks for working on this. Sorry for the delay. Thanks for the push. open_item--; Thank you, Robert and Michael. Best regards, Etsuro Fujita -- Sent via pgsq

Re: [HACKERS] Fix of doc for synchronous_standby_names.

2016-04-21 Thread Kyotaro HORIGUCHI
I'm not so confident on me but, please let me continue on this a bit more for my understanding. At Thu, 21 Apr 2016 13:33:23 -0400, Robert Haas wrote in > On Thu, Apr 21, 2016 at 1:01 AM, Amit Langote > wrote: > > ISTM, the sentence describes what happens in a *single instance* of > > encounte

Re: [HACKERS] pg_stat_activity crashes

2016-04-21 Thread Kyotaro HORIGUCHI
At Thu, 21 Apr 2016 14:05:28 -0400, Robert Haas wrote in > >>> Here is PoC patch which fixes the problem. I am wondering if we should > >>> raise warning in the pg_stat_get_backend_wait_event_type() and > >>> pg_stat_get_backend_wait_event() like the pg_signal_backend() does > >>> when proc is N

Re: [HACKERS] Disallow unique index on system columns

2016-04-21 Thread Eric Ridge
On Wed, Apr 20, 2016 at 9:24 PM Tom Lane wrote: > > SELECT FROM table WHERE my_func('table', ctid) ==> 'index condition' > > Um, why's the ctid important here, or perhaps more directly, what is > it you're really trying to do? > This function is defined as my_func(regclass, tid) and simply

Re: [HACKERS] more parallel query documentation

2016-04-21 Thread Amit Langote
On 2016/04/15 12:02, Robert Haas wrote: > As previously threatened, I have written some user documentation for > parallel query. I put it up here: > > https://wiki.postgresql.org/wiki/Parallel_Query > > This is not totally comprehensive and I can think of a few more > details that could be added

Re: [HACKERS] EXPLAIN VERBOSE with parallel Aggregate

2016-04-21 Thread David Rowley
On 21 April 2016 at 17:14, Tom Lane wrote: > David Rowley writes: >> I'd like to admit that I'm a bit confused as to why >> generate_function_name(), when it already knows the funcid, bothers to >> call func_get_detail(), which performs a search for the function based >> on the name and argument

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-21 Thread Michael Paquier
On Thu, Apr 21, 2016 at 11:53 PM, Robert Haas wrote: > On Thu, Apr 21, 2016 at 8:44 AM, Michael Paquier > wrote: >> On Thu, Apr 21, 2016 at 5:22 PM, Etsuro Fujita >> wrote: >>> Attached is an updated version of the patch, which modified Michael's >>> version of the patch, as I proposed in [1] (s

Re: [HACKERS] [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-21 Thread Tom Lane
Peter Eisentraut writes: > On 04/19/2016 04:48 PM, Tom Lane wrote: >> Pushed. Peter, what results do you get from these tests on your >> problematic machine? > acosd(x), > acosd(x) IN (0,60,90,120,180) AS acosd_exact > FROM (VALUES (-1), (-0.5), (0), (0.5), (1)) AS t(x); > - x

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Tom Lane
Robert Haas writes: > On Thu, Apr 21, 2016 at 4:01 PM, Gavin Flower > wrote: >> Why not 4? As most processors now have at least 4 physical cores, & surely >> it be more likely to flush out race conditions. > Because if we did that, then it's extremely likely that people would > end up writing q

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 4:01 PM, Gavin Flower wrote: > On 22/04/16 06:07, Robert Haas wrote: >> >> On Thu, Apr 21, 2016 at 1:48 PM, Tom Lane wrote: >>> >>> Robert Haas writes: On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: > > Andres Freund writes: >> >> max_paralle

[HACKERS] Incomplete description for \t in psql documentation - should mention caption

2016-04-21 Thread David G. Johnston
​​http://www.postgresql.org/docs/9.5/interactive/app-psql.html """ \t Toggles the display of output column name headings and row count footer. This command is equivalent to \pset tuples_only and is provided for convenience. """ Experience says that a table caption (i.e., \C) is also suppressed wh

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Tom Lane
Andrew Dunstan writes: > 5. most importantly, on my Release/X64 build, I am getting a regression > failure on contrib/seg. regression diffs attached. Until that's fixed > this isn't going anywhere. I'll bet a nickel that this means MSVC has broken the ABI rules that allowed old-style (version 0

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 2:10 PM, Ants Aasma wrote: > On Thu, Apr 21, 2016 at 5:16 PM, Kevin Grittner wrote: >> Could you provide enough to make that a self-contained >> reproducible test case [?] > [provided] Thanks! I have your test case running, and it is not immediately clear why old rows

Re: [HACKERS] Should XLogInsert() be done only inside a critical section?

2016-04-21 Thread Alvaro Herrera
Michael Paquier wrote: > On Thu, Apr 21, 2016 at 5:44 AM, Tom Lane wrote: > > Anyway, I went through our tree and added START/END_CRIT_SECTION calls > > around all XLogInsert calls that could currently be reached without one; > > see attached. Since this potentially breaks third-party code I woul

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Gavin Flower
On 22/04/16 06:07, Robert Haas wrote: On Thu, Apr 21, 2016 at 1:48 PM, Tom Lane wrote: Robert Haas writes: On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: Andres Freund writes: max_parallel_degree currently defaults to 0. I think we should enable it by default for at least the beta peri

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Christian Ullrich
* From: Andrew Dunstan [mailto:and...@dunslane.net] > 4. The compiler complains about one of Microsoft's own header files - > essentially it dislikes the=is construct: > > typedef enum { ... }; > > It would be nice to make it shut up about it. I doubt that's possible; the declaration *is* w

Re: [HACKERS] kqueue

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 3:31 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> On Thu, Apr 21, 2016 at 2:22 PM, Andres Freund wrote: >> > On 2016-04-21 14:15:53 -0400, Robert Haas wrote: >> >> On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro >> >> wrote: >> >> > On the WaitEventSet thread I posted

Re: [HACKERS] Dead code in win32.h

2016-04-21 Thread Tom Lane
I wrote: > Perhaps I'm missing something, but if so, in what way is the > "#if _MSC_VER >= 1600" stanza not totally useless given the > immediately preceding macro redefinitions? Some rummaging in the git history says that that stanza did something when it was added (in 63876d3ba), but the later c

Re: [HACKERS] [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-21 Thread Peter Eisentraut
On 04/19/2016 04:48 PM, Tom Lane wrote: > Pushed. Peter, what results do you get from these tests on your > problematic machine? acosd(x), acosd(x) IN (0,60,90,120,180) AS acosd_exact FROM (VALUES (-1), (-0.5), (0), (0.5), (1)) AS t(x); - x | asind | asind_exact | acosd | acos

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-21 Thread Andrew Dunstan
On 04/11/2016 03:47 AM, Michael Paquier wrote: On Mon, Apr 11, 2016 at 3:25 PM, Michael Paquier wrote: Now, I have produced two patches: - 0001-Support-for-VS-2015-locale-hack.patch, which makes use of __crt_locale_data_public in ucrt/corecrt.h. This is definitely an ugly hack, though I am co

Re: [HACKERS] kqueue

2016-04-21 Thread Alvaro Herrera
Robert Haas wrote: > On Thu, Apr 21, 2016 at 2:22 PM, Andres Freund wrote: > > On 2016-04-21 14:15:53 -0400, Robert Haas wrote: > >> On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro > >> wrote: > >> > On the WaitEventSet thread I posted a small patch to add kqueue > >> > support[1]. Since then I pe

[HACKERS] Dead code in win32.h

2016-04-21 Thread Tom Lane
src/include/port/win32.h contains (starting around line 270): /* * Supplement to . */ #undef EAGAIN #undef EINTR #define EINTR WSAEINTR #define EAGAIN WSAEWOULDBLOCK #undef EMSGSIZE #define EMSGSIZE WSAEMSGSIZE #undef EAFNOSUPPORT #define EAFNOSUPPORT WSAEAFNOSUPPORT #undef EWOULDBLOCK #define

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-21 Thread Ants Aasma
On Thu, Apr 21, 2016 at 5:16 PM, Kevin Grittner wrote: > On Wed, Apr 20, 2016 at 8:08 PM, Ants Aasma wrote: > >> However, while checking out if my proof of concept patch actually >> works I hit another issue. I couldn't get my test for the feature to >> actually work. The test script I used is at

Re: [HACKERS] Wire protocol change

2016-04-21 Thread Tom Lane
Tatsuo Ishii writes: > If we are going to change the wire protocol, it would be nice if parse > complete message includes an identification of the previous parse > message. Same thing can be said to bind complete, command complete and > close complete. > The identification could be an either sequ

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Tom Lane
Kevin Grittner writes: > No joy with that shot in the dark. > Should I add PGDLLEXPORT to the declaration of > old_snapshot_threshold. That doesn't seem to be documented > anywhere, or have any useful comments; but it looks like it *might* > be the arcane incantation needed here. PGDLLIMPORT is

Re: [HACKERS] Reducing the size of BufferTag & remodeling forks

2016-04-21 Thread Andres Freund
On 2016-04-19 15:44:36 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > > I've actually changed course a bit and I'm trying something different: A > > two level structure. One hashtable that maps (RelFileNode, ForkNumber) > > to a 'open relation' data structure, and from there a radix tree

Re: [HACKERS] kqueue

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 2:22 PM, Andres Freund wrote: > On 2016-04-21 14:15:53 -0400, Robert Haas wrote: >> On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro >> wrote: >> > On the WaitEventSet thread I posted a small patch to add kqueue >> > support[1]. Since then I peeked at how some other software

Re: [HACKERS] kqueue

2016-04-21 Thread Andres Freund
On 2016-04-21 14:15:53 -0400, Robert Haas wrote: > On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro > wrote: > > On the WaitEventSet thread I posted a small patch to add kqueue > > support[1]. Since then I peeked at how some other software[2] > > interacts with kqueue and discovered that there are p

Re: [HACKERS] checkpoint_flush_after documentation inconsistency

2016-04-21 Thread Andres Freund
On 2016-04-18 14:33:28 +0900, Fujii Masao wrote: > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander wrote: > > The documentation says that the default value is 128Kb on Linux, but the > > code says it's 256Kb. > > > > Not sure which one is correct, but the other one should be updated :) I'm > > gu

Re: [HACKERS] kqueue

2016-04-21 Thread Robert Haas
On Tue, Mar 29, 2016 at 7:53 PM, Thomas Munro wrote: > On the WaitEventSet thread I posted a small patch to add kqueue > support[1]. Since then I peeked at how some other software[2] > interacts with kqueue and discovered that there are platforms > including NetBSD where kevent.udata is an intptr

Re: [HACKERS] [BUGS] Breakage with VACUUM ANALYSE + partitions

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 9:45 AM, Andres Freund wrote: >> My attempts to test things were also singularly unrewarding. Even >> after messing with the filesystem in various ways, I couldn't figure >> out exactly how this makes a difference. > > What do you mean by this? You couldn't reproduce the b

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 1:48 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: >>> Andres Freund writes: max_parallel_degree currently defaults to 0. I think we should enable it by default for at least the beta period. Otherwise we're prima

Re: [HACKERS] pg_stat_activity crashes

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 2:04 PM, Robert Haas wrote: > On Wed, Apr 20, 2016 at 10:56 PM, Kyotaro HORIGUCHI > wrote: >> At Wed, 20 Apr 2016 15:14:16 +0200, Petr Jelinek >> wrote in <571780a8.4070...@2ndquadrant.com> >>> I noticed sporadic segfaults when selecting from pg_stat_activity on >>> curr

Re: [HACKERS] pg_stat_activity crashes

2016-04-21 Thread Robert Haas
On Wed, Apr 20, 2016 at 10:56 PM, Kyotaro HORIGUCHI wrote: > At Wed, 20 Apr 2016 15:14:16 +0200, Petr Jelinek wrote > in <571780a8.4070...@2ndquadrant.com> >> I noticed sporadic segfaults when selecting from pg_stat_activity on >> current HEAD. >> >> The culprit is the 53be0b1add7064ca5db3cd8843

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 11:58 AM, Kevin Grittner wrote: > On Thu, Apr 21, 2016 at 9:58 AM, Kevin Grittner wrote: >> On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner >> wrote: >>> Inline initial comparisons in TestForOldSnapshot() >> >> This seems to have broken Windows builds. Is there somethin

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Tom Lane
Robert Haas writes: > On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: >> Andres Freund writes: >>> max_parallel_degree currently defaults to 0. I think we should enable >>> it by default for at least the beta period. Otherwise we're primarily >>> going to get reports back after the release. >

Re: [HACKERS] [BUGS] Breakage with VACUUM ANALYSE + partitions

2016-04-21 Thread Andres Freund
On 2016-04-15 13:42:34 -0400, Robert Haas wrote: > On Thu, Apr 14, 2016 at 1:39 AM, Abhijit Menon-Sen > wrote: > > At 2016-04-12 09:00:57 -0400, robertmh...@gmail.com wrote: > >> > >> On Mon, Apr 11, 2016 at 1:17 PM, Andres Freund wrote: > >> > > >> > 3) Actually handle the case of the last open

Re: [HACKERS] Description of ForeignPath

2016-04-21 Thread Amit Langote
On Fri, Apr 22, 2016 at 2:32 AM, Robert Haas wrote: > On Wed, Apr 20, 2016 at 3:37 AM, Amit Langote wrote: >>> I think it'd be better to match the comment with that for >>> create_foreignscan_path(). So how about "ForeignPath represents a >>> potential scan of a foreign table, foreign join, or fo

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-04-21 Thread Robert Haas
On Wed, Apr 20, 2016 at 2:28 PM, Tom Lane wrote: > Andres Freund writes: >> max_parallel_degree currently defaults to 0. I think we should enable >> it by default for at least the beta period. Otherwise we're primarily >> going to get reports back after the release. > >> Then, at the end of beta

Re: [HACKERS] Fix of doc for synchronous_standby_names.

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 1:01 AM, Amit Langote wrote: > ISTM, the sentence describes what happens in a *single instance* of > encountering duplicate (same name found in primary_conninfo of 2 or more > standbys). It's still one name but which of the standbys claims the spot > (for that name) of bei

Re: [HACKERS] Description of ForeignPath

2016-04-21 Thread Robert Haas
On Wed, Apr 20, 2016 at 3:37 AM, Amit Langote wrote: >> I think it'd be better to match the comment with that for >> create_foreignscan_path(). So how about "ForeignPath represents a >> potential scan of a foreign table, foreign join, or foreign upper-relation >> processing"? I think we would pr

Re: [HACKERS] [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche.

2016-04-21 Thread Robert Haas
On Mon, Apr 11, 2016 at 7:31 AM, Andres Freund wrote: > In the patch attached to > http://www.postgresql.org/message-id/20160411051004.yvniqb2pkc7re...@alap3.anarazel.de > I did this instead by fixing up the actual shared memory allocation, > which seems a tiny bit cleaner. I don't really find t

Re: [HACKERS] Defaults for replication/backup

2016-04-21 Thread Robert Haas
On Wed, Apr 20, 2016 at 2:04 PM, Magnus Hagander wrote: > So what more do we need to just get going with this? Given feature freeze > we're perhaps too late to actually build the parameter feature for initdb, > but we could still change the defaults (and then we could add such a > parameter for ne

Re: [HACKERS] Parser extensions (maybe for 10?)

2016-04-21 Thread Robert Haas
On Tue, Apr 19, 2016 at 10:05 AM, Andres Freund wrote: > On 2016-04-19 15:32:07 +0300, Aleksander Alekseev wrote: >> > As Tom says, we can't easily break it down into multiple co-operating >> > pieces, so lets forget that as unworkable. >> >> I'm sorry but didn't I just demonstrate the opposite? >

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 9:58 AM, Kevin Grittner wrote: > On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner > wrote: >> Inline initial comparisons in TestForOldSnapshot() > > This seems to have broken Windows builds. Is there something > special that needs to be done if a function referenced from

Re: [HACKERS] Query Procedures

2016-04-21 Thread David G. Johnston
On Thu, Apr 21, 2016 at 8:26 AM, Andrea Adami wrote: > > Hello, i'm a developer from italy and i need to make a query to get the > list of stored procedures with its signature. > Basically I would like to get the same list pgAdmin shows under the node > functions of the database tree on left pane

[HACKERS] Wire protocol change

2016-04-21 Thread Tatsuo Ishii
If we are going to change the wire protocol, it would be nice if parse complete message includes an identification of the previous parse message. Same thing can be said to bind complete, command complete and close complete. The identification could be an either sequence number assigned to the pars

[HACKERS] Query Procedures

2016-04-21 Thread Andrea Adami
Hello, i'm a developer from italy and i need to make a query to get the list of stored procedures with its signature. Basically I would like to get the same list pgAdmin shows under the node functions of the database tree on left panel. with the query : p.oid AS SELECT oid , p.proname AS name , p.p

Re: [HACKERS] [PATCH] Phrase search ported to 9.6

2016-04-21 Thread Dmitry Ivanov
There are some previously unnoticed errors in docs (master branch), this patch fixes them. -- Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Companydiff --git a/doc/src/sgml/textsearch.sgml b/doc/src/sgml/textsearch.sgml index 930c8f0..78eaf74 100644 --- a/doc/s

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner wrote: > Inline initial comparisons in TestForOldSnapshot() This seems to have broken Windows builds. Is there something special that needs to be done if a function referenced from a contrib module changes to an inline function? -- Kevin Grittner

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-21 Thread Robert Haas
On Thu, Apr 21, 2016 at 8:44 AM, Michael Paquier wrote: > On Thu, Apr 21, 2016 at 5:22 PM, Etsuro Fujita > wrote: >> Attached is an updated version of the patch, which modified Michael's >> version of the patch, as I proposed in [1] (see "Other changes:"). I >> modified comments for pgfdw_get_re

Re: [HACKERS] Why doesn't src/backend/port/win32/socket.c implement bind()?

2016-04-21 Thread Tom Lane
I wrote: > Michael Paquier writes: >> And this gives the patch attached, just took the time to hack it. > I think this is a good idea, but (1) I'm inclined not to restrict it to > Windows, and (2) I think we should hold off applying it until we've seen > a failure or two more, and can confirm whe

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-21 Thread Kevin Grittner
On Wed, Apr 20, 2016 at 8:08 PM, Ants Aasma wrote: > However, while checking out if my proof of concept patch actually > works I hit another issue. I couldn't get my test for the feature to > actually work. The test script I used is attached. Could you provide enough to make that a self-containe

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Andreas Karlsson
On 04/21/2016 03:04 PM, Aleksander Alekseev wrote: I guess since the usual answer for compression was "use what SSL provides you for free", it's rather unlikely that someone bothered to make a proxy just for that purpose, and really, a proxy is just another moving part in your setup: not everyone

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Tom Lane
Craig Ringer writes: > On 21 April 2016 at 14:19, Shay Rojansky wrote: >> There are potentially huge bandwidth savings which could benefit both WAN >> and non-WAN scenarios, and decoupling this problem from TLS would make it >> both accessible to everyone (assuming PostgreSQL clients follow). It

Re: [HACKERS] snapshot too old, configured by time

2016-04-21 Thread Kevin Grittner
On Wed, Apr 20, 2016 at 8:50 AM, Kevin Grittner wrote: > In case anyone notices some code left at the bottom of bufmgr.h > related to inline functions, that was left on purpose, because I am > pretty sure that the fix for the performance regression observed > when the "snapshot too old" feature i

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Craig Ringer
On 21 April 2016 at 14:19, Shay Rojansky wrote: > Does it make sense to you guys to discuss compression outside of TLS? > Yes. > There are potentially huge bandwidth savings which could benefit both WAN > and non-WAN scenarios, and decoupling this problem from TLS would make it > both accessi

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Shulgin, Oleksandr
On Thu, Apr 21, 2016 at 3:17 PM, Aleksander Alekseev < a.aleks...@postgrespro.ru> wrote: > > > or on Linux TCP/IP stack level. > > > > > > > Yes, but if you want to have both compression and encryption it is > > crucial to apply compression *before* encryption and I don't see how > > this can happ

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Aleksander Alekseev
> > or on Linux TCP/IP stack level. > > > > Yes, but if you want to have both compression and encryption it is > crucial to apply compression *before* encryption and I don't see how > this can happen with this approach. If I'm not mistaken IPSec gives you both compression and encryption. Just as

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Shulgin, Oleksandr
On Thu, Apr 21, 2016 at 3:04 PM, Aleksander Alekseev < a.aleks...@postgrespro.ru> wrote: > > I guess since the usual answer for compression was "use what SSL > > provides you for free", it's rather unlikely that someone bothered to > > make a proxy just for that purpose, and really, a proxy is jus

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Aleksander Alekseev
> I guess since the usual answer for compression was "use what SSL > provides you for free", it's rather unlikely that someone bothered to > make a proxy just for that purpose, and really, a proxy is just > another moving part in your setup: not everyone will be thrilled to > add that. It just doe

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-21 Thread Michael Paquier
On Thu, Apr 21, 2016 at 5:22 PM, Etsuro Fujita wrote: > Attached is an updated version of the patch, which modified Michael's > version of the patch, as I proposed in [1] (see "Other changes:"). I > modified comments for pgfdw_get_result/pgfdw_exec_query also, mainly because > words like "non-blo

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Shulgin, Oleksandr
On Thu, Apr 21, 2016 at 11:07 AM, Aleksander Alekseev < a.aleks...@postgrespro.ru> wrote: > > Does it make sense to you guys to discuss compression outside of TLS? > > There are potentially huge bandwidth savings which could benefit both > > WAN and non-WAN scenarios, and decoupling this problem f

Re: [HACKERS] Timeline following for logical slots

2016-04-21 Thread Alvaro Herrera
Noah Misch wrote: > The above-described topic is currently a PostgreSQL 9.6 open item. Alvaro, > since you committed the patch believed to have created it, you own this open > item. If that responsibility lies elsewhere, please let us know whose > responsibility it is to fix this. Since new ope

Re: [HACKERS] Wire protocol compression

2016-04-21 Thread Aleksander Alekseev
> Does it make sense to you guys to discuss compression outside of TLS? > There are potentially huge bandwidth savings which could benefit both > WAN and non-WAN scenarios, and decoupling this problem from TLS would > make it both accessible to everyone (assuming PostgreSQL clients > follow). It wo

Re: [HACKERS] "parallel= " information is not coming in pg_dumpall for create aggregate

2016-04-21 Thread tushar
On 04/21/2016 08:36 AM, Robert Haas wrote: Nice catch, Tushar. Thanks for the patch, Fabrízio. Committed. Thanks, Verified against the latest sources of PG9.6 - issue has been fixed now. -- regards,tushar -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make change

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-21 Thread Etsuro Fujita
On 2016/04/19 14:25, Etsuro Fujita wrote: On 2016/04/19 13:59, Michael Paquier wrote: But huge objection to that because this fragilizes the current logic postgres_fdw is based on: PQexec returns the last result to caller, I'd rather not break that logic for 9.6 stability's sake. IIUC, I thin