Re: [HACKERS] PATCH: nbklno in _hash_splitbucket unused (after ed9cc2b)

2015-04-04 Thread Tomas Vondra
On 04/05/15 01:26, Petr Jelinek wrote: On 05/04/15 01:03, Tomas Vondra wrote: Hi there, the changes in _hash_splitbucket() made nblkno unused when compiled without asserts. Attached is a simple fix to get rid of the warnings. This has been already fixed, see b7e1652d5 . D'oh! Sorry for the

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-04-04 Thread Tomas Vondra
Hi, On 04/03/15 15:46, Greg Stark wrote: > The simple workaround for this was adding a fallback to GEE when f[1] or f[2] is 0. GEE is another estimator described in the paper, behaving much better in those cases. For completeness, what's the downside in just always using GEE? That's a good q

Re: [HACKERS] PATCH: nbklno in _hash_splitbucket unused (after ed9cc2b)

2015-04-04 Thread Petr Jelinek
On 05/04/15 01:03, Tomas Vondra wrote: Hi there, the changes in _hash_splitbucket() made nblkno unused when compiled without asserts. Attached is a simple fix to get rid of the warnings. This has been already fixed, see b7e1652d5 . -- Petr Jelinek http://www.2ndQuadrant.co

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-04 Thread Jeff Janes
On Sat, Apr 4, 2015 at 3:10 PM, Jim Nasby wrote: > On 4/3/15 12:59 AM, Sawada Masahiko wrote: > >> + case HEAPTUPLE_LIVE: >> + case HEAPTUPLE_RECENTLY_DEAD: >> + case HEAPTUPLE_INSERT_IN_PROGRESS: >> +

[HACKERS] PATCH: nbklno in _hash_splitbucket unused (after ed9cc2b)

2015-04-04 Thread Tomas Vondra
Hi there, the changes in _hash_splitbucket() made nblkno unused when compiled without asserts. Attached is a simple fix to get rid of the warnings. regards Tomas diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index 9a77945..e32c4fc 100644 --- a/src/backend

Re: [HACKERS] COALESCE() query yield different result with MJ vs. NLJ/HJ

2015-04-04 Thread Tom Lane
Qingqing Zhou writes: > [ this fails: ] > set enable_mergejoin=on; set enable_nestloop=off; set enable_hashjoin=off; > explain analyze select a, b from t1 left join t2 on coalesce(a, 1) = > coalesce(b,1) where (coalesce(b,1))>0 Ugh. The core of the problem is a mistaken assumption that "b" bel

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-04 Thread Jim Nasby
On 4/4/15 5:10 PM, Jim Nasby wrote: On 4/3/15 12:59 AM, Sawada Masahiko wrote: +case HEAPTUPLE_LIVE: +case HEAPTUPLE_RECENTLY_DEAD: +case HEAPTUPLE_INSERT_IN_PROGRESS: +case HEAPTUPLE_DELETE_IN_PROGRESS: +if (hea

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-04 Thread Jim Nasby
On 4/3/15 12:59 AM, Sawada Masahiko wrote: + case HEAPTUPLE_LIVE: + case HEAPTUPLE_RECENTLY_DEAD: + case HEAPTUPLE_INSERT_IN_PROGRESS: + case HEAPTUPLE_DELETE_IN_PROGRESS: +

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Robert Haas
On Apr 4, 2015, at 4:37 PM, Andrew Dunstan wrote: > The attached patch should set float8byval as the default on 64 bit MSVC > builds and error out if it is explicitly set on 32 bit platforms. +1 for changing this. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Tom Lane
Robert Haas writes: > On Sat, Apr 4, 2015 at 10:27 AM, Tom Lane wrote: >> Having said that, I'm fine with leaving this as-is, if only because >> it means we're exercising the --disable-float8-byval code paths in >> the buildfarm ;-) > But... are we? I mean, I don't see anything in the Windows c

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Peter Geoghegan
On Sat, Apr 4, 2015 at 4:37 PM, Andrew Dunstan wrote: > This seems quite wrong. If we want those paths tested we should ensure that > buildfarm members are set up with that explicit setting. > > I think not making this the default for 64 bit MSVC builds was simply an > error of omission. +1. I do

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Andrew Dunstan
On 04/04/2015 04:27 PM, Robert Haas wrote: On Sat, Apr 4, 2015 at 10:27 AM, Tom Lane wrote: I see nothing in the win32 stuff that tries to define USE_FLOAT8_BYVAL on 64-bit windows, is this just an oversight or does it not actually work there? or is it for on-disk compatibility with 32-bit win

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Andrew Dunstan
On 04/04/2015 10:27 AM, Tom Lane wrote: Andrew Gierth writes: "Tom" == Tom Lane writes: Tom> ... btw, has anyone noticed that this patch broke hamerkop and Tom> bowerbird? Or at least, it's hard to see what other recent commit Tom> would explain the failures they're showing. Now that R

Re: [HACKERS] File count restriction of directory limits number of relations inside a database.

2015-04-04 Thread Tomas Vondra
Hi, On 4.4.2015 21:24, sudalai wrote: > Hi, > We have a requirement to have multiple schemas in a database.Each > schema will have all application tables and hold a set of users > data. We have segmented data across different schemas. We > dynamically increase the schemas as in when user signs up

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Robert Haas
On Sat, Apr 4, 2015 at 10:27 AM, Tom Lane wrote: >> I see nothing in the win32 stuff that tries to define USE_FLOAT8_BYVAL >> on 64-bit windows, is this just an oversight or does it not actually >> work there? or is it for on-disk compatibility with 32-bit windows? > > That flag doesn't affect on-

[HACKERS] File count restriction of directory limits number of relations inside a database.

2015-04-04 Thread sudalai
Hi, We have a requirement to have multiple schemas in a database.Each schema will have all application tables and hold a set of users data. We have segmented data across different schemas. We dynamically increase the schemas as in when user signs up. So the table files created across all

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-04 Thread Tom Lane
Michael Paquier writes: > On Sat, Apr 4, 2015 at 6:21 AM, Tom Lane wrote: >> It occurred to me that maybe we could just turn off this class of warning, >> and after some experimentation I found out that >> "-Wno-unused-command-line-argument" does that, at least in the version >> of clang that App

Re: [HACKERS] TABLESAMPLE patch

2015-04-04 Thread Petr Jelinek
On 04/04/15 14:57, Amit Kapila wrote: 1. +tablesample_clause: +TABLESAMPLE ColId '(' func_arg_list ')' opt_repeatable_clause Why do you want to allow func_arg_list? Basically if user tries to pass multiple arguments in TABLESAMPLE method's clause like (10,20), then I think that should be caug

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Andrew Gierth
> "Tom" == Tom Lane writes: >> I see nothing in the win32 stuff that tries to define >> USE_FLOAT8_BYVAL on 64-bit windows, is this just an oversight or >> does it not actually work there? or is it for on-disk compatibility >> with 32-bit windows? Tom> That flag doesn't affect on-disk c

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> ... btw, has anyone noticed that this patch broke hamerkop and > Tom> bowerbird? Or at least, it's hard to see what other recent commit > Tom> would explain the failures they're showing. > Now that Robert committed the fix for 64bit Da

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-04-04 Thread Pavel Stehule
2015-04-04 15:29 GMT+02:00 Haribabu Kommi : > On Sat, Apr 4, 2015 at 4:19 PM, Pavel Stehule > wrote: > > Hi > > > > 2015-03-31 14:38 GMT+02:00 Haribabu Kommi : > >> > >> keyword_databases - The database name can be "all", "replication", > >> sameuser", "samerole" and "samegroup". > >> keyword_rol

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-04-04 Thread Haribabu Kommi
On Sat, Apr 4, 2015 at 4:19 PM, Pavel Stehule wrote: > Hi > > 2015-03-31 14:38 GMT+02:00 Haribabu Kommi : >> >> keyword_databases - The database name can be "all", "replication", >> sameuser", "samerole" and "samegroup". >> keyword_roles - The role can be "all" and a group name prefixed with "+".

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-04 Thread Sawada Masahiko
On Wed, Mar 11, 2015 at 11:46 PM, Sawada Masahiko wrote: > On Tue, Mar 10, 2015 at 12:08 PM, Stephen Frost wrote: >> Sawada, >> >> * Sawada Masahiko (sawada.m...@gmail.com) wrote: >>> Thank you for your review! >>> Attached file is the latest version (without document patch. I making it >>> now.

Re: [HACKERS] TABLESAMPLE patch

2015-04-04 Thread Amit Kapila
On Fri, Apr 3, 2015 at 3:06 AM, Petr Jelinek wrote: > > Hi, > > so here is version 11. > Thanks, patch looks much better, but I think still few more things needs to discussed/fixed. 1. +tablesample_clause: + TABLESAMPLE ColId '(' func_arg_list ')' opt_repeatable_clause Why do you want to allow

Re: [HACKERS] Parallel Seq Scan

2015-04-04 Thread David Rowley
So I've just finished reading the impressive 244 emails (so far) about Parallel Seq scan, and I've had a quick skim over the latest patch. Its quite exciting to think that one day we'll have parallel query in PostgreSQL, but I have to say, that I think that there's a major point about the proposed

Re: [HACKERS] Abbreviated keys for Numeric

2015-04-04 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> ... btw, has anyone noticed that this patch broke hamerkop and Tom> bowerbird? Or at least, it's hard to see what other recent commit Tom> would explain the failures they're showing. Now that Robert committed the fix for 64bit Datum w/o USE_FLOAT8_BYVAL,