Re: [HACKERS] alter user set local_preload_libraries.

2014-10-20 Thread Kyotaro HORIGUCHI
Wow. > > By the way, I became unable to login at all after wrongly setting > > *_preload_libraries for all available users. Is there any releaf > > measures for the situation? I think it's okay even if there's no > > way to login again but want to know if any. > > Yep, that's a problem. You can l

Re: [HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-10-20 Thread Brightwell, Adam
Julien, The following is an initial review: * Applies cleanly to master (f330a6d). * Regression tests updated and pass, including 'check-world'. * Documentation updated and builds successfully. * Might want to consider replacing the following magic number with a constant or perhaps calculated val

Re: [HACKERS] pg_basebackup fails with long tablespace paths

2014-10-20 Thread Amit Kapila
On Tue, Oct 21, 2014 at 12:29 AM, Tom Lane wrote: > > My Salesforce colleague Thomas Fanghaenel observed that the TAP tests > for pg_basebackup fail when run in a sufficiently deeply-nested directory > tree. The cause appears to be that we rely on standard "tar" format > to represent the symlink

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Noah Misch
On Mon, Oct 20, 2014 at 10:24:47PM +0200, Andres Freund wrote: > On 2014-10-20 01:03:31 -0400, Noah Misch wrote: > > On Wed, Oct 15, 2014 at 12:53:03AM -0400, Noah Misch wrote: > > I happened to try the same contrib/dblink test suite on PostgreSQL built > > with > > modern MinGW-w64 (i686-4.9.1-re

Re: [HACKERS] Inconsistencies in documentation of row-level locking

2014-10-20 Thread Jim Nasby
On 10/10/14, 8:31 AM, Michael Paquier wrote: Hi all, Currently all the row-level lock modes are described in the page for SELECT query: http://www.postgresql.org/docs/devel/static/explicit-locking.html#LOCKING-ROWS However, after browsing the documentation, I noticed in the page describing all t

Re: [HACKERS] Questions on domain on composite / casts ignoring domains

2014-10-20 Thread David G Johnston
Jim Nasby-5 wrote > I'm trying to create what amounts to a new type. This would be rather easy > if I could perform a CHECK on a composite type, which I could do if I > could create a domain on top of a composite. Is there any reason in > particular that hasn't been done? > > As an alternative, I

Re: [HACKERS] Trailing comma support in SELECT statements

2014-10-20 Thread Jim Nasby
On 10/20/14, 11:16 AM, Andrew Dunstan wrote: On 10/20/2014 11:59 AM, David E. Wheeler wrote: On Oct 18, 2014, at 7:06 PM, Jim Nasby wrote: Yes. The only case I can think of where we wouldn't want this is COPY. BTW, this should also apply to delimiters other than commas; for example, some g

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread Wim Lewis
On Oct 20, 2014, at 5:03 PM, David E. Wheeler wrote: > This another reason not to use KeepAlive, I guess. OnDemand is supposed to > fire up a job only when it’s needed. No idea what that means. I think the idea of OnDemand is for launchd items to act a bit like inetd does: launchd creates the

Re: [HACKERS] Proposal: Log inability to lock pages during vacuum

2014-10-20 Thread Andres Freund
On 2014-10-20 19:43:38 -0500, Jim Nasby wrote: > On 10/20/14, 7:31 PM, Andres Freund wrote: > >On 2014-10-20 19:18:31 -0500, Jim Nasby wrote: > >>>In the meantime, I think it's worth adding this logging. If in fact this > >>>basically never happens (the current assumption), it doesn't hurt > >>>a

Re: [HACKERS] Autovacuum fails to keep visibility map up-to-date in mostly-insert-only-tables

2014-10-20 Thread Andres Freund
On 2014-10-20 17:43:26 -0700, Josh Berkus wrote: > On 10/20/2014 05:39 PM, Jim Nasby wrote: > > Or maybe vacuum isn't the right way to handle some of these scenarios. > > It's become the catch-all for all of this stuff, but maybe that doesn't > > make sense anymore. Certainly when it comes to deali

Re: [HACKERS] Proposal: Log inability to lock pages during vacuum

2014-10-20 Thread Jim Nasby
On 10/20/14, 7:31 PM, Andres Freund wrote: On 2014-10-20 19:18:31 -0500, Jim Nasby wrote: >In the meantime, I think it's worth adding this logging. If in fact this basically never happens (the current assumption), it doesn't hurt anything. If it turns out our assumption is wrong, then we'll ac

Re: [HACKERS] Autovacuum fails to keep visibility map up-to-date in mostly-insert-only-tables

2014-10-20 Thread Josh Berkus
On 10/20/2014 05:39 PM, Jim Nasby wrote: > Or maybe vacuum isn't the right way to handle some of these scenarios. > It's become the catch-all for all of this stuff, but maybe that doesn't > make sense anymore. Certainly when it comes to dealing with inserts > there's no reason we *have* to do anyth

Re: [HACKERS] Autovacuum fails to keep visibility map up-to-date in mostly-insert-only-tables

2014-10-20 Thread Jim Nasby
On 10/20/14, 3:11 PM, Andres Freund wrote: On 2014-10-19 20:43:29 -0500, Jim Nasby wrote: On 10/19/14, 11:41 AM, Andres Freund wrote: On 2014-10-18 21:36:48 -0500, Jim Nasby wrote: The "weird" part is that if it's not doing a freeze it will just punt on a page if it can't get the cleanup lock.

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread David E. Wheeler
On Oct 20, 2014, at 5:17 PM, Tom Lane wrote: > [ looks ... ] Yeah, there's no mention of KeepAlive in 10.4's > launchd.plist man page. It does have a convenient example > saying that OnDemand = false does what we want: Yeah, let’s see if we can cover both. > I'd just drop them into files in t

Re: [HACKERS] Proposal: Log inability to lock pages during vacuum

2014-10-20 Thread Andres Freund
On 2014-10-20 19:18:31 -0500, Jim Nasby wrote: > In the meantime, I think it's worth adding this logging. If in fact this > basically never happens (the current assumption), it doesn't hurt anything. > If it turns out our assumption is wrong, then we'll actually be able to fin> > that out. :) I

Re: [HACKERS] Proposal: Log inability to lock pages during vacuum

2014-10-20 Thread Jim Nasby
On 10/20/14, 10:29 AM, Greg Stark wrote: On Mon, Oct 20, 2014 at 2:57 AM, Jim Nasby wrote: Currently, a non-freeze vacuum will punt on any page it can't get a cleanup lock on, with no retry. Presumably this should be a rare occurrence, but I think it's bad that we just assume that and won't war

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread Tom Lane
"David E. Wheeler" writes: > On Oct 20, 2014, at 4:36 PM, Tom Lane wrote: >> (1) I'd vote for just removing the SystemStarter stuff: it complicates >> understanding what's happening, to no very good end. We can easily >> check that the launchd way works back to whatever we think our oldest >> su

Re: [HACKERS] get_actual_variable_range vs idx_scan/idx_tup_fetch

2014-10-20 Thread Jim Nasby
On 10/18/14, 8:58 AM, Bruce Momjian wrote: On Fri, Oct 17, 2014 at 11:03:04PM -0400, Tom Lane wrote: Bruce Momjian writes: On Fri, Oct 17, 2014 at 06:15:37PM -0400, Tom Lane wrote: Those stats were perfectly valid: what the planner is looking for is accurate minimum and maximum values for the

Re: [HACKERS] Re: Add regression tests for autocommit-off mode for psql and fix some omissions

2014-10-20 Thread Jim Nasby
On 10/20/14, 3:49 PM, David G Johnston wrote: Well, that is at least doable, but probably rather ugly. It would probably >be less ugly if our test framework had a way to test for errors (ala >pgTap). > >Where I was going with this is a full-on brute-force test: execute every >possible command wit

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread David E. Wheeler
On Oct 20, 2014, at 4:58 PM, Jim Nasby wrote: > You're enabling POSTGRESQL in /etc/hostconfig before any of the files are > copied over... what happens if we puke before the files get copied? Would it > be better to enable after the scripts are in place? That code was there; I just indented it

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread David E. Wheeler
On Oct 20, 2014, at 4:36 PM, Tom Lane wrote: > (1) I'd vote for just removing the SystemStarter stuff: it complicates > understanding what's happening, to no very good end. We can easily > check that the launchd way works back to whatever we think our oldest > supported OS X release is. (10.4.x

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread Jim Nasby
On 10/20/14, 5:59 PM, David E. Wheeler wrote: In Mac OS X 10.10 “Yosemite,” Apple removed SystemStarter, upon which our OS X start script has relied since 2007. So here is a patch that adds support for its replacement, launchd. It includes 7 day log rotation like the old script did. The instal

[HACKERS] Questions on domain on composite / casts ignoring domains

2014-10-20 Thread Jim Nasby
I'm trying to create what amounts to a new type. This would be rather easy if I could perform a CHECK on a composite type, which I could do if I could create a domain on top of a composite. Is there any reason in particular that hasn't been done? As an alternative, I tried accomplishing this w

Re: [HACKERS] Patch: Add launchd Support

2014-10-20 Thread Tom Lane
"David E. Wheeler" writes: > In Mac OS X 10.10 “Yosemite,” Apple removed SystemStarter, upon which our > OS X start script has relied since 2007. So here is a patch that adds support > for its replacement, launchd. It includes 7 day log rotation like the old > script did. The install script

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-20 Thread Tatsuo Ishii
> Buildfarm member hamerkop has been failing in the pg_upgrade regression > test for the last several days. The problem looks like this: > > command: > "C:/buildfarm/build_root/HEAD/pgsql.build/contrib/pg_upgrade/tmp_check/install/bin/pg_restore" > --port 50432 --username "Administrator" --exit

[HACKERS] Patch: Add launchd Support

2014-10-20 Thread David E. Wheeler
Hackers, In Mac OS X 10.10 “Yosemite,” Apple removed SystemStarter, upon which our OS X start script has relied since 2007. So here is a patch that adds support for its replacement, launchd. It includes 7 day log rotation like the old script did. The install script still prefers the SystemStart

Re: [HACKERS] pg_basebackup fails with long tablespace paths

2014-10-20 Thread Peter Eisentraut
On 10/20/14 2:59 PM, Tom Lane wrote: > What do we want to do about this? I think a minimum expectation would be > for pg_basebackup to notice and complain when it's trying to create an > unworkably long symlink entry, but it would be far better if we found a > way to cope instead. Isn't it the ba

[HACKERS] Re: Add regression tests for autocommit-off mode for psql and fix some omissions

2014-10-20 Thread David G Johnston
Jim Nasby-5 wrote > On 10/7/14, 2:11 AM, Feike Steenbergen wrote: >> On 7 October 2014 01:41, Jim Nasby< > Jim.Nasby@ > > wrote: >>> >The options I see... >>> > >>> >1) If there's a definitive way to tell from backend source code what >>> >commands disallow transactions then we can just use that

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Andres Freund
On 2014-10-20 01:03:31 -0400, Noah Misch wrote: > On Wed, Oct 15, 2014 at 12:53:03AM -0400, Noah Misch wrote: > > On Tue, Oct 14, 2014 at 07:07:17PM -0400, Tom Lane wrote: > > > Dave Page writes: > > > > On Tue, Oct 14, 2014 at 11:38 PM, Tom Lane wrote: > > > >> I think we're hoping that somebody

Re: [HACKERS] Autovacuum fails to keep visibility map up-to-date in mostly-insert-only-tables

2014-10-20 Thread Andres Freund
On 2014-10-19 20:43:29 -0500, Jim Nasby wrote: > On 10/19/14, 11:41 AM, Andres Freund wrote: > >On 2014-10-18 21:36:48 -0500, Jim Nasby wrote: > >>The "weird" part is that if it's not doing a freeze it will just punt > >>on a page if it can't get the cleanup lock. > > > >I don't think that's partic

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread jesper
> On 2014-10-20 21:41:26 +0200, jes...@krogh.cc wrote: >> >> > On 2014-10-20 21:03:59 +0200, jes...@krogh.cc wrote: >> >> One of our "production issues" is that the system generates lots of >> >> wal-files, lots is like 151952 files over the last 24h, which is >> about >> >> 2.4TB worth of WAL file

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread Andres Freund
On 2014-10-20 21:41:26 +0200, jes...@krogh.cc wrote: > > > On 2014-10-20 21:03:59 +0200, jes...@krogh.cc wrote: > >> One of our "production issues" is that the system generates lots of > >> wal-files, lots is like 151952 files over the last 24h, which is about > >> 2.4TB worth of WAL files. I woul

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread jesper
> On 2014-10-20 21:03:59 +0200, jes...@krogh.cc wrote: >> One of our "production issues" is that the system generates lots of >> wal-files, lots is like 151952 files over the last 24h, which is about >> 2.4TB worth of WAL files. I wouldn't say that isn't an issue by itself, >> but the system does

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread Tom Lane
jes...@krogh.cc writes: >> configure --with-wal-segsize=something ? > Yes, but there are good reasons not to go down that route. One is that: > 1) It looks like I'am going to be the only one, beware of the dragons. > 2) It requires apparently a re-initdb, thus dump/restore of 4.5TB of data I thi

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread Andres Freund
Hi, On 2014-10-20 21:03:59 +0200, jes...@krogh.cc wrote: > One of our "production issues" is that the system generates lots of > wal-files, lots is like 151952 files over the last 24h, which is about > 2.4TB worth of WAL files. I wouldn't say that isn't an issue by itself, > but the system does in

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread jesper
> jes...@krogh.cc writes: >> Thread here around the same topic: >> http://postgresql.1045698.n5.nabble.com/How-do-you-change-the-size-of-the-WAL-files-td3425516.html >> But not a warm welcoming workaround. > > configure --with-wal-segsize=something ? Yes, but there are good reasons not to go down

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread k...@rice.edu
On Mon, Oct 20, 2014 at 09:03:59PM +0200, jes...@krogh.cc wrote: > Hi. > > One of our "production issues" is that the system generates lots of > wal-files, lots is like 151952 files over the last 24h, which is about > 2.4TB worth of WAL files. I wouldn't say that isn't an issue by itself, > but th

Re: [HACKERS] Superuser connect during smart shutdown

2014-10-20 Thread Tom Lane
Robert Haas writes: > On Sun, Oct 19, 2014 at 12:27 PM, Tom Lane wrote: >> I've certainly objected to it in the past, but I don't believe >> I was the only one objecting. > What's your feeling now? I'm prepared to yield on the point. regards, tom lane -- Sent via pgs

Re: [HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread Tom Lane
jes...@krogh.cc writes: > Thread here around the same topic: > http://postgresql.1045698.n5.nabble.com/How-do-you-change-the-size-of-the-WAL-files-td3425516.html > But not a warm welcoming workaround. configure --with-wal-segsize=something ? regards, tom lane -- Sent vi

[HACKERS] wal-size limited to 16MB - Performance issue for subsequent backup

2014-10-20 Thread jesper
Hi. One of our "production issues" is that the system generates lots of wal-files, lots is like 151952 files over the last 24h, which is about 2.4TB worth of WAL files. I wouldn't say that isn't an issue by itself, but the system does indeed work fine. We do subsequently gzip the files to limit ac

[HACKERS] pg_basebackup fails with long tablespace paths

2014-10-20 Thread Tom Lane
My Salesforce colleague Thomas Fanghaenel observed that the TAP tests for pg_basebackup fail when run in a sufficiently deeply-nested directory tree. The cause appears to be that we rely on standard "tar" format to represent the symlink for a tablespace, and POSIX tar format has a hard-wired restr

Re: [HACKERS] Superuser connect during smart shutdown

2014-10-20 Thread Robert Haas
On Sun, Oct 19, 2014 at 12:27 PM, Tom Lane wrote: > Robert Haas writes: >>> But TBH I suspect 95% of the problems here would vanish if smart >>> shutdown weren't the default ... > >> But for your repeated objections, we would have changed the default to fast >> years ago. AFAICT everyone else is

Re: [HACKERS] Trailing comma support in SELECT statements

2014-10-20 Thread Andrew Dunstan
On 10/20/2014 11:59 AM, David E. Wheeler wrote: On Oct 18, 2014, at 7:06 PM, Jim Nasby wrote: Yes. The only case I can think of where we wouldn't want this is COPY. BTW, this should also apply to delimiters other than commas; for example, some geometry types use ; as a delimiter between po

Re: [HACKERS] Would you help to review our modifications

2014-10-20 Thread David G Johnston
rohtodeveloper wrote > So how to deal with this kind of situation if I want a implicit > conversion? As of the out-of-support 8.3 release many of the implicit casts previously defined have been changed to explicit casts. It is a catalog change - obviously, since you can still define implicit cast

Re: [HACKERS] Trailing comma support in SELECT statements

2014-10-20 Thread David E. Wheeler
On Oct 18, 2014, at 7:06 PM, Jim Nasby wrote: > Yes. > > The only case I can think of where we wouldn't want this is COPY. > > BTW, this should also apply to delimiters other than commas; for example, > some geometry types use ; as a delimiter between points. I don’t think it should apply to

Re: [HACKERS] Proposal: Log inability to lock pages during vacuum

2014-10-20 Thread Greg Stark
On Mon, Oct 20, 2014 at 2:57 AM, Jim Nasby wrote: > Currently, a non-freeze vacuum will punt on any page it can't get a cleanup > lock on, with no retry. Presumably this should be a rare occurrence, but I > think it's bad that we just assume that and won't warn the user if something > bad is going

Re: [HACKERS] alter user/role CURRENT_USER

2014-10-20 Thread Brightwell, Adam
Kyotaro, Food for thought. Couldn't you reduce the following block: + if (strcmp(stmt->role, "current_user") == 0) + { + roleid = GetUserId(); + tuple = SearchSysCache1(AUTHOID, ObjectIdGetDatum(roleid)); + if (!HeapTupleIsValid(tuple)) + ereport(ERROR, + (errcode(ERRCODE_UNDEFINED_OBJECT), + er

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Noah Misch
On Mon, Oct 20, 2014 at 11:06:54AM -0400, Tom Lane wrote: > Noah Misch writes: > > I don't expect to understand the mechanism > > behind it, but I recommend we switch back to linking libpq with shell32.dll. > > The MSVC build already does that in all supported branches, and it feels > > right > >

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Tom Lane
Noah Misch writes: > I reproduced narwhal's problem using its toolchain on another 32-bit Windows > Server 2003 system. The crash happens at the SHGetFolderPath() call in > pqGetHomeDirectory(). A program can acquire that function via shfolder.dll or > via shell32.dll; we've used the former meth

Re: [HACKERS] Wrong filename in comment

2014-10-20 Thread Tom Lane
Marko Tiikkaja writes: > Commit 32984d8fc3dbb90a3fafb69fece0134f1ea790f9 forgot to change the > filename in the comment in contrib/pgcrypto/pgcrypto--1.2.sql. Trivial > patch attached. Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-h

[HACKERS] Would you help to review our modifications

2014-10-20 Thread rohtodeveloper
Dear All, L've got a question for you. If the value of the integer type is converted to a value of type Boolean,PostgreSQL will display just like"The rule has already exist"; 1. CREATE CAST (integer AS bool) WITH INOUT AS IMPLICIT; ERROR: cast from type integer to typ

Re: [HACKERS] Typos in comments

2014-10-20 Thread Robert Haas
On Mon, Oct 20, 2014 at 3:04 AM, David Rowley wrote: > On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita > wrote: >> I ran into a type " a a " in a comment in snapmgr.c, and found that >> there are four other places that've made the same typo, by the grep >> command. And in one of those places, I f

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-20 Thread Fabrízio de Royes Mello
On Mon, Oct 20, 2014 at 11:24 AM, Sawada Masahiko wrote: > > On Mon, Oct 20, 2014 at 9:41 AM, Fabrízio de Royes Mello > wrote: > > > > > > On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello > > wrote: > >> > >> > >> On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko > >> wrote: > >> > > >>

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-20 Thread Sawada Masahiko
On Mon, Oct 20, 2014 at 9:41 AM, Fabrízio de Royes Mello wrote: > > > On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello > wrote: >> >> >> On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko >> wrote: >> > >> > On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello >> > wrote: >> > > On W

Re: [HACKERS] Perfomance degradation 9.3 (vs 9.2) for FreeBSD

2014-10-20 Thread Palle Girgensohn
Hello, How did this testing turn out? Palle 3 jul 2014 kl. 12:15 skrev Tatsuo Ishii : > Hi, > >> Hi, >> >> Attached you can find a short (compile tested only ) patch implementing >> a 'shared_memory_type' GUC, akin to 'dynamic_shared_memory_type'. Will >> only apply to 9.4, not 9.3, but it sh

Re: [HACKERS] BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves)

2014-10-20 Thread Michael Paquier
On Fri, Oct 17, 2014 at 10:12 PM, Fujii Masao wrote: > On Fri, Oct 17, 2014 at 9:23 PM, Fujii Masao > wrote: > > On Thu, Oct 9, 2014 at 3:26 PM, Michael Paquier > > wrote: > >> > >> > >> On Wed, Oct 8, 2014 at 10:00 PM, Michael Paquier < > michael.paqu...@gmail.com> > >> wrote: > >>> > >>> The

Re: [HACKERS] agent_init concurrent running question

2014-10-20 Thread Michael Paquier
On Mon, Oct 20, 2014 at 4:29 PM, Jov wrote: > in poolmgr.c function agent_init(): > This code is part of Postgres-XC (or Postgres-XL) and not PostgreSQL itself, you should send your questions there: https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers Regards, -- Michael

Re: [HACKERS] alter user/role CURRENT_USER

2014-10-20 Thread Rushabh Lathia
I gone through patch and here is the review for this patch: .) patch go applied on master branch with patch -p1 command (git apply failed) .) regression make check run fine .) testcase coverage is missing in the patch .) Over all coding/patch looks good. Few comments: 1) Any particular reaso

[HACKERS] Refactor status detection for XLOG segment file in xlogarchive.c (Was: *FF WALs under 9.2)

2014-10-20 Thread Michael Paquier
Hi all, Except if I am missing something, is there any reason why the sequence used in XLogArchiveCheckDone and XLogArchiveIsBusy to check if a XLOG segment has been already archived is duplicated? I guess that doing a little bit of refactoring here would make sense for simplicity, patch is attach

[HACKERS] agent_init concurrent running question

2014-10-20 Thread Jov
hello,I am reading the pool manager code,and have some problem: in poolmgr.c function agent_init(): if (agent->pool) > agent_release_connections(agent, false); .. #ifdef XCP > /* find database */ > agent->pool = find_database_pool(database, user_name); > /* create if not found */ > if (agen

Re: [HACKERS] Typos in comments

2014-10-20 Thread David Rowley
On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita wrote: > I ran into a type " a a " in a comment in snapmgr.c, and found that > there are four other places that've made the same typo, by the grep > command. And in one of those places, I found yet another typo. Please > find attached a patch. > >