Re: [HACKERS] insert throw error when year field len > 4 for timestamptz datatype

2013-10-02 Thread Rushabh Lathia
Thanks Bruce. Yes for me main problem was to make assumption that a 5-digit number is a year, as was bit worried about side effect of that assumption in the date/time module. I did tested patch shared by you with various test and so far it looks good to me. I would like reviewer to review/test th

Re: [HACKERS] Suggestion: Issue warning when calling SET TRANSACTION outside transaction block

2013-10-02 Thread Amit Kapila
On Tue, Oct 1, 2013 at 7:49 AM, Bruce Momjian wrote: > On Sun, Sep 29, 2013 at 11:40:51AM +0530, Amit Kapila wrote: >> >> Shouldn't we do it for Set Constraints as well? >> > >> > Oh, very good point. I missed that one. Updated patch attached. > > I am glad you are seeing things I am not. :-) >

Re: [HACKERS] Prevent pg_basebackup -Fp -D -?

2013-10-02 Thread Magnus Hagander
On Oct 3, 2013 2:47 AM, "Michael Paquier" wrote: > > On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander wrote: > > Right now, if you use > > > > pg_basebackup -Ft -D - > > > > you get a tarfile, written to stdout, for redirection. > > > > However, if you use: > > > > pg_basebackup -Fp -D - > > > >

Re: [HACKERS] Prevent pg_basebackup -Fp -D -?

2013-10-02 Thread Josh Berkus
On 10/02/2013 05:47 PM, Michael Paquier wrote: > On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander wrote: >> Right now, if you use >> >> pg_basebackup -Ft -D - >> >> you get a tarfile, written to stdout, for redirection. >> >> However, if you use: >> >> pg_basebackup -Fp -D - >> >> you get a plaint

Re: [HACKERS] Prevent pg_basebackup -Fp -D -?

2013-10-02 Thread Michael Paquier
On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander wrote: > Right now, if you use > > pg_basebackup -Ft -D - > > you get a tarfile, written to stdout, for redirection. > > However, if you use: > > pg_basebackup -Fp -D - > > you get a plaintext (unpackaged) backup, in a directory called "-". > > I ca

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread KONDO Mitsumasa
(2013/10/02 17:37), KONDO Mitsumasa wrote: > I want to submit new project in pgFoundery project. Our new project was approved yesterday! Thanks very much for pgFoundery crew. Regards, -- Mitsumasa KONDO NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Larry Rosenman
On 2013-10-02 17:32, Josh Berkus wrote: No fundamental reason; I'm hoping ZFS will be supported in addition to btrfs, but I don't have any systems with ZFS filesystems at the moment so I haven't been able to test it or find out the mechanisms ZFS uses for cloning. On btrfs cloning is implemented

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Josh Berkus
> No fundamental reason; I'm hoping ZFS will be supported in addition to > btrfs, but I don't have any systems with ZFS filesystems at the moment > so I haven't been able to test it or find out the mechanisms ZFS uses > for cloning. On btrfs cloning is implemented with a custom > btrfs-specific i

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Merlin Moncure
On Wed, Oct 2, 2013 at 3:43 PM, Ants Aasma wrote: > On Wed, Oct 2, 2013 at 10:37 PM, Merlin Moncure wrote: >> On Wed, Oct 2, 2013 at 9:45 AM, Ants Aasma wrote: >>> I haven't reviewed the code in as much detail to say if there is an >>> actual race here, I tend to think there's probably not, but

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Ants Aasma
On Wed, Oct 2, 2013 at 10:37 PM, Merlin Moncure wrote: > On Wed, Oct 2, 2013 at 9:45 AM, Ants Aasma wrote: >> I haven't reviewed the code in as much detail to say if there is an >> actual race here, I tend to think there's probably not, but the >> specific pattern that I had in mind is that with

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Bruce Momjian
On Wed, Oct 2, 2013 at 05:23:31PM +0300, Oskari Saarenmaa wrote: > On 02/10/13 17:18, Andrew Dunstan wrote: > > > >On 10/01/2013 06:31 PM, Oskari Saarenmaa wrote: > >>Add file cloning as an alternative data transfer method to pg_upgrade. > >>Currently only btrfs is supported, but copy-on-write clo

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Merlin Moncure
On Wed, Oct 2, 2013 at 9:45 AM, Ants Aasma wrote: > I haven't reviewed the code in as much detail to say if there is an > actual race here, I tend to think there's probably not, but the > specific pattern that I had in mind is that with the following actual > code: hm. I think there *is* a race.

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Andrew Gierth
> "Merlin" == Merlin Moncure writes: >> Who is pgFoundery administrator or board member now? I would like >> to send e-mail them. At least, it does not have information and >> support page in pgFoundery homepage. Merlin> I have not been able to get in contact with Marc either to Merlin>

Re: [HACKERS] hstore extension version screwup

2013-10-02 Thread Jim Nasby
On 9/29/13 9:41 PM, Andrew Dunstan wrote: On 09/29/2013 10:38 PM, Peter Eisentraut wrote: On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write them in your git repo might be a clue to that. Git doesn't support setting

Re: [HACKERS] ToDo: fast update of arrays with fixed length fields for PL/pgSQL

2013-10-02 Thread Pavel Stehule
2013/10/2 Andres Freund > Hi, > > On 2013-10-02 18:56:51 +0200, Pavel Stehule wrote: > > Hello > > > > this proposal is related to reported issue > > > http://www.postgresql.org/message-id/e1vquta-0007y4...@wrigleys.postgresql.org > > > > > > We can directly modify any fields of int, float, doubl

Re: [HACKERS] ToDo: fast update of arrays with fixed length fields for PL/pgSQL

2013-10-02 Thread Andres Freund
Hi, On 2013-10-02 18:56:51 +0200, Pavel Stehule wrote: > Hello > > this proposal is related to reported issue > http://www.postgresql.org/message-id/e1vquta-0007y4...@wrigleys.postgresql.org > > > We can directly modify any fields of int, float, double arrays (when result > size will be immutab

[HACKERS] ToDo: fast update of arrays with fixed length fields for PL/pgSQL

2013-10-02 Thread Pavel Stehule
Hello this proposal is related to reported issue http://www.postgresql.org/message-id/e1vquta-0007y4...@wrigleys.postgresql.org We can directly modify any fields of int, float, double arrays (when result size will be immutable). This trick is used now for acceleration of some aggregates. Ideas,

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Merlin Moncure
On Wed, Oct 2, 2013 at 10:42 AM, Marc Fournier wrote: > > direct_cp project approved, sorry for delay … > > as to the the mailing list issue, where did you send it? can you resend it > to me here? sure -- I had sent it initially to the www list then directly to you.. "Trying to figure out wha

Re: [HACKERS] insert throw error when year field len > 4 for timestamptz datatype

2013-10-02 Thread Bruce Momjian
On Wed, Oct 2, 2013 at 11:00:30AM -0400, Robert Haas wrote: > On Tue, Oct 1, 2013 at 7:52 PM, Bruce Momjian wrote: > > On Fri, Sep 27, 2013 at 10:42:17AM +, Haribabu kommi wrote: > >> If the changes are very high to deal all scenarios, > >> > >> I feel it is better do it only in scenarios whe

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Marc Fournier
direct_cp project approved, sorry for delay … as to the the mailing list issue, where did you send it? can you resend it to me here? On 2013-10-02, at 6:46 , Merlin Moncure wrote: > On Wed, Oct 2, 2013 at 3:37 AM, KONDO Mitsumasa > wrote: >> Hi, >> >> I want to submit new project in pgFo

Re: [HACKERS] logical changeset generation v6.1

2013-10-02 Thread Andres Freund
On 2013-10-02 11:06:59 -0400, Robert Haas wrote: > On Wed, Oct 2, 2013 at 11:05 AM, Andres Freund wrote: > > On 2013-10-02 10:56:38 -0400, Robert Haas wrote: > >> On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund > >> wrote: > >> > On 2013-10-01 10:07:19 -0400, Robert Haas wrote: > >> >> - It seems

Re: [HACKERS] logical changeset generation v6.1

2013-10-02 Thread Robert Haas
On Wed, Oct 2, 2013 at 11:05 AM, Andres Freund wrote: > On 2013-10-02 10:56:38 -0400, Robert Haas wrote: >> On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund wrote: >> > On 2013-10-01 10:07:19 -0400, Robert Haas wrote: >> >> - It seems that HeapSatisfiesHOTandKeyUpdate is now >> >> HeapSatisfiesHOTan

Re: [HACKERS] logical changeset generation v6.1

2013-10-02 Thread Andres Freund
On 2013-10-02 10:56:38 -0400, Robert Haas wrote: > On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund wrote: > > On 2013-10-01 10:07:19 -0400, Robert Haas wrote: > >> - It seems that HeapSatisfiesHOTandKeyUpdate is now > >> HeapSatisfiesHOTandKeyandCandidateKeyUpdate. Considering I think this > >> was

Re: [HACKERS] logical changeset generation v6.1

2013-10-02 Thread Robert Haas
On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund wrote: > On 2013-10-01 10:07:19 -0400, Robert Haas wrote: >> - It seems that HeapSatisfiesHOTandKeyUpdate is now >> HeapSatisfiesHOTandKeyandCandidateKeyUpdate. Considering I think this >> was merely HeapSatisfiesHOTUpdate a year ago, it's hard not to

Re: [HACKERS] pluggable compression support

2013-10-02 Thread Robert Haas
On Tue, Oct 1, 2013 at 9:56 PM, Daniel Farina wrote: > On Mon, Sep 30, 2013 at 1:49 PM, Huchev wrote: >> How come any compressor which could put some competition to pglz is >> systematically pushed out of the field on the ground of unverifiable "legal >> risks" ? > > Because pglz has been around

Re: [HACKERS] insert throw error when year field len > 4 for timestamptz datatype

2013-10-02 Thread Robert Haas
On Tue, Oct 1, 2013 at 7:52 PM, Bruce Momjian wrote: > On Fri, Sep 27, 2013 at 10:42:17AM +, Haribabu kommi wrote: >> If the changes are very high to deal all scenarios, >> >> I feel it is better do it only in scenarios where the use cases needs it, >> until >> it is not confusing users. >> >

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Ants Aasma
On Wed, Oct 2, 2013 at 4:39 PM, Merlin Moncure wrote: > On Mon, Sep 30, 2013 at 7:51 PM, Ants Aasma wrote: >> So we need a read barrier somewhere *after* reading the flag in >> RecoveryInProgress() and reading the shared memory structures, and in >> theory a full barrier if we are going to be wri

[HACKERS] Prevent pg_basebackup -Fp -D -?

2013-10-02 Thread Magnus Hagander
Right now, if you use pg_basebackup -Ft -D - you get a tarfile, written to stdout, for redirection. However, if you use: pg_basebackup -Fp -D - you get a plaintext (unpackaged) backup, in a directory called "-". I can't think of a single usecase where this is a good idea. Therefor, I would su

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Andrew Dunstan
On 10/01/2013 06:31 PM, Oskari Saarenmaa wrote: Add file cloning as an alternative data transfer method to pg_upgrade. Currently only btrfs is supported, but copy-on-write cloning is also available on at least ZFS. Cloning must be requested explicitly and if it isn't supported by the operating

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Oskari Saarenmaa
On 02/10/13 17:18, Andrew Dunstan wrote: On 10/01/2013 06:31 PM, Oskari Saarenmaa wrote: Add file cloning as an alternative data transfer method to pg_upgrade. Currently only btrfs is supported, but copy-on-write cloning is also available on at least ZFS. Cloning must be requested explicitly a

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Andres Freund
On 2013-10-02 08:39:59 -0500, Merlin Moncure wrote: > wow -- thanks for your review and provided detail. Considering there > are no examples of barrier instructions to date, I think some of your > commentary should be included in the in-source documentation. I think most of it is in README.barrie

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-02 Thread Kevin Grittner
Oskari Saarenmaa wrote: > Add file cloning as an alternative data transfer method to pg_upgrade. > Currently only btrfs is supported, but copy-on-write cloning is also > available on at least ZFS.  Cloning must be requested explicitly and if > it isn't supported by the operating system or filesy

Re: [HACKERS] relscan_details.h

2013-10-02 Thread Alvaro Herrera
Bruce Momjian escribió: > On Wed, Oct 2, 2013 at 08:59:42AM -0400, Noah Misch wrote: > > On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote: > > > If we had not made massive cleanup changes years ago, our code would not > > > be as good as it is today. By avoiding cleanup to reduce the

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Merlin Moncure
On Wed, Oct 2, 2013 at 3:37 AM, KONDO Mitsumasa wrote: > Hi, > > I want to submit new project in pgFoundery project. > > I submitted new project which is WAL archive copy tool with directIO method in > pgFoundery homepage 2 weeks ago, but it does not have approved and responded > at > all:-( > >

Re: [HACKERS] [PERFORM] Cpu usage 100% on slave. s_lock problem.

2013-10-02 Thread Merlin Moncure
On Mon, Sep 30, 2013 at 8:15 AM, Peter Eisentraut wrote: > On 9/27/13 3:00 PM, Merlin Moncure wrote: >> Attached is simplified patch that replaces the spinlock with a read >> barrier based on a suggestion made by Andres offlist. > > This patch doesn't apply. works for me: merlin@mmoncure-ubuntu:

Re: [HACKERS] relscan_details.h

2013-10-02 Thread Noah Misch
On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote: > If we had not made massive cleanup changes years ago, our code would not > be as good as it is today. By avoiding cleanup to reduce the burden on > people who use our code, we are positioning our code on a slow decline > in clarity.

Re: [HACKERS] Looking for information on our elephant

2013-10-02 Thread Bruce Momjian
On Mon, Sep 23, 2013 at 12:40:06AM +0400, Oleg Bartunov wrote: > I found in my archives several logos. The oldest one comes from postgres95 > time.  I recall that logo with cheetah was made by Bruce (?) No, I don't remember who did that cheetah. -- Bruce Momjian http://momjian.us En

Re: [HACKERS] relscan_details.h

2013-10-02 Thread Bruce Momjian
On Wed, Oct 2, 2013 at 08:59:42AM -0400, Noah Misch wrote: > On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote: > > If we had not made massive cleanup changes years ago, our code would not > > be as good as it is today. By avoiding cleanup to reduce the burden on > > people who use ou

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-10-02 Thread Sameer Thakur
> > Looks pretty good. Do you want to package up the patch with your > change and do the honors and re-submit it? Thanks for helping out so > much! Sure, will do. Need to add a bit of documentation explaining statistics session as well. I did some more basic testing around pg_stat_statements.max, n

Re: [HACKERS] No Index-Only Scan on Partial Index

2013-10-02 Thread Merlin Moncure
On Tuesday, October 1, 2013, David E. Wheeler wrote: > On Oct 1, 2013, at 3:56 PM, Merlin Moncure wrote: > >> I don't think it has anything to do with the conditional index -- it's >> the functional based. For some reason postgres always wants to post >> filter (note the filter step below): >> >

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-02 Thread Peter Eisentraut
On 10/2/13 5:12 AM, Asif Naeem wrote: > Neither git nor patch command apply the patch successfully. Can you > please guide ?. Thanks. Works for me. Check that your email client isn't mangling line endings. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Michael Paquier
On Wed, Oct 2, 2013 at 5:37 PM, KONDO Mitsumasa wrote: > Who is pgFoundery administrator or board member now? I would like to send > e-mail > them. At least, it does not have information and support page in pgFoundery > homepage. Why don't you consider github as a potential solution? You could u

Re: [HACKERS] review: psql and pset without any arguments

2013-10-02 Thread Pavel Stehule
Hello all there are no comments, so I'll close this topic This feature is ready for commit Regards Pavel Stehule 2013/10/1 Pavel Stehule > Hello all > > I am thinking so almost all is done > > I fixed a help and appended a simple test > > But it is a cosmetic changes. > > Comments? > > Rega

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-02 Thread Asif Naeem
Thank you Peter. When I try to apply the patch on latest PG source code on master branch, it gives the following error message i.e. > asif$ git apply /Users/asif/core/Patch\:\ Add\ use\ of\ > asprintf\(\)/v2-0001-Add-use-of-asprintf.patch > /Users/asif/core/Patch: Add use of > asprintf()/v2-0001-A

Re: [HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread Tatsuo Ishii
> Hi, > > I want to submit new project in pgFoundery project. > > I submitted new project which is WAL archive copy tool with directIO method in > pgFoundery homepage 2 weeks ago, but it does not have approved and responded > at > all:-( > > Who is pgFoundery administrator or board member now?

[HACKERS] Who is pgFoundery administrator?

2013-10-02 Thread KONDO Mitsumasa
Hi, I want to submit new project in pgFoundery project. I submitted new project which is WAL archive copy tool with directIO method in pgFoundery homepage 2 weeks ago, but it does not have approved and responded at all:-( Who is pgFoundery administrator or board member now? I would like to send

Re: [HACKERS] Documentation for SET var_name FROM CURRENT

2013-10-02 Thread Amit Kapila
On Tue, Oct 1, 2013 at 9:01 PM, Alvaro Herrera wrote: > Amit Kapila escribió: >> While reading documentation for SET command, I observed that FROM >> CURRENT syntax and its description is missing from SET command's >> syntax page (http://www.postgresql.org/docs/devel/static/sql-set.html). >> >> Do