Re: [HACKERS] Bugfix and new feature for PGXS

2013-09-29 Thread Cédric Villemain
Le lundi 30 septembre 2013 00:10:09 Andrew Dunstan a écrit : > On 09/29/2013 07:09 PM, Andrew Dunstan wrote: > > On 09/03/2013 04:04 AM, Cédric Villemain wrote: > >>> Simple one, attached. > >>> I didn't document USE_VPATH, not sure how to explain that clearly. > >> > >> Just a remember that the d

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-09-29 Thread Daniel Farina
On Sun, Sep 29, 2013 at 10:25 AM, Sameer Thakur wrote: > Yes i was. Just saw a warning when pg_stat_statements is loaded that > valid values for pg_stat_statements.max is between 100 and 2147483647. > Not sure why though. I remember hacking that out for testing sake. I can only justify it as a f

Re: [HACKERS] Compression of full-page-writes

2013-09-29 Thread Amit Kapila
On Mon, Sep 30, 2013 at 10:04 AM, Fujii Masao wrote: > On Mon, Sep 30, 2013 at 1:27 PM, KONDO Mitsumasa > wrote: >> Hi Fujii-san, >> >> >> (2013/09/30 12:49), Fujii Masao wrote: >>> On second thought, the patch could compress WAL very much because I used >>> pgbench. >>> >>> I will do the same me

Re: [HACKERS] Compression of full-page-writes

2013-09-29 Thread Fujii Masao
On Mon, Sep 30, 2013 at 1:27 PM, KONDO Mitsumasa wrote: > Hi Fujii-san, > > > (2013/09/30 12:49), Fujii Masao wrote: >> On second thought, the patch could compress WAL very much because I used >> pgbench. >> >> I will do the same measurement by using another benchmark. > > If you hope, I can test

Re: [HACKERS] Compression of full-page-writes

2013-09-29 Thread KONDO Mitsumasa
Hi Fujii-san, (2013/09/30 12:49), Fujii Masao wrote: > On second thought, the patch could compress WAL very much because I used pgbench. I will do the same measurement by using another benchmark. If you hope, I can test this patch in DBT-2 benchmark in end of this week. I will use under follow

Re: [HACKERS] Bugfix and new feature for PGXS

2013-09-29 Thread Andrew Dunstan
On 09/29/2013 07:09 PM, Andrew Dunstan wrote: On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by Chris

Re: [HACKERS] gaussian distribution pgbench

2013-09-29 Thread KONDO Mitsumasa
(2013/09/27 5:29), Peter Eisentraut wrote: > This patch no longer applies. I will try to create this patch in next commit fest. If you have nice idea, please send me! Regards, -- Mitsumasa KONDO NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] gaussian distribution pgbench

2013-09-29 Thread KONDO Mitsumasa
Sorry for my delay reply. Since I have had vacation last week, I replied from gmail. However, it was stalled post to pgsql-hackers:-( (2013/09/21 7:54), Fabien COELHO wrote: However this pattern induces stronger cache effects which are maybe not too realistic, because neighboring keys in the mi

Re: [HACKERS] gaussian distribution pgbench

2013-09-29 Thread KONDO Mitsumasa
Sorry for my delay reply. Since I have had vacation last week, I replyed from gmail. However, it was stalled post to pgsql-hackers:-( (2013/09/21 6:05), Kevin Grittner wrote: > You had accidentally added to the CF In Progress. Oh, I had completely mistook this CF schedule :-) Maybe, Horiguchi-san

Re: [HACKERS] Compression of full-page-writes

2013-09-29 Thread Fujii Masao
On Wed, Sep 11, 2013 at 7:39 PM, Fujii Masao wrote: > On Fri, Aug 30, 2013 at 11:55 AM, Fujii Masao wrote: >> Hi, >> >> Attached patch adds new GUC parameter 'compress_backup_block'. >> When this parameter is enabled, the server just compresses FPW >> (full-page-writes) in WAL by using pglz_compr

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Alvaro Herrera
Gilles Darold escribió: > + else if (strcmp(param, "numericlocale") == 0) > + { > + if (popt->topt.numericLocale) > + puts(_("Locale-adjusted numeric output (numericlocale) > is on.")); > + else > + puts(_("Locale-adjusted nu

Re: [HACKERS] pgbench filler columns

2013-09-29 Thread Fujii Masao
On Fri, Sep 27, 2013 at 4:03 PM, Pavan Deolasee wrote: > On Thu, Sep 26, 2013 at 7:20 PM, Noah Misch wrote: >> >> On Thu, Sep 26, 2013 at 03:23:30PM +0530, Pavan Deolasee wrote: >> >> > Should we just fix the comment and say its applicable for all tables >> > except >> > accounts ? >> >> Please d

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Andrew Dunstan
On 09/29/2013 10:38 PM, Peter Eisentraut wrote: On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write them in your git repo might be a clue to that. Git doesn't support setting file permissions other than the executable

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Peter Eisentraut
On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: > Well if these are not meant to be changed then not being able to write > them in your git repo might be a clue to that. Git doesn't support setting file permissions other than the executable bit, so this is a nonstarter. -- Sent via

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Andrew Dunstan
On 09/29/2013 09:58 PM, Peter Eisentraut wrote: On Fri, 2013-09-27 at 13:23 -0400, Andrew Dunstan wrote: This was lazy and there's no real excuse, although I will note that it was a mistake far too easy to make. Perhaps as a warning indicator we should remove write permissions from these files.

Re: [HACKERS] appendStringInfo vs appendStringInfoString

2013-09-29 Thread Peter Eisentraut
On Sat, 2013-09-28 at 21:50 +1200, David Rowley wrote: > Also on making the changes I noticed a possible small bug in the code > that could cause a crash if for some reason a translation contained a > %s. I know it is an unlikely scenario, never-the-less here is a patch > to fix it. There are mech

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Peter Eisentraut
On Fri, 2013-09-27 at 13:23 -0400, Andrew Dunstan wrote: > This was lazy and there's no real excuse, although I will note that it > was a mistake far too easy to make. Perhaps as a warning indicator we > should remove write permissions from these files. What do you mean by that? > See attached

Re: [HACKERS] Bugfix and new feature for PGXS

2013-09-29 Thread Andrew Dunstan
On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by Christoph with the installdirs prerequisite, the atta

Re: [HACKERS] Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls

2013-09-29 Thread Nicholas White
> bms_add_member() is an accident waiting to happen I've attached a patch that makes it use repalloc as suggested - is it OK to commit separately? I'll address the lead-lag patch comments in the next couple of days. Thanks - repalloc.patch Description: Binary data -- Sent via pgsql-hackers mai

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Pavel Stehule
> Pavel > > > Hello, > > Sorry for the delay, here is the new patch. The \pset output will look > like follow: > > postgres=# \pset > > Border style (border) is 1. > Target width (columns) unset. > > Expanded display (expanded) is off. > Field separator (fieldsep) is "|". > Default footer (footer)

Re: [HACKERS] record identical operator - Review

2013-09-29 Thread Steve Singer
On 09/28/2013 03:03 PM, Kevin Grittner wrote: +To support matching of rows which include elements without a default +B-tree operator class, the following operators are defined for composite +type comparison: +*=, +*<>, +*<, +*<=, +*>, and +*>=. +These oper

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-09-29 Thread Sameer Thakur
On Mon, Sep 23, 2013 at 1:26 PM, samthakur74 wrote: >> >> I forgot about removal of the relevant SGML, amended here in v6. > > Thank you for this! > i did a quick test with following steps: > 1. Applied v6 patch > 2. make and make install on pg_stat_statements; > 3. Restarted Postgres with pg_stat

[HACKERS] Upcoming backbranch releases

2013-09-29 Thread Dave Page
Just a quick heads-up: following discussion within the core team and the packagers, we're planning to wrap tarballs for 8.4 - 9.3 backbranch releases on Monday 7th October for release on Thursday 10th. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.e

Re: [HACKERS] appendStringInfo vs appendStringInfoString

2013-09-29 Thread David Rowley
On Sat, Sep 28, 2013 at 11:11 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > On 28.09.2013 12:44, David Rowley wrote: > >> The macro for test 4 was as follows: >> #define appendStringInfoStringConst(**buf, s) appendBinaryStringInfo(buf, >> (s), sizeof(s)-1) >> > > If that makes any dif

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Gilles Darold
Le 07/09/2013 21:22, Pavel Stehule a écrit : > > > > 2013/9/7 Gilles Darold > > > Le 07/09/2013 10:02, Pavel Stehule a écrit : > > Hello > > > > * patch is cleanly patchable and compilation is without warnings > > * all regression tests passed >

[HACKERS] Patch: FORCE_NULL option for copy COPY in CSV mode

2013-09-29 Thread Ian Lawrence Barwick
Hi, This patch implements the following TODO item: Allow COPY in CSV mode to control whether a quoted zero-length string is treated as NULL Currently this is always treated as a zero-length string, which generates an error when loading into an integer column Re: [PATCHES