Re: [HACKERS] Change authentication error message (patch)

2013-06-19 Thread Markus Wanner
On 06/20/2013 12:51 AM, Jeff Janes wrote: > I think we need to keep the first "password". "Password authentication" > is a single thing, it is the authentication method attempted. It is the > password method (which includes MD5) which failed, as opposed to the > LDAP method or the Peer method or

Re: [HACKERS] Re: Adding IEEE 754:2008 decimal floating point and hardware support for it

2013-06-19 Thread Simon Riggs
On 20 June 2013 06:45, Craig Ringer wrote: > I think a good starting point would be to use the Intel and IBM > libraries to implement basic DECIMAL32/64/128 to see if they perform > better than the gcc builtins tested by Pavel by adapting his extension. > > If the performance isn't interesting it

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Simon Riggs
On 20 June 2013 04:26, Satoshi Nagayasu wrote: > I'm looking into this patch as a reviewer. > > > (2013/06/19 18:03), Simon Riggs wrote: >> >> On 19 June 2013 09:19, Kyotaro HORIGUCHI >> wrote: >> >>> It should useful in other aspects but it seems a bit complicated >>> just to know about visibili

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-19 Thread Amit Kapila
On Wednesday, June 19, 2013 10:45 PM Sawada Masahiko wrote: On Tuesday, June 18, 2013, Amit Kapila wrote: On Tuesday, June 18, 2013 12:18 AM Sawada Masahiko wrote: > On Sun, Jun 16, 2013 at 2:00 PM, Amit kapila > wrote: > > On Saturday, June 15, 2013 8:29 PM Sawada Masahiko wrote: > > On Sat, Jun

Re: [HACKERS] Re: Adding IEEE 754:2008 decimal floating point and hardware support for it

2013-06-19 Thread Craig Ringer
On 06/12/2013 07:51 PM, Andres Freund wrote: > On 2013-06-12 19:47:46 +0800, Craig Ringer wrote: >> On 06/12/2013 05:55 PM, Greg Stark wrote: >>> On Wed, Jun 12, 2013 at 12:56 AM, Craig Ringer >>> wrote: The main thing I'm wondering is how/if to handle backward compatibility with

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Alvaro Herrera
Amit Kapila wrote: > Currently header comment is: > # Do not edit this file manually! > # It will be overwritten by ALTER SYSTEM command. > > Kindly let me know your suggestion about the above comment in header? This seems perfect to me. -- Álvaro Herrerahttp://www.2ndQuadrant

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Craig Ringer
On 06/20/2013 11:26 AM, Peter Eisentraut wrote: > 3) Install them in a different directory and require a different > #include line. But then you have to change the existing uses as well, > which would probably require moving files around. If I understand you correctly, your concern seems to be w

Re: [HACKERS] Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2013-06-19 Thread Amit Langote
On Wed, Jun 19, 2013 at 12:45 PM, Fabrízio de Royes Mello wrote: > On Mon, Jun 17, 2013 at 11:33 PM, Peter Eisentraut wrote: >> >> Replace/alter the object if it already exists, but fail if it does not >> exist. >> >> The complete set of variants is: >> >> - object does not exist: >> >> - pro

Re: [HACKERS] C++ compiler

2013-06-19 Thread Craig Ringer
On 06/16/2013 03:19 AM, Gaetano Mendola wrote: > I have read Peter Eisentraut blog entry about "Moving to C++", I full agree > with him about what he wrote. > > Is there any interest or work in progress in making the entire Postgresql > code base compilable by a C++ compiler? Well, from Peter at le

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Amit Kapila
On Thursday, June 20, 2013 12:32 AM Alvaro Herrera wrote: > Magnus Hagander wrote: > > On Jun 19, 2013 7:55 PM, "Peter Eisentraut" wrote: > > > > generated_by_server.conf > > > > System.conf? > > alter_system.conf ? All the names proposed in this thread are as follows: Auto.conf- 1

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Amit Kapila
On Thursday, June 20, 2013 3:53 AM Tom Lane wrote: > Josh Berkus writes: > > True, but can you think of a better word to mean "don't edit this by > hand"? > > The file name is not nearly as important for that as putting in a > header comment "# Don't edit this file by hand." Currently header com

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-06-19 Thread Amit Kapila
On Wednesday, June 19, 2013 11:30 PM Peter Eisentraut wrote: > On 6/7/13 12:14 AM, Amit Kapila wrote: > > I will change the patch as per below syntax if there are no > objections: > > > > ALTER SYSTEM SET configuration_parameter {TO | =} {value, | > 'value'}; > > I do like using ALTER SYSTEM in g

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-19 Thread fabriziomello
> New submission which put long options in alphabetical order, which seems > more logical. > > This is for reference to the next commitfest. When I applied your patch appeared the following messages: $ patch -p1 < /tmp/pgbench-longopts.patch patching file contrib/pgbench/pgbench.c Hunk #1 succe

Re: [HACKERS] Add visibility map information to pg_freespace.

2013-06-19 Thread Satoshi Nagayasu
I'm looking into this patch as a reviewer. (2013/06/19 18:03), Simon Riggs wrote: On 19 June 2013 09:19, Kyotaro HORIGUCHI wrote: It should useful in other aspects but it seems a bit complicated just to know about visibility bits for certain blocks. With your current patch you can only see

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Peter Eisentraut
On Wed, 2013-06-19 at 20:58 +0200, Cédric Villemain wrote: > I believe he answered the proposal to put all headers on the same flat > directory, instead of a tree. The headers are used as #include "hstore.h" #include "ltree.h" etc. in the existing source code. If you want to install the for us

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-19 Thread Satoshi Nagayasu
(2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu wrote: It is obviously easy to keep two types of function interfaces, one with regclass-type and another with text-type, in the next release for backward-compatibility like below: pgstattuple(regclass) -- s

Re: [HACKERS] slightly confusing JSON error context

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 09:19 PM, Peter Eisentraut wrote: These are some cases from the regression tests: SELECT ''::json;-- ERROR, no value ERROR: invalid input syntax for type json LINE 1: SELECT ''::json; ^ DETAIL: The input string ended unexpectedly. CONTEXT: JSON d

Re: backend hangs at immediate shutdown (Re: [HACKERS] Back-branch update releases coming in a couple weeks)

2013-06-19 Thread Alvaro Herrera
MauMau escribió: > Could you review the patch? The summary of the change is: > 1. postmaster waits for children to terminate when it gets an > immediate shutdown request, instead of exiting. > > 2. postmaster sends SIGKILL to remaining children if all of the > child processes do not terminate wi

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Peter Eisentraut
On Wed, 2013-06-19 at 14:50 -0700, Jeff Janes wrote: > Is there an infrastructure to use a different expected file depending > on the LANG used? Not really. A couple of years ago I did the same exercise you just did, and we just fixed most of what was reasonable to fix by adjusting the test case

Re: [HACKERS] pg_resetxlog -m documentation not up to date

2013-06-19 Thread Alvaro Herrera
Peter Eisentraut wrote: > Ping. This ought to be fixed before 9.3 goes out. Will fix. > On Sat, 2013-04-27 at 21:22 -0400, Peter Eisentraut wrote: > > The pg_resetxlog -m option was changed from -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: [HACKERS] pg_resetxlog -m documentation not up to date

2013-06-19 Thread Peter Eisentraut
Ping. This ought to be fixed before 9.3 goes out. On Sat, 2013-04-27 at 21:22 -0400, Peter Eisentraut wrote: > The pg_resetxlog -m option was changed from > > -m XID set next multitransaction ID > > to > > -m XID,OLDESTset next multitransaction ID and oldest value > > but t

[HACKERS] warn_unused_result in pgbench

2013-06-19 Thread Peter Eisentraut
When building without thread safety, I get the following compiler warning in pgbench: pgbench.c:2612:2: error: ignoring return value of function declared with warn_unused_result attribute [-Werror,-Wunused-result] write(th->pipes[1], ret, sizeof(TResult)); That should be fixed, I think.

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
> On Wed, Jun 19, 2013 at 8:40 PM, Tatsuo Ishii wrote: >>> On Wed, Jun 19, 2013 at 6:20 PM, Stephen Frost wrote: * Claudio Freire (klaussfre...@gmail.com) wrote: > I don't see how this is better than snapshotting at the filesystem > level. I have no experience with TB scale databases

[HACKERS] slightly confusing JSON error context

2013-06-19 Thread Peter Eisentraut
These are some cases from the regression tests: SELECT ''::json;-- ERROR, no value ERROR: invalid input syntax for type json LINE 1: SELECT ''::json; ^ DETAIL: The input string ended unexpectedly. CONTEXT: JSON data, line 1: SELECT ''::json;-- ER

Re: [HACKERS] event trigger API documentation?

2013-06-19 Thread Peter Eisentraut
Random observation in this general area: Regular triggers provide the field Trigger *tg_trigger in the trigger data, which allows you to get the trigger name, OID, and such. Event triggers don't expose anything comparable. That should perhaps be added. Also, as I'm maybe about the fourth person

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 8:40 PM, Tatsuo Ishii wrote: >> On Wed, Jun 19, 2013 at 6:20 PM, Stephen Frost wrote: >>> * Claudio Freire (klaussfre...@gmail.com) wrote: I don't see how this is better than snapshotting at the filesystem level. I have no experience with TB scale databases (I've

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Stephen Frost
* Tatsuo Ishii (is...@postgresql.org) wrote: > Why do you think WAL compressor idea is more scalable? I really want > to know why. Besides the unlogged tables issue, I can accept the idea > if WAL based solution is much more efficient. If there's no perfect, > ideal solution, we need to prioritize

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Stephen Frost
* Tatsuo Ishii (is...@postgresql.org) wrote: > I don't think using rsync (or tar or whatever general file utils) > against TB database for incremental backup is practical. If it's > practical, I would never propose my idea. You could use rsync for incremental updates if you wanted, it'd certainly

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
> On Wed, Jun 19, 2013 at 6:20 PM, Stephen Frost wrote: >> * Claudio Freire (klaussfre...@gmail.com) wrote: >>> I don't see how this is better than snapshotting at the filesystem >>> level. I have no experience with TB scale databases (I've been limited >>> to only hundreds of GB), but from my lim

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
> * Tatsuo Ishii (is...@postgresql.org) wrote: >> > * Tatsuo Ishii (is...@postgresql.org) wrote: >> >> Yeah, at first I thought using WAL was a good idea. However I realized >> >> that the problem using WAL is we cannot backup unlogged tables because >> >> they are not written to WAL. >> > >> > U

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Stephen Frost
* Tatsuo Ishii (is...@postgresql.org) wrote: > > * Tatsuo Ishii (is...@postgresql.org) wrote: > >> Yeah, at first I thought using WAL was a good idea. However I realized > >> that the problem using WAL is we cannot backup unlogged tables because > >> they are not written to WAL. > > > > Unlogged

Re: [HACKERS] SET work_mem = '1TB';

2013-06-19 Thread Fujii Masao
On Wed, Jun 19, 2013 at 4:47 PM, Simon Riggs wrote: > On 18 June 2013 22:57, Fujii Masao wrote: >> On Wed, Jun 19, 2013 at 2:40 AM, Simon Riggs wrote: >>> On 18 June 2013 17:10, Fujii Masao wrote: On Tue, Jun 18, 2013 at 1:06 PM, Jeff Janes wrote: > On Tuesday, May 21, 2013, Simon Rig

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
> * Tatsuo Ishii (is...@postgresql.org) wrote: >> Yeah, at first I thought using WAL was a good idea. However I realized >> that the problem using WAL is we cannot backup unlogged tables because >> they are not written to WAL. > > Unlogged tables are also nuked on recovery, so I'm not sure why yo

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Stephen Frost
* Tatsuo Ishii (is...@postgresql.org) wrote: > Yeah, at first I thought using WAL was a good idea. However I realized > that the problem using WAL is we cannot backup unlogged tables because > they are not written to WAL. Unlogged tables are also nuked on recovery, so I'm not sure why you think a

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
>>> I'm trying to figure out how that's actually different from WAL..? It >>> sounds like you'd get what you're suggesting with simply increasing the >>> checkpoint timeout until the WAL stream is something which you can keep >>> up with. Of course, the downside there is that you'd have to replay

Re: [HACKERS] Change authentication error message (patch)

2013-06-19 Thread Jeff Janes
On Wed, Jun 19, 2013 at 11:55 AM, Joshua D. Drake wrote: > > On 06/18/2013 02:25 AM, Markus Wanner wrote: > >> >> On 06/16/2013 06:02 PM, Joshua D. Drake wrote: >> >>> >>> >> How about: >> "password authentication failed or account expired for user \"%s\"" >> >> It's a bit longer, but sounds more

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 7:39 PM, Tatsuo Ishii wrote: >>> I'm thinking of implementing an incremental backup tool for >>> PostgreSQL. The use case for the tool would be taking a backup of huge >>> database. For that size of database, pg_dump is too slow, even WAL >>> archive is too slow/ineffective

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Tatsuo Ishii
>> I'm thinking of implementing an incremental backup tool for >> PostgreSQL. The use case for the tool would be taking a backup of huge >> database. For that size of database, pg_dump is too slow, even WAL >> archive is too slow/ineffective as well. However even in a TB >> database, sometimes actu

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 7:18 PM, Alvaro Herrera wrote: > If you have the two technologies, you could teach them to work in > conjunction: you set up WAL replication, and tell the WAL compressor to > prune updates for high-update tables (avoid useless traffic), then use > incremental backup to back

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Tom Lane
Josh Berkus writes: > True, but can you think of a better word to mean "don't edit this by hand"? The file name is not nearly as important for that as putting in a header comment "# Don't edit this file by hand." regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Alvaro Herrera
Claudio Freire escribió: > On Wed, Jun 19, 2013 at 6:20 PM, Stephen Frost wrote: > > * Claudio Freire (klaussfre...@gmail.com) wrote: > >> I don't see how this is better than snapshotting at the filesystem > >> level. I have no experience with TB scale databases (I've been limited > >> to only hun

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Kevin Grittner
Jeff Janes wrote: > Kevin Grittner wrote: >> Peter Eisentraut wrote: >>> On 6/19/13 9:18 AM, Kevin Grittner wrote: >> >> Does anyone object to the attached change, so that regression tests pass when run in a Danish locale?  I think it should be back-patched to 9.2, where the test

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 6:20 PM, Stephen Frost wrote: > * Claudio Freire (klaussfre...@gmail.com) wrote: >> I don't see how this is better than snapshotting at the filesystem >> level. I have no experience with TB scale databases (I've been limited >> to only hundreds of GB), but from my limited m

Re: [HACKERS] Vacuum/visibility is busted

2013-06-19 Thread Jeff Janes
On Thu, Feb 7, 2013 at 12:01 PM, Andres Freund wrote: > On 2013-02-07 11:15:46 -0800, Jeff Janes wrote: > > > > Does anyone have suggestions on how to hack the system to make it > > fast-forward the current transaction id? It would certainly make > > testing this kind of thing faster if I could ma

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Jeff Janes
On Wed, Jun 19, 2013 at 8:41 AM, Kevin Grittner wrote: > Peter Eisentraut wrote: > > On 6/19/13 9:18 AM, Kevin Grittner wrote: > > >> Does anyone object to the attached change, so that regression tests > >> pass when run in a Danish locale? I think it should be > >> back-patched to 9.2, where t

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Stephen Frost
* Claudio Freire (klaussfre...@gmail.com) wrote: > I don't see how this is better than snapshotting at the filesystem > level. I have no experience with TB scale databases (I've been limited > to only hundreds of GB), but from my limited mid-size db experience, > filesystem snapshotting is pretty m

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-19 Thread Cédric Villemain
Le mercredi 19 juin 2013 22:22:22, Andrew Dunstan a écrit : > On 06/19/2013 03:52 PM, Dimitri Fontaine wrote: > > Peter Eisentraut writes: > >> We could do something like > >> > >> PG_CONFIG = fake_intree_pg_config > >> PGXS := $(shell $(PG_CONFIG) --pgxs) > >> include $(PGXS) > > > > There's so

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 04:47 PM, Dimitri Fontaine wrote: Andrew Dunstan writes: Not true - you're forgetting there is no pgxs for MSVC builds. Oh, indeed, totally forgot about that. If we're going to enable building of contrib modules using pgxs but without an install we will make targets for that,

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19-06-2013 17:41, Kevin Grittner wrote: > > OK, pushed without the comment. > Works like a charm :) Svenne -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQI5BAE

Re: [HACKERS] FP precision

2013-06-19 Thread Kevin Grittner
Sorry folks.  That email was misdirected by accident. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Cédric Villemain
Le mercredi 19 juin 2013 21:06:23, Alvaro Herrera a écrit : > Peter Eisentraut wrote: > > On 6/19/13 12:20 PM, Andrew Dunstan wrote: > > > So you're saying to install extension headers, but into the main > > > directory where we put server headers? > > > > Yes, if we choose to install some extensi

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-19 Thread Dimitri Fontaine
Andrew Dunstan writes: > Not true - you're forgetting there is no pgxs for MSVC builds. Oh, indeed, totally forgot about that. > If we're going to enable building of contrib modules using pgxs but without > an install we will make targets for that, and buildfarm support. So we would need some k

Re: [HACKERS] Change authentication error message (patch)

2013-06-19 Thread Joshua D. Drake
On 06/19/2013 01:18 PM, Markus Wanner wrote: "Authentication failed or password has expired for user \"%s\"" Authentication failed covers any combination of a username/password being wrong and obviously password expired covers the other. Works for me. Considering the password to be the thing

[HACKERS] FP precision

2013-06-19 Thread Kevin Grittner
test=# select '100'::real + '5'::real;  ?column? --     1e+06 (1 row) test=# select '100'::real + '6'::real;   ?column?   -  1.1e+06 (1 row) test=# select '0.1'::real + 0.0; ?column?  ---  0.10001490116 (1 row) -- Sent via pgsql-

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 03:52 PM, Dimitri Fontaine wrote: Peter Eisentraut writes: We could do something like PG_CONFIG = fake_intree_pg_config PGXS := $(shell $(PG_CONFIG) --pgxs) include $(PGXS) There's something to that idea. Of course we would need to offer a comment about the PG_CONFIG game and p

Re: [HACKERS] Change authentication error message (patch)

2013-06-19 Thread Markus Wanner
This probably is nit-picking, but it interests me in terms of how the language is used and understood. On 06/19/2013 08:55 PM, Joshua D. Drake wrote: > I believe it actually can. The error message that is returned for a bad > password, bad user or expired password is all the same. Which is why I >

Re: [HACKERS] [PATCH] add --throttle to pgbench (submission 3)

2013-06-19 Thread Fabien COELHO
Because you may want to put something very readable and understandable in a script and like long options, or have to type it interactively every day in a terminal and like short ones. Most UNIX commands include both kind. Would it make sense then to add long versions for all the other standard

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-06-19 Thread Dimitri Fontaine
Peter Eisentraut writes: > We could do something like > > PG_CONFIG = fake_intree_pg_config > PGXS := $(shell $(PG_CONFIG) --pgxs) > include $(PGXS) There's something to that idea. Of course we would need to offer a comment about the PG_CONFIG game and propose something else for real world extens

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 3:54 PM, Jim Nasby wrote: > On 6/19/13 11:02 AM, Claudio Freire wrote: >> >> On Wed, Jun 19, 2013 at 7:13 AM, Tatsuo Ishii >> wrote: >>> >>> >>> For now, my idea is pretty vague. >>> >>> - Record info about modified blocks. We don't need to remember the >>>whole histor

Re: [HACKERS] pg_dump cosmetic problem while dumping/restoring rules

2013-06-19 Thread Gražvydas Valeika
> This has been fixed by Joe Conway meanwhile. > Nice, thaks!

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 6/19/13 12:20 PM, Andrew Dunstan wrote: > > So you're saying to install extension headers, but into the main > > directory where we put server headers? > > Yes, if we choose to install some extension headers, that is where we > should put them. The question of the nam

Re: [HACKERS] Change authentication error message (patch)

2013-06-19 Thread Joshua D. Drake
On 06/18/2013 02:25 AM, Markus Wanner wrote: On 06/16/2013 06:02 PM, Joshua D. Drake wrote: Instead of pushing extra info to the logs I decided that we could without giving away extra details per policy. I wrote the error message in a way that tells the most obvious problems, without admitting

Re: [HACKERS] How do we track backpatches?

2013-06-19 Thread Alvaro Herrera
Josh Berkus wrote: > > > I'd imagine having a "CF" entry per release, so after a set of minor > > releases, the "CF" is closed. > > How would we name these? > > Also, what about patches for beta? Should we have a "beta" CF? Don't we have the Open Items wiki page for those? Seems to work well

Re: [HACKERS] [PATCH] Add transforms feature

2013-06-19 Thread Peter Eisentraut
On 6/17/13 5:31 PM, Alvaro Herrera wrote: > This is a large patch. Do you intend to push the whole thing as a > single commit, or split it? I thought about splitting it up, but I didn't find a reasonable way to do it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Alvaro Herrera
Magnus Hagander wrote: > On Jun 19, 2013 7:55 PM, "Peter Eisentraut" wrote: > > generated_by_server.conf > > System.conf? alter_system.conf ? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mai

Re: [HACKERS] Bad error message on valuntil

2013-06-19 Thread Joshua D. Drake
On 06/19/2013 08:24 AM, Peter Eisentraut wrote: I think it's intentional that we don't tell the *client* that level of detail. I could see emitting a log message about it, but it's not clear whether that will help an unsophisticated user. Usually, when I log in somewhere and the password is

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Cédric Villemain
Le mercredi 19 juin 2013 18:48:21, Andrew Dunstan a écrit : > On 06/19/2013 12:32 PM, Cédric Villemain wrote: > > Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit : > >> On 06/19/2013 11:26 AM, Peter Eisentraut wrote: > >>> On 6/19/13 10:19 AM, Andrew Dunstan wrote: > What are they go

Re: [HACKERS] How do we track backpatches?

2013-06-19 Thread Magnus Hagander
On Wed, Jun 19, 2013 at 8:54 PM, Alvaro Herrera wrote: > Josh Berkus wrote: >> >> > I'd imagine having a "CF" entry per release, so after a set of minor >> > releases, the "CF" is closed. >> >> How would we name these? >> >> Also, what about patches for beta? Should we have a "beta" CF? > > Don't

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Jim Nasby
On 6/19/13 11:02 AM, Claudio Freire wrote: On Wed, Jun 19, 2013 at 7:13 AM, Tatsuo Ishii wrote: For now, my idea is pretty vague. - Record info about modified blocks. We don't need to remember the whole history of a block if the block was modified multiple times. We just remember that t

Re: [HACKERS] [PATCH] add --throttle to pgbench (submission 3)

2013-06-19 Thread Jan Wieck
On 06/19/13 14:34, Fabien COELHO wrote: > >>> The use case of the option is to be able to generate a continuous gentle >>> load for functional tests, eg in a practice session with students or for >>> testing features on a laptop. >> >> Why does this need two option formats (-H and --throttle)? >

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

2013-06-19 Thread Fabien COELHO
number of transactions actually processed: 301921 Just a thought before spending too much time on this subtle issue. The patch worked reasonnably for 301900 transactions in your above run, and the few last ones, less than the number of clients, show strange latency figures which suggest tha

Re: [HACKERS] [PATCH] add --throttle to pgbench (submission 3)

2013-06-19 Thread Fabien COELHO
The use case of the option is to be able to generate a continuous gentle load for functional tests, eg in a practice session with students or for testing features on a laptop. Why does this need two option formats (-H and --throttle)? On the latest version it is --rate and -R. Because you m

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-06-19 Thread Peter Eisentraut
On 6/7/13 12:14 AM, Amit Kapila wrote: > I will change the patch as per below syntax if there are no objections: > > ALTER SYSTEM SET configuration_parameter {TO | =} {value, | 'value'}; I do like using ALTER SYSTEM in general, but now that I think about it, the 9.3 feature to create global sett

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Magnus Hagander
On Jun 19, 2013 7:55 PM, "Peter Eisentraut" wrote: > > On 6/19/13 1:49 PM, Josh Berkus wrote: > > On 06/19/2013 10:48 AM, Peter Eisentraut wrote: > >> On 6/13/13 5:47 PM, Josh Berkus wrote: > 2. File name to store settings set by ALTER SYSTEM command is still > > persistent.auto.conf > >>

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Peter Eisentraut
On 6/19/13 1:49 PM, Josh Berkus wrote: > On 06/19/2013 10:48 AM, Peter Eisentraut wrote: >> On 6/13/13 5:47 PM, Josh Berkus wrote: 2. File name to store settings set by ALTER SYSTEM command is still > persistent.auto.conf >>> Why? Shouldn't it just be auto.conf? Or system.auto.conf? >>>

Re: [HACKERS] how to find out whether a view is updatable

2013-06-19 Thread Dean Rasheed
On 19 June 2013 18:12, Peter Eisentraut wrote: > On 6/19/13 11:50 AM, Dean Rasheed wrote: >> On 19 June 2013 15:22, Peter Eisentraut wrote: >>> We still don't have any support for this in psql, do we? >>> >> >> No, but at least we now have an API that psql can use. >> >> There are still a number

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Josh Berkus
On 06/19/2013 10:48 AM, Peter Eisentraut wrote: > On 6/13/13 5:47 PM, Josh Berkus wrote: >>> 2. File name to store settings set by ALTER SYSTEM command is still persistent.auto.conf >> Why? Shouldn't it just be auto.conf? Or system.auto.conf? >> >> I prefer auto.conf, personally. > > Well,

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Peter Eisentraut
On 6/13/13 5:47 PM, Josh Berkus wrote: >> 2. File name to store settings set by ALTER SYSTEM command is still >> > persistent.auto.conf > Why? Shouldn't it just be auto.conf? Or system.auto.conf? > > I prefer auto.conf, personally. Well, not much about it is automatic, really. It's just set el

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-19 Thread Sawada Masahiko
On Tuesday, June 18, 2013, Amit Kapila wrote: > On Tuesday, June 18, 2013 12:18 AM Sawada Masahiko wrote: > > On Sun, Jun 16, 2013 at 2:00 PM, Amit kapila > > > > > > wrote: > > > On Saturday, June 15, 2013 8:29 PM Sawada Masahiko wrote: > > > On Sat, Jun 15, 2013 at 10:34 PM, Amit kapila > > >

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Peter Eisentraut
On 6/19/13 12:20 PM, Andrew Dunstan wrote: > So you're saying to install extension headers, but into the main > directory where we put server headers? Yes, if we choose to install some extension headers, that is where we should put them. -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

Re: [HACKERS] How do we track backpatches?

2013-06-19 Thread Josh Berkus
> I'd imagine having a "CF" entry per release, so after a set of minor > releases, the "CF" is closed. How would we name these? Also, what about patches for beta? Should we have a "beta" CF? -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] how to find out whether a view is updatable

2013-06-19 Thread Peter Eisentraut
On 6/19/13 11:50 AM, Dean Rasheed wrote: > On 19 June 2013 15:22, Peter Eisentraut wrote: >> We still don't have any support for this in psql, do we? >> > > No, but at least we now have an API that psql can use. > > There are still a number of questions about the best way to display it in > psq

Re: [HACKERS] pg_dump cosmetic problem while dumping/restoring rules

2013-06-19 Thread Dimitri Fontaine
Gražvydas Valeika writes: > - create new database; > - CREATE EXTENSION IF NOT EXISTS postgis WITH SCHEMA public; > - backup it; > - create new database and restore it from this new backup. > > It produces 3 errors while executing these 3 statements: This has been fixed by Joe Conway meanwhile.

Re: [HACKERS] event trigger API documentation?

2013-06-19 Thread Dimitri Fontaine
Peter Eisentraut writes: > Looks pretty good, but the description of the parsetree field was > obviously copied from somewhere else. I would fix it myself, but I > don't know what kind of assurances we want to offer about what's in that > field. Oh, oops. I think we should direct the reader to

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 12:32 PM, Cédric Villemain wrote: Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit : On 06/19/2013 11:26 AM, Peter Eisentraut wrote: On 6/19/13 10:19 AM, Andrew Dunstan wrote: What are they going to be used for anyway? I rubbed up against this not too long ago. Things

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Cédric Villemain
Le mercredi 19 juin 2013 18:20:11, Andrew Dunstan a écrit : > On 06/19/2013 11:26 AM, Peter Eisentraut wrote: > > On 6/19/13 10:19 AM, Andrew Dunstan wrote: > >> What are they going to be used for anyway? I rubbed up against this not > >> too long ago. Things will blow up if you use stuff from the

Re: [HACKERS] Patch for removng unused targets

2013-06-19 Thread Hitoshi Harada
On Wed, Jun 19, 2013 at 4:49 AM, Etsuro Fujita wrote: > Hi Harada-san, > > ** ** > > Thank you for the review. > > ** ** > > I think that the parse tree has enough information to do this optimization > and that the easiest way to do it is to use the information, though I might > not have u

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 11:26 AM, Peter Eisentraut wrote: On 6/19/13 10:19 AM, Andrew Dunstan wrote: What are they going to be used for anyway? I rubbed up against this not too long ago. Things will blow up if you use stuff from the module and the module isn't already loaded. See transforms. So you'

Re: [HACKERS] Implementing incremental backup

2013-06-19 Thread Claudio Freire
On Wed, Jun 19, 2013 at 7:13 AM, Tatsuo Ishii wrote: > > For now, my idea is pretty vague. > > - Record info about modified blocks. We don't need to remember the > whole history of a block if the block was modified multiple times. > We just remember that the block was modified since the last >

Re: [HACKERS] how to find out whether a view is updatable

2013-06-19 Thread Dean Rasheed
On 19 June 2013 15:22, Peter Eisentraut wrote: > We still don't have any support for this in psql, do we? > No, but at least we now have an API that psql can use. There are still a number of questions about the best way to display it in psql. Should it be another column in \d+'s list of relation

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Kevin Grittner
Peter Eisentraut wrote: > On 6/19/13 9:18 AM, Kevin Grittner wrote: >> Does anyone object to the attached change, so that regression tests >> pass when run in a Danish locale?  I think it should be >> back-patched to 9.2, where the test was introduced. > > Yes, that should be fixed.  I wouldn't p

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Peter Eisentraut
On 6/19/13 10:19 AM, Andrew Dunstan wrote: > What are they going to be used for anyway? I rubbed up against this not > too long ago. Things will blow up if you use stuff from the module and > the module isn't already loaded. See transforms. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Bad error message on valuntil

2013-06-19 Thread Peter Eisentraut
On 6/7/13 2:57 PM, Tom Lane wrote: > "Joshua D. Drake" writes: >> I had a customer pulling their hair out today because they couldn't >> login to their system. The error was consistently: > >> 2013-06-07 08:42:44 MST postgres 10.1.11.67 27440 FATAL: password >> authentication failed for user "u

[HACKERS] Push down

2013-06-19 Thread Yacov Wolfowicz
Hi all, I'm writing a foreign data wrapper in which i'm taking control of various aspects of SELECT queries (such as join, order by, count, sum etc.). Is it possible? for example, when trying to count(*), i see that pg supplies an empty list of columns to select from, and probably does the counti

Re: [HACKERS] how to find out whether a view is updatable

2013-06-19 Thread Peter Eisentraut
On 6/13/13 1:37 AM, Dean Rasheed wrote: > On 12 June 2013 23:01, Tom Lane wrote: >> > Dean Rasheed writes: >>> >> [ pg_relation_is_updatable.patch ] >> > >> > I've committed this with some modifications as mentioned. There is >> > still room to debate exactly what >> > information_schema.columns

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Andrew Dunstan
On 06/19/2013 10:06 AM, Peter Eisentraut wrote: On 6/19/13 5:55 AM, Cédric Villemain wrote: Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a écrit : On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote: This allows for example to install hstore header and be able to include them in

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-19 Thread Peter Eisentraut
On 6/19/13 5:55 AM, Cédric Villemain wrote: > Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a écrit : >> On Tue, 2013-06-18 at 15:52 +0200, Cédric Villemain wrote: >>> This allows for example to install hstore header and be able to >>> include them >>> >>> in another extension like that: >>>

Re: [HACKERS] Git-master regression failure

2013-06-19 Thread Peter Eisentraut
On 6/19/13 9:18 AM, Kevin Grittner wrote: > Svenne Krap wrote: >> On 18-06-2013 22:18, Jeff Janes wrote: > >>>In Danish, apparently 'AA' > 'WA', so two more rows show up. >> >> Yes of course >> >> We have three extra vowels following Z (namely Æ, Ø and Å) and >> for keyboard missing those

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

2013-06-19 Thread Fabien COELHO
I'm still getting the same sort of pauses waiting for input with your v11. Alas. This is a pretty frustrating problem; I've spent about two days so far trying to narrow down how it happens. I've attached the test program I'm using. It seems related to my picking a throttled rate that's cl

Re: [HACKERS] [PATCH] add --throttle to pgbench (submission 3)

2013-06-19 Thread Jan Wieck
On 05/01/13 04:57, Fabien COELHO wrote: > > Add --throttle to pgbench > > Each client is throttled to the specified rate, which can be expressed in > tps or in time (s, ms, us). Throttling is achieved by scheduling > transactions along a Poisson-distribution. > > This is an update of the previ

  1   2   >