Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Craig Ringer
On 01/24/2013 01:34 AM, Tom Lane wrote: > Alexander Law writes: >> Please let me know if I can do something to get the bug fix >> (https://commitfest.postgresql.org/action/patch_view?id=902) committed. > It's waiting on some Windows-savvy committer to pick it up, IMO. I'm no committer, but I can

Re: [HACKERS] My first patch! (to \df output)

2013-01-23 Thread Craig Ringer
On 01/24/2013 01:50 AM, Phil Sorber wrote: > This looks good to me now. Compiles and works as described. Ready to go? https://commitfest.postgresql.org/action/patch_view?id=1008 -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Servi

Re: [HACKERS] bgwriter reference to HOT standby

2013-01-23 Thread Pavan Deolasee
On Thu, Jan 24, 2013 at 12:36 PM, Jeff Janes wrote: > The docs on bgworker twice refer to "HOT standby". I don't think that in > either case, the "hot" needs emphasis, and if it does making it look like an > acronym (one already used for something else) is probably not the way to do > it. I thin

[HACKERS] bgwriter reference to HOT standby

2013-01-23 Thread Jeff Janes
The docs on bgworker twice refer to "HOT standby". I don't think that in either case, the "hot" needs emphasis, and if it does making it look like an acronym (one already used for something else) is probably not the way to do it. Patch to HEAD attached. Cheers, Jeff diff --git a/doc/src/sgml/bg

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-23 Thread Tom Lane
Robert Haas writes: > On Wed, Jan 23, 2013 at 11:40 AM, Tom Lane wrote: >> Your point that the locking code doesn't quite cope with newly-masked >> objects makes me feel that we could get away with not solving the case >> for plan caching either. Or at least that we could put off the problem >>

Re: [HACKERS] pg_basebackup with -R option and start standby have problems with escaped password

2013-01-23 Thread Hari Babu
On Wed, Jan 23, 2013 11:48 PM, Magnus Hagander wrote: >On Wed, Jan 23, 2013 at 10:18 AM, Hari Babu wrote: >> Test scenario to reproduce: >> 1. Start the server >> 2. create the user as follows >> ./psql postgres -c "create user user1 superuser login >> password 'u

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Amit Kapila
On Wednesday, January 23, 2013 11:51 PM Alvaro Herrera wrote: > Fujii Masao escribió: > > On Wed, Jan 23, 2013 at 12:24 PM, Amit Kapila > wrote: > > > >> Is it safe to write something in the directory other than data > > >> directory > > >> via SQL? > > >> > > >> postgres user usually has the wri

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Amit Kapila
On Wednesday, January 23, 2013 9:51 PM Fujii Masao wrote: > On Wed, Jan 23, 2013 at 6:18 PM, Amit Kapila > wrote: > > On Tuesday, January 22, 2013 10:14 PM Fujii Masao wrote: > >> When I removed postgresql.auto.conf and restarted the server, > >> I got the following warning message. This is not co

Re: [HACKERS] Teaching pg_receivexlog to follow timeline switches

2013-01-23 Thread Craig Ringer
On 01/22/2013 06:43 AM, Noah Misch wrote: > This patch was in Needs Review status, but you committed it on 2013-01-17. I > have marked it as such in the CF app. Thankyou. There's a lot to keep up with :S -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 11:28 AM, Craig Ringer wrote: > On 01/24/2013 09:38 AM, Noah Misch wrote: >> The most notable difference is that I have no pre-VS2012 Microsoft >> compilers installed and no SDKs installed by my explicit action. I >> suggest assessing how the Framework64 directories get into your path

Re: [HACKERS] [sepgsql 1/3] add name qualified creation label

2013-01-23 Thread Tom Lane
John R Pierce writes: > On 1/23/2013 8:32 PM, Tom Lane wrote: >> FWIW, in Fedora-land I see: ... > I'd be far more interested in what is in RHEL and CentOS.Fedora, > with its 6 month obsolescence cycle, is of zero interest to me for > deploying database servers. But of course Fedora is als

Re: [HACKERS] [sepgsql 1/3] add name qualified creation label

2013-01-23 Thread John R Pierce
On 1/23/2013 8:32 PM, Tom Lane wrote: FWIW, in Fedora-land I see: F16: 2.1.6 (F16 will go out of support next month) F17: 2.1.10 (F17 has been stable for 6+ months) F18: 2.1.12 (F18 just went stable) While requiring 2.1.10 today might be thought a tad leading-edge, will that still

Re: [HACKERS] [sepgsql 1/3] add name qualified creation label

2013-01-23 Thread Tom Lane
Heikki Linnakangas writes: > On 17.01.2013 23:20, Kohei KaiGai wrote: >> In addition, I forgot to update minimum required version for libselinux; >> (it also takes change in configure script). > libselinux1 2.1.10 or newer is a pretty tall order. That's not in debian > testing yet, for example.

Re: [HACKERS] Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-01-23 Thread Tom Lane
Noah Misch writes: > On Wed, Jan 09, 2013 at 11:22:06AM +, Simon Riggs wrote: >> On balance, it would seem optimizing for this special case would >> affect everybody negatively; not much, but enough. Which means we >> should rekect this patch. > I've failed to come up with a non-arbitrary rea

Re: [HACKERS] pg_ctl idempotent option

2013-01-23 Thread Ashutosh Bapat
I agree, answering the question, whether the particular attempt of starting a server succeeded or not, will need the current behaviour. Now, question is which of these behaviours should be default? Bruce, what if we make idempotent behaviour default and provide an option for current behaviour? On

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 09:38 AM, Noah Misch wrote: > The most notable difference is that I have no pre-VS2012 Microsoft > compilers installed and no SDKs installed by my explicit action. I > suggest assessing how the Framework64 directories get into your path > and trying without them. nm A further update

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 09:38 AM, Noah Misch wrote: > The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no SDKs installed by my explicit action. I suggest assessing how the Framework64 directories get into your path and trying without them. nm Interesting. The Frame

[HACKERS] Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-01-23 Thread Noah Misch
On Wed, Jan 09, 2013 at 11:22:06AM +, Simon Riggs wrote: > On 24 December 2012 16:57, Amit Kapila wrote: > > Performance: Average of 3 runs of pgbench in tps > > 9.3devel | with trailing null patch > > --+-- > > 578.9872 | 573.4980 > > On balance, it would

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Noah Misch
Hi Craig, Thanks for testing. On Wed, Jan 23, 2013 at 02:55:55PM +0800, Craig Ringer wrote: > When building a tree with your patch applied using VS 2012 Express via a > command line environment set up with: > >"c:\program files (x86)\Microsoft Visual Studio > 11.0\VC\vcvarsall.bat" x86 Like

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-23 Thread Joshua D. Drake
On 01/23/2013 05:17 PM, Robert Haas wrote: Of course, I have no evidence that that will happen. But it is a really big piece of code, and therefore unless you are superman, it's probably got a really large number of bugs. The scary thing is that it is not as if we can say, well, this is a big

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 5:30 PM, Andres Freund wrote: > pgbench upstream: > tps: 22275.941409 > space overhead: 0% > pgbench logical-submitted > tps: 16274.603046 > space overhead: 2.1% > pgbench logical-HEAD (will submit updated version tomorrow or so): > tps: 20853.341551 > space overhead: 2.3%

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Fujii Masao
On Thu, Jan 24, 2013 at 8:47 AM, Phil Sorber wrote: > On Wed, Jan 23, 2013 at 6:07 PM, Tom Lane wrote: >> Phil Sorber writes: >>> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: > +1 for default timeout --- if this isn't l

Re: [HACKERS] Back-branch update releases coming in a couple weeks

2013-01-23 Thread Fujii Masao
On Thu, Jan 24, 2013 at 7:42 AM, MauMau wrote: > From: "Tom Lane" > >> Since we've fixed a couple of relatively nasty bugs recently, the core >> committee has determined that it'd be a good idea to push out PG update >> releases soon. The current plan is to wrap on Monday Feb 4 for public >> ann

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 03:23 AM, Brar Piening wrote: >> On 01/23/2013 02:14 PM, Craig Ringer wrote: >> >> How have you been testing VS2012 builds? In what environment? > > When I tested this patch the last time I've been using Windows 8 RTM > (Microsoft Windows 8 Enterprise Evaluation - 6.2.9200 Build 9200)

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 6:07 PM, Tom Lane wrote: > Phil Sorber writes: >> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: >>> On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: +1 for default timeout --- if this isn't like "ping" where you are expecting to run indefinitely

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Tom Lane
Simon Riggs writes: > On 23 January 2013 17:15, Andres Freund wrote: >> On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >>> Can't we do better than that? > "row level locks cannot be applied to the NULLable side of an outer join" I think it should read "row-level locks cannot ...", but othe

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Tom Lane
Phil Sorber writes: > On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: >> On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: >>> +1 for default timeout --- if this isn't like "ping" where you are >>> expecting to run indefinitely, I can't see that it's a good idea for it >>> to sit ve

Re: [HACKERS] Back-branch update releases coming in a couple weeks

2013-01-23 Thread MauMau
From: "Tom Lane" Since we've fixed a couple of relatively nasty bugs recently, the core committee has determined that it'd be a good idea to push out PG update releases soon. The current plan is to wrap on Monday Feb 4 for public announcement Thursday Feb 7. If you're aware of any bug fixes yo

Re: [HACKERS] logical changeset generation v4 - Heikki's thoughts about the patch state

2013-01-23 Thread Andres Freund
Hi, I decided to reply on the patches thread to be able to find this later. On 2013-01-23 22:48:50 +0200, Heikki Linnakangas wrote: > "logical changeset generation v4" > This is a boatload of infrastructure for supporting logical replication, yet > we have no code actually implementing logical re

[HACKERS] Re: [BUGS] BUG #7815: Upgrading PostgreSQL from 9.1 to 9.2 with pg_upgrade/postgreql-setup fails - invalid status retrieve

2013-01-23 Thread Bruce Momjian
On Sat, Jan 19, 2013 at 09:56:48PM -0500, Bruce Momjian wrote: > > (But, at least with the type of packaging I'm using in Fedora, he would > > first have to go through a package downgrade/reinstallation process, > > because the packaging provides no simple scripted way of manually > > starting the

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Pavel Stehule
Hello > > I do that pretty often. A better approach, imv, would be making psql a > bit more of a 'real' shell, with loops, conditionals, better variable > handling, etc. > after a few years prototyping on this area I am not sure so this is good idea. Maybe better to start some new console from s

Re: [HACKERS] Potential TODO: schema in ALTER DEFAULT PRIVILEGES?

2013-01-23 Thread Stephen Frost
Josh, * Josh Berkus (j...@agliodbs.com) wrote: > As you know, there's a lot of people these days using SCHEMA for > multi-tenant application partitioning. One of them pointed out to me > that "schema" is missing from ALTER DEFAULT PRIVS; that is, there's no > way for you to set default permissio

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Stephen Frost
Heikki, * Heikki Linnakangas (hlinnakan...@vmware.com) wrote: > FWIW, here's how I feel about some the patches. It's not an exhaustive list. Thanks for going through them and commenting on them. > "Event Triggers: Passing Information to User Functions (from 2012-11)" > I don't care about this wh

Re: [HACKERS] [sepgsql 1/3] add name qualified creation label

2013-01-23 Thread Heikki Linnakangas
On 17.01.2013 23:20, Kohei KaiGai wrote: 2013/1/16 Robert Haas: This looks OK on a quick once-over, but should it update the documentation somehow? Documentation does not take so much description for type_transition rules, so I just modified relevant description a bit to mention about type_tra

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andrew Dunstan
On 01/23/2013 12:48 PM, Simon Riggs wrote: On 23 January 2013 17:15, Andres Freund wrote: On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: On 01/23/2013 10:12 AM, Alvaro Herrera wrote: Improve concurrency of foreign key locking This error message change looks rather odd, and has my head

[HACKERS] Potential TODO: schema in ALTER DEFAULT PRIVILEGES?

2013-01-23 Thread Josh Berkus
Folks, As you know, there's a lot of people these days using SCHEMA for multi-tenant application partitioning. One of them pointed out to me that "schema" is missing from ALTER DEFAULT PRIVS; that is, there's no way for you to set default permissions on a new schema. For folks using schema for

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Heikki Linnakangas
On 23.01.2013 20:44, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: For all of that, I'm not sure that people failing to seek consensus before coding is really so much of a problem as you seem to think. For my part, I don't think the lack of consensus-finding before submitti

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 3:23 PM, Phil Sorber wrote: > On Wed, Jan 23, 2013 at 1:44 PM, Stephen Frost wrote: >> * Robert Haas (robertmh...@gmail.com) wrote: >>> For all of that, I'm not sure that people failing to seek consensus >>> before coding is really so much of a problem as you seem to think

[HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Andres Freund
On 2013-01-22 12:32:07 +, Amit kapila wrote: > This closes all comments raised till now for this patch. > Kindly let me know if you feel something is missing? I am coming late to this patch, so bear with me if I repeat somethign said elsewhere. Review comments of cursory pass through the patc

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 1:44 PM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: >> For all of that, I'm not sure that people failing to seek consensus >> before coding is really so much of a problem as you seem to think. > > For my part, I don't think the lack of consensus-fin

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 2:51 PM, Bruce Momjian wrote: > On Wed, Jan 23, 2013 at 02:50:01PM -0500, Phil Sorber wrote: >> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: >> > On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: >> >> Phil Sorber writes: >> >> > On Wed, Jan 23, 2013 at 1

Re: [HACKERS] Event Triggers: adding information

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 03:02:24PM -0500, Robert Haas wrote: > On Wed, Jan 23, 2013 at 2:36 PM, Bruce Momjian wrote: > > On Wed, Jan 23, 2013 at 09:33:58AM -0500, Robert Haas wrote: > >> On Wed, Jan 23, 2013 at 4:57 AM, Dimitri Fontaine > >> wrote: > >> > Thanks for commiting the fixes. About the

Re: [HACKERS] COPY FREEZE has no warning

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 2:02 PM, Bruce Momjian wrote: > As a reminder, COPY FREEZE still does not issue any warning/notice if > the freezing does not happen: > > Requests copying the data with rows already frozen, just as they > would be after running the VACUUM FREEZE command. >

Re: [HACKERS] Event Triggers: adding information

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 2:36 PM, Bruce Momjian wrote: > On Wed, Jan 23, 2013 at 09:33:58AM -0500, Robert Haas wrote: >> On Wed, Jan 23, 2013 at 4:57 AM, Dimitri Fontaine >> wrote: >> > Thanks for commiting the fixes. About the regression tests, I think >> > you're right, but then I can't see how

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 02:50:01PM -0500, Phil Sorber wrote: > On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: > > On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: > >> Phil Sorber writes: > >> > On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas > >> > wrote: > >> >> [rhaas pgsql]$ p

Re: [HACKERS] autovacuum truncate exclusive lock round two

2013-01-23 Thread Kevin Grittner
Kevin Grittner wrote: > Applied with trivial editing, mostly from a pgindent run against > modified files. Applied back as far as 9.0. Before that code didn't match well enough for it to seem safe to apply without many hours of additional testing. I have confirmed occurences of this problem at l

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote: > On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: >> Phil Sorber writes: >> > On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas >> > wrote: >> >> [rhaas pgsql]$ pg_isready -h www.google.com >> >> >> >> > Do you think we should have a

Re: [HACKERS] Patch: UNNEST (and other functions) WITH ORDINALITY

2013-01-23 Thread David Fetter
On Wed, Jan 23, 2013 at 02:40:45PM -0500, Bruce Momjian wrote: > On Wed, Jan 23, 2013 at 10:15:27AM -0800, David Fetter wrote: > > On Wed, Jan 23, 2013 at 03:12:37PM -0300, Alvaro Herrera wrote: > > > David Fetter wrote: > > > > On Tue, Jan 22, 2013 at 10:29:43PM -0800, David Fetter wrote: > > > >

Re: [HACKERS] Patch: UNNEST (and other functions) WITH ORDINALITY

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 10:15:27AM -0800, David Fetter wrote: > On Wed, Jan 23, 2013 at 03:12:37PM -0300, Alvaro Herrera wrote: > > David Fetter wrote: > > > On Tue, Jan 22, 2013 at 10:29:43PM -0800, David Fetter wrote: > > > > Folks, > > > > > > > > Please find attached a patch which implements t

Re: [HACKERS] Event Triggers: adding information

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 09:33:58AM -0500, Robert Haas wrote: > On Wed, Jan 23, 2013 at 4:57 AM, Dimitri Fontaine > wrote: > > Thanks for commiting the fixes. About the regression tests, I think > > you're right, but then I can't see how to include such a test. Maybe you > > could add the other one

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Brar Piening
On 01/23/2013 02:14 PM, Craig Ringer wrote: How have you been testing VS2012 builds? In what environment? When I tested this patch the last time I've been using Windows 8 RTM (Microsoft Windows 8 Enterprise Evaluation - 6.2.9200 Build 9200) and Microsoft Visual Studio Express 2012 für Windows

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-01-23 Thread Pavel Stehule
2013/1/14 Tom Lane : > Robert Haas writes: >> On Mon, Jan 14, 2013 at 11:56 AM, Tom Lane wrote: >>> So far as I can tell, get_create_function_cmd (and lookup_function_oid >>> too) were intentionally designed to not show their queries, and for that >>> matter they go out of their way to produce te

Re: [HACKERS] pg_ctl idempotent option

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 09:00:25PM +0200, Heikki Linnakangas wrote: > On 23.01.2013 20:56, Bruce Momjian wrote: > >On Tue, Jan 22, 2013 at 06:03:28PM +0530, Ashutosh Bapat wrote: > >>anyway, +1 for making this as default option. Going that path, would > >>we be breaking backward compatibility? Ther

[HACKERS] COPY FREEZE has no warning

2013-01-23 Thread Bruce Momjian
As a reminder, COPY FREEZE still does not issue any warning/notice if the freezing does not happen: Requests copying the data with rows already frozen, just as they would be after running the VACUUM FREEZE command. This is intended as a performance option for initial data loading

Re: [HACKERS] pg_ctl idempotent option

2013-01-23 Thread Heikki Linnakangas
On 23.01.2013 20:56, Bruce Momjian wrote: On Tue, Jan 22, 2013 at 06:03:28PM +0530, Ashutosh Bapat wrote: anyway, +1 for making this as default option. Going that path, would we be breaking backward compatibility? There might be scripts, (being already used), which depend upon the current behavi

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Bruce Momjian
On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote: > Phil Sorber writes: > > On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas wrote: > >> [rhaas pgsql]$ pg_isready -h www.google.com > >> > > > Do you think we should have a default timeout, or only have one if > > specified at the command li

Re: [HACKERS] pg_ctl idempotent option

2013-01-23 Thread Bruce Momjian
On Tue, Jan 22, 2013 at 06:03:28PM +0530, Ashutosh Bapat wrote: > On Tue, Jan 15, 2013 at 9:36 PM, Tom Lane wrote: > > Peter Eisentraut writes: > >> On 1/14/13 10:22 AM, Tom Lane wrote: > >>> Also it appears to me that the hunk at lines 812ff is changing the > >>> default behavior, which is not w

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-01-23 Thread Gavin Flower
On 24/01/13 07:45, Alvaro Herrera wrote: Andres Freund escribió: I somewhat dislike the fact that CONCURRENTLY isn't really concurrent here (for the listeners: swapping the indexes acquires exlusive locks) , but I don't see any other naming being better. REINDEX ALMOST CONCURRENTLY? REINDEX

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-01-23 Thread Alvaro Herrera
Andres Freund escribió: > I somewhat dislike the fact that CONCURRENTLY isn't really concurrent > here (for the listeners: swapping the indexes acquires exlusive locks) , > but I don't see any other naming being better. REINDEX ALMOST CONCURRENTLY? -- Álvaro Herrerahttp://www.2n

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > For all of that, I'm not sure that people failing to seek consensus > before coding is really so much of a problem as you seem to think. For my part, I don't think the lack of consensus-finding before submitting patches is, in itself, a problem. The

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-01-23 Thread Andres Freund
On 2013-01-15 18:16:59 +0900, Michael Paquier wrote: > OK. I am back to this patch after a too long time. Dito ;) > > > > * would be nice (but thats probably a step #2 thing) to do the > > > > individual steps of concurrent reindex over multiple relations to > > > > avoid too much overall wai

Re: [HACKERS] foreign key locks

2013-01-23 Thread Alvaro Herrera
I just pushed this patch to the master branch. There was a corresponding catversion bump and pg_control version bump. I have verified that "make check-world" passes on my machine, as well as isolation tests and pg_upgrade. Tom Lane said at one point "this is too complex to maintain". Several ti

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Joshua D. Drake
On 01/23/2013 09:51 AM, Josh Berkus wrote: The only way to fix increasing bug counts is through more-comprehensive regular testing. Currently we have regression/unit tests which cover maybe 30% of our code. Performance testing is largely ad-hoc. We don't require comprehensive acceptance test

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Alvaro Herrera
Fujii Masao escribió: > On Wed, Jan 23, 2013 at 12:24 PM, Amit Kapila wrote: > >> Is it safe to write something in the directory other than data > >> directory > >> via SQL? > >> > >> postgres user usually has the write permission for the configuration > >> directory like /etc/postgresql? > > > >

Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Andrew Dunstan
On 01/23/2013 01:08 PM, Alvaro Herrera wrote: Tom Lane escribió: Alexander Law writes: Please let me know if I can do something to get the bug fix (https://commitfest.postgresql.org/action/patch_view?id=902) committed. It's waiting on some Windows-savvy committer to pick it up, IMO. (FWIW, I

Re: [HACKERS] pg_basebackup with -R option and start standby have problems with escaped password

2013-01-23 Thread Magnus Hagander
On Wed, Jan 23, 2013 at 10:18 AM, Hari Babu wrote: > Test scenario to reproduce: > 1. Start the server > 2. create the user as follows > ./psql postgres -c "create user user1 superuser login > password 'use''1'" > > 3. Take the backup with -R option as follo

Re: [HACKERS] Patch: UNNEST (and other functions) WITH ORDINALITY

2013-01-23 Thread David Fetter
On Wed, Jan 23, 2013 at 03:12:37PM -0300, Alvaro Herrera wrote: > David Fetter wrote: > > On Tue, Jan 22, 2013 at 10:29:43PM -0800, David Fetter wrote: > > > Folks, > > > > > > Please find attached a patch which implements the SQL standard > > > UNNEST() WITH ORDINALITY. > > > > Added to CF4. >

Re: [HACKERS] Patch: UNNEST (and other functions) WITH ORDINALITY

2013-01-23 Thread Alvaro Herrera
David Fetter wrote: > On Tue, Jan 22, 2013 at 10:29:43PM -0800, David Fetter wrote: > > Folks, > > > > Please find attached a patch which implements the SQL standard > > UNNEST() WITH ORDINALITY. > > Added to CF4. Surely you meant CF 2013-Next (i.e. first commit of 9.4 cycle). -- Álvaro Herrer

Re: [HACKERS] Patch: clean up addRangeTableEntryForFunction

2013-01-23 Thread David Fetter
On Tue, Jan 22, 2013 at 11:02:18PM -0500, Tom Lane wrote: > David Fetter writes: > > I've been working with Andrew Gierth (well, mostly he's been doing > > the work, as usual) to add WITH ORDINALITY as an option for > > set-returning functions. In the process, he found a minor > > opportunity to

Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Alvaro Herrera
Tom Lane escribió: > Alexander Law writes: > > Please let me know if I can do something to get the bug fix > > (https://commitfest.postgresql.org/action/patch_view?id=902) committed. > > It's waiting on some Windows-savvy committer to pick it up, IMO. > (FWIW, I have no objection to the patch as

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Alvaro Herrera
Andrew Dunstan wrote: > > On 01/23/2013 10:12 AM, Alvaro Herrera wrote: > >Improve concurrency of foreign key locking > > This error message change looks rather odd, and has my head spinning a bit: > > -errmsg("SELECT FOR UPDATE/SHARE cannot be > applied to the nullable side

Re: [HACKERS] proposal: fix corner use case of variadic fuctions usage

2013-01-23 Thread Pavel Stehule
2013/1/23 Tom Lane : > Pavel Stehule writes: >> next related example > >> CREATE OR REPLACE FUNCTION public.myleast(VARIADIC integer[]) >> RETURNS integer >> LANGUAGE sql >> AS $function$ >> select min(v) from unnest($1) g(v) >> $function$ > > The reason you get a null from that is that (1) unne

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Josh Berkus
On 01/23/2013 09:08 AM, Andres Freund wrote: > On 2013-01-23 11:44:29 -0500, Robert Haas wrote: >> On Tue, Jan 22, 2013 at 1:15 AM, Tom Lane wrote: >>> Yeah, and a lot more fairly-new developers who don't understand all the >>> connections in the existing system. Let me just push back a bit here:

Re: [HACKERS] My first patch! (to \df output)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 12:31 AM, Jon Erdman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Done. Attached. > - -- > Jon T Erdman (aka StuckMojo) > PostgreSQL Zealot > > On 01/22/2013 11:17 PM, Phil Sorber wrote: >> On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman >> wrote: >> >>

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Simon Riggs
On 23 January 2013 17:15, Andres Freund wrote: > On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >> >> On 01/23/2013 10:12 AM, Alvaro Herrera wrote: >> >Improve concurrency of foreign key locking >> >> This error message change looks rather odd, and has my head spinning a bit: >> >> -

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Tom Lane
Andres Freund writes: > On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >> This error message change looks rather odd, and has my head spinning a bit: >> >> -errmsg("SELECT FOR UPDATE/SHARE cannot be applied to >> the nullable side of an outer join"))); >> +

[HACKERS] [PATCH] Add Makefile dep in bin/scripts for libpgport

2013-01-23 Thread Phil Sorber
I get the following error when I try to compile just a specific binary in src/bin/scripts: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard reindexdb

Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Tom Lane
Alexander Law writes: > Please let me know if I can do something to get the bug fix > (https://commitfest.postgresql.org/action/patch_view?id=902) committed. It's waiting on some Windows-savvy committer to pick it up, IMO. (FWIW, I have no objection to the patch as given, but I am unqualified to

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Tom Lane
Phil Sorber writes: > On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas wrote: >> [rhaas pgsql]$ pg_isready -h www.google.com >> > Do you think we should have a default timeout, or only have one if > specified at the command line? +1 for default timeout --- if this isn't like "ping" where you are

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Bruce Momjian
On Mon, Jan 21, 2013 at 02:04:14PM -0500, Tom Lane wrote: > Josh Berkus writes: > >> IMHO that's the single most important task of a review. > > > Really? I'd say the most important task for a review is "does the patch > > do what it says it does?". That is, if the patch is supposed to > > impl

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas wrote: > On Mon, Jan 21, 2013 at 12:23 PM, Phil Sorber wrote: >> Changing up the subject line because this is no longer a work in >> progress nor is it pg_ping anymore. > > OK, I committed this. However, I have one suggestion. Maybe it would > be a

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andres Freund
On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: > > On 01/23/2013 10:12 AM, Alvaro Herrera wrote: > >Improve concurrency of foreign key locking > > This error message change looks rather odd, and has my head spinning a bit: > > -errmsg("SELECT FOR UPDATE/SHARE cannot be a

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Andres Freund
On 2013-01-23 11:44:29 -0500, Robert Haas wrote: > On Tue, Jan 22, 2013 at 1:15 AM, Tom Lane wrote: > > Yeah, and a lot more fairly-new developers who don't understand all the > > connections in the existing system. Let me just push back a bit here: > > based on the amount of time I've had to spe

Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Alexander Law
Hello, Please let me know if I can do something to get the bug fix (https://commitfest.postgresql.org/action/patch_view?id=902) committed. I would like to fix other bugs related to postgres localization, but I am not sure yet how to do it. Thanks in advance, Alexander 18.10.2012 19:46, Alvaro

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andrew Dunstan
On 01/23/2013 10:12 AM, Alvaro Herrera wrote: Improve concurrency of foreign key locking This error message change looks rather odd, and has my head spinning a bit: -errmsg("SELECT FOR UPDATE/SHARE cannot be applied to the nullable side of an outer join"))); +

Re: [HACKERS] proposal: fix corner use case of variadic fuctions usage

2013-01-23 Thread Tom Lane
Pavel Stehule writes: > next related example > CREATE OR REPLACE FUNCTION public.myleast(VARIADIC integer[]) > RETURNS integer > LANGUAGE sql > AS $function$ > select min(v) from unnest($1) g(v) > $function$ The reason you get a null from that is that (1) unnest() produces zero rows out for ei

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 11:40 AM, Tom Lane wrote: > Yeah, that is probably the major hazard IMO too. The designs sketched > in this thread would be sufficient to ensure that DDL in one session's > temp schema wouldn't have to invalidate plans in other sessions --- but > is that good enough? > > Y

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-23 Thread Robert Haas
On Tue, Jan 22, 2013 at 1:15 AM, Tom Lane wrote: > Yeah, and a lot more fairly-new developers who don't understand all the > connections in the existing system. Let me just push back a bit here: > based on the amount of time I've had to spend fixing bugs over the past > five months, 9.2 was our w

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-23 Thread Tom Lane
Robert Haas writes: > I agree with that, but I think Tom's concern is more with the cost of > too-frequent re-planning. The most obvious case in which DDL might be > frequent enough to cause an issue here is if there is heavy use of > temporary objects - sessions might be rapidly creating and dro

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Fujii Masao
On Wed, Jan 23, 2013 at 6:18 PM, Amit Kapila wrote: > On Tuesday, January 22, 2013 10:14 PM Fujii Masao wrote: >> When I removed postgresql.auto.conf and restarted the server, >> I got the following warning message. This is not correct because >> I didn't remove "auto.conf.d" from postgresql.conf.

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-23 Thread Pavel Stehule
2013/1/23 Robert Haas : > On Wed, Jan 23, 2013 at 8:10 AM, Dimitri Fontaine > wrote: >> Really, live DDL is not that frequent, and when you do that, you want >> transparent replanning. I can't see any use case where it's important to >> be able to run DDL in a live application yet continue to oper

Re: [HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-23 Thread Robert Haas
On Mon, Jan 21, 2013 at 12:23 PM, Phil Sorber wrote: > Changing up the subject line because this is no longer a work in > progress nor is it pg_ping anymore. OK, I committed this. However, I have one suggestion. Maybe it would be a good idea to add a -c or -t option that sets the connect_timeou

Re: [HACKERS] [PATCH] PQping Docs

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 10:59 AM, Phil Sorber wrote: > On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas wrote: >> On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber wrote: >>> Attached is a patch that adds a note about the FATAL messages that >>> appear in the logs if you don't pass a valid user or dbnam

Re: [HACKERS] [PATCH] PQping Docs

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas wrote: > On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber wrote: >> Attached is a patch that adds a note about the FATAL messages that >> appear in the logs if you don't pass a valid user or dbname to PQping >> or PQpingParams. >> >> This was requested in

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-23 Thread Fujii Masao
On Wed, Jan 23, 2013 at 12:24 PM, Amit Kapila wrote: > On Tuesday, January 22, 2013 8:25 PM Fujii Masao wrote: >> On Tue, Jan 22, 2013 at 11:07 PM, Amit Kapila >> wrote: >> > On Tuesday, January 22, 2013 7:10 PM Zoltán Böszörményi wrote: >> >> 2013-01-22 13:32 keltezéssel, Amit kapila írta: >> >>

Re: [HACKERS] [PATCH] PQping Docs

2013-01-23 Thread Robert Haas
On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber wrote: > Attached is a patch that adds a note about the FATAL messages that > appear in the logs if you don't pass a valid user or dbname to PQping > or PQpingParams. > > This was requested in the pg_isready thread. Can I counter-propose the attached,

Re: [HACKERS] unlogged tables vs. GIST

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 4:04 AM, Jeevan Chalke wrote: > Yes. > > I guess my earlier patch, which was directly incrementing > ControlFile->unloggedLSN counter was the concern as it will take > ControlFileLock several times. > > In this version of patch I did what Robert has suggested. At start of t

Re: [HACKERS] WIP: index support for regexp search

2013-01-23 Thread Tom Lane
Heikki Linnakangas writes: > On 23.01.2013 09:36, Alexander Korotkov wrote: >> On Wed, Jan 23, 2013 at 6:08 AM, Tom Lane wrote: >>> The biggest problem is that I really don't care for the idea of >>> contrib/pg_trgm being this cozy with the innards of regex_t. >> The only option I see now is to

Re: [HACKERS] logical changeset generation v4

2013-01-23 Thread Andres Freund
On 2013-01-23 10:18:50 -0500, Robert Haas wrote: > On Wed, Jan 23, 2013 at 7:14 AM, Andres Freund wrote: > > With the (attached for convenience) patch applied you can do > > # ALTER TABLE replication_metadata SET (treat_as_catalog_table = true); > > > > to enable this. > > What I wonder about is:

Re: [HACKERS] logical changeset generation v4

2013-01-23 Thread Robert Haas
On Wed, Jan 23, 2013 at 7:14 AM, Andres Freund wrote: > With the (attached for convenience) patch applied you can do > # ALTER TABLE replication_metadata SET (treat_as_catalog_table = true); > > to enable this. > What I wonder about is: > * does anybody have a better name for the reloption? IMHO,

  1   2   >