[HACKERS] Query plan optimization for CHECK NO INHERIT and single table?

2012-08-29 Thread Matthias
Hey, I tried out the new CHECK NO INHERIT feature for inherited tables. There seems to be an opportunity to generate slightly better query plans sometimes. E.g. when I do SELECT * FROM base WHERE partition_id = 3 and there exists only one child table for which partition_id = 3 is true I guess th

[HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-29 Thread Matthias
Hello, when running VACUUM ANALYZE on my database built on win32-x86 from yesterday's git checkout I always get this at some point during VACUUM ANALYZE: LOG: server process (PID 5880) was terminated by exception 0xC094 DETAIL: Failed process was running: VACUUM VERBOSE ANALYZE HINT: See C

Re: [HACKERS] Draft release notes complete

2012-08-29 Thread Andrew Dunstan
On 08/29/2012 11:20 PM, Peter Eisentraut wrote: On Wed, 2012-08-29 at 22:23 -0400, Alvaro Herrera wrote: Where are we on building the development docs more frequently? Still waiting for details on how it works to set that up on the buildfarm client. Where are we on this? Waiting on Andrew.

Re: [HACKERS] Draft release notes complete

2012-08-29 Thread Peter Eisentraut
On Wed, 2012-08-29 at 22:23 -0400, Alvaro Herrera wrote: > > > > Where are we on building the development docs more frequently? > > > > > > Still waiting for details on how it works to set that up on the > > > buildfarm client. > > > > Where are we on this? > > Waiting on Andrew. > > As far as

Re: [HACKERS] wal_buffers

2012-08-29 Thread Peter Geoghegan
On 19 February 2012 05:24, Robert Haas wrote: > I have attached tps scatterplots. The obvious conclusion appears to > be that, with only 16MB of wal_buffers, the buffer "wraps around" with > some regularity: we can't insert more WAL because the buffer we need > to use still contains WAL that hasn

Re: [HACKERS] Draft release notes complete

2012-08-29 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of mié ago 29 21:25:11 -0400 2012: > On Thu, May 31, 2012 at 05:58:58PM +0200, Magnus Hagander wrote: > > On Thu, May 31, 2012 at 5:55 PM, Bruce Momjian wrote: > > > On Tue, May 15, 2012 at 12:57:37PM -0400, Magnus Hagander wrote: > > >> On Fri, May 11, 2012 a

Re: [HACKERS] Pre-alloc ListCell's optimization

2012-08-29 Thread Alvaro Herrera
Excerpts from Stephen Frost's message of mié ago 29 21:46:06 -0400 2012: > Based on the test runs that I did using Josh's box (thanks!), the > performance with the pre-allocation patch and an pre-alloc of 8 ends up > being about a wash. Allocating less (4) or more (16) actually makes > things wor

Re: [HACKERS] Pre-alloc ListCell's optimization

2012-08-29 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, May 18, 2012 at 06:19:52PM -0400, Stephen Frost wrote: > > Dropping it to 4 improved performance a bit: 9476 tps. > > > > Going to keep playing around and see where this goes. > > Any status on this? Based on the test runs that I did us

Re: [HACKERS] LISTEN/NOTIFY Security and the docs

2012-08-29 Thread Bruce Momjian
On Thu, May 24, 2012 at 01:03:18PM +0200, Magnus Hagander wrote: > On Fri, May 18, 2012 at 5:08 PM, Chander Ganesan wrote: > > Hi All, > > > > I just realized that anyone can listen for notifications (using listen) so > > long as they know the "channel" name.  This means that a user could receive

Re: [HACKERS] Pre-alloc ListCell's optimization

2012-08-29 Thread Bruce Momjian
On Fri, May 18, 2012 at 06:19:52PM -0400, Stephen Frost wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > > llist_opt: 9289 tps > > > HEAD: 9286 tps > > > > llist_opt: 9407 tps > > > > Which gives us ~1.3% improvment. > > Trying out some different options- going with 32 pre-allocated

Re: [HACKERS] Draft release notes complete

2012-08-29 Thread Bruce Momjian
On Thu, May 31, 2012 at 05:58:58PM +0200, Magnus Hagander wrote: > On Thu, May 31, 2012 at 5:55 PM, Bruce Momjian wrote: > > On Tue, May 15, 2012 at 12:57:37PM -0400, Magnus Hagander wrote: > >> On Fri, May 11, 2012 at 11:44 AM, Andrew Dunstan > >> wrote: > >> > > >> > > >> > On 05/11/2012 05:32

Re: [HACKERS] What is the current status of FOR UPDATE cursors ?

2012-08-29 Thread Bruce Momjian
On Sun, May 6, 2012 at 10:55:54PM +0200, Hannu Krosing wrote: > On Sun, 2012-05-06 at 13:17 -0400, Tom Lane wrote: > > Hannu Krosing writes: > > > What is the current status of FOR UPDATE cursors ? > > > > Same as it's been for a long time: FOR UPDATE [ OF table_name ] > > works fine. > > Ok, t

Re: [HACKERS] multi-master pgbench?

2012-08-29 Thread Tatsuo Ishii
> Tatsuo Ishii writes: >> I am thinking about to implement "multi-master" option for pgbench. > > Please consider using Tsung, which solves that problem and many others. > > http://tsung.erlang-projects.org/ Thank you for introducing Tsung. I have some questions regarding it. Does it support

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Tom Lane
Robert Haas writes: > On the more general issue, I continue to see minimal risk of harm in > allowing things like LPAD() to implicitly cast the first argument to > text. Well, I see your point about LPAD(), but the problem is how to tell the difference between a harmless cast omission and an actu

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Robert Haas
On Wed, Aug 29, 2012 at 3:54 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 8/29/12 11:40 AM, Tom Lane wrote: >>> regression=# select lpad(42,8); > >> We are not seriously intending to make the above query work, are we? > > Well, *I* don't want to, but apparently Robert does. > > I don't re

Re: [HACKERS] FATAL: bogus data in lock file "postmaster.pid": ""

2012-08-29 Thread Bruce Momjian
Applied. --- On Wed, Aug 29, 2012 at 08:51:40AM -0400, Bruce Momjian wrote: > On Wed, Aug 29, 2012 at 12:56:26AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Wed, Aug 29, 2012 at 12:24:26AM -0400, Alvaro Herrer

Re: [HACKERS] splitting *_desc routines

2012-08-29 Thread Tom Lane
Alvaro Herrera writes: > I looked at Andres' patch and the general idea is rather horrible: it > links all backend files into the output executable. This is so that the > *_desc functions can be used from their respective object files, which > obviously have a lot of requirements for backend infr

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Tom Lane
Peter Eisentraut writes: > On 8/29/12 11:40 AM, Tom Lane wrote: >> regression=# select lpad(42,8); > We are not seriously intending to make the above query work, are we? Well, *I* don't want to, but apparently Robert does. I don't really want to go much further than finding a way to handle the

[HACKERS] splitting *_desc routines

2012-08-29 Thread Alvaro Herrera
So Andres Freund floated a proposal to create an xlogdump sort of tool, in core, and posted a patch. One advantage of having xlogdump in core is that we can have buildfarm test that part of the Xlog code, which currently sees no testing at all. In fact we could use it as a testbed for XLog in gene

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Peter Eisentraut
On 8/29/12 11:40 AM, Tom Lane wrote: regression=# select lpad(42,8); >>ERROR: failed to find conversion function from integer to text >>I'm not sure why that's happening, either, but evidently some >>additional coercion laxity would required. >This, however, is a trivial problem; make_fn_argume

Re: [HACKERS] splitting htup.h

2012-08-29 Thread Andres Freund
On Wednesday, August 29, 2012 05:47:14 PM Tom Lane wrote: > Alvaro Herrera writes: > > Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012: > >> Also, is there any reason to consider just moving those defs into > >> heapam.h, instead of inventing a new header? I'm not sure if there

Re: [HACKERS] splitting htup.h

2012-08-29 Thread Tom Lane
Alvaro Herrera writes: > ... we already have catalog/heap.h, so that would be one reason to avoid > that name. Yeah, good point. We do have some duplicate file names elsewhere, but it's not a terribly good practice. regards, tom lane -- Sent via pgsql-hackers mailing

Re: [HACKERS] splitting htup.h

2012-08-29 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012: >> Also, is there any reason to consider just moving those defs into >> heapam.h, instead of inventing a new header? I'm not sure if there's >> any principled distinction between heap.h and heapam.h, or a

Re: [HACKERS] splitting htup.h

2012-08-29 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of mié ago 29 11:32:04 -0400 2012: > Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012: > > This should > > reduce the number of changes needed, not only in our code but third > > party code. Not sure if the new file could sanely be called >

Re: [HACKERS] multi-master pgbench?

2012-08-29 Thread Dimitri Fontaine
Tatsuo Ishii writes: > I am thinking about to implement "multi-master" option for pgbench. Please consider using Tsung, which solves that problem and many others. http://tsung.erlang-projects.org/ Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Sup

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Tom Lane
Robert Haas writes: > The upshot here appears to be that we're kind of schizophrenic about > what we want. With things like text || anyelement, anyelement || > text, and concat(variadic "any") we are basically asserting that we > want to treat anything that we don't recognize as a string. But th

Re: [HACKERS] splitting htup.h

2012-08-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012: > Alvaro Herrera writes: > > This patch is mainly doing four things: > > > 1. take some typedefs and the HeapTupleData struct definition from > > access/htup.h, and put them in access/tupbasics.h. This new file is > > used as #i

Re: [HACKERS] [BUGS] BUG #6572: The example of SPI_execute is bogus

2012-08-29 Thread Rajeev rastogi
From: pgsql-bugs-ow...@postgresql.org [pgsql-bugs-ow...@postgresql.org] on behalf of Bruce Momjian [br...@momjian.us] Sent: Wednesday, August 29, 2012 8:46 AM To: Tom Lane Cc: Robert Haas; Hitoshi Harada; pgsql-b...@postgresql.org; pgsql-hackers@postgresql

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Gavin Flower
On 29/08/12 23:34, Robert Haas wrote: On Wed, Aug 29, 2012 at 12:27 AM, Tom Lane wrote: To put some concreteness into what so far has been a pretty hand-wavy discussion, I experimented with the attached patch. I'm not sure that it exactly corresponds to what you proposed, but I think this is th

Re: [HACKERS] TRUE/FALSE vs true/false

2012-08-29 Thread Bruce Momjian
On Sat, Aug 25, 2012 at 12:26:30PM -0400, Robert Haas wrote: > > So a patch of 1K lines would by itself represent about 2% of the typical > > inter-branch delta. Maybe that's below our threshold of pain, or maybe > > it isn't. I'd be happier about it if there were a more compelling > > argument f

Re: [HACKERS] FATAL: bogus data in lock file "postmaster.pid": ""

2012-08-29 Thread Bruce Momjian
On Wed, Aug 29, 2012 at 12:56:26AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Aug 29, 2012 at 12:24:26AM -0400, Alvaro Herrera wrote: > >> It's a pretty strange line wrap you got in this version of the patch. > >> Normally we just let the string run past the 78 char limit, without

[HACKERS] Doc Patch and test for Patch to compute Max LSN of Data Pages

2012-08-29 Thread Amit kapila
>>> Based on the discussion and suggestions in this mail chain, following >>> features can be implemented: >>> >>> 1. To compute the value of max LSN in data pages based on user input >>> whether he wants it for an individual >>> file, a particular directory or whole database. >> >>> 2a. To s

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Robert Haas
On Wed, Aug 29, 2012 at 12:27 AM, Tom Lane wrote: > To put some concreteness into what so far has been a pretty hand-wavy > discussion, I experimented with the attached patch. I'm not sure that > it exactly corresponds to what you proposed, but I think this is the > only place the consideration co

Re: [HACKERS] wal_buffers

2012-08-29 Thread Amit Kapila
On Tuesday, August 28, 2012 9:33 PM Bruce Momjian wrote: On Tue, Aug 28, 2012 at 09:40:33AM +0530, Amit Kapila wrote: > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Bruce Momjian > >>> Added to TODO: > >>> Allow reporting of stalls due to

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-29 Thread Robert Haas
On Tue, Aug 28, 2012 at 11:23 PM, Tom Lane wrote: > That argument would hold water if we got rid of every single usage of > overloading in the system-defined operators/functions, which as you well > know is not an attractive idea. Since that's not going to happen, > arguing for this on the basis

Re: [HACKERS] [v9.3] writable foreign tables

2012-08-29 Thread Kohei KaiGai
2012/8/28 David Fetter : > On Tue, Aug 28, 2012 at 06:08:59PM +0200, Kohei KaiGai wrote: >> 2012/8/28 David Fetter : >> > On Tue, Aug 28, 2012 at 05:18:34PM +0200, Kohei KaiGai wrote: >> >> 2012/8/28 David Fetter : >> >> > On Tue, Aug 28, 2012 at 10:58:25AM -0400, Tom Lane wrote: >> >> >> Kohei Kai

Re: [HACKERS] [v9.3] writable foreign tables

2012-08-29 Thread Kohei KaiGai
2012/8/28 Kohei KaiGai : > 2012/8/28 Tom Lane : >> Kohei KaiGai writes: Would it be too invasive to introduce a new pointer in TupleTableSlot that is NULL for anything but virtual tuples from foreign tables? >> >>> I'm not certain whether the duration of TupleTableSlot is enough to >>> c

Re: [HACKERS] SP-GiST micro-optimizations

2012-08-29 Thread Heikki Linnakangas
On 28.08.2012 22:50, Ants Aasma wrote: On Tue, Aug 28, 2012 at 9:42 PM, Tom Lane wrote: Seems like that's down to the CPU not doing "rep stosq" particularly quickly, which might well be chip-specific. AMD optimization manual[1] states the following: For repeat counts of less than 4k, ex